40127 2010-06-03 09:41:42 -0700 [Qt] Don't send notifications event after the page was navigated away 2010-08-03 08:33:18 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 39995 1 yael webkit-unassigned hausmann oldest_to_newest 233797 0 yael 2010-06-03 09:41:42 -0700 Notification objects can outlive the page they are in. If the ScriptExecutionContext that created the notification was destroyed, don't invoke "display" or "close" events on the notification object. When running inside DRT, also don't log after the ScriptExecutionContext was destroyed. I actually don't understand why this is not causing failures on the build bot. 233800 1 57783 yael 2010-06-03 09:47:15 -0700 Created attachment 57783 Patch. 233807 2 57783 laszlo.gombos 2010-06-03 10:12:08 -0700 Comment on attachment 57783 Patch. Looks good to me. r+. 233823 3 yael 2010-06-03 10:36:10 -0700 Committed r60630: <http://trac.webkit.org/changeset/60630> 259467 4 hausmann 2010-08-03 08:33:18 -0700 Revision r60630 cherry-picked into qtwebkit-2.1 with commit 7c263035b4010a8c7cf057eb7d2ba0fdd336929d 57783 2010-06-03 09:47:15 -0700 2010-06-03 10:12:08 -0700 Patch. 40127.patch text/plain 1962 yael SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjA2MjUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYtMDMgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFy b25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gRG9uJ3Qgc2VuZCBub3RpZmljYXRpb25zIGV2ZW50IGFmdGVyIHRoZSBwYWdl IHdhcyBuYXZpZ2F0ZWQgYXdheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDAxMjcKKworICAgICAgICBBZGRlZCBhIGNoZWNrIGJlZm9yZSBzZW5kaW5n IGV2ZW50cyB0byB0aGUgbm90aWZpY2F0aW9uIGFuZCBiZWZvcmUgbG9nZ2luZy4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0OjpjYW5jZWwpOgor ICAgICAgICAoV2ViQ29yZTo6Tm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQ6OnNlbmRFdmVu dCk6CisKIDIwMTAtMDYtMDIgIFRhc3VrdSBTdXp1a2kgIDx0YXN1a3Uuc3V6dWtpQG5va2lhLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaGluaWNoaXJvIEhhbWFqaS4KSW5kZXg6IFdlYktp dC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRl ckNsaWVudFF0LmNwcAkocmV2aXNpb24gNjA2MTkpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NDMsNyArMTQzLDcgQEAgdm9pZCBOb3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdDo6ZGlzcAog CiB2b2lkIE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0OjpjYW5jZWwoTm90aWZpY2F0aW9u KiBub3RpZmljYXRpb24pCiB7Ci0gICAgaWYgKGR1bXBOb3RpZmljYXRpb24pIHsKKyAgICBpZiAo ZHVtcE5vdGlmaWNhdGlvbiAmJiBub3RpZmljYXRpb24tPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQo KSkgewogICAgICAgICBpZiAobm90aWZpY2F0aW9uLT5pc0hUTUwoKSkKICAgICAgICAgICAgIHBy aW50ZigiREVTS1RPUCBOT1RJRklDQVRJT04gQ0xPU0VEOiAlc1xuIiwgUVN0cmluZyhub3RpZmlj YXRpb24tPnVybCgpLnN0cmluZygpKS50b1V0ZjgoKS5jb25zdERhdGEoKSk7CiAgICAgICAgIGVs c2UKQEAgLTIyNiw3ICsyMjYsOCBAQCB2b2lkIE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0 OjphbGxvCiAKIHZvaWQgTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQ6OnNlbmRFdmVudChO b3RpZmljYXRpb24qIG5vdGlmaWNhdGlvbiwgY29uc3QgQXRvbWljU3RyaW5nJiBldmVudE5hbWUp CiB7Ci0gICAgbm90aWZpY2F0aW9uLT5kaXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVhdGUoZXZlbnRO YW1lLCBmYWxzZSwgdHJ1ZSkpOworICAgIGlmIChub3RpZmljYXRpb24tPnNjcmlwdEV4ZWN1dGlv bkNvbnRleHQoKSkKKyAgICAgICAgbm90aWZpY2F0aW9uLT5kaXNwYXRjaEV2ZW50KEV2ZW50Ojpj cmVhdGUoZXZlbnROYW1lLCBmYWxzZSwgdHJ1ZSkpOwogfQogCiB2b2lkIE5vdGlmaWNhdGlvblBy ZXNlbnRlckNsaWVudFF0OjpyZW1vdmVSZXBsYWNlZE5vdGlmaWNhdGlvbkZyb21RdWV1ZShOb3Rp ZmljYXRpb24qIG5vdGlmaWNhdGlvbikK