40078 2010-06-02 12:22:15 -0700 [Qt] QtTestLauncher should allow notifications by default. 2010-08-03 08:33:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Enhancement --- 39995 1 yael webkit-unassigned hausmann kbalazs laszlo.gombos ossy oldest_to_newest 233384 0 yael 2010-06-02 12:22:15 -0700 QtWebKit does not allow notifications to be displayed, unless the client of QtWebKit explicitly allows them. For testing purpose, QtTestLauncher should allow notifications to be displayed. 233697 1 kbalazs 2010-06-03 04:32:54 -0700 As I see the notifications API does not depend on that. On the contrary, this feature depends on the API. Please correct the dependency tree if that is the case. 233703 2 yael 2010-06-03 04:48:27 -0700 (In reply to comment #1) > As I see the notifications API does not depend on that. On the contrary, this feature depends on the API. Please correct the dependency tree if that is the case. I disagree :-) #39995 is a meta tag that lists everything I plan to do for notifications. This bug is one of the tasks I am planning to do for notifications, thus the meta bug depends on this one. 233804 3 57784 yael 2010-06-03 09:51:45 -0700 Created attachment 57784 Patch 233806 4 57784 kenneth 2010-06-03 10:03:37 -0700 Comment on attachment 57784 Patch It seems a bit strange to use DRT methods in our launcher. Are these methods supposed to be private (later public) API instead? 233814 5 yael 2010-06-03 10:27:58 -0700 (In reply to comment #4) > (From update of attachment 57784 [details]) > It seems a bit strange to use DRT methods in our launcher. Are these methods supposed to be private (later public) API instead? It seems strage to me too :-) Once the feature is more mature we should think about what public API we want to provide for it. 234178 6 57784 hausmann 2010-06-04 06:00:14 -0700 Comment on attachment 57784 Patch r=me Using it in QtTestBrowser is perhaps a good way to test and maturize the API. The current one is not designed to be public. As a side-note: This patch is going to break the symbian build, as these DRT symbols are not exported. 234194 7 yael 2010-06-04 06:51:50 -0700 Committed r60678 <http://trac.webkit.org/changeset/60678> 234260 8 laszlo.gombos 2010-06-04 10:12:16 -0700 Updated the def file for Symbian - http://trac.webkit.org/changeset/60686 259466 9 hausmann 2010-08-03 08:33:03 -0700 Revision r60678 cherry-picked into qtwebkit-2.1 with commit 720c83fa263ba3d2ce4867c118efcf646613d20b 57784 2010-06-03 09:51:45 -0700 2010-06-04 06:00:14 -0700 Patch 40078.patch text/plain 2241 yael SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwNjI2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYtMDMgIFlhZWwgQWhhcm9uICA8eWFl bC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gUXRUZXN0TGF1bmNoZXIgc2hvdWxkIGFsbG93IG5vdGlmaWNhdGlv bnMgYnkgZGVmYXVsdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQwMDc4CisKKyAgICAgICAgKiBRdFRlc3RCcm93c2VyL21haW4uY3BwOgorICAgICAg ICAoTm90aWZpY2F0aW9uc1Blcm1pc3Npb25Db250cm9sbGVyOjpOb3RpZmljYXRpb25zUGVybWlz c2lvbkNvbnRyb2xsZXIpOgorICAgICAgICAoTm90aWZpY2F0aW9uc1Blcm1pc3Npb25Db250cm9s bGVyOjpjaGVja1Blcm1pc3Npb24pOgorICAgICAgICAoTm90aWZpY2F0aW9uc1Blcm1pc3Npb25D b250cm9sbGVyOjpyZXF1ZXN0UGVybWlzc2lvbik6CisgICAgICAgIChMYXVuY2hlcldpbmRvdzo6 TGF1bmNoZXJXaW5kb3cpOgorCiAyMDEwLTA2LTAzICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJp bS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KSW5kZXg6IFdlYktpdFRvb2xzL1F0VGVzdEJy b3dzZXIvbWFpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9t YWluLmNwcAkocmV2aXNpb24gNjA2MTkpCisrKyBXZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL21h aW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Miw2ICs5MiwyOCBAQCBzdGF0aWMgYm9vbCBnVXNl RnJhbWVGbGF0dGVuaW5nID0gZmFsc2U7CiBzdGF0aWMgYm9vbCBnVXNlUUdMV2lkZ2V0Vmlld3Bv cnQgPSBmYWxzZTsKICNlbmRpZgogCitjbGFzcyBOb3RpZmljYXRpb25zUGVybWlzc2lvbkNvbnRy b2xsZXIgOiBwdWJsaWMgUU9iamVjdCB7CisgICAgUV9PQkpFQ1QKK3B1YmxpYzoKKyAgICBOb3Rp ZmljYXRpb25zUGVybWlzc2lvbkNvbnRyb2xsZXIoUU9iamVjdCogcGFyZW50KSA6IFFPYmplY3Qo cGFyZW50KSAKKyAgICB7CisgICAgICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXROb3Rp ZmljYXRpb25zUmVjZWl2ZXIodGhpcyk7CisgICAgICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0 OjpzZXRDaGVja1Blcm1pc3Npb25GdW5jdGlvbihjaGVja1Blcm1pc3Npb24pOworICAgICAgICBE dW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6c2V0UmVxdWVzdFBlcm1pc3Npb25GdW5jdGlvbihyZXF1 ZXN0UGVybWlzc2lvbik7CisgICAgfQorCisgICAgc3RhdGljIHZvaWQgY2hlY2tQZXJtaXNzaW9u KFFPYmplY3QqLCBjb25zdCBRVXJsJiwgTm90aWZpY2F0aW9uUGVybWlzc2lvbiYgcGVybWlzc2lv bikKKyAgICB7CisgICAgICAgIHBlcm1pc3Npb24gPSBOb3RpZmljYXRpb25BbGxvd2VkOworICAg IH0KKworICAgIHN0YXRpYyB2b2lkIHJlcXVlc3RQZXJtaXNzaW9uKFFPYmplY3QqLCBjb25zdCBR U3RyaW5nJiBvcmlnaW4pCisgICAgeworICAgICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6 YWxsb3dOb3RpZmljYXRpb25Gb3JPcmlnaW4ob3JpZ2luKTsKKyAgICB9Cit9OworCitOb3RpZmlj YXRpb25zUGVybWlzc2lvbkNvbnRyb2xsZXIqIG5vdGlmaWNhdGlvbnNQZXJtaXNzaW9uQ29udHJv bGxlciA9IDA7CiAKIGNsYXNzIExhdW5jaGVyV2luZG93IDogcHVibGljIE1haW5XaW5kb3cgewog ICAgIFFfT0JKRUNUCkBAIC0yMTAsNiArMjMyLDggQEAgTGF1bmNoZXJXaW5kb3c6OkxhdW5jaGVy V2luZG93KExhdW5jaGVyVwogICAgIH0KIAogICAgIGNyZWF0ZUNocm9tZSgpOworICAgIGlmICgh bm90aWZpY2F0aW9uc1Blcm1pc3Npb25Db250cm9sbGVyKQorICAgICAgICBub3RpZmljYXRpb25z UGVybWlzc2lvbkNvbnRyb2xsZXIgPSBuZXcgTm90aWZpY2F0aW9uc1Blcm1pc3Npb25Db250cm9s bGVyKFFDb3JlQXBwbGljYXRpb246Omluc3RhbmNlKCkpOwogfQogCiBMYXVuY2hlcldpbmRvdzo6 fkxhdW5jaGVyV2luZG93KCkK