40047 2010-06-02 00:03:07 -0700 document.write is not synchronous when using the HTML5 parser 2010-06-02 22:25:32 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth ap commit-queue hsivonen hyatt ian oldest_to_newest 233110 0 eric 2010-06-02 00:03:07 -0700 REGRESSION(60409): document.write is not synchronous when using the HTML5 parser It's unclear from the spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/apis-in-html-documents.html#document.write() But it seems to me that document.write() should wait until all parsing is "done" for the write before returning. In the old parser this was not an issue, as it was not as aggressive about yielding. The new HTML5 parser yields when waiting for script loads or for stylesheet loads. http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#running-a-script talks about queuing tasks on the task queue, but it doesn't really talk about the parser yielding. The old parser never seems to wait for <script src=""> tags during parsing (in violation of HTML5) nor does it block inline <script> tags ever (which HTML5 says it should for style-sheets), so I think that's how it produces a synchronous document.write behavior. 233113 1 eric 2010-06-02 00:05:53 -0700 http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.html#parsing-main-incdata Talks about: Spin the event loop until there is no style sheet blocking scripts and the script's "ready to be parser-executed" flag is set. Which may be what we need to do when the parser is supposed to be synchronous (like for document.write). 233117 2 eric 2010-06-02 00:30:38 -0700 I've tested and confirmed: The old parser does not block document.write() for <script src> loads, however it won't actually process any contents of the write (or future writes) after the <script src> until that script has loaded. I think the easiest way out of this is to remove the blocking of inline <script> tags on stylesheet loads. To do so, we'd probably have to spin the event loop inside the parser like recommend by the HTML5 spec. I don't really want to write that code (I am not even sure it's possible to spin the event loop from WebCore). I think that's something we can deal with after we turn the HTML5 parser on as the default parser. 233127 3 57632 eric 2010-06-02 01:09:38 -0700 Created attachment 57632 Patch 233132 4 57632 abarth 2010-06-02 01:21:07 -0700 Comment on attachment 57632 Patch WebCore/html/HTML5ScriptRunner.cpp:244 + // m_parsingBlockingScript.element = script; Commented out code! :( 233133 5 57633 eric 2010-06-02 01:25:36 -0700 Created attachment 57633 Patch for landing 233198 6 57633 commit-queue 2010-06-02 03:58:43 -0700 Comment on attachment 57633 Patch for landing Rejecting patch 57633 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/HTML5ScriptRunner.cpp Hunk #2 FAILED at 238. 1 out of 2 hunks FAILED -- saving rejects to file WebCore/html/HTML5ScriptRunner.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/2812104 233209 7 hsivonen 2010-06-02 04:54:01 -0700 (In reply to comment #2) > I think the easiest way out of this is to remove the blocking of inline <script> tags on stylesheet loads. It seems to me that it would be sufficient to make document.written inline scripts not wait on network loads of any kind. By inspection, it seems to me that Gecko isn't spec-compliant here. I intend to file a spec bug. 233431 8 ap 2010-06-02 13:51:41 -0700 Since this isn't an issue in any production (or nightly) configuration, I've removed the REGRESSION prefix. Please let me know if this is a problem for your workflow. 233442 9 57701 eric 2010-06-02 14:07:18 -0700 Created attachment 57701 Patch for landing 233611 10 57701 commit-queue 2010-06-02 22:25:24 -0700 Comment on attachment 57701 Patch for landing Clearing flags on attachment: 57701 Committed r60606: <http://trac.webkit.org/changeset/60606> 233612 11 commit-queue 2010-06-02 22:25:32 -0700 All reviewed patches have been landed. Closing bug. 57632 2010-06-02 01:09:38 -0700 2010-06-02 01:25:04 -0700 Patch bug-40047-20100602010937.patch text/plain 3368 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODI2ODE4MjAwNjY0NzNkMDU2NzZhZGNkNmRlOTQwZjZmNWVkZTZjNy4uMmU3NDdmNGZjODA0N2U0 ZDcyNzcwYWIxODM1NzA4M2U5YTdiYWEyNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxMC0wNi0wMiAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTig2MDQwOSk6IGRvY3VtZW50LndyaXRlIGlz IG5vdCBzeW5jaHJvbm91cyB3aGVuIHVzaW5nIHRoZSBIVE1MNSBwYXJzZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMDQ3CisKKyAgICAgICAgVGhl IEhUTUw1IHNwZWMgc3RhdGVzIHRoYXQgd2Ugc2hvdWxkICJzcGluIHRoZSBldmVudCBsb29wIiB3 aGlsZQorICAgICAgICB3YWl0aW5nIGZvciBzdHlsZXNoZWV0cyB0byBsb2FkLiAgQ3VycmVudGx5 IHdlIGRvIHRoYXQgYnkgeWllbGRpbmcKKyAgICAgICAgb3V0IG9mIHRoZSBwYXJzZXIgd2hlbiBz dHlsZXNoZWV0cyBhcmUgbG9hZGluZy4gIEJlY2F1c2UgaXQgd2FzIGVhc3kKKyAgICAgICAgd2Ug bWFkZSBpbmxpbmUgPHNjcmlwdHM+IHlpZWxkIGZvciBzdHlsZXNoZWV0IGxvYWRzIGFzIHdlbGwu ICBIb3dldmVyLAorICAgICAgICB0aGlzIGNhdXNlZCBkb2N1bWVudC53cml0ZSgpIHRvIHJldHVy biBhZnRlciBlbmNvdW50ZXJpbmcgdGhlIGZpcnN0CisgICAgICAgIGlubGluZSA8c2NyaXB0PiB0 YWcgaW4gbWFueSBjYXNlcyB3aGljaCBpcyBpbmNvcnJlY3QuICBkb2N1bWVudC53cml0ZQorICAg ICAgICBpcyBzdXBwb3NlZCB0byBibG9jayB1bnRpbCB0aGUgZW50aXJlIGRvY3VtZW50IGlzIHBh cnNlZCAoaW5jbHVkaW5nKQorICAgICAgICBleGVjdXRpbmcgaW5saW5lIHNjcmlwdCB0YWdzLiAg VG8gbWF0Y2ggdGhlIGV4aXRpbmcgcGFyc2VyLCB3ZSdsbCBqdXN0CisgICAgICAgIG1ha2UgaW5s aW5lIDxzY3JpcHQ+IHRhZ3Mgbm90IGJsb2NrIG9uIHN0eWxlc2hlZXRzIGZvciBub3cuCisKKyAg ICAgICAgVGhpcyBpcyB0ZXN0ZWQgYnkgV2ViQ29yZS9iZW5jaG1hcmtzL2h0bWwtcGFyc2VyLmh0 bWwgYXMgd2VsbAorICAgICAgICBhcyBsaWtlbHkgc2V2ZXJhbCBvdGhlciB0ZXN0cyBpbiBMYXlv dXRUZXN0cyB3aGljaCB3ZSBoYXZlbid0CisgICAgICAgIHRyaWFnZWQgeWV0LgorCisgICAgICAg ICogaHRtbC9IVE1MNVNjcmlwdFJ1bm5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MNVNj cmlwdFJ1bm5lcjo6ZXhlY3V0ZVNjcmlwdCk6CisgICAgICAgICAtIEFTU0VSVCB0aGF0IGVpdGhl ciBzdHlsZXNoZWV0cyBoYXZlIGxvYWRlZCBvciB3ZSdyZSBleGVjdXRpbmcgYW4KKyAgICAgICAg ICAgaW5saW5lIDxzY3JpcHQ+IHRhZy4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUw1U2NyaXB0UnVu bmVyOjpydW5TY3JpcHQpOgorICAgICAgICAgLSBSZW1vdmUgdGhlIGNvZGUgdG8gYmxvY2sgaW5s aW5lIDxzY3JpcHQ+IHRhZ3Mgb24gc3R5bGVzaGVldCBsb2Fkcy4KKwogMjAxMC0wNi0wMSAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjYwNTMwLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUw1 U2NyaXB0UnVubmVyLmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MNVNjcmlwdFJ1bm5lci5jcHAKaW5k ZXggM2UwY2Q3ZmI4YjE3NmExNDI0ZDM0YWEwMTBhYTM0MzA4NDNlOGU5Yy4uMWUwMzAwZDg3MTll OTVmNGUxZjAyMGE4ZTk5ZjRjMzdlMGI5MzY5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hU TUw1U2NyaXB0UnVubmVyLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTDVTY3JpcHRSdW5uZXIu Y3BwCkBAIC0xMjcsNiArMTI3LDEwIEBAIHZvaWQgSFRNTDVTY3JpcHRSdW5uZXI6OmV4ZWN1dGVQ ZW5kaW5nU2NyaXB0KCkKIAogdm9pZCBIVE1MNVNjcmlwdFJ1bm5lcjo6ZXhlY3V0ZVNjcmlwdChF bGVtZW50KiBlbGVtZW50LCBjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3VyY2VDb2RlKQogewor ICAgIC8vIEZJWE1FOiBXZSBkbyBub3QgYmxvY2sgaW5saW5lIDxzY3JpcHQ+IHRhZ3Mgb24gc3R5 bGVzaGVldHMgZm9yIG5vdy4KKyAgICAvLyBXaGVuIHdlIGRvLCAgfHwgIWVsZW1lbnQtPmhhc0F0 dHJpYnV0ZShzcmNBdHRyKSBzaG91bGQgYmUgcmVtb3ZlZCBmcm9tCisgICAgLy8gdGhlIEFTU0VS VCBiZWxvdy4gIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAw NDcKKyAgICBBU1NFUlQobV9kb2N1bWVudC0+aGF2ZVN0eWxlc2hlZXRzTG9hZGVkKCkgfHwgIWVs ZW1lbnQtPmhhc0F0dHJpYnV0ZShzcmNBdHRyKSk7CiAgICAgU2NyaXB0RWxlbWVudCogc2NyaXB0 RWxlbWVudCA9IHRvU2NyaXB0RWxlbWVudChlbGVtZW50KTsKICAgICBBU1NFUlQoc2NyaXB0RWxl bWVudCk7CiAgICAgaWYgKCFzY3JpcHRFbGVtZW50LT5zaG91bGRFeGVjdXRlQXNKYXZhU2NyaXB0 KCkpCkBAIC0yMzQsOCArMjM4LDEwIEBAIHZvaWQgSFRNTDVTY3JpcHRSdW5uZXI6OnJ1blNjcmlw dChFbGVtZW50KiBzY3JpcHQpCiAgICAgaWYgKHNjcmlwdC0+aGFzQXR0cmlidXRlKHNyY0F0dHIp KSB7CiAgICAgICAgIC8vIEZJWE1FOiBIYW5kbGUgZGVmZXIgYW5kIGFzeW5jCiAgICAgICAgIHJl cXVlc3RTY3JpcHQoc2NyaXB0KTsKLSAgICB9IGVsc2UgaWYgKCFtX2RvY3VtZW50LT5oYXZlU3R5 bGVzaGVldHNMb2FkZWQoKSkgewotICAgICAgICBtX3BhcnNpbmdCbG9ja2luZ1NjcmlwdC5lbGVt ZW50ID0gc2NyaXB0OworICAgIC8vIEZJWE1FOiBXZSBkbyBub3QgYmxvY2sgaW5saW5lIDxzY3Jp cHQ+IHRhZ3Mgb24gc3R5bGVzaGVldHMgdG8gbWF0Y2ggdGhlCisgICAgLy8gb2xkIHBhcnNlciBm b3Igbm93LiAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDA0 NworICAgIC8vIH0gZWxzZSBpZiAoIW1fZG9jdW1lbnQtPmhhdmVTdHlsZXNoZWV0c0xvYWRlZCgp KSB7CisgICAgLy8gICAgIG1fcGFyc2luZ0Jsb2NraW5nU2NyaXB0LmVsZW1lbnQgPSBzY3JpcHQ7 CiAgICAgfSBlbHNlIHsKICAgICAgICAgLy8gRklYTUU6IE5lZWQgYSBsaW5lIG51bWJlcnMgaW1w bGVtZW5hdGlvbi4KICAgICAgICAgU2NyaXB0U291cmNlQ29kZSBzb3VyY2VDb2RlKHNjcmlwdC0+ dGV4dENvbnRlbnQoKSwgZG9jdW1lbnRVUkxGb3JTY3JpcHRFeGVjdXRpb24obV9kb2N1bWVudCks IDApOwo= 57633 2010-06-02 01:25:36 -0700 2010-06-02 14:05:03 -0700 Patch for landing bug-40047-20100602012535.patch text/plain 3302 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODI2ODE4MjAwNjY0NzNkMDU2NzZhZGNkNmRlOTQwZjZmNWVkZTZjNy4uOTIxM2M1M2ZiYmQxZTkw YjUwNGMyNDMzOWU4YTRlOTcxMTI1NjBiOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxMC0wNi0wMiAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBC YXJ0aC4KKworICAgICAgICBSRUdSRVNTSU9OKDYwNDA5KTogZG9jdW1lbnQud3JpdGUgaXMgbm90 IHN5bmNocm9ub3VzIHdoZW4gdXNpbmcgdGhlIEhUTUw1IHBhcnNlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAwNDcKKworICAgICAgICBUaGUgSFRN TDUgc3BlYyBzdGF0ZXMgdGhhdCB3ZSBzaG91bGQgInNwaW4gdGhlIGV2ZW50IGxvb3AiIHdoaWxl CisgICAgICAgIHdhaXRpbmcgZm9yIHN0eWxlc2hlZXRzIHRvIGxvYWQuICBDdXJyZW50bHkgd2Ug ZG8gdGhhdCBieSB5aWVsZGluZworICAgICAgICBvdXQgb2YgdGhlIHBhcnNlciB3aGVuIHN0eWxl c2hlZXRzIGFyZSBsb2FkaW5nLiAgQmVjYXVzZSBpdCB3YXMgZWFzeQorICAgICAgICB3ZSBtYWRl IGlubGluZSA8c2NyaXB0cz4geWllbGQgZm9yIHN0eWxlc2hlZXQgbG9hZHMgYXMgd2VsbC4gIEhv d2V2ZXIsCisgICAgICAgIHRoaXMgY2F1c2VkIGRvY3VtZW50LndyaXRlKCkgdG8gcmV0dXJuIGFm dGVyIGVuY291bnRlcmluZyB0aGUgZmlyc3QKKyAgICAgICAgaW5saW5lIDxzY3JpcHQ+IHRhZyBp biBtYW55IGNhc2VzIHdoaWNoIGlzIGluY29ycmVjdC4gIGRvY3VtZW50LndyaXRlCisgICAgICAg IGlzIHN1cHBvc2VkIHRvIGJsb2NrIHVudGlsIHRoZSBlbnRpcmUgZG9jdW1lbnQgaXMgcGFyc2Vk IChpbmNsdWRpbmcpCisgICAgICAgIGV4ZWN1dGluZyBpbmxpbmUgc2NyaXB0IHRhZ3MuICBUbyBt YXRjaCB0aGUgZXhpdGluZyBwYXJzZXIsIHdlJ2xsIGp1c3QKKyAgICAgICAgbWFrZSBpbmxpbmUg PHNjcmlwdD4gdGFncyBub3QgYmxvY2sgb24gc3R5bGVzaGVldHMgZm9yIG5vdy4KKworICAgICAg ICBUaGlzIGlzIHRlc3RlZCBieSBXZWJDb3JlL2JlbmNobWFya3MvaHRtbC1wYXJzZXIuaHRtbCBh cyB3ZWxsCisgICAgICAgIGFzIGxpa2VseSBzZXZlcmFsIG90aGVyIHRlc3RzIGluIExheW91dFRl c3RzIHdoaWNoIHdlIGhhdmVuJ3QKKyAgICAgICAgdHJpYWdlZCB5ZXQuCisKKyAgICAgICAgKiBo dG1sL0hUTUw1U2NyaXB0UnVubmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUw1U2NyaXB0 UnVubmVyOjpleGVjdXRlU2NyaXB0KToKKyAgICAgICAgIC0gQVNTRVJUIHRoYXQgZWl0aGVyIHN0 eWxlc2hlZXRzIGhhdmUgbG9hZGVkIG9yIHdlJ3JlIGV4ZWN1dGluZyBhbgorICAgICAgICAgICBp bmxpbmUgPHNjcmlwdD4gdGFnLgorICAgICAgICAoV2ViQ29yZTo6SFRNTDVTY3JpcHRSdW5uZXI6 OnJ1blNjcmlwdCk6CisgICAgICAgICAtIFJlbW92ZSB0aGUgY29kZSB0byBibG9jayBpbmxpbmUg PHNjcmlwdD4gdGFncyBvbiBzdHlsZXNoZWV0IGxvYWRzLgorCiAyMDEwLTA2LTAxICBTaGVyaWZm IEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByNjA1MzAuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTDVTY3Jp cHRSdW5uZXIuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUw1U2NyaXB0UnVubmVyLmNwcAppbmRleCAz ZTBjZDdmYjhiMTc2YTE0MjRkMzRhYTAxMGFhMzQzMDg0M2U4ZTljLi40Nzg1YzI5OTJmNWJkMjFk NTRlZTc5YmFhZWE5MDJjZTE2MjZhMzJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTDVT Y3JpcHRSdW5uZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MNVNjcmlwdFJ1bm5lci5jcHAK QEAgLTEyNyw2ICsxMjcsMTAgQEAgdm9pZCBIVE1MNVNjcmlwdFJ1bm5lcjo6ZXhlY3V0ZVBlbmRp bmdTY3JpcHQoKQogCiB2b2lkIEhUTUw1U2NyaXB0UnVubmVyOjpleGVjdXRlU2NyaXB0KEVsZW1l bnQqIGVsZW1lbnQsIGNvbnN0IFNjcmlwdFNvdXJjZUNvZGUmIHNvdXJjZUNvZGUpCiB7CisgICAg Ly8gRklYTUU6IFdlIGRvIG5vdCBibG9jayBpbmxpbmUgPHNjcmlwdD4gdGFncyBvbiBzdHlsZXNo ZWV0cyBmb3Igbm93LgorICAgIC8vIFdoZW4gd2UgZG8sICB8fCAhZWxlbWVudC0+aGFzQXR0cmli dXRlKHNyY0F0dHIpIHNob3VsZCBiZSByZW1vdmVkIGZyb20KKyAgICAvLyB0aGUgQVNTRVJUIGJl bG93LiAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDA0Nwor ICAgIEFTU0VSVChtX2RvY3VtZW50LT5oYXZlU3R5bGVzaGVldHNMb2FkZWQoKSB8fCAhZWxlbWVu dC0+aGFzQXR0cmlidXRlKHNyY0F0dHIpKTsKICAgICBTY3JpcHRFbGVtZW50KiBzY3JpcHRFbGVt ZW50ID0gdG9TY3JpcHRFbGVtZW50KGVsZW1lbnQpOwogICAgIEFTU0VSVChzY3JpcHRFbGVtZW50 KTsKICAgICBpZiAoIXNjcmlwdEVsZW1lbnQtPnNob3VsZEV4ZWN1dGVBc0phdmFTY3JpcHQoKSkK QEAgLTIzNCw5ICsyMzgsOSBAQCB2b2lkIEhUTUw1U2NyaXB0UnVubmVyOjpydW5TY3JpcHQoRWxl bWVudCogc2NyaXB0KQogICAgIGlmIChzY3JpcHQtPmhhc0F0dHJpYnV0ZShzcmNBdHRyKSkgewog ICAgICAgICAvLyBGSVhNRTogSGFuZGxlIGRlZmVyIGFuZCBhc3luYwogICAgICAgICByZXF1ZXN0 U2NyaXB0KHNjcmlwdCk7Ci0gICAgfSBlbHNlIGlmICghbV9kb2N1bWVudC0+aGF2ZVN0eWxlc2hl ZXRzTG9hZGVkKCkpIHsKLSAgICAgICAgbV9wYXJzaW5nQmxvY2tpbmdTY3JpcHQuZWxlbWVudCA9 IHNjcmlwdDsKICAgICB9IGVsc2UgeworICAgICAgICAvLyBGSVhNRTogV2UgZG8gbm90IGJsb2Nr IGlubGluZSA8c2NyaXB0PiB0YWdzIG9uIHN0eWxlc2hlZXRzIHRvIG1hdGNoIHRoZQorICAgICAg ICAvLyBvbGQgcGFyc2VyIGZvciBub3cuICBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQwMDQ3CiAgICAgICAgIC8vIEZJWE1FOiBOZWVkIGEgbGluZSBudW1iZXJz IGltcGxlbWVuYXRpb24uCiAgICAgICAgIFNjcmlwdFNvdXJjZUNvZGUgc291cmNlQ29kZShzY3Jp cHQtPnRleHRDb250ZW50KCksIGRvY3VtZW50VVJMRm9yU2NyaXB0RXhlY3V0aW9uKG1fZG9jdW1l bnQpLCAwKTsKICAgICAgICAgZXhlY3V0ZVNjcmlwdChzY3JpcHQsIHNvdXJjZUNvZGUpOwo= 57701 2010-06-02 14:07:18 -0700 2010-06-02 22:25:24 -0700 Patch for landing bug-40047-20100602140659.patch text/plain 3356 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmQyNDY2MjgxYTljNDU3MmQ0ZWI4YzkwMGI1NmFmODllMzZjYmU1Zi4uMjBmYzlhM2E2ZmMzZmY0 MDE1MGI4NjI1NGRjOTE1MTY3MDJkNThkYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxMC0wNi0wMiAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBC YXJ0aC4KKworICAgICAgICBSRUdSRVNTSU9OKDYwNDA5KTogZG9jdW1lbnQud3JpdGUgaXMgbm90 IHN5bmNocm9ub3VzIHdoZW4gdXNpbmcgdGhlIEhUTUw1IHBhcnNlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAwNDcKKworICAgICAgICBUaGUgSFRN TDUgc3BlYyBzdGF0ZXMgdGhhdCB3ZSBzaG91bGQgInNwaW4gdGhlIGV2ZW50IGxvb3AiIHdoaWxl CisgICAgICAgIHdhaXRpbmcgZm9yIHN0eWxlc2hlZXRzIHRvIGxvYWQuICBDdXJyZW50bHkgd2Ug ZG8gdGhhdCBieSB5aWVsZGluZworICAgICAgICBvdXQgb2YgdGhlIHBhcnNlciB3aGVuIHN0eWxl c2hlZXRzIGFyZSBsb2FkaW5nLiAgQmVjYXVzZSBpdCB3YXMgZWFzeQorICAgICAgICB3ZSBtYWRl IGlubGluZSA8c2NyaXB0cz4geWllbGQgZm9yIHN0eWxlc2hlZXQgbG9hZHMgYXMgd2VsbC4gIEhv d2V2ZXIsCisgICAgICAgIHRoaXMgY2F1c2VkIGRvY3VtZW50LndyaXRlKCkgdG8gcmV0dXJuIGFm dGVyIGVuY291bnRlcmluZyB0aGUgZmlyc3QKKyAgICAgICAgaW5saW5lIDxzY3JpcHQ+IHRhZyBp biBtYW55IGNhc2VzIHdoaWNoIGlzIGluY29ycmVjdC4gIGRvY3VtZW50LndyaXRlCisgICAgICAg IGlzIHN1cHBvc2VkIHRvIGJsb2NrIHVudGlsIHRoZSBlbnRpcmUgZG9jdW1lbnQgaXMgcGFyc2Vk IChpbmNsdWRpbmcpCisgICAgICAgIGV4ZWN1dGluZyBpbmxpbmUgc2NyaXB0IHRhZ3MuICBUbyBt YXRjaCB0aGUgZXhpdGluZyBwYXJzZXIsIHdlJ2xsIGp1c3QKKyAgICAgICAgbWFrZSBpbmxpbmUg PHNjcmlwdD4gdGFncyBub3QgYmxvY2sgb24gc3R5bGVzaGVldHMgZm9yIG5vdy4KKworICAgICAg ICBUaGlzIGlzIHRlc3RlZCBieSBXZWJDb3JlL2JlbmNobWFya3MvaHRtbC1wYXJzZXIuaHRtbCBh cyB3ZWxsCisgICAgICAgIGFzIGxpa2VseSBzZXZlcmFsIG90aGVyIHRlc3RzIGluIExheW91dFRl c3RzIHdoaWNoIHdlIGhhdmVuJ3QKKyAgICAgICAgdHJpYWdlZCB5ZXQuCisKKyAgICAgICAgKiBo dG1sL0hUTUw1U2NyaXB0UnVubmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUw1U2NyaXB0 UnVubmVyOjpleGVjdXRlU2NyaXB0KToKKyAgICAgICAgIC0gQVNTRVJUIHRoYXQgZWl0aGVyIHN0 eWxlc2hlZXRzIGhhdmUgbG9hZGVkIG9yIHdlJ3JlIGV4ZWN1dGluZyBhbgorICAgICAgICAgICBp bmxpbmUgPHNjcmlwdD4gdGFnLgorICAgICAgICAoV2ViQ29yZTo6SFRNTDVTY3JpcHRSdW5uZXI6 OnJ1blNjcmlwdCk6CisgICAgICAgICAtIFJlbW92ZSB0aGUgY29kZSB0byBibG9jayBpbmxpbmUg PHNjcmlwdD4gdGFncyBvbiBzdHlsZXNoZWV0IGxvYWRzLgorCiAyMDEwLTA2LTAyICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2Fy bHNzb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTDVTY3JpcHRSdW5uZXIuY3BwIGIv V2ViQ29yZS9odG1sL0hUTUw1U2NyaXB0UnVubmVyLmNwcAppbmRleCAwNTVhZGQ5ZGY2YzRiOTlh MGM1ZDBkNzA2MzdlNTZmODRjOWE3MTczLi4wYTc1YTg0NmI3NjUzNGFlMGNjY2VhYjFhNjllYTBm YWY3OTFhMTIyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTDVTY3JpcHRSdW5uZXIuY3Bw CisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MNVNjcmlwdFJ1bm5lci5jcHAKQEAgLTEyNyw2ICsxMjcs MTAgQEAgdm9pZCBIVE1MNVNjcmlwdFJ1bm5lcjo6ZXhlY3V0ZVBlbmRpbmdTY3JpcHQoKQogCiB2 b2lkIEhUTUw1U2NyaXB0UnVubmVyOjpleGVjdXRlU2NyaXB0KEVsZW1lbnQqIGVsZW1lbnQsIGNv bnN0IFNjcmlwdFNvdXJjZUNvZGUmIHNvdXJjZUNvZGUpCiB7CisgICAgLy8gRklYTUU6IFdlIGRv IG5vdCBibG9jayBpbmxpbmUgPHNjcmlwdD4gdGFncyBvbiBzdHlsZXNoZWV0cyBmb3Igbm93Lgor ICAgIC8vIFdoZW4gd2UgZG8sICB8fCAhZWxlbWVudC0+aGFzQXR0cmlidXRlKHNyY0F0dHIpIHNo b3VsZCBiZSByZW1vdmVkIGZyb20KKyAgICAvLyB0aGUgQVNTRVJUIGJlbG93LiAgU2VlIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDA0NworICAgIEFTU0VSVChtX2Rv Y3VtZW50LT5oYXZlU3R5bGVzaGVldHNMb2FkZWQoKSB8fCAhZWxlbWVudC0+aGFzQXR0cmlidXRl KHNyY0F0dHIpKTsKICAgICBTY3JpcHRFbGVtZW50KiBzY3JpcHRFbGVtZW50ID0gdG9TY3JpcHRF bGVtZW50KGVsZW1lbnQpOwogICAgIEFTU0VSVChzY3JpcHRFbGVtZW50KTsKICAgICBpZiAoIXNj cmlwdEVsZW1lbnQtPnNob3VsZEV4ZWN1dGVBc0phdmFTY3JpcHQoKSkKQEAgLTIzNCwxMCArMjM4 LDkgQEAgdm9pZCBIVE1MNVNjcmlwdFJ1bm5lcjo6cnVuU2NyaXB0KEVsZW1lbnQqIHNjcmlwdCwg aW50IHN0YXJ0aW5nTGluZU51bWJlcikKICAgICBpZiAoc2NyaXB0LT5oYXNBdHRyaWJ1dGUoc3Jj QXR0cikpIHsKICAgICAgICAgLy8gRklYTUU6IEhhbmRsZSBkZWZlciBhbmQgYXN5bmMKICAgICAg ICAgcmVxdWVzdFNjcmlwdChzY3JpcHQpOwotICAgIH0gZWxzZSBpZiAoIW1fZG9jdW1lbnQtPmhh dmVTdHlsZXNoZWV0c0xvYWRlZCgpKSB7Ci0gICAgICAgIG1fcGFyc2luZ0Jsb2NraW5nU2NyaXB0 LmVsZW1lbnQgPSBzY3JpcHQ7Ci0gICAgICAgIG1fcGFyc2luZ0Jsb2NraW5nU2NyaXB0LnN0YXJ0 aW5nTGluZU51bWJlciA9IHN0YXJ0aW5nTGluZU51bWJlcjsKICAgICB9IGVsc2UgeworICAgICAg ICAvLyBGSVhNRTogV2UgZG8gbm90IGJsb2NrIGlubGluZSA8c2NyaXB0PiB0YWdzIG9uIHN0eWxl c2hlZXRzIHRvIG1hdGNoIHRoZQorICAgICAgICAvLyBvbGQgcGFyc2VyIGZvciBub3cuICBTZWUg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMDQ3CiAgICAgICAgIFNj cmlwdFNvdXJjZUNvZGUgc291cmNlQ29kZShzY3JpcHQtPnRleHRDb250ZW50KCksIGRvY3VtZW50 VVJMRm9yU2NyaXB0RXhlY3V0aW9uKG1fZG9jdW1lbnQpLCBzdGFydGluZ0xpbmVOdW1iZXIpOwog ICAgICAgICBleGVjdXRlU2NyaXB0KHNjcmlwdCwgc291cmNlQ29kZSk7CiAgICAgfQo=