39694 2010-05-25 15:34:32 -0700 [Qt] GraphicsLayer: warnings when reloading page 2010-06-01 22:40:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED Qt P2 Normal --- 38744 1 noam webkit-unassigned commit-queue hausmann oldest_to_newest 230504 0 noam 2010-05-25 15:34:32 -0700 The following warnings appear at times: QPainter::begin: Paint device returned engine == 0, type: 2 QPainter::setRenderHint: Painter must be active to set rendering hints QPainter::end: Painter not active, aborted 230509 1 57049 noam 2010-05-25 15:47:21 -0700 Created attachment 57049 Fix the warnings by making sure we don't recache/mask empty layers 232808 2 57562 noam 2010-06-01 10:20:10 -0700 Created attachment 57562 Same thing without the extra tab 233050 3 57562 commit-queue 2010-06-01 20:40:10 -0700 Comment on attachment 57562 Same thing without the extra tab Clearing flags on attachment: 57562 Committed r60532: <http://trac.webkit.org/changeset/60532> 233051 4 commit-queue 2010-06-01 20:40:15 -0700 All reviewed patches have been landed. Closing bug. 233083 5 hausmann 2010-06-01 22:39:35 -0700 Revision r60532 cherry-picked into qtwebkit-2.0 with commit 57c68f5a29404093d801c8f76f70d573712ddea3 57049 2010-05-25 15:47:21 -0700 2010-06-01 10:20:10 -0700 Fix the warnings by making sure we don't recache/mask empty layers patch-39694-1.diff text/plain 2083 noam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTc0NzE1Yi4uYjgwYjJiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNS0yNSAgTm8nYW0gUm9zZW50 aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gR3JhcGhpY3NMYXllcjogd2FybmluZ3Mgd2hl biByZWxvYWRpbmcgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mzk2OTQKKworICAgICAgICBNYWRlIHN1cmUgcmVjYWNoaW5nIGFuZCBtYXNrcyBh cmVuJ3QgYXR0ZW1wdGVkIG9uIHplcm8tc2l6ZSBsYXllcnMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBPbGQgdGVzdHMgKGUuZy4gTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvbWFza3MpIHNob3cg dGhlIHByb2JsZW0uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xh eWVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWFza0VmZmVjdFF0OjpkcmF3KToKKyAgICAg ICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJRdEltcGw6OnJlY2FjaGUpOgorCiAyMDEwLTA1LTI1 ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvR3JhcGhpY3NMYXllclF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3Jh cGhpY3NMYXllclF0LmNwcAppbmRleCBiZTU0NzM1Li42ZjAwYjQ3IDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwCkBAIC01OSw3ICs1OSwx MiBAQCBwdWJsaWM6CiAgICAgICAgIC8vIChhKSBXZSBkb24ndCBuZWVkIHRoZSBRQnJ1c2ggYWJz dHJhY3Rpb24gLSB3ZSBhbHdheXMgZW5kIHVwIHVzaW5nIFFHcmFwaGljc0l0ZW06OnBhaW50CiAg ICAgICAgIC8vICAgICBmcm9tIHRoZSBtYXNrIGxheWVyLgogICAgICAgICAvLyAoYikgUUdyYXBo aWNzT3BhY2l0eUVmZmVjdCBkZXRhY2hlcyB0aGUgcGl4bWFwLCB3aGljaCBpcyBpbmVmZmljaWVu dCBvbiBPcGVuR0wuCi0gICAgICAgIFFQaXhtYXAgbWFza1BpeG1hcChzb3VyY2VCb3VuZGluZ1Jl Y3QoKS50b0FsaWduZWRSZWN0KCkuc2l6ZSgpKTsKKyAgICAgICAgY29uc3QgUVNpemUgbWFza1Np emUgPSBzb3VyY2VCb3VuZGluZ1JlY3QoKS50b0FsaWduZWRSZWN0KCkuc2l6ZSgpOworICAgICAg ICBpZiAoIW1hc2tTaXplLmlzVmFsaWQoKSB8fCBtYXNrU2l6ZS5pc0VtcHR5KCkpIHsKKyAgICAg ICAgICAgIGRyYXdTb3VyY2UocGFpbnRlcik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAg IH0KKyAgICAgICAgUVBpeG1hcCBtYXNrUGl4bWFwKG1hc2tTaXplKTsKIAogICAgICAgICAvLyBX ZSBuZWVkIHRvIGRvIHRoaXMgc28gdGhlIHBpeG1hcCB3b3VsZCBoYXZlIGhhc0FscGhhKCkuCiAg ICAgICAgIG1hc2tQaXhtYXAuZmlsbChRdDo6dHJhbnNwYXJlbnQpOwpAQCAtMzM0LDggKzMzOSw4 IEBAIGNvbnN0IEdyYXBoaWNzTGF5ZXJRdEltcGwqIEdyYXBoaWNzTGF5ZXJRdEltcGw6OnJvb3RM YXllcigpIGNvbnN0CiAKIFFQaXhtYXAgR3JhcGhpY3NMYXllclF0SW1wbDo6cmVjYWNoZShjb25z dCBRUmVnaW9uJiByZWdpb25Ub1VwZGF0ZSkKIHsKLSAgICBpZiAoIW1fbGF5ZXItPmRyYXdzQ29u dGVudCgpKQotICAgICAgICByZXR1cm4gUVBpeG1hcCgpOworICAgIGlmICghbV9sYXllci0+ZHJh d3NDb250ZW50KCkgfHwgbV9zaXplLmlzRW1wdHkoKSB8fCFtX3NpemUuaXNWYWxpZCgpKQorICAg ICAgICAgICAgcmV0dXJuIFFQaXhtYXAoKTsKIAogICAgIFFSZWdpb24gcmVnaW9uID0gcmVnaW9u VG9VcGRhdGU7CiAgICAgUVBpeG1hcCBwaXhtYXA7Cg== 57562 2010-06-01 10:20:10 -0700 2010-06-01 20:40:10 -0700 Same thing without the extra tab patch-39694-1.diff text/plain 2079 noam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTc0NzE1Yi4uYjgwYjJiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNS0yNSAgTm8nYW0gUm9zZW50 aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gR3JhcGhpY3NMYXllcjogd2FybmluZ3Mgd2hl biByZWxvYWRpbmcgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mzk2OTQKKworICAgICAgICBNYWRlIHN1cmUgcmVjYWNoaW5nIGFuZCBtYXNrcyBh cmVuJ3QgYXR0ZW1wdGVkIG9uIHplcm8tc2l6ZSBsYXllcnMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBPbGQgdGVzdHMgKGUuZy4gTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvbWFza3MpIHNob3cg dGhlIHByb2JsZW0uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xh eWVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWFza0VmZmVjdFF0OjpkcmF3KToKKyAgICAg ICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJRdEltcGw6OnJlY2FjaGUpOgorCiAyMDEwLTA1LTI1 ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvR3JhcGhpY3NMYXllclF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3Jh cGhpY3NMYXllclF0LmNwcAppbmRleCBiZTU0NzM1Li42ZjAwYjQ3IDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwCkBAIC01OSw3ICs1OSwx MiBAQCBwdWJsaWM6CiAgICAgICAgIC8vIChhKSBXZSBkb24ndCBuZWVkIHRoZSBRQnJ1c2ggYWJz dHJhY3Rpb24gLSB3ZSBhbHdheXMgZW5kIHVwIHVzaW5nIFFHcmFwaGljc0l0ZW06OnBhaW50CiAg ICAgICAgIC8vICAgICBmcm9tIHRoZSBtYXNrIGxheWVyLgogICAgICAgICAvLyAoYikgUUdyYXBo aWNzT3BhY2l0eUVmZmVjdCBkZXRhY2hlcyB0aGUgcGl4bWFwLCB3aGljaCBpcyBpbmVmZmljaWVu dCBvbiBPcGVuR0wuCi0gICAgICAgIFFQaXhtYXAgbWFza1BpeG1hcChzb3VyY2VCb3VuZGluZ1Jl Y3QoKS50b0FsaWduZWRSZWN0KCkuc2l6ZSgpKTsKKyAgICAgICAgY29uc3QgUVNpemUgbWFza1Np emUgPSBzb3VyY2VCb3VuZGluZ1JlY3QoKS50b0FsaWduZWRSZWN0KCkuc2l6ZSgpOworICAgICAg ICBpZiAoIW1hc2tTaXplLmlzVmFsaWQoKSB8fCBtYXNrU2l6ZS5pc0VtcHR5KCkpIHsKKyAgICAg ICAgICAgIGRyYXdTb3VyY2UocGFpbnRlcik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAg IH0KKyAgICAgICAgUVBpeG1hcCBtYXNrUGl4bWFwKG1hc2tTaXplKTsKIAogICAgICAgICAvLyBX ZSBuZWVkIHRvIGRvIHRoaXMgc28gdGhlIHBpeG1hcCB3b3VsZCBoYXZlIGhhc0FscGhhKCkuCiAg ICAgICAgIG1hc2tQaXhtYXAuZmlsbChRdDo6dHJhbnNwYXJlbnQpOwpAQCAtMzM0LDggKzMzOSw4 IEBAIGNvbnN0IEdyYXBoaWNzTGF5ZXJRdEltcGwqIEdyYXBoaWNzTGF5ZXJRdEltcGw6OnJvb3RM YXllcigpIGNvbnN0CiAKIFFQaXhtYXAgR3JhcGhpY3NMYXllclF0SW1wbDo6cmVjYWNoZShjb25z dCBRUmVnaW9uJiByZWdpb25Ub1VwZGF0ZSkKIHsKLSAgICBpZiAoIW1fbGF5ZXItPmRyYXdzQ29u dGVudCgpKQotICAgICAgICByZXR1cm4gUVBpeG1hcCgpOworICAgIGlmICghbV9sYXllci0+ZHJh d3NDb250ZW50KCkgfHwgbV9zaXplLmlzRW1wdHkoKSB8fCFtX3NpemUuaXNWYWxpZCgpKQorICAg ICAgICByZXR1cm4gUVBpeG1hcCgpOwogCiAgICAgUVJlZ2lvbiByZWdpb24gPSByZWdpb25Ub1Vw ZGF0ZTsKICAgICBRUGl4bWFwIHBpeG1hcDsK