39667 2010-05-25 04:05:24 -0700 [BREWMP] Add more types to OwnPtr 2010-06-07 18:31:20 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned abarth beergun commit-queue joybro201 webkit.review.bot oldest_to_newest 230206 0 skyul 2010-05-25 04:05:24 -0700 Add ISSL and ISocket to the list of OwnPtr-ed type. 230210 1 57003 skyul 2010-05-25 04:07:51 -0700 Created attachment 57003 Patch ISocket and ISSL are used to implement SocketStream. 230211 2 webkit.review.bot 2010-05-25 04:10:18 -0700 Attachment 57003 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/wtf/brew/OwnPtrBrew.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 230212 3 57004 skyul 2010-05-25 04:13:52 -0700 Created attachment 57004 Patch Style fix. 234543 4 57004 eric 2010-06-04 23:02:37 -0700 Comment on attachment 57004 Patch OK. 234561 5 57004 commit-queue 2010-06-05 00:18:36 -0700 Comment on attachment 57004 Patch Rejecting patch 57004 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html 234729 6 57996 skyul 2010-06-06 23:53:09 -0700 Created attachment 57996 Patch Add missing ChangeLog. 234892 7 57004 eric 2010-06-07 09:40:18 -0700 Comment on attachment 57004 Patch Cleared Eric Seidel's review+ from obsolete attachment 57004 so that this bug does not appear in http://webkit.org/pending-commit. 234903 8 57996 eric 2010-06-07 10:04:35 -0700 Comment on attachment 57996 Patch OK. 234922 9 57996 commit-queue 2010-06-07 10:34:20 -0700 Comment on attachment 57996 Patch Clearing flags on attachment: 57996 Committed r60787: <http://trac.webkit.org/changeset/60787> 234923 10 commit-queue 2010-06-07 10:34:25 -0700 All reviewed patches have been landed. Closing bug. 234972 11 abarth 2010-06-07 11:51:16 -0700 Turns out OwnPtrCommon.h is a really bad design. This changed needlessly caused all ports to do full rebuilds. We should change OwnPtrCommon to include platform-specific headers instead. 235081 12 skyul 2010-06-07 18:31:20 -0700 (In reply to comment #11) > Turns out OwnPtrCommon.h is a really bad design. > > This changed needlessly caused all ports to do full rebuilds. > > We should change OwnPtrCommon to include platform-specific headers instead. I agree. I will file a bug to change OwnPtrCommon to include platform-specific headers. We need to add only Win32 and Brew MP headers for now. 57003 2010-05-25 04:07:51 -0700 2010-05-25 04:13:52 -0700 Patch OwnPtrBrew.patch text/plain 2114 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYwMTUzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMjUgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBBZGQgbW9yZSB0eXBlcyB0byBPd25QdHIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NjY3CisK KyAgICAgICAgQWRkIElTU0wgYW5kIElTb2NrZXQgdG8gdGhlIGxpc3Qgb2YgT3duUHRyLWVkIHR5 cGUuCisKKyAgICAgICAgKiB3dGYvT3duUHRyQ29tbW9uLmg6CisgICAgICAgICogd3RmL2JyZXcv T3duUHRyQnJldy5jcHA6CisgICAgICAgIChXVEY6OmRlbGV0ZU93bmVkUHRyKToKKwogMjAxMC0w NS0yNCAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9Pd25Q dHJDb21tb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyQ29tbW9u LmgJKHJldmlzaW9uIDYwMTUzKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL093blB0ckNvbW1vbi5o CSh3b3JraW5nIGNvcHkpCkBAIC00MSw5ICs0MSwxMSBAQCB0eXBlZGVmIHN0cnVjdCBIUkdOX18q IEhSR047CiAjaWYgUExBVEZPUk0oQlJFV01QKQogLy8gRm9yd2FyZCBkZWxjYXJhdGlvbnMgYXQg dGhpcyBwb2ludCBhdm9pZCB0aGUgbmVlZCB0byBpbmNsdWRlIEJSRVcgaW5jbHVkZXMKIC8vIGlu IFdURiBoZWFkZXJzLgordHlwZWRlZiBzdHJ1Y3QgX0lTb2NrZXQgSVNvY2tldDsKIHR5cGVkZWYg c3RydWN0IF9JRmlsZU1nciBJRmlsZU1ncjsKIHR5cGVkZWYgc3RydWN0IF9JRmlsZSBJRmlsZTsK IHR5cGVkZWYgc3RydWN0IElCaXRtYXAgSUJpdG1hcDsKK3R5cGVkZWYgc3RydWN0IElTU0wgSVNT TDsKICNlbmRpZgogCiBuYW1lc3BhY2UgV1RGIHsKQEAgLTY5LDYgKzcxLDggQEAgbmFtZXNwYWNl IFdURiB7CiAgICAgdm9pZCBkZWxldGVPd25lZFB0cihJRmlsZU1nciopOwogICAgIHZvaWQgZGVs ZXRlT3duZWRQdHIoSUZpbGUqKTsKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKElCaXRtYXAqKTsK KyAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKElTU0wqKTsKKyAgICB2b2lkIGRlbGV0ZU93bmVkUHRy KElTb2NrZXQqKTsKICNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBXVEYKSW5kZXg6IEphdmFTY3Jp cHRDb3JlL3d0Zi9icmV3L093blB0ckJyZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRD b3JlL3d0Zi9icmV3L093blB0ckJyZXcuY3BwCShyZXZpc2lvbiA2MDE1MykKKysrIEphdmFTY3Jp cHRDb3JlL3d0Zi9icmV3L093blB0ckJyZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw3ICsy OCw5IEBACiAKICNpbmNsdWRlIDxBRUVCaXRtYXAuaD4KICNpbmNsdWRlIDxBRUVGaWxlLmg+Cisj aW5jbHVkZSA8QUVFTmV0Lmg+CiAjaW5jbHVkZSA8QUVFU3RkTGliLmg+CisjaW5jbHVkZSA8QUVF U1NMLmg+CiAKIG5hbWVzcGFjZSBXVEYgewogCkBAIC01MCw0ICs1MiwxNiBAQCB2b2lkIGRlbGV0 ZU93bmVkUHRyKElCaXRtYXAqIHB0cikKICAgICAgICAgSUJpdG1hcF9SZWxlYXNlKHB0cik7CiB9 CiAKK3ZvaWQgZGVsZXRlT3duZWRQdHIoSVNTTCogcHRyKQoreworICAgIGlmIChwdHIpCisgICAg ICAgIElTU0xfUmVsZWFzZShwdHIpOworfQorCit2b2lkIGRlbGV0ZU93bmVkUHRyKElTb2NrZXQq IHB0cikKK3sKKyAgICBpZiAocHRyKQorICAgICAgICBJU09DS0VUX1JlbGVhc2UocHRyKTsKK30K KwogfQo= 57004 2010-05-25 04:13:52 -0700 2010-06-07 09:40:18 -0700 Patch OwnPtrBrew.patch text/plain 1458 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHJDb21tb24uaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvT3duUHRyQ29tbW9uLmgJKHJldmlzaW9uIDYwMTUzKQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL093blB0ckNvbW1vbi5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw5ICs0 MSwxMSBAQCB0eXBlZGVmIHN0cnVjdCBIUkdOX18qIEhSR047CiAjaWYgUExBVEZPUk0oQlJFV01Q KQogLy8gRm9yd2FyZCBkZWxjYXJhdGlvbnMgYXQgdGhpcyBwb2ludCBhdm9pZCB0aGUgbmVlZCB0 byBpbmNsdWRlIEJSRVcgaW5jbHVkZXMKIC8vIGluIFdURiBoZWFkZXJzLgordHlwZWRlZiBzdHJ1 Y3QgX0lTb2NrZXQgSVNvY2tldDsKIHR5cGVkZWYgc3RydWN0IF9JRmlsZU1nciBJRmlsZU1ncjsK IHR5cGVkZWYgc3RydWN0IF9JRmlsZSBJRmlsZTsKIHR5cGVkZWYgc3RydWN0IElCaXRtYXAgSUJp dG1hcDsKK3R5cGVkZWYgc3RydWN0IElTU0wgSVNTTDsKICNlbmRpZgogCiBuYW1lc3BhY2UgV1RG IHsKQEAgLTY5LDYgKzcxLDggQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgdm9pZCBkZWxldGVPd25l ZFB0cihJRmlsZU1nciopOwogICAgIHZvaWQgZGVsZXRlT3duZWRQdHIoSUZpbGUqKTsKICAgICB2 b2lkIGRlbGV0ZU93bmVkUHRyKElCaXRtYXAqKTsKKyAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKElT U0wqKTsKKyAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKElTb2NrZXQqKTsKICNlbmRpZgogCiB9IC8v IG5hbWVzcGFjZSBXVEYKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9icmV3L093blB0ckJyZXcu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9icmV3L093blB0ckJyZXcuY3Bw CShyZXZpc2lvbiA2MDE1MykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9icmV3L093blB0ckJyZXcu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw4IEBACiAKICNpbmNsdWRlIDxBRUVCaXRt YXAuaD4KICNpbmNsdWRlIDxBRUVGaWxlLmg+CisjaW5jbHVkZSA8QUVFTmV0Lmg+CisjaW5jbHVk ZSA8QUVFU1NMLmg+CiAjaW5jbHVkZSA8QUVFU3RkTGliLmg+CiAKIG5hbWVzcGFjZSBXVEYgewpA QCAtNTAsNCArNTIsMTYgQEAgdm9pZCBkZWxldGVPd25lZFB0cihJQml0bWFwKiBwdHIpCiAgICAg ICAgIElCaXRtYXBfUmVsZWFzZShwdHIpOwogfQogCit2b2lkIGRlbGV0ZU93bmVkUHRyKElTU0wq IHB0cikKK3sKKyAgICBpZiAocHRyKQorICAgICAgICBJU1NMX1JlbGVhc2UocHRyKTsKK30KKwor dm9pZCBkZWxldGVPd25lZFB0cihJU29ja2V0KiBwdHIpCit7CisgICAgaWYgKHB0cikKKyAgICAg ICAgSVNPQ0tFVF9SZWxlYXNlKHB0cik7Cit9CisKIH0K 57996 2010-06-06 23:53:09 -0700 2010-06-07 10:34:20 -0700 Patch OwnPtrBrew.patch text/plain 2133 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYwNzY5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYtMDYgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBBZGQgbW9yZSB0eXBlcyB0byBPd25QdHIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NjY3CisK KyAgICAgICAgQWRkIElTU0wgYW5kIElTb2NrZXQgdG8gdGhlIGxpc3Qgb2YgT3duUHRyLWVkIHR5 cGUuCisKKyAgICAgICAgKiB3dGYvT3duUHRyQ29tbW9uLmg6CisgICAgICAgICogd3RmL2JyZXcv T3duUHRyQnJldy5jcHA6CisgICAgICAgIChXVEY6OmRlbGV0ZU93bmVkUHRyKToKKwogMjAxMC0w Ni0wNiAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZICh3aW5kb3dzIGJ1aWxkIGZpeCBwdCAyKS4KSW5kZXg6IEph dmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHJDb21tb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS93dGYvT3duUHRyQ29tbW9uLmgJKHJldmlzaW9uIDYwNzY3KQorKysgSmF2YVNjcmlwdENv cmUvd3RmL093blB0ckNvbW1vbi5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw5ICs0MSwxMSBAQCB0 eXBlZGVmIHN0cnVjdCBIUkdOX18qIEhSR047CiAjaWYgUExBVEZPUk0oQlJFV01QKQogLy8gRm9y d2FyZCBkZWxjYXJhdGlvbnMgYXQgdGhpcyBwb2ludCBhdm9pZCB0aGUgbmVlZCB0byBpbmNsdWRl IEJSRVcgaW5jbHVkZXMKIC8vIGluIFdURiBoZWFkZXJzLgordHlwZWRlZiBzdHJ1Y3QgX0lTb2Nr ZXQgSVNvY2tldDsKIHR5cGVkZWYgc3RydWN0IF9JRmlsZU1nciBJRmlsZU1ncjsKIHR5cGVkZWYg c3RydWN0IF9JRmlsZSBJRmlsZTsKIHR5cGVkZWYgc3RydWN0IElCaXRtYXAgSUJpdG1hcDsKK3R5 cGVkZWYgc3RydWN0IElTU0wgSVNTTDsKICNlbmRpZgogCiBuYW1lc3BhY2UgV1RGIHsKQEAgLTY5 LDYgKzcxLDggQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgdm9pZCBkZWxldGVPd25lZFB0cihJRmls ZU1nciopOwogICAgIHZvaWQgZGVsZXRlT3duZWRQdHIoSUZpbGUqKTsKICAgICB2b2lkIGRlbGV0 ZU93bmVkUHRyKElCaXRtYXAqKTsKKyAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKElTU0wqKTsKKyAg ICB2b2lkIGRlbGV0ZU93bmVkUHRyKElTb2NrZXQqKTsKICNlbmRpZgogCiB9IC8vIG5hbWVzcGFj ZSBXVEYKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9icmV3L093blB0ckJyZXcuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9icmV3L093blB0ckJyZXcuY3BwCShyZXZpc2lv biA2MDc2NykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9icmV3L093blB0ckJyZXcuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw4IEBACiAKICNpbmNsdWRlIDxBRUVCaXRtYXAuaD4KICNp bmNsdWRlIDxBRUVGaWxlLmg+CisjaW5jbHVkZSA8QUVFTmV0Lmg+CisjaW5jbHVkZSA8QUVFU1NM Lmg+CiAjaW5jbHVkZSA8QUVFU3RkTGliLmg+CiAKIG5hbWVzcGFjZSBXVEYgewpAQCAtNTAsNCAr NTIsMTYgQEAgdm9pZCBkZWxldGVPd25lZFB0cihJQml0bWFwKiBwdHIpCiAgICAgICAgIElCaXRt YXBfUmVsZWFzZShwdHIpOwogfQogCit2b2lkIGRlbGV0ZU93bmVkUHRyKElTU0wqIHB0cikKK3sK KyAgICBpZiAocHRyKQorICAgICAgICBJU1NMX1JlbGVhc2UocHRyKTsKK30KKwordm9pZCBkZWxl dGVPd25lZFB0cihJU29ja2V0KiBwdHIpCit7CisgICAgaWYgKHB0cikKKyAgICAgICAgSVNPQ0tF VF9SZWxlYXNlKHB0cik7Cit9CisKIH0K