39581 2010-05-23 23:21:23 -0700 [DRT/Chromium] Import layout_test_helper for Windows 2010-05-24 21:16:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Windows XP RESOLVED FIXED P2 Normal --- 35902 1 tkent webkit-unassigned dglazkov hamaji webkit.review.bot oldest_to_newest 229611 0 tkent 2010-05-23 23:21:23 -0700 [DRT/Chromium] Import layout_test_helper for Windows 229613 1 56849 tkent 2010-05-23 23:25:48 -0700 Created attachment 56849 Patch ([build/include_order] error expected) 229615 2 webkit.review.bot 2010-05-23 23:27:43 -0700 Attachment 56849 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/chromium/LayoutTestHelperWin.cpp:31: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 229732 3 56849 dglazkov 2010-05-24 07:28:05 -0700 Comment on attachment 56849 Patch ([build/include_order] error expected) ok. 230073 4 56849 tkent 2010-05-24 21:16:12 -0700 Comment on attachment 56849 Patch ([build/include_order] error expected) Clearing flags on attachment: 56849 Committed r60123: <http://trac.webkit.org/changeset/60123> 230074 5 tkent 2010-05-24 21:16:21 -0700 All reviewed patches have been landed. Closing bug. 56849 2010-05-23 23:25:48 -0700 2010-05-24 21:16:12 -0700 Patch ([build/include_order] error expected) bug-39581-20100524152546.patch text/plain 5687 tkent ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDA3ZTZlZGIyZTE2MDVjMDU3Y2E1M2VmNzQzODBiNjNkZjBhMWM3ZTUu LjljNGNiNjRlZDI0MGUxMTQ2OWUxM2I0YzAxYTMzMzk0YWM2NTIzZTcgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEyIEBACisyMDEwLTA1LTIzICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb RFJUL0Nocm9taXVtXSBJbXBvcnQgbGF5b3V0X3Rlc3RfaGVscGVyIGZvciBXaW5kb3dzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTU4MQorCisgICAg ICAgICogV2ViS2l0Lmd5cDogQWRkIGEgYnVpbGQgcnVsZSBmb3IgTGF5b3V0VGVzdEhlbHBlci5l eGUgZm9yIFdpbmRvd3MuCisKIDIwMTAtMDUtMjEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2Nocm9taXVtL1dlYktpdC5neXAgYi9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAppbmRl eCA5NGQ3YTQ2ODgxNzkwMGU3YWMxZDdhYTBmMTJmYmEwMGFjMDE2NTdlLi5mN2ExNGU4NzE2MGZl M2YwOWI3NGIwM2U0MGQyZWJkYWIyMjNkN2E2IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0v V2ViS2l0Lmd5cAorKysgYi9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cApAQCAtNTgxLDYgKzU4 MSw4IEBACiAgICAgICAgICAgICBdLAogICAgICAgICAgICAgJ2NvbmRpdGlvbnMnOiBbCiAgICAg ICAgICAgICAgICAgWydPUz09IndpbiInLCB7CisgICAgICAgICAgICAgICAgICAgICdkZXBlbmRl bmNpZXMnOiBbJ0xheW91dFRlc3RIZWxwZXInXSwKKwogICAgICAgICAgICAgICAgICAgICAncmVz b3VyY2VfaW5jbHVkZV9kaXJzJzogWyc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQn XSwKICAgICAgICAgICAgICAgICAgICAgJ3NvdXJjZXMnOiBbCiAgICAgICAgICAgICAgICAgICAg ICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS9uZXQvbmV0X3Jlc291cmNlcy5yYycsCkBA IC02NTEsNiArNjUzLDEzIEBACiAgICAgICAgIH0sCiAgICAgXSwgIyB0YXJnZXRzCiAgICAgJ2Nv bmRpdGlvbnMnOiBbCisgICAgICAgIFsnT1M9PSJ3aW4iJywgeworICAgICAgICAgICAgJ3Rhcmdl dHMnOiBbeworICAgICAgICAgICAgICAgICd0YXJnZXRfbmFtZSc6ICdMYXlvdXRUZXN0SGVscGVy JywKKyAgICAgICAgICAgICAgICAndHlwZSc6ICdleGVjdXRhYmxlJywKKyAgICAgICAgICAgICAg ICAnc291cmNlcyc6IFsnLi4vLi4vV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v TGF5b3V0VGVzdEhlbHBlcldpbi5jcHAnXSwKKyAgICAgICAgICAgIH1dLAorICAgICAgICB9XSwK ICAgICAgICAgWydPUz09Im1hYyInLCB7CiAgICAgICAgICAgICAndGFyZ2V0cyc6IFsKICAgICAg ICAgICAgICAgICB7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRU b29scy9DaGFuZ2VMb2cKaW5kZXggYmVjMjMxZmViODI0NzliYzk1OGFlYTZhNzMyNTNlNTIxZDFi MGFiNC4uNzEyNjEzNjYyMjk5MTcyMDExNjNkMjViNTY0NGE0N2FiNDg3OWM3YSAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDEwLTA1LTIzICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRFJU L0Nocm9taXVtXSBJbXBvcnQgbGF5b3V0X3Rlc3RfaGVscGVyIGZvciBXaW5kb3dzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTU4MQorCisgICAgICAg IEltcG9ydCBDaHJvbWl1bSB3aW4vbGF5b3V0X3Rlc3RfaGVscGVyLmNjIGFzIExheW91dFRlc3RI ZWxwZXJXaW4uY3BwLgorICAgICAgICBodHRwOi8vc3JjLmNocm9taXVtLm9yZy92aWV3dmMvY2hy b21lL3RydW5rL3NyYy93ZWJraXQvdG9vbHMvdGVzdF9zaGVsbC93aW4vbGF5b3V0X3Rlc3RfaGVs cGVyLmNjCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0SGVs cGVyV2luLmNwcDogQWRkZWQuCisKIDIwMTAtMDUtMjMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbmllbCBCYXRlcy4KZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RIZWxwZXJXaW4u Y3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdEhlbHBl cldpbi5jcHAKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uMjVlZmRjZGNiYjU4YWU0OTQ5ZDM2ZDUyNzJhNzZhNjg4Y2Rk M2I3YgotLS0gL2Rldi9udWxsCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL0xheW91dFRlc3RIZWxwZXJXaW4uY3BwCkBAIC0wLDAgKzEsODQgQEAKKy8qCisgKiBDb3B5 cmlnaHQgKEMpIDIwMTAgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBS ZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9y IHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRo ZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1ldDoKKyAqCisgKiAgICAgKiBSZWRpc3Ry aWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAor ICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNj bGFpbWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVw cm9kdWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRp dGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorICogaW4gdGhlIGRvY3VtZW50YXRp b24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorICogZGlzdHJpYnV0 aW9uLgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5h bWVzIG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJv bW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVj aWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQ Uk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworICogIkFT IElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJV VCBOT1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRB QklMSVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NM QUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyAqIE9XTkVSIE9SIENPTlRS SUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAor ICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElO RywgQlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09E UyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJ TkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9SWSBP RiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRP UlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5Z IFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VE IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5jbHVkZSA8c2ln bmFsLmg+CisjaW5jbHVkZSA8c3RkaW8uaD4KKyNpbmNsdWRlIDxzdGRsaWIuaD4KKyNpbmNsdWRl IDx3aW5kb3dzLmg+CisKK3N0YXRpYyBCT09MIGZvbnRTbW9vdGhpbmdFbmFibGVkID0gRkFMU0U7 CisKK3N0YXRpYyB2b2lkIHNhdmVJbml0aWFsU2V0dGluZ3Modm9pZCkKK3sKKyAgICA6OlN5c3Rl bVBhcmFtZXRlcnNJbmZvKFNQSV9HRVRGT05UU01PT1RISU5HLCAwLCAmZm9udFNtb290aGluZ0Vu YWJsZWQsIDApOworfQorCisvLyBUZWNobmljYWxseSwgYWxsIHdlIG5lZWQgdG8gZG8gaXMgZGlz YWJsZSBDbGVhclR5cGUuIEhvd2V2ZXIsCisvLyBmb3Igc29tZSByZWFzb24sIHRoZSBjYWxsIHRv IFNQSV9TRVRGT05UU01PT1RISU5HVFlQRSBkb2Vzbid0CisvLyBzZWVtIHRvIHdvcmssIHNvIHdl IGp1c3QgZGlzYWJsZSBmb250IHNtb290aGluZyBhbGwgdG9nZXRoZXIKKy8vICh3aGljaCB3b3Jr cyByZWxpYWJseSkKK3N0YXRpYyB2b2lkIGluc3RhbGxMYXlvdXRUZXN0U2V0dGluZ3Modm9pZCkK K3sKKyAgICA6OlN5c3RlbVBhcmFtZXRlcnNJbmZvKFNQSV9TRVRGT05UU01PT1RISU5HLCBGQUxT RSwgMCwgMCk7Cit9CisKK3N0YXRpYyB2b2lkIHJlc3RvcmVJbml0aWFsU2V0dGluZ3Modm9pZCkK K3sKKyAgICA6OlN5c3RlbVBhcmFtZXRlcnNJbmZvKFNQSV9TRVRGT05UU01PT1RISU5HLCBzdGF0 aWNfY2FzdDxVSU5UPihmb250U21vb3RoaW5nRW5hYmxlZCksIDAsIDApOworfQorCitzdGF0aWMg dm9pZCBzaW1wbGVTaWduYWxIYW5kbGVyKGludCBzaWduYWxOdW1iZXIpCit7CisgICAgLy8gVHJ5 IHRvIHJlc3RvcmUgdGhlIHNldHRpbmdzIGFuZCB0aGVuIGdvIGRvd24gY2xlYW5seQorICAgIHJl c3RvcmVJbml0aWFsU2V0dGluZ3MoKTsKKyAgICBleGl0KDEyOCArIHNpZ25hbE51bWJlcik7Cit9 CisKK2ludCBtYWluKGludCwgY2hhcipbXSkKK3sKKyAgICAvLyBIb29rcyB0aGUgd2F5cyB3ZSBt aWdodCBnZXQgdG9sZCB0byBjbGVhbiB1cC4uLgorICAgIHNpZ25hbChTSUdJTlQsIHNpbXBsZVNp Z25hbEhhbmRsZXIpOworICAgIHNpZ25hbChTSUdURVJNLCBzaW1wbGVTaWduYWxIYW5kbGVyKTsK KworICAgIHNhdmVJbml0aWFsU2V0dGluZ3MoKTsKKworICAgIGluc3RhbGxMYXlvdXRUZXN0U2V0 dGluZ3MoKTsKKworICAgIC8vIExldCB0aGUgc2NyaXB0IGtub3cgd2UncmUgcmVhZHkKKyAgICBw cmludGYoInJlYWR5XG4iKTsKKyAgICBmZmx1c2goc3Rkb3V0KTsKKworICAgIC8vIFdhaXQgZm9y IGFueSBrZXkgKG9yIHNpZ25hbCkKKyAgICBnZXRjaGFyKCk7CisKKyAgICByZXN0b3JlSW5pdGlh bFNldHRpbmdzKCk7CisKKyAgICByZXR1cm4gRVhJVF9TVUNDRVNTOworfQo=