39517 2010-05-21 16:28:48 -0700 [Qt] GraphicsLayer: The rocket animation doesn't scroll together with the page 2010-06-10 01:22:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED http://www.the-art-of-web.com/css/css-animation/ Qt P2 Normal --- 38744 1 noam webkit-unassigned commit-queue hausmann jesus kenneth oldest_to_newest 229164 0 noam 2010-05-21 16:28:48 -0700 it only scrolls after the animation is over 229169 1 56762 noam 2010-05-21 16:49:24 -0700 Created attachment 56762 Fix 229262 2 kenneth 2010-05-22 08:09:42 -0700 Jesus, your refactoring broke this. 229455 3 56762 commit-queue 2010-05-23 05:10:23 -0700 Comment on attachment 56762 Fix Clearing flags on attachment: 56762 Committed r60041: <http://trac.webkit.org/changeset/60041> 229456 4 commit-queue 2010-05-23 05:10:29 -0700 All reviewed patches have been landed. Closing bug. 230169 5 hausmann 2010-05-25 01:53:55 -0700 As far as I can see this is a regression introduced in r59152, which appears to have removed the call to updateCompositingScrollPosition(). Since 59152 wasn't cherry-picked into the release branch, the patch for this bug doesn't apply. However pre-59152 - i.e. with what's in the 2.0 branch - the call to updateCompositionScrollPosition() is there but it happens before calling syncLayers(). Is this analysis correct? What's the right thing to do for 2.0? Keep it as is? Move the call to after syncLayers(), like in the trunk? 230227 6 kenneth 2010-05-25 05:23:17 -0700 If the rocket animation scrolls together with the page, I say you need to do nothing. 230267 7 noam 2010-05-25 07:50:20 -0700 It doesn't matter - the implementations are interchangeable. I agree with Kenneth... 234757 8 hausmann 2010-06-07 03:16:16 -0700 Fixed url to testcase 234758 9 hausmann 2010-06-07 03:22:19 -0700 (In reply to comment #6) > If the rocket animation scrolls together with the page, I say you need to do nothing. I assume with "scroll together" you mean scrolling the page with the wheel should work fine while the animation is running? 234804 10 kenneth 2010-06-07 05:28:30 -0700 (In reply to comment #9) > (In reply to comment #6) > > If the rocket animation scrolls together with the page, I say you need to do nothing. > > I assume with "scroll together" you mean scrolling the page with the wheel should work fine while the animation is running? Exactly. 234833 11 hausmann 2010-06-07 07:03:21 -0700 Good, since that worked I'll remove it from the blockers. No picking necessary :) 56762 2010-05-21 16:49:24 -0700 2010-05-23 05:10:22 -0700 Fix patch-39517-1.diff text/plain 1242 noam ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGI1OTE5N2EuLjdhMDMzOGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA1LTIxICBOb2Ft IFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYXBoaWNzTGF5ZXI6IFRoZSBy b2NrZXQgYW5pbWF0aW9uIGRvZXNuJ3Qgc2Nyb2xsIHRvZ2V0aGVyIHdpdGggdGhlIHBhZ2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NTE3CisKKyAg ICAgICAgQSBwcmV2aW91cyBmaXggdG8gdGhpcyBpc3N1ZSB3YXMgb3ZlcnJpZGRlbiBieSB0aGUg UGFnZUNsaWVudFF0IHJlZmFjdG9yLiBSZWFwcGx5aW5nLgorCisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvUGFnZUNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VDbGllbnRRR3Jh cGhpY3NXaWRnZXQ6OnVwZGF0ZSk6CisKIDIwMTAtMDUtMjEgIFN0ZXZlIEJsb2NrICA8c3RldmVi bG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlm ZiAtLWdpdCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50UXQuY3BwIGIvV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRRdC5jcHAKaW5kZXggODgzYzkxMy4uNGNj ZjM0YSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRRdC5j cHAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRRdC5jcHAKQEAgLTEz Miw2ICsxMzIsOCBAQCB2b2lkIFBhZ2VDbGllbnRRR3JhcGhpY3NXaWRnZXQ6OnVwZGF0ZShjb25z dCBRUmVjdCYgZGlydHlSZWN0KQogICAgICAgICBvdmVybGF5LT51cGRhdGUoUVJlY3RGKGRpcnR5 UmVjdCkpOwogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBzeW5jTGF5ZXJz KCk7CisgICAgLy8gVGhpcyBtaWdodCBiZSBhIHNsb3ctc2Nyb2xsLiBXZSBlbnN1cmUgdGhhdCB0 aGUgY29tcG9zaXRpbmcgbGF5ZXJzIGFyZSBpbiB0aGUgcmlnaHQgcG9zaXRpb24uCisgICAgdXBk YXRlQ29tcG9zaXRpbmdTY3JvbGxQb3NpdGlvbigpOwogI2VuZGlmCiB9CiAK