39465 2010-05-20 18:34:19 -0700 [GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt 2010-05-27 01:03:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 39459 30623 1 mrobinson webkit-unassigned xan.lopez oldest_to_newest 228675 0 mrobinson 2010-05-20 18:34:19 -0700 This is required so that the DOM can process dragEnd events. 228676 1 56656 mrobinson 2010-05-20 18:37:26 -0700 Created attachment 56656 Patch for this issue I've attached a patch for this issue. 229245 2 56656 xan.lopez 2010-05-22 01:42:47 -0700 Comment on attachment 56656 Patch for this issue >+ [GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt >+ https://bugs.webkit.org/show_bug.cgi?id=39465 Why should it call it? What happens if you don't? Just because of the names it makes sense, but we should explain it in the ChangeLog. >+ event->button.window = static_cast<GdkWindow*>(g_object_ref( >+ gdk_display_get_window_at_pointer(display, &x, &y))); I think the style is to let lines be as long as needed. >+ event->button.x = x; >+ event->button.y = y; >+ event->button.x_root = xRoot; >+ event->button.y_root = yRoot; >+ event->button.state = modifiers; >+ >+ PlatformMouseEvent platformEvent(&event->button); >+ frame->eventHandler()->dragSourceEndedAt(platformEvent, >+ gdkDragActionToDragOperation(context->action)); Same. r- for missing rationale and because I'm feeling evil. 229246 3 56656 xan.lopez 2010-05-22 01:46:08 -0700 Comment on attachment 56656 Patch for this issue Bah, sorry, the explanation actually was in the ChangeLog, just inlined in the function mention. My apologies. r=me 229292 4 56784 mrobinson 2010-05-22 12:04:57 -0700 Created attachment 56784 Patch 229293 5 mrobinson 2010-05-22 12:06:36 -0700 (In reply to comment #3) > (From update of attachment 56656 [details]) > Bah, sorry, the explanation actually was in the ChangeLog, just inlined in the function mention. My apologies. r=me I think you're right in that it could be expanded a bit. I've done that above and removed the newlines as you've asked. I'll commit the patch that I just posted. Thanks for the review. :) 229296 6 mrobinson 2010-05-22 12:12:55 -0700 Committed r60010: <http://trac.webkit.org/changeset/60010> 231162 7 56784 mrobinson 2010-05-27 01:03:59 -0700 Comment on attachment 56784 Patch Clearing flags, as this has landed. 56656 2010-05-20 18:37:26 -0700 2010-05-22 12:04:53 -0700 Patch for this issue drag-end.patch text/plain 5060 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmE2MDZhZS4uODBjYzNjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFtHVEtdIHdlYmtpdF93ZWJfdmlld19kcmFnX2VuZCBz aG91bGQgY2FsbCBFdmVudEhhbmRsZXI6OmRyYWdTb3VyY2VFbmRlZEF0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTQ2NQorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBhcyBiZWhhdmlvciBoYXMgbm90IGNoYW5nZWQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ndGsvQ2xpcGJvYXJkVXRpbGl0aWVzR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omdka0Ry YWdBY3Rpb25Ub0RyYWdPcGVyYXRpb24pOgorICAgICAgICBBZGRlZCB0aGlzIGhlbHBlciBmdW5j dGlvbiBmb3IgY29udmVydGluZyBhIEdESyBhY3Rpb24gYml0bWFzayBpbnRvIGEgRHJhZ09wZXJh dGlvbiBiaXRtYXNrLgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9DbGlwYm9hcmRVdGlsaXRpZXNH dGsuaDoKKworMjAxMC0wNS0yMCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgW0dU S10gV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrOjpzdGFydERyYWcgc2hv dWxkIHVzZSB0aGUgQ2xpcGJvYXJkOjpzb3VyY2VPcGVyYXRpb24KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NDU5CiAKZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL0NsaXBib2FyZFV0aWxpdGllc0d0ay5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2d0ay9DbGlwYm9hcmRVdGlsaXRpZXNHdGsuY3BwCmluZGV4IGRjYjI1NzMuLmY2ZGVhNzkg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0NsaXBib2FyZFV0aWxpdGllc0d0ay5j cHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkVXRpbGl0aWVzR3RrLmNwcApA QCAtMzgsNCArMzgsMTkgQEAgR2RrRHJhZ0FjdGlvbiBkcmFnT3BlcmF0aW9uVG9HZGtEcmFnQWN0 aW9ucyhEcmFnT3BlcmF0aW9uIGNvcmVBY3Rpb24pCiAKICAgICByZXR1cm4gZ2RrQWN0aW9uOwog fQorCitEcmFnT3BlcmF0aW9uIGdka0RyYWdBY3Rpb25Ub0RyYWdPcGVyYXRpb24oR2RrRHJhZ0Fj dGlvbiBnZGtBY3Rpb24pCit7CisgICAgdW5zaWduZWQgaW50IGFjdGlvbiA9IERyYWdPcGVyYXRp b25Ob25lOworICAgIGlmIChnZGtBY3Rpb24gJiBHREtfQUNUSU9OX0NPUFkpCisgICAgICAgIGFj dGlvbiB8PSBEcmFnT3BlcmF0aW9uQ29weTsKKyAgICBpZiAoZ2RrQWN0aW9uICYgR0RLX0FDVElP Tl9NT1ZFKQorICAgICAgICBhY3Rpb24gfD0gRHJhZ09wZXJhdGlvbk1vdmU7CisgICAgaWYgKGdk a0FjdGlvbiAmIEdES19BQ1RJT05fTElOSykKKyAgICAgICAgYWN0aW9uIHw9IERyYWdPcGVyYXRp b25MaW5rOworICAgIGlmIChnZGtBY3Rpb24gJiBHREtfQUNUSU9OX1BSSVZBVEUpCisgICAgICAg IGFjdGlvbiB8PSBEcmFnT3BlcmF0aW9uUHJpdmF0ZTsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8 RHJhZ09wZXJhdGlvbj4oYWN0aW9uKTsKK30KKwogfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvQ2xpcGJvYXJkVXRpbGl0aWVzR3RrLmggYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9D bGlwYm9hcmRVdGlsaXRpZXNHdGsuaAppbmRleCBkNGI0YzgyLi5iZGIyYWVjIDEwMDY0NAotLS0g YS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DbGlwYm9hcmRVdGlsaXRpZXNHdGsuaAorKysgYi9XZWJD b3JlL3BsYXRmb3JtL2d0ay9DbGlwYm9hcmRVdGlsaXRpZXNHdGsuaApAQCAtMjUsNiArMjUsNyBA QAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBHZGtEcmFnQWN0aW9uIGRyYWdPcGVyYXRpb25Ub0dk a0RyYWdBY3Rpb25zKERyYWdPcGVyYXRpb24pOworRHJhZ09wZXJhdGlvbiBnZGtEcmFnQWN0aW9u VG9EcmFnT3BlcmF0aW9uKEdka0RyYWdBY3Rpb24pOwogCiB9CiAKZGlmZiAtLWdpdCBhL1dlYktp dC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMjE3YzVlYS4uMTc2 NDdiYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKQEAgLTIsNiArMiwxNyBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgogCisgICAgICAgIFtHVEtdIHdlYmtpdF93ZWJfdmlld19kcmFnX2VuZCBzaG91bGQg Y2FsbCBFdmVudEhhbmRsZXI6OmRyYWdTb3VyY2VFbmRlZEF0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTQ2NQorCisgICAgICAgICogd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2RyYWdfZW5kKToKKyAg ICAgICAgUHJvcGVybHkgY2FsbCBFdmVudEhhbmRsZXI6OmRyYWdTb3VyY2VFbmRlZEF0IHNvIHRo YXQgZHJhZ0VuZCBldmVudHMgYXJlIHByb2Nlc3NlZCBpbiB0aGUgRE9NLgorCisyMDEwLTA1LTIw ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBbR1RLXSBXZWJLaXQvZ3RrL1dlYkNv cmVTdXBwb3J0L0RyYWdDbGllbnRHdGs6OnN0YXJ0RHJhZyBzaG91bGQgdXNlIHRoZSBDbGlwYm9h cmQ6OnNvdXJjZU9wZXJhdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzk0NTkKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAx MGEwODJjLi4xZmM0MDBiIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2 aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtNDQs NiArNDQsNyBAQAogI2luY2x1ZGUgIkJhY2tGb3J3YXJkTGlzdC5oIgogI2luY2x1ZGUgIkNhY2hl LmgiCiAjaW5jbHVkZSAiQ2hyb21lQ2xpZW50R3RrLmgiCisjaW5jbHVkZSAiQ2xpcGJvYXJkVXRp bGl0aWVzR3RrLmgiCiAjaW5jbHVkZSAiQ29udGV4dE1lbnVDbGllbnRHdGsuaCIKICNpbmNsdWRl ICJDb250ZXh0TWVudUNvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJDb250ZXh0TWVudS5oIgpAQCAt MTIzNiw3ICsxMjM3LDggQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3NjcmVlbl9jaGFu Z2VkKEd0a1dpZGdldCogd2lkZ2V0LCBHZGtTY3JlZW4qIHByZXZpb3UKIAogc3RhdGljIHZvaWQg d2Via2l0X3dlYl92aWV3X2RyYWdfZW5kKEd0a1dpZGdldCogd2lkZ2V0LCBHZGtEcmFnQ29udGV4 dCogY29udGV4dCkKIHsKLSAgICBXZWJLaXRXZWJWaWV3UHJpdmF0ZSogcHJpdiA9IFdFQktJVF9X RUJfVklFV19HRVRfUFJJVkFURShXRUJLSVRfV0VCX1ZJRVcod2lkZ2V0KSk7CisgICAgV2ViS2l0 V2ViVmlldyogd2ViVmlldyA9IFdFQktJVF9XRUJfVklFVyh3aWRnZXQpOworICAgIFdlYktpdFdl YlZpZXdQcml2YXRlKiBwcml2ID0gV0VCS0lUX1dFQl9WSUVXX0dFVF9QUklWQVRFKHdlYlZpZXcp OwogCiAgICAgLy8gVGhpcyBtaWdodCBoYXBwZW4gaWYgYSBkcmFnIGlzIHN0aWxsIGluIHByb2dy ZXNzIGFmdGVyIGEgV2ViS2l0V2ViVmlldwogICAgIC8vIGlzIGRpcG9zZWQgYW5kIGJlZm9yZSBp dCBpcyBmaW5hbGl6ZWQuCkBAIC0xMjQ0LDYgKzEyNDYsMzAgQEAgc3RhdGljIHZvaWQgd2Via2l0 X3dlYl92aWV3X2RyYWdfZW5kKEd0a1dpZGdldCogd2lkZ2V0LCBHZGtEcmFnQ29udGV4dCogY29u dGV4dCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgcHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cy5y ZW1vdmUoY29udGV4dCk7CisKKyAgICBGcmFtZSogZnJhbWUgPSBjb3JlKHdlYlZpZXcpLT5mb2N1 c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCk7CisgICAgaWYgKCFmcmFtZSkKKyAg ICAgICAgcmV0dXJuOworCisgICAgR2RrRXZlbnQqIGV2ZW50ID0gZ2RrX2V2ZW50X25ldyhHREtf QlVUVE9OX1JFTEVBU0UpOworICAgIGludCB4LCB5LCB4Um9vdCwgeVJvb3Q7CisgICAgR2RrTW9k aWZpZXJUeXBlIG1vZGlmaWVyczsKKyAgICBHZGtEaXNwbGF5KiBkaXNwbGF5ID0gZ2RrX2Rpc3Bs YXlfZ2V0X2RlZmF1bHQoKTsKKyAgICBnZGtfZGlzcGxheV9nZXRfcG9pbnRlcihkaXNwbGF5LCAw LCAmeFJvb3QsICZ5Um9vdCwgJm1vZGlmaWVycyk7CisKKyAgICBldmVudC0+YnV0dG9uLndpbmRv dyA9IHN0YXRpY19jYXN0PEdka1dpbmRvdyo+KGdfb2JqZWN0X3JlZigKKyAgICAgICAgZ2RrX2Rp c3BsYXlfZ2V0X3dpbmRvd19hdF9wb2ludGVyKGRpc3BsYXksICZ4LCAmeSkpKTsKKyAgICBldmVu dC0+YnV0dG9uLnggPSB4OworICAgIGV2ZW50LT5idXR0b24ueSA9IHk7CisgICAgZXZlbnQtPmJ1 dHRvbi54X3Jvb3QgPSB4Um9vdDsKKyAgICBldmVudC0+YnV0dG9uLnlfcm9vdCA9IHlSb290Owor ICAgIGV2ZW50LT5idXR0b24uc3RhdGUgPSBtb2RpZmllcnM7CisKKyAgICBQbGF0Zm9ybU1vdXNl RXZlbnQgcGxhdGZvcm1FdmVudCgmZXZlbnQtPmJ1dHRvbik7CisgICAgZnJhbWUtPmV2ZW50SGFu ZGxlcigpLT5kcmFnU291cmNlRW5kZWRBdChwbGF0Zm9ybUV2ZW50LAorICAgICAgICBnZGtEcmFn QWN0aW9uVG9EcmFnT3BlcmF0aW9uKGNvbnRleHQtPmFjdGlvbikpOworCisgICAgZ2RrX2V2ZW50 X2ZyZWUoZXZlbnQpOwogfQogCiBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfZHJhZ19kYXRh X2dldChHdGtXaWRnZXQqIHdpZGdldCwgR2RrRHJhZ0NvbnRleHQqIGNvbnRleHQsIEd0a1NlbGVj dGlvbkRhdGEqIHNlbGVjdGlvbkRhdGEsIGd1aW50IGluZm8sIGd1aW50KQo= 56784 2010-05-22 12:04:57 -0700 2010-05-27 01:03:59 -0700 Patch bug-39465-20100522120456.patch text/plain 5583 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDYzMjYzNzU3MWVlYjUwNjExNDU5OGM3YjI5ZTBlNWE1OGFhY2I5My4uZTJkMWVjYzMyMTY0ZWZi MTk2NTBmMmRmZmI2MzAxNWI1MTFmZjBjZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMSBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IFhhbiBMb3Blei4KIAorICAgICAgICBbR1RLXSB3ZWJraXRfd2ViX3ZpZXdfZHJhZ19l bmQgc2hvdWxkIGNhbGwgRXZlbnRIYW5kbGVyOjpkcmFnU291cmNlRW5kZWRBdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk0NjUKKworICAgICAgICBB ZGRlZCBhIGhlbHBlciBmdW5jdGlvbiBmb3IgY29udmVydGluZyBhIEdESyBhY3Rpb24gYml0bWFz ayBpbnRvIGEgRHJhZ09wZXJhdGlvbiBiaXRtYXNrLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBh cyBiZWhhdmlvciBoYXMgbm90IGNoYW5nZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvQ2xp cGJvYXJkVXRpbGl0aWVzR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omdka0RyYWdBY3Rpb25U b0RyYWdPcGVyYXRpb24pOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvQ2xpcGJvYXJk VXRpbGl0aWVzR3RrLmg6CisKKzIwMTAtMDUtMjIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNv bkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAg ICAgICAgIFtHVEtdIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0azo6c3Rh cnREcmFnIHNob3VsZCB1c2UgdGhlIENsaXBib2FyZDo6c291cmNlT3BlcmF0aW9uCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTQ1OQogCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DbGlwYm9hcmRVdGlsaXRpZXNHdGsuY3BwIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkVXRpbGl0aWVzR3RrLmNwcAppbmRleCBkY2IyNTcz MzQ3MTQxNjJiOGJlMjU2MmZiY2Y3NDlkZDM0ZmM0NzUwLi5mNmRlYTc5MzdjY2NjYzJiN2YxYTMy MDViNTdhOWZjODRlMWM1ZmJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DbGlw Ym9hcmRVdGlsaXRpZXNHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0NsaXBib2Fy ZFV0aWxpdGllc0d0ay5jcHAKQEAgLTM4LDQgKzM4LDE5IEBAIEdka0RyYWdBY3Rpb24gZHJhZ09w ZXJhdGlvblRvR2RrRHJhZ0FjdGlvbnMoRHJhZ09wZXJhdGlvbiBjb3JlQWN0aW9uKQogCiAgICAg cmV0dXJuIGdka0FjdGlvbjsKIH0KKworRHJhZ09wZXJhdGlvbiBnZGtEcmFnQWN0aW9uVG9EcmFn T3BlcmF0aW9uKEdka0RyYWdBY3Rpb24gZ2RrQWN0aW9uKQoreworICAgIHVuc2lnbmVkIGludCBh Y3Rpb24gPSBEcmFnT3BlcmF0aW9uTm9uZTsKKyAgICBpZiAoZ2RrQWN0aW9uICYgR0RLX0FDVElP Tl9DT1BZKQorICAgICAgICBhY3Rpb24gfD0gRHJhZ09wZXJhdGlvbkNvcHk7CisgICAgaWYgKGdk a0FjdGlvbiAmIEdES19BQ1RJT05fTU9WRSkKKyAgICAgICAgYWN0aW9uIHw9IERyYWdPcGVyYXRp b25Nb3ZlOworICAgIGlmIChnZGtBY3Rpb24gJiBHREtfQUNUSU9OX0xJTkspCisgICAgICAgIGFj dGlvbiB8PSBEcmFnT3BlcmF0aW9uTGluazsKKyAgICBpZiAoZ2RrQWN0aW9uICYgR0RLX0FDVElP Tl9QUklWQVRFKQorICAgICAgICBhY3Rpb24gfD0gRHJhZ09wZXJhdGlvblByaXZhdGU7CisgICAg cmV0dXJuIHN0YXRpY19jYXN0PERyYWdPcGVyYXRpb24+KGFjdGlvbik7Cit9CisKIH0KZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0NsaXBib2FyZFV0aWxpdGllc0d0ay5oIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkVXRpbGl0aWVzR3RrLmgKaW5kZXggZDRiNGM4MjFj YWIzY2UzZjQyMWNmMjNmZTAzM2E0MDE0ZDc4ZjNlYy4uYmRiMmFlYzFmZTdiMmI2MGNlYTJjMjQ1 NDI5ZWNkZmZlODVlOTFjOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJv YXJkVXRpbGl0aWVzR3RrLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkVXRp bGl0aWVzR3RrLmgKQEAgLTI1LDYgKzI1LDcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogR2Rr RHJhZ0FjdGlvbiBkcmFnT3BlcmF0aW9uVG9HZGtEcmFnQWN0aW9ucyhEcmFnT3BlcmF0aW9uKTsK K0RyYWdPcGVyYXRpb24gZ2RrRHJhZ0FjdGlvblRvRHJhZ09wZXJhdGlvbihHZGtEcmFnQWN0aW9u KTsKIAogfQogCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsv Q2hhbmdlTG9nCmluZGV4IDA3ZTNmZjEzZWI0NTZlYWE2NDA4MzdiOTc2YTQwZjM5ZDc0Y2ViNWMu LmQ5MDY1ZTk3MzFjYjJlYWY5NjMzNmE1ZDM0YTFhZDVlYjcwODI4MDAgMTAwNjQ0Ci0tLSBhL1dl YktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0yLDYgKzIs MjAgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCiAKKyAgICAgICAgW0dUS10g d2Via2l0X3dlYl92aWV3X2RyYWdfZW5kIHNob3VsZCBjYWxsIEV2ZW50SGFuZGxlcjo6ZHJhZ1Nv dXJjZUVuZGVkQXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM5NDY1CisKKyAgICAgICAgUHJvcGVybHkgY2FsbCBFdmVudEhhbmRsZXI6OmRyYWdTb3Vy Y2VFbmRlZEF0IHNvIHRoYXQgZHJhZ0VuZCBldmVudHMgYXJlIHByb2Nlc3NlZCBpbiB0aGUgRE9N LgorICAgICAgICBkcmFnU291cmNlRW5kZWRBdCBpcyByZXNwb25zaWJsZSBmb3IgY2FsbGluZyB0 aGUgZHJhZ0VuZCBET00gZXZlbnQgYXMgd2VsbCBhcyBjbGVhbmluZyB1cCBhc3NldHMKKyAgICAg ICAgKHN1Y2ggYXMgdGhlIENsaXBib2FyZCkgYXNzb2NpYXRlZCB3aXRoIHRoZSBkcmFnIHNvdXJj ZS4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtp dF93ZWJfdmlld19kcmFnX2VuZCk6IFJlbWVtYmVyIHRvIGNhbGwgZHJhZ1NvdXJjZUVuZGVkQXQg aGVyZS4KKworMjAxMC0wNS0yMiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgW0dU S10gV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrOjpzdGFydERyYWcgc2hv dWxkIHVzZSB0aGUgQ2xpcGJvYXJkOjpzb3VyY2VPcGVyYXRpb24KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NDU5CiAKZGlmZiAtLWdpdCBhL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5jcHAKaW5kZXggMWU1ZjdhYzQ0OWYzZmVkOWI2ODliMDNlYzkwZWFkNTE5NTIzYTFj OS4uZjNiYjVlNmMzZGQ4OTVhNTcyMDFlYmRjZGFmZTBiMDQ3ZDgzOTlhYyAxMDA2NDQKLS0tIGEv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTQ0LDYgKzQ0LDcgQEAKICNpbmNsdWRlICJCYWNrRm9y d2FyZExpc3QuaCIKICNpbmNsdWRlICJDYWNoZS5oIgogI2luY2x1ZGUgIkNocm9tZUNsaWVudEd0 ay5oIgorI2luY2x1ZGUgIkNsaXBib2FyZFV0aWxpdGllc0d0ay5oIgogI2luY2x1ZGUgIkNvbnRl eHRNZW51Q2xpZW50R3RrLmgiCiAjaW5jbHVkZSAiQ29udGV4dE1lbnVDb250cm9sbGVyLmgiCiAj aW5jbHVkZSAiQ29udGV4dE1lbnUuaCIKQEAgLTEyMzYsMTQgKzEyMzcsMzcgQEAgc3RhdGljIHZv aWQgd2Via2l0X3dlYl92aWV3X3NjcmVlbl9jaGFuZ2VkKEd0a1dpZGdldCogd2lkZ2V0LCBHZGtT Y3JlZW4qIHByZXZpb3UKIAogc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2RyYWdfZW5kKEd0 a1dpZGdldCogd2lkZ2V0LCBHZGtEcmFnQ29udGV4dCogY29udGV4dCkKIHsKLSAgICBXZWJLaXRX ZWJWaWV3UHJpdmF0ZSogcHJpdiA9IFdFQktJVF9XRUJfVklFV19HRVRfUFJJVkFURShXRUJLSVRf V0VCX1ZJRVcod2lkZ2V0KSk7CisgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IFdFQktJVF9X RUJfVklFVyh3aWRnZXQpOworICAgIFdlYktpdFdlYlZpZXdQcml2YXRlKiBwcml2ID0gV0VCS0lU X1dFQl9WSUVXX0dFVF9QUklWQVRFKHdlYlZpZXcpOwogCiAgICAgLy8gVGhpcyBtaWdodCBoYXBw ZW4gaWYgYSBkcmFnIGlzIHN0aWxsIGluIHByb2dyZXNzIGFmdGVyIGEgV2ViS2l0V2ViVmlldwot ICAgIC8vIGlzIGRpcG9zZWQgYW5kIGJlZm9yZSBpdCBpcyBmaW5hbGl6ZWQuCisgICAgLy8gaXMg ZGlzcG9zZWQgYW5kIGJlZm9yZSBpdCBpcyBmaW5hbGl6ZWQuCiAgICAgaWYgKCFwcml2LT5kcmFn Z2luZ0RhdGFPYmplY3RzLmNvbnRhaW5zKGNvbnRleHQpKQogICAgICAgICByZXR1cm47CiAKICAg ICBwcml2LT5kcmFnZ2luZ0RhdGFPYmplY3RzLnJlbW92ZShjb250ZXh0KTsKKworICAgIEZyYW1l KiBmcmFtZSA9IGNvcmUod2ViVmlldyktPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWlu RnJhbWUoKTsKKyAgICBpZiAoIWZyYW1lKQorICAgICAgICByZXR1cm47CisKKyAgICBHZGtFdmVu dCogZXZlbnQgPSBnZGtfZXZlbnRfbmV3KEdES19CVVRUT05fUkVMRUFTRSk7CisgICAgaW50IHgs IHksIHhSb290LCB5Um9vdDsKKyAgICBHZGtNb2RpZmllclR5cGUgbW9kaWZpZXJzOworICAgIEdk a0Rpc3BsYXkqIGRpc3BsYXkgPSBnZGtfZGlzcGxheV9nZXRfZGVmYXVsdCgpOworICAgIGdka19k aXNwbGF5X2dldF9wb2ludGVyKGRpc3BsYXksIDAsICZ4Um9vdCwgJnlSb290LCAmbW9kaWZpZXJz KTsKKworICAgIGV2ZW50LT5idXR0b24ud2luZG93ID0gc3RhdGljX2Nhc3Q8R2RrV2luZG93Kj4o Z19vYmplY3RfcmVmKGdka19kaXNwbGF5X2dldF93aW5kb3dfYXRfcG9pbnRlcihkaXNwbGF5LCAm eCwgJnkpKSk7CisgICAgZXZlbnQtPmJ1dHRvbi54ID0geDsKKyAgICBldmVudC0+YnV0dG9uLnkg PSB5OworICAgIGV2ZW50LT5idXR0b24ueF9yb290ID0geFJvb3Q7CisgICAgZXZlbnQtPmJ1dHRv bi55X3Jvb3QgPSB5Um9vdDsKKyAgICBldmVudC0+YnV0dG9uLnN0YXRlID0gbW9kaWZpZXJzOwor CisgICAgUGxhdGZvcm1Nb3VzZUV2ZW50IHBsYXRmb3JtRXZlbnQoJmV2ZW50LT5idXR0b24pOwor ICAgIGZyYW1lLT5ldmVudEhhbmRsZXIoKS0+ZHJhZ1NvdXJjZUVuZGVkQXQocGxhdGZvcm1FdmVu dCwgZ2RrRHJhZ0FjdGlvblRvRHJhZ09wZXJhdGlvbihjb250ZXh0LT5hY3Rpb24pKTsKKworICAg IGdka19ldmVudF9mcmVlKGV2ZW50KTsKIH0KIAogc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3 X2RyYWdfZGF0YV9nZXQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0RyYWdDb250ZXh0KiBjb250ZXh0 LCBHdGtTZWxlY3Rpb25EYXRhKiBzZWxlY3Rpb25EYXRhLCBndWludCBpbmZvLCBndWludCkK