39459 2010-05-20 17:09:14 -0700 [GTK] WebKit/gtk/WebCoreSupport/DragClientGtk::startDrag should use the Clipboard::sourceOperation 2010-05-22 11:14:52 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 30623 39465 1 mrobinson webkit-unassigned oldest_to_newest 228638 0 mrobinson 2010-05-20 17:09:14 -0700 Currently the GdkDragAction for the new drag is calculated by looking at the dragged element. This can be controlled via the DOM, so ::startDrag should respect that. 228644 1 56650 mrobinson 2010-05-20 17:18:51 -0700 Created attachment 56650 Patch for this issue 229244 2 56650 xan.lopez 2010-05-22 01:38:12 -0700 Comment on attachment 56650 Patch for this issue Looks good to me. 229290 3 mrobinson 2010-05-22 11:14:52 -0700 Committed r60008: <http://trac.webkit.org/changeset/60008> 56650 2010-05-20 17:18:51 -0700 2010-05-22 01:38:12 -0700 Patch for this issue bug-39459-20100520171851.patch text/plain 7407 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mjc3MjNiMDM4ZjY3ZjIzZDQ2YTAxNWUxNjFkNjFmZDQ2MmFmMTlmZS4uYmE2MDZhZTkxMDIxYTQ5 MjQxZjlmZmYwNGE2YTUyNWVmYzUwMWZkOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wNS0yMCAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gV2ViS2l0L2d0ay9XZWJDb3JlU3Vw cG9ydC9EcmFnQ2xpZW50R3RrOjpzdGFydERyYWcgc2hvdWxkIHVzZSB0aGUgQ2xpcGJvYXJkOjpz b3VyY2VPcGVyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM5NDU5CisKKyAgICAgICAgQWRkIENsaXBib2FyZFV0aWxpdGllc0d0aywgYSBjb250 YWluZXIgZm9yIEdUSysvV2ViQ29yZSBjbGlwYm9hcmQgdXRpbGl0eSBmdW5jdGlvbnMuCisgICAg ICAgIEluaXRpYWxseSBhZGQgYSBmdW5jdGlvbiB3aGljaCBjb252ZXJ0cyBhIFdlYkNvcmU6OkRy YWdPcGVyYXRpb24gdG8gYSBiaXRtYXNrIG9mCisgICAgICAgIEdka0RyYWdBY3Rpb25zLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgYmVjYXVzZSBiZWhhdmlvciBoYXMgbm90IGNoYW5nZWQuCisK KyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvQ2xpcGJv YXJkVXRpbGl0aWVzR3RrLmNwcDogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpkcmFnT3BlcmF0 aW9uVG9HZGtEcmFnQWN0aW9ucyk6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9DbGlw Ym9hcmRVdGlsaXRpZXNHdGsuaDogQWRkZWQuCisKIDIwMTAtMDUtMjAgIEplciBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0gYi9XZWJDb3JlL0dOVW1ha2VmaWxlLmFt CmluZGV4IDYxYjczNGFmYWVjYWNiNWU3ZGEyNTFmMDMwNmZiNDk3NjgyMGM2NzIuLjM3MmQ3MjE5 ZGFjOTk5MWQ2NjM4NTY5M2QzZjRhMTRkNTYxYmExYTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvR05V bWFrZWZpbGUuYW0KKysrIGIvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQpAQCAtMjEwNiw2ICsyMTA2 LDggQEAgd2ViY29yZWd0a19zb3VyY2VzICs9IFwKIAlXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2d0ay9JbnRSZWN0R3RrLmNwcCBcCiAJV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkR3Rr LmNwcCBcCiAJV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkR3RrLmggXAorCVdlYkNvcmUv cGxhdGZvcm0vZ3RrL0NsaXBib2FyZFV0aWxpdGllc0d0ay5jcHAgXAorCVdlYkNvcmUvcGxhdGZv cm0vZ3RrL0NsaXBib2FyZFV0aWxpdGllc0d0ay5oIFwKIAlXZWJDb3JlL3BsYXRmb3JtL2d0ay9D b250ZXh0TWVudUd0ay5jcHAgXAogCVdlYkNvcmUvcGxhdGZvcm0vZ3RrL0NvbnRleHRNZW51SXRl bUd0ay5jcHAgXAogCVdlYkNvcmUvcGxhdGZvcm0vZ3RrL0N1cnNvckd0ay5jcHAgXApkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkVXRpbGl0aWVzR3RrLmNwcCBiL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL0NsaXBib2FyZFV0aWxpdGllc0d0ay5jcHAKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u ZGNiMjU3MzM0NzE0MTYyYjhiZTI1NjJmYmNmNzQ5ZGQzNGZjNDc1MAotLS0gL2Rldi9udWxsCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0NsaXBib2FyZFV0aWxpdGllc0d0ay5jcHAKQEAgLTAs MCArMSw0MSBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMCwgSWdhbGlhIFMuTC4KKyAqCisg KiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0 IGFuZC9vcgorICogIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIg R2VuZXJhbCBQdWJsaWMKKyAqICBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0 d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqICB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9y IChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisgKgorICogIFRoaXMgbGlicmFy eSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorICog IGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJh bnR5IG9mCisgKiAgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQ VVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAqICBMZXNzZXIgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBm b3IgbW9yZSBkZXRhaWxzLgorICoKKyAqICBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5 IG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCisgKiAgTGljZW5zZSBhbG9uZyB3aXRo IHRoaXMgbGlicmFyeTsgaWYgbm90LCB3cml0ZSB0byB0aGUgRnJlZSBTb2Z0d2FyZQorICogIEZv dW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsIEJvc3Rvbiwg TUEgIDAyMTEwLTEzMDEgIFVTQQorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRl ICJDbGlwYm9hcmRVdGlsaXRpZXNHdGsuaCIKKworbmFtZXNwYWNlIFdlYkNvcmUgeworCitHZGtE cmFnQWN0aW9uIGRyYWdPcGVyYXRpb25Ub0dka0RyYWdBY3Rpb25zKERyYWdPcGVyYXRpb24gY29y ZUFjdGlvbikKK3sKKyAgICBHZGtEcmFnQWN0aW9uIGdka0FjdGlvbiA9IHN0YXRpY19jYXN0PEdk a0RyYWdBY3Rpb24+KDApOworICAgIGlmIChjb3JlQWN0aW9uID09IERyYWdPcGVyYXRpb25Ob25l KQorICAgICAgICByZXR1cm4gZ2RrQWN0aW9uOworCisgICAgaWYgKGNvcmVBY3Rpb24gJiBEcmFn T3BlcmF0aW9uQ29weSkKKyAgICAgICAgZ2RrQWN0aW9uID0gc3RhdGljX2Nhc3Q8R2RrRHJhZ0Fj dGlvbj4oR0RLX0FDVElPTl9DT1BZIHwgZ2RrQWN0aW9uKTsKKyAgICBpZiAoY29yZUFjdGlvbiAm IERyYWdPcGVyYXRpb25Nb3ZlKQorICAgICAgICBnZGtBY3Rpb24gPSBzdGF0aWNfY2FzdDxHZGtE cmFnQWN0aW9uPihHREtfQUNUSU9OX01PVkUgfCBnZGtBY3Rpb24pOworICAgIGlmIChjb3JlQWN0 aW9uICYgRHJhZ09wZXJhdGlvbkxpbmspCisgICAgICAgIGdka0FjdGlvbiA9IHN0YXRpY19jYXN0 PEdka0RyYWdBY3Rpb24+KEdES19BQ1RJT05fTElOSyB8IGdka0FjdGlvbik7CisgICAgaWYgKGNv cmVBY3Rpb24gJiBEcmFnT3BlcmF0aW9uUHJpdmF0ZSkKKyAgICAgICAgZ2RrQWN0aW9uID0gc3Rh dGljX2Nhc3Q8R2RrRHJhZ0FjdGlvbj4oR0RLX0FDVElPTl9QUklWQVRFIHwgZ2RrQWN0aW9uKTsK KworICAgIHJldHVybiBnZGtBY3Rpb247Cit9Cit9CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9DbGlwYm9hcmRVdGlsaXRpZXNHdGsuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0Ns aXBib2FyZFV0aWxpdGllc0d0ay5oCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQ0YjRjODIxY2FiM2NlM2Y0MjFjZjIz ZmUwMzNhNDAxNGQ3OGYzZWMKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9DbGlwYm9hcmRVdGlsaXRpZXNHdGsuaApAQCAtMCwwICsxLDMxIEBACisvKgorICogQ29weXJp Z2h0IChDKSAyMDEwLCBJZ2FsaWEgUy5MLgorICoKKyAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBz b2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiAgbW9kaWZ5IGl0IHVu ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYworICogIExpY2Vu c2UgYXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgor ICogIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0 ZXIgdmVyc2lvbi4KKyAqCisgKiAgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBo b3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgKiAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZ OyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqICBNRVJDSEFOVEFCSUxJ VFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICog IExlc3NlciBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgorICog IFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJh bCBQdWJsaWMKKyAqICBMaWNlbnNlIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBpZiBub3QsIHdy aXRlIHRvIHRoZSBGcmVlIFNvZnR3YXJlCisgKiAgRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJhbmts aW4gU3RyZWV0LCBGaWZ0aCBGbG9vciwgQm9zdG9uLCBNQSAgMDIxMTAtMTMwMSAgVVNBCisgKi8K KworI2lmbmRlZiBDbGlwYm9hcmRVdGlsaXRpZXNHdGtfaAorI2RlZmluZSBDbGlwYm9hcmRVdGls aXRpZXNHdGtfaAorCisjaW5jbHVkZSAiRHJhZ0FjdGlvbnMuaCIKKyNpbmNsdWRlIDxnZGsvZ2Rr Lmg+CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworR2RrRHJhZ0FjdGlvbiBkcmFnT3BlcmF0aW9u VG9HZGtEcmFnQWN0aW9ucyhEcmFnT3BlcmF0aW9uKTsKKworfQorCisjZW5kaWYgLy8gQ2xpcGJv YXJkVXRpbGl0aWVzR3RrX2gKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggZmJkZTZlNTU3Zjc2ZDM2MjQzZDM4NDI1ZjVhMzA5Yzgz NmI4Y2I1Ni4uMjE3YzVlYWRkMzhiYmQwOGU5NmMyZGFkNzE2YzljYjQ4NmY4NTgyMCAxMDA2NDQK LS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMC0wNS0yMCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrOjpzdGFydERy YWcgc2hvdWxkIHVzZSB0aGUgQ2xpcGJvYXJkOjpzb3VyY2VPcGVyYXRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NDU5CisKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RHJhZ0Ns aWVudDo6c3RhcnREcmFnKToKKyAgICAgICAgVXNlIENsaXBib2FyZDo6c291cmNlT3BlcmF0aW9u IGluc3RlYWQgb2YgdHJ5aW5nIHRvIGZpZ3VyZSBvdXQgdGhlIEdka0RyYWdBY3Rpb24KKyAgICAg ICAgbWFudWFsbHkuIFRoZSBET00gbWF5IGhhdmUgY2hhbmdlZCB0aGUgYXBwcm9wcmlhdGUgbGlz dCBvZiBhY3Rpb25zIGFueWhvdy4KKwogMjAxMC0wNS0xOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjU5MjQwLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50 R3RrLmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5jcHAKaW5k ZXggMjQ2NzY0NjA5Yzg1ZDY3OWM1OGJhZDQzMDNmNWE0MTIzOWQ3NzNhMy4uN2Y0ZWFlMmU4MTlm Yjc5MDQxODcxNDRjMjI1NjkwMWMyODM1MDBkNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0RyYWdDbGllbnRHdGsuY3BwCkBAIC0yMCw4ICsyMCwxMCBAQAogI2luY2x1ZGUgIkRyYWdD bGllbnRHdGsuaCIKIAogI2luY2x1ZGUgIkNsaXBib2FyZEd0ay5oIgorI2luY2x1ZGUgIkNsaXBi b2FyZFV0aWxpdGllc0d0ay5oIgogI2luY2x1ZGUgIkRhdGFPYmplY3RHdGsuaCIKICNpbmNsdWRl ICJEb2N1bWVudC5oIgorI2luY2x1ZGUgIkRyYWdDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiRWxl bWVudC5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiR1JlZlB0ckd0ay5oIgpAQCAt NzEsMTAgKzczLDYgQEAgdm9pZCBEcmFnQ2xpZW50OjpzdGFydERyYWcoRHJhZ0ltYWdlUmVmIGlt YWdlLCBjb25zdCBJbnRQb2ludCYgZHJhZ0ltYWdlT3JpZ2luLAogewogICAgIENsaXBib2FyZEd0 ayogY2xpcGJvYXJkR3RrID0gcmVpbnRlcnByZXRfY2FzdDxDbGlwYm9hcmRHdGsqPihjbGlwYm9h cmQpOwogCi0gICAgR2RrRHJhZ0FjdGlvbiBkcmFnQWN0aW9uID0gR0RLX0FDVElPTl9DT1BZOwot ICAgIGlmIChsaW5rRHJhZykKLSAgICAgICAgZHJhZ0FjdGlvbiA9IChHZGtEcmFnQWN0aW9uKSAo ZHJhZ0FjdGlvbiB8IEdES19BQ1RJT05fTElOSyk7Ci0KICAgICBXZWJLaXRXZWJWaWV3KiB3ZWJW aWV3ID0gd2Via2l0X3dlYl9mcmFtZV9nZXRfd2ViX3ZpZXcoa2l0KGZyYW1lKSk7CiAgICAgUmVm UHRyPERhdGFPYmplY3RHdGs+IGRhdGFPYmplY3QgPSBjbGlwYm9hcmRHdGstPmRhdGFPYmplY3Qo KTsKIApAQCAtODQsNyArODIsOCBAQCB2b2lkIERyYWdDbGllbnQ6OnN0YXJ0RHJhZyhEcmFnSW1h Z2VSZWYgaW1hZ2UsIGNvbnN0IEludFBvaW50JiBkcmFnSW1hZ2VPcmlnaW4sCiAgICAgZXZlbnQt PmJ1dHRvbi53aW5kb3cgPSBzdGF0aWNfY2FzdDxHZGtXaW5kb3cqPihnX29iamVjdF9yZWYoZ3Rr X3dpZGdldF9nZXRfd2luZG93KEdUS19XSURHRVQobV93ZWJWaWV3KSkpKTsKICAgICBldmVudC0+ YnV0dG9uLnRpbWUgPSBHREtfQ1VSUkVOVF9USU1FOwogCi0gICAgR2RrRHJhZ0NvbnRleHQqIGNv bnRleHQgPSBndGtfZHJhZ19iZWdpbihHVEtfV0lER0VUKG1fd2ViVmlldyksIHRhcmdldExpc3Qu Z2V0KCksIGRyYWdBY3Rpb24sIDEsIGV2ZW50KTsKKyAgICBHZGtEcmFnQ29udGV4dCogY29udGV4 dCA9IGd0a19kcmFnX2JlZ2luKEdUS19XSURHRVQobV93ZWJWaWV3KSwgdGFyZ2V0TGlzdC5nZXQo KSwKKyAgICAgICAgZHJhZ09wZXJhdGlvblRvR2RrRHJhZ0FjdGlvbnMoY2xpcGJvYXJkLT5zb3Vy Y2VPcGVyYXRpb24oKSksIDEsIGV2ZW50KTsKICAgICB3ZWJWaWV3LT5wcml2LT5kcmFnZ2luZ0Rh dGFPYmplY3RzLnNldChjb250ZXh0LCBkYXRhT2JqZWN0KTsKIAogICAgIGlmIChpbWFnZSkK