39322 2010-05-18 14:38:00 -0700 [GTK] DragClientGtk::startDrag leaks GdkEvents 2010-05-18 15:15:13 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 30623 1 mrobinson webkit-unassigned oldest_to_newest 227505 0 mrobinson 2010-05-18 14:38:00 -0700 SSIA 227508 1 56414 mrobinson 2010-05-18 14:40:28 -0700 Created attachment 56414 Fix memory leak 227509 2 56414 xan.lopez 2010-05-18 14:46:00 -0700 Comment on attachment 56414 Fix memory leak >+ GdkWindow* window = gtk_widget_get_window(GTK_WIDGET(m_webView)); >+ g_object_ref(window); // This will be decremented by gdk_event_free() below. >+ event->button.window = gtk_widget_get_window(GTK_WIDGET(m_webView)); just event->button.window = window; ? r=me 227516 3 mrobinson 2010-05-18 15:15:13 -0700 Committed r59714: <http://trac.webkit.org/changeset/59714> 56414 2010-05-18 14:40:28 -0700 2010-05-18 14:46:00 -0700 Fix memory leak bug-39322-20100518144027.patch text/plain 2221 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZTE2NmI1MmE1Y2Q3MDE2YWQwYmYzNGFkYjJhNjllNDE0NGE2YWJiOC4uOGU1MDc5MzI5 ZDU1YzExMGQ3ZGI1NWI2MDMxY2FhMzAyMjJjNzFkMSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAx MC0wNS0xOCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRHJhZ0NsaWVu dEd0azo6c3RhcnREcmFnIGxlYWtzIEdka0V2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkzMjIKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L0RyYWdDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmFnQ2xpZW50OjpzdGFydERy YWcpOiBQcm9wZXJseSBjbGVhbiB1cCBhbGxvY2F0ZWQgR2RrRXZlbnQuCisKIDIwMTAtMDUtMTIg IE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQv RHJhZ0NsaWVudEd0ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0RyYWdDbGllbnRH dGsuY3BwCmluZGV4IDkwMGZiNjFiZWEzOTBmMWNmN2Q1YmY3MjRhNWVhMDc1NjIzZjQ3YjUuLjQ0 ZjkzZTUzMTYwMGM2NTM3ZjUwZDFjYjQ1YTA5MzQ4Mjg3NDgxOGIgMTAwNjQ0Ci0tLSBhL1dlYktp dC9ndGsvV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9X ZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcApAQCAtODAsOCArODAsMTAgQEAgdm9pZCBE cmFnQ2xpZW50OjpzdGFydERyYWcoRHJhZ0ltYWdlUmVmIGltYWdlLCBjb25zdCBJbnRQb2ludCYg ZHJhZ0ltYWdlT3JpZ2luLAogCiAgICAgR1JlZlB0cjxHdGtUYXJnZXRMaXN0PiB0YXJnZXRMaXN0 KGNsaXBib2FyZEd0ay0+aGVscGVyKCktPnRhcmdldExpc3RGb3JEYXRhT2JqZWN0KGRhdGFPYmpl Y3QuZ2V0KCkpKTsKICAgICBHZGtFdmVudCogZXZlbnQgPSBnZGtfZXZlbnRfbmV3KEdES19CVVRU T05fUFJFU1MpOwotICAgIHJlaW50ZXJwcmV0X2Nhc3Q8R2RrRXZlbnRCdXR0b24qPihldmVudCkt PndpbmRvdyA9IGd0a193aWRnZXRfZ2V0X3dpbmRvdyhHVEtfV0lER0VUKG1fd2ViVmlldykpOwot ICAgIHJlaW50ZXJwcmV0X2Nhc3Q8R2RrRXZlbnRCdXR0b24qPihldmVudCktPnRpbWUgPSBHREtf Q1VSUkVOVF9USU1FOworICAgIEdka1dpbmRvdyogd2luZG93ID0gZ3RrX3dpZGdldF9nZXRfd2lu ZG93KEdUS19XSURHRVQobV93ZWJWaWV3KSk7CisgICAgZ19vYmplY3RfcmVmKHdpbmRvdyk7IC8v IFRoaXMgd2lsbCBiZSBkZWNyZW1lbnRlZCBieSBnZGtfZXZlbnRfZnJlZSgpIGJlbG93LgorICAg IGV2ZW50LT5idXR0b24ud2luZG93ID0gZ3RrX3dpZGdldF9nZXRfd2luZG93KEdUS19XSURHRVQo bV93ZWJWaWV3KSk7CisgICAgZXZlbnQtPmJ1dHRvbi50aW1lID0gR0RLX0NVUlJFTlRfVElNRTsK IAogICAgIEdka0RyYWdDb250ZXh0KiBjb250ZXh0ID0gZ3RrX2RyYWdfYmVnaW4oR1RLX1dJREdF VChtX3dlYlZpZXcpLCB0YXJnZXRMaXN0LmdldCgpLCBkcmFnQWN0aW9uLCAxLCBldmVudCk7CiAg ICAgd2ViVmlldy0+cHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cy5zZXQoY29udGV4dCwgZGF0YU9i amVjdCk7CkBAIC05MCw2ICs5Miw4IEBAIHZvaWQgRHJhZ0NsaWVudDo6c3RhcnREcmFnKERyYWdJ bWFnZVJlZiBpbWFnZSwgY29uc3QgSW50UG9pbnQmIGRyYWdJbWFnZU9yaWdpbiwKICAgICAgICAg Z3RrX2RyYWdfc2V0X2ljb25fcGl4YnVmKGNvbnRleHQsIGltYWdlLCBldmVudFBvcy54KCkgLSBk cmFnSW1hZ2VPcmlnaW4ueCgpLCBldmVudFBvcy55KCkgLSBkcmFnSW1hZ2VPcmlnaW4ueSgpKTsK ICAgICBlbHNlCiAgICAgICAgIGd0a19kcmFnX3NldF9pY29uX2RlZmF1bHQoY29udGV4dCk7CisK KyAgICBnZGtfZXZlbnRfZnJlZShldmVudCk7CiB9CiAKIERyYWdJbWFnZVJlZiBEcmFnQ2xpZW50 OjpjcmVhdGVEcmFnSW1hZ2VGb3JMaW5rKEtVUkwmLCBjb25zdCBTdHJpbmcmLCBGcmFtZSopCg==