39182 2010-05-16 13:11:13 -0700 FrameLoader: factor applyUserAgent(), addExtraFieldsToRequest(), and addHTTPOriginIfNeeded() out of the FrameLoader class 2011-06-12 02:30:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 29947 1 cjerdonek cjerdonek abarth cjerdonek oldest_to_newest 226524 0 cjerdonek 2010-05-16 13:11:13 -0700 It looks like none of these methods that add information to a ResourceRequest (applyUserAgent, addExtraFieldsToRequest, and addHTTPOriginIfNeeded) require access to private FrameLoader data, so we should be able to make all of them non-member, non-friend. Teasing these out will increase encapsulation a bit more. 226569 1 abarth 2010-05-16 17:38:37 -0700 Hum... It's not 100% clear to me where we'd put these methods. What did you have in mind? 226574 2 cjerdonek 2010-05-16 17:47:14 -0700 (In reply to comment #1) > Hum... It's not 100% clear to me where we'd put these methods. What did you have in mind? I had in mind declaring applyUserAgent() and addHTTPOriginIfNeeded() in FrameLoader.h outside of the class (suitably renamed). addExtraFieldsToRequest() can be declared static (file-scope) in the .cpp file. 226576 3 abarth 2010-05-16 18:01:02 -0700 Generally, we prefer keeping methods in the class, except for some kinds of utility methods. One thing that might make sense is putting these methods on some sort of request object because they operate on the request. You'll have to look to see which layer of request makes the most sense. ResourceRequest might be slightly too low-level because the platform directory isn't allowed to depend on anything else in WebCore... 419278 4 abarth 2011-06-12 02:30:39 -0700 Marking WONTFIX for now. We can revisit this later if we still think this is a good idea.