39118 2010-05-14 08:26:17 -0700 Touch events are marked DontEnum in DOMWindow.idl 2010-05-19 02:37:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32485 1 benm benm android-webkit-unforking commit-queue gdk hausmann steveblock oldest_to_newest 225834 0 benm 2010-05-14 08:26:17 -0700 The touch event listener attributes are marked as DontEnum in DOMWindow.idl in contrast to all the other attribute EventListeners. Is this intentional? I propose that we remove the flag from the IDL and make them enumerable for consistency. I can send a patch if there is agreement. Thanks! 226754 1 56240 benm 2010-05-17 07:15:50 -0700 Created attachment 56240 Patch Here's what the patch would look like. I believe Qt is the only platform that needs the layout test to be updated - AFAIK no other platforms that don't skip this test (e.g. Chromium skip it) have touch events enabled. 226787 2 56240 darin 2010-05-17 09:43:03 -0700 Comment on attachment 56240 Patch OK. r=me 227751 3 56240 commit-queue 2010-05-19 02:37:47 -0700 Comment on attachment 56240 Patch Clearing flags on attachment: 56240 Committed r59754: <http://trac.webkit.org/changeset/59754> 227752 4 commit-queue 2010-05-19 02:37:52 -0700 All reviewed patches have been landed. Closing bug. 56240 2010-05-17 07:15:50 -0700 2010-05-19 02:37:46 -0700 Patch 39118.txt text/plain 3355 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTYwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMTcgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvdWNo IGV2ZW50cyBhcmUgbWFya2VkIERvbnRFbnVtIGluIERPTVdpbmRvdy5pZGwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MTE4CisKKyAgICAgICAgVG91 Y2ggZXZlbnRzIGFyZSB0aGUgb25seSBhdHRyaWJ1dGUgZXZlbnQgbGlzdGVuZXJzIG9uIHRoZQor ICAgICAgICB3aW5kb3cgb2JqZWN0IHRoYXQgYXJlIG1hcmtlZCBEb250RW51bS4gRm9yIGNvbnNp c3RlbmN5IGFsbG93CisgICAgICAgIHRoZW0gdG8gYmUgZW51bWVyYXRlZC4KKworICAgICAgICAq IHBhZ2UvRE9NV2luZG93LmlkbDogUmVtb3ZlIERvbnRFbnVtIGZyb20gdG91Y2hjYW5jZWwsIHRv dWNoZW5kLAorICAgICAgICAgICAgdG91Y2hzdGFydCBhbmQgdG91Y2htb3ZlIGF0dHJpYnV0ZXMu CisKIDIwMTAtMDUtMTcgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IExhc3psbyBHb21ib3MuCkluZGV4OiBXZWJD b3JlL3BhZ2UvRE9NV2luZG93LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2lu ZG93LmlkbAkocmV2aXNpb24gNTk2MDEpCisrKyBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAko d29ya2luZyBjb3B5KQpAQCAtMjk0LDEwICsyOTQsMTAgQEAgbW9kdWxlIHdpbmRvdyB7CiAjaWYg ZGVmaW5lZChFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTKSAmJiBFTkFCTEVfT1JJRU5UQVRJT05f RVZFTlRTCiAgICAgICAgIGF0dHJpYnV0ZSBFdmVudExpc3RlbmVyIG9ub3JpZW50YXRpb25jaGFu Z2U7CiAjZW5kaWYKLSAgICAgICAgYXR0cmlidXRlIFtEb250RW51bSxDb25kaXRpb25hbD1UT1VD SF9FVkVOVFMsRW5hYmxlZEF0UnVudGltZV0gRXZlbnRMaXN0ZW5lciBvbnRvdWNoc3RhcnQ7Ci0g ICAgICAgIGF0dHJpYnV0ZSBbRG9udEVudW0sQ29uZGl0aW9uYWw9VE9VQ0hfRVZFTlRTLEVuYWJs ZWRBdFJ1bnRpbWVdIEV2ZW50TGlzdGVuZXIgb250b3VjaG1vdmU7Ci0gICAgICAgIGF0dHJpYnV0 ZSBbRG9udEVudW0sQ29uZGl0aW9uYWw9VE9VQ0hfRVZFTlRTLEVuYWJsZWRBdFJ1bnRpbWVdIEV2 ZW50TGlzdGVuZXIgb250b3VjaGVuZDsKLSAgICAgICAgYXR0cmlidXRlIFtEb250RW51bSxDb25k aXRpb25hbD1UT1VDSF9FVkVOVFMsRW5hYmxlZEF0UnVudGltZV0gRXZlbnRMaXN0ZW5lciBvbnRv dWNoY2FuY2VsOworICAgICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPVRPVUNIX0VWRU5UUyxF bmFibGVkQXRSdW50aW1lXSBFdmVudExpc3RlbmVyIG9udG91Y2hzdGFydDsKKyAgICAgICAgYXR0 cmlidXRlIFtDb25kaXRpb25hbD1UT1VDSF9FVkVOVFMsRW5hYmxlZEF0UnVudGltZV0gRXZlbnRM aXN0ZW5lciBvbnRvdWNobW92ZTsKKyAgICAgICAgYXR0cmlidXRlIFtDb25kaXRpb25hbD1UT1VD SF9FVkVOVFMsRW5hYmxlZEF0UnVudGltZV0gRXZlbnRMaXN0ZW5lciBvbnRvdWNoZW5kOworICAg ICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPVRPVUNIX0VWRU5UUyxFbmFibGVkQXRSdW50aW1l XSBFdmVudExpc3RlbmVyIG9udG91Y2hjYW5jZWw7CiAKICAgICAgICAgLy8gRXZlbnRUYXJnZXQg aW50ZXJmYWNlCiAgICAgICAgIFtDdXN0b21dIHZvaWQgYWRkRXZlbnRMaXN0ZW5lcihpbiBET01T dHJpbmcgdHlwZSwKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5NjA2KQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMTcgIEJlbiBN dXJkb2NoICA8YmVubUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRvdWNoIGV2ZW50cyBhcmUgbWFya2VkIERvbnRFbnVtIGluIERP TVdpbmRvdy5pZGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM5MTE4CisKKyAgICAgICAgVXBkYXRlIHRoZSBleHBlY3RlZCByZXN1bHRzIGZvciBlbnVt ZXJhdGluZyB0aGUgd2luZG93IG9iamVjdAorICAgICAgICBwcm9wZXJ0aWVzIG5vdyB0b3VjaCBl dmVudCBsaXN0ZW5lcnMgYXJlIG5vIGxvbmdlciBtYXJrZWQgRG9udEVudW0uCisKKyAgICAgICAg KiBwbGF0Zm9ybS9xdC9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMtZXhwZWN0ZWQu dHh0OgorCiAyMDEwLTA1LTE0ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hhcGluLgpJbmRleDogTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2RvbS9XaW5kb3cvd2lu ZG93LXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1OTYwMSkKKysrIExheW91dFRl c3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydGllcy1leHBlY3Rl ZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTIxNDQsNiArMjE0NCwxMCBAQCB3aW5kb3cub25zdG9y YWdlIFtudWxsXQogd2luZG93Lm9uc3VibWl0IFtudWxsXQogd2luZG93Lm9uc3VzcGVuZCBbbnVs bF0KIHdpbmRvdy5vbnRpbWV1cGRhdGUgW251bGxdCit3aW5kb3cub250b3VjaGNhbmNlbCBbbnVs bF0KK3dpbmRvdy5vbnRvdWNoZW5kIFtudWxsXQord2luZG93Lm9udG91Y2htb3ZlIFtudWxsXQor d2luZG93Lm9udG91Y2hzdGFydCBbbnVsbF0KIHdpbmRvdy5vbnVubG9hZCBbbnVsbF0KIHdpbmRv dy5vbnZvbHVtZWNoYW5nZSBbbnVsbF0KIHdpbmRvdy5vbndhaXRpbmcgW251bGxdCg==