38926 2010-05-11 12:31:43 -0700 [chromium] Chromium window build system does not rebuild correctly when enabling/disabling a feature 2012-10-23 14:10:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 39054 1 jianli tony bradnelson bruno.abinader dglazkov eric mark thakis tkent tony tonyg webkit.review.bot yaar oldest_to_newest 224085 0 jianli 2010-05-11 12:31:43 -0700 When a feature is turned on, Chromium window build bot cannot build it successfully. The clean build has been forced. We need to find a solution for this. 226496 1 eric 2010-05-16 10:22:32 -0700 Claimed another victim: bug 39054. 226636 2 56214 tkent 2010-05-17 00:08:30 -0700 Created attachment 56214 A workaround patch 226781 3 yaar 2010-05-17 09:23:35 -0700 (In reply to comment #2) > Created an attachment (id=56214) [details] > A workaround patch Smart! LGTM, though I'm not a reviewer. 226812 4 56214 eric 2010-05-17 10:39:56 -0700 Comment on attachment 56214 A workaround patch I think that either the log or a comment should mention that this is a hack, and what bug we're working around. I'm told this is a bug in visual studio? 226813 5 eric 2010-05-17 10:40:51 -0700 Is there a better fix to be done? Or is this a permanent work-around? The comments in the code should make that clear. If this is permanent workaround, is there a way to add this hack into gyp directly? 226998 6 tkent 2010-05-17 17:12:55 -0700 I think my patch is a temporal workaround. I'll commit the patch with an additional comment. I'm not sure what is the real fix. Can we solve this by adding dependencies in .gyp files? Does GYP has no capability solve this? Should we remove build directories in GYP, gyp_webkit or gyp_chromium? 227094 7 tkent 2010-05-17 21:06:07 -0700 I landed "A workaround patch" as r59646. I won't close this bug. 227111 8 tkent 2010-05-17 22:07:34 -0700 Unfortunately, the workaround didn't work. Windows buildbot doesn't use update-webkit. It run "svn update", then update-webkit-chromium. 227137 9 eric 2010-05-17 22:53:55 -0700 It should call update-webkit --chromium. WE need to fix the master.cfg file. 635093 10 eric 2012-05-28 03:24:32 -0700 Is this still an issue? 636181 11 tony 2012-05-29 10:22:12 -0700 (In reply to comment #10) > Is this still an issue? Kent's workaround is still checked in and still works around the problem. I think msbuild (part of VS2010) doesn't have this problem, but we're not using VS2010 on build.webkit.org yet (we just started the rollout on the build.chromium.org bots). ninja doesn't have this problem either. Once the bots switch to VS2010 or ninja, we can test to verify that rebuilds work properly, remove Kent's work around and close this bug. 636186 12 thakis 2012-05-29 10:23:58 -0700 (In reply to comment #11) > Once the bots switch to VS2010 or ninja, we can test to verify that rebuilds work properly, remove Kent's work around and close this bug. ninja/win won't be ready for bot use for a while; I think it's more likely we'll switch the windows bots to vs2010 first. (ist that blocked on anything?) 636268 13 tony 2012-05-29 11:31:16 -0700 (In reply to comment #12) > (In reply to comment #11) > > Once the bots switch to VS2010 or ninja, we can test to verify that rebuilds work properly, remove Kent's work around and close this bug. > > ninja/win won't be ready for bot use for a while; I think it's more likely we'll switch the windows bots to vs2010 first. (ist that blocked on anything?) We can probably switch the bot to VS2010 now. Someone just has to do the work. 704033 14 bruno.abinader 2012-08-24 06:11:21 -0700 Adding bug 94094 as depending on this (EWS test runs with compile flag enabled are failing on win, gtk and mac ports). 747483 15 thakis 2012-10-22 06:22:47 -0700 Bruno: I think win is Apple's windows port, gtk is the gtk port, and mac is Apple's mac port. Neither of those use chromium's build system. The chromium bots all start with 'cr-'. I think you can remove this dependency again. Since I'm posting this anyway: We deprecated msvc2008 in chromium and don't have any bots for it anymore upstream. If the webkit chromium bots still use msvc2008, you should move away from that (upstream uses both msvs2010 and ninja now) 747494 16 bruno.abinader 2012-10-22 06:50:01 -0700 (In reply to comment #15) > Bruno: I think win is Apple's windows port, gtk is the gtk port, and mac is Apple's mac port. Neither of those use chromium's build system. The chromium bots all start with 'cr-'. I think you can remove this dependency again. > > Since I'm posting this anyway: We deprecated msvc2008 in chromium and don't have any bots for it anymore upstream. If the webkit chromium bots still use msvc2008, you should move away from that (upstream uses both msvs2010 and ninja now) Thank you for the clarification, Nico! I'm going to update the bug depedencies accordingly. 747699 17 tony 2012-10-22 11:07:30 -0700 The build.webkit.org Chromium Win bot has been using VS2010 for a few months now. I think it's safe to remove this hack. 748870 18 170209 tony 2012-10-23 12:53:37 -0700 Created attachment 170209 Patch 748898 19 tony 2012-10-23 13:23:05 -0700 (In reply to comment #18) > Created an attachment (id=170209) [details] > Patch I manually verified that VS2010 properly rebuilds after changing features.gypi. 748914 20 thakis 2012-10-23 13:34:17 -0700 Looks good, but I'm no reviewer. 748930 21 170209 eric 2012-10-23 13:42:15 -0700 Comment on attachment 170209 Patch LGTM. 748974 22 170209 webkit.review.bot 2012-10-23 14:10:08 -0700 Comment on attachment 170209 Patch Clearing flags on attachment: 170209 Committed r132262: <http://trac.webkit.org/changeset/132262> 748975 23 webkit.review.bot 2012-10-23 14:10:13 -0700 All reviewed patches have been landed. Closing bug. 56214 2010-05-17 00:08:30 -0700 2012-10-23 12:53:30 -0700 A workaround patch bug-38926-20100517160828.patch text/plain 1934 tkent ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlOTc5YjE4YzZiZjRlNDRhOTJjNDgyYjRlNzU4YjY2MzY3OGQzMTQ1Li4zZjEyZmVi OTAxMmVlZmZlMDg0M2I3MWE4Y2Y3MDgxMDNiMjQ3Yjk5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMDUtMTcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9taXVtIHdpbmRvdyBi dWlsZCBzeXN0ZW0gZG9lcyBub3QgcmVidWlsZCBjb3JyZWN0bHkgd2hlbgorICAgICAgICBlbmFi bGluZy9kaXNhYmxpbmcgYSBmZWF0dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zODkyNgorCisgICAgICAgIEFkZCBhIHdvcmthcm91bmQgb2YgdGhp cyBpc3N1ZS4KKworICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtpdDoKKyAgICAgICAgICBD aHJvbWl1bS1XaW5kb3dzIG9ubHk6IElmIFdlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXAgaGFz IGJlZW4KKyAgICAgICAgICB1cGRhdGVkLCByZW1vdmUgV2ViS2l0L2Nocm9taXVtL0RlYnVnIGFu ZCBXZWJLaXQvY2hyb21pdW0vUmVsZWFzZS4KKwogMjAxMC0wNS0xNiAgRGFuaWVsIEJhdGVzICA8 ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgSmVyZG9uZWsuCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQKaW5kZXggNzYwMmM0MWRlMTdhMWVmZjU1OTkyN2JkMWVl YTgxZjQ3NjJkNTljZS4uNTZhOTk3YjQzM2Q2YTk2ZTVlNjE5MzY1ZTYwMTU3YmMxY2VkOGE5MyAx MDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdApAQCAtMzMsNiArMzMsNyBAQCB1c2Ugc3RyaWN0 OwogdXNlIEZpbmRCaW47CiB1c2UgbGliICRGaW5kQmluOjpCaW47CiB1c2UgRmlsZTo6QmFzZW5h bWU7Cit1c2UgRmlsZTo6UGF0aDsKIHVzZSBGaWxlOjpTcGVjOwogdXNlIEdldG9wdDo6TG9uZzsK IHVzZSBWQ1NVdGlsczsKQEAgLTY3LDYgKzY4LDggQEAgX19FTkRfXwogICAgIGV4aXQgMTsKIH0K IAorbXkgJHN0YXJ0VGltZSA9IHRpbWUoKTsKKwogbXkgQHN2bk9wdGlvbnMgPSAoKTsKIHB1c2gg QHN2bk9wdGlvbnMsICctcScgaWYgJHF1aWV0OwogCkBAIC04Myw2ICs4NiwxMCBAQCBpZiAoLWQg Ii4uL0ludGVybmFsIikgewogICAgIHJ1blN2blVwZGF0ZSgpIGlmICRpc1NWTjsKICAgICBydW5H aXRVcGRhdGUoKSBpZiAkaXNHaXQ7CiB9IGVsc2lmIChpc0Nocm9taXVtKCkpIHsKKyAgICBpZiAo KGlzQ3lnd2luKCkgfHwgaXNXaW5kb3dzKCkpICYmIChzdGF0KCJXZWJLaXQvY2hyb21pdW0vZmVh dHVyZXMuZ3lwaSIpKVs5XSA+PSAkc3RhcnRUaW1lKSB7CisgICAgICAgIHByaW50ICJmZWF0dXJl cy5neXBpIGhhcyBiZWVuIHVwZGF0ZWQuIENsZWFuaW5nIHRoZSBidWlsZCBkaXJlY3Rvcmllcy5c biI7CisgICAgICAgIHJtdHJlZShbIldlYktpdC9jaHJvbWl1bS9EZWJ1ZyIsICJXZWJLaXQvY2hy b21pdW0vUmVsZWFzZSJdKTsKKyAgICB9CiAgICAgc3lzdGVtKCJwZXJsIiwgIldlYktpdFRvb2xz L1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bSIpID09IDAgb3IgZGllICQhOwogfSBlbHNp ZiAoaXNBcHBsZVdpbldlYktpdCgpKSB7CiAgICAgc3lzdGVtKCJwZXJsIiwgIldlYktpdFRvb2xz L1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1hdXhpbGlhcnktbGlicyIpID09IDAgb3IgZGllOwo= 170209 2012-10-23 12:53:37 -0700 2012-10-23 14:10:08 -0700 Patch bug-38926-20121023125214.patch text/plain 2152 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMjU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzE1NWViZmVmMWE4OGY5ZjNjYmY4ODFiMmRkYmU4YjA2 NjcxMDUwNC4uY2QzMjQ0ZGQ0ZWYyZjUzM2I1MzEyNDlmNWMzMGVlMDBmNzE2NzRlOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEwLTIzICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgW2Nocm9taXVtXSBDaHJvbWl1bSB3aW5kb3cgYnVpbGQgc3lzdGVtIGRvZXMgbm90IHJlYnVp bGQgY29ycmVjdGx5IHdoZW4gZW5hYmxpbmcvZGlzYWJsaW5nIGEgZmVhdHVyZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg5MjYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgaGFjayBmb3IgY2xv YmJlcmluZyBidWlsZCB3aGVuIGZlYXR1cmVzLmd5cGkgY2hhbmdlcy4gTm93IHRoYXQKKyAgICAg ICAgQ2hyb21pdW0gcmVxdWlyZXMgVlMyMDEwIG9yIG5ld2VyLCB0aGlzIGJ1ZyBoYXMgZ29uZSBh d2F5LgorCisgICAgICAgICogU2NyaXB0cy91cGRhdGUtd2Via2l0OgorCiAyMDEyLTEwLTIzICBK b2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1 bV0gcmVtb3ZlIHRoZSBjb25zdCBxdWFsaWZpZXIgZnJvbSBXZWJUZXN0RGVsZWdhdGU6OnByaW50 TWVzc2FnZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0IGIvVG9vbHMv U2NyaXB0cy91cGRhdGUtd2Via2l0CmluZGV4IGViOTRmMTY1YjRlMGM3YjBkNmY3MWIzNzA1YWFi YzAyZmI1OGZmZDUuLjZiYTgwNDRmNDg4ZGU1ZTFlNWMzNzJiZGZiN2E0ZTA2NDg0MjkxMmYgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRz L3VwZGF0ZS13ZWJraXQKQEAgLTM0LDcgKzM0LDYgQEAgdXNlIHN0cmljdDsKIHVzZSBGaW5kQmlu OwogdXNlIGxpYiAkRmluZEJpbjo6QmluOwogdXNlIEZpbGU6OkJhc2VuYW1lOwotdXNlIEZpbGU6 OlBhdGg7CiB1c2UgRmlsZTo6U3BlYzsKIHVzZSBHZXRvcHQ6Okxvbmc7CiB1c2UgVkNTVXRpbHM7 CkBAIC04Nyw4ICs4Niw2IEBAIGlmICgkdXNlTmluamEpIHsKICAgICAkRU5WeyJHWVBfR0VORVJB VE9SUyJ9ID0gIm5pbmphIjsKIH0KIAotbXkgJHN0YXJ0VGltZSA9IHRpbWUoKTsKLQogbXkgQHN2 bk9wdGlvbnMgPSAoKTsKIHB1c2ggQHN2bk9wdGlvbnMsICctcScgaWYgJHF1aWV0OwogCkBAIC0x MDUsMTMgKzEwMiw2IEBAIGlmICgtZCAiLi4vSW50ZXJuYWwiKSB7CiAgICAgcnVuU3ZuVXBkYXRl KCkgaWYgaXNTVk5EaXJlY3RvcnkoIi4iKTsKICAgICBydW5HaXRVcGRhdGUoKSBpZiBpc0dpdERp cmVjdG9yeSgiLiIpOwogfSBlbHNpZiAoaXNDaHJvbWl1bSgpKSB7Ci0gICAgIyBXb3JrYXJvdW5k IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg5MjYKLSAgICAj IFdlIHNob3VsZCByZW1vdmUgdGhlIGZvbGxvd2luZyAiaWYiIGJsb2NrIHdoZW4gd2UgZmluZCBh IHJpZ2h0IGZpeC4KLSAgICBpZiAoKGlzQ3lnd2luKCkgfHwgaXNXaW5kb3dzKCkpICYmIChzdGF0 KCJXZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaSIpKVs5XSA+PSAkc3RhcnRUaW1lKSB7Ci0g ICAgICAgIHByaW50ICJmZWF0dXJlcy5neXBpIGhhcyBiZWVuIHVwZGF0ZWQuIENsZWFuaW5nIHRo ZSBidWlsZCBkaXJlY3Rvcmllcy5cbiI7Ci0gICAgICAgIHJtdHJlZShbIldlYktpdC9jaHJvbWl1 bS9EZWJ1ZyIsICJXZWJLaXQvY2hyb21pdW0vUmVsZWFzZSJdKTsKLSAgICB9Ci0KICAgICBteSBA Y2hyb21pdW1VcGRhdGVBcmdzID0gKCJwZXJsIiwgIlRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtp dC1jaHJvbWl1bSIpOwogICAgIHB1c2ggQGNocm9taXVtVXBkYXRlQXJncywgIi0tY2hyb21pdW0t YW5kcm9pZCIgaWYgaXNDaHJvbWl1bUFuZHJvaWQoKTsKICAgICBwdXNoIEBjaHJvbWl1bVVwZGF0 ZUFyZ3MsICItLWZvcmNlIiBpZiBmb3JjZUNocm9taXVtVXBkYXRlKCk7Cg==