38913 2010-05-11 09:28:37 -0700 REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works 2010-05-22 10:49:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 39021 1 dglazkov dglazkov ap darin oldest_to_newest 223955 0 dglazkov 2010-05-11 09:28:37 -0700 REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works 223997 1 dglazkov 2010-05-11 10:31:25 -0700 Turns out my super-duper test had incomplete coverage. http://www.shacknews.com/search.x?terms=abcdef&type=comments no longer implicitly submits. Patch coming up. 224012 2 55720 dglazkov 2010-05-11 10:49:09 -0700 Created attachment 55720 Patch 224016 3 55720 darin 2010-05-11 10:55:57 -0700 Comment on attachment 55720 Patch I would have preferred to see the bug fix separate from the cleanup. Clearly all that was needed to fix the bug was to check isSuccessfulSubmitButton even when the element is not an <input>. And the renaming and refactoring obscures that change. The final resulting code looks great. r=me 224020 4 ap 2010-05-11 11:05:34 -0700 <rdar://problem/7969230> 224023 5 dglazkov 2010-05-11 11:09:42 -0700 I apologize, I started with a fix and then it was looking uglier and uglier. I have another patch that makes it even less ugly, but I'll land this first, then lick it some more. 224173 6 dglazkov 2010-05-11 15:01:37 -0700 Committed r59173: <http://trac.webkit.org/changeset/59173> 55720 2010-05-11 10:49:09 -0700 2010-05-11 10:55:56 -0700 Patch bug-38913-20100511104908.patch text/plain 11999 dglazkov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzOWMzNmUxMjgwOTA1NDBkZDdiYzU5YjI0M2VhMDNiNTA2NTg1YjU0Li40N2MxYzFl YTJhZDY4ZDRjYTg0NGM0MWEwYzg3YTc0ZmVkMDc5Yjk0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDUtMTEgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9O KHI1ODUyMCk6IEltcGxpY2l0IHN1Ym1pc3Npb24gb24gZm9ybXMgd2l0aCBidXR0b24gdHlwZT0i c3VibWl0IiBubyBsb25nZXIgd29ya3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM4OTEzCisKKyAgICAgICAgVXBkYXRlZCB0aGUgdGVzdCB0byBpbmNs dWRlIGNvdmVyYWdlIG9mIGJ1dHRvbiBlbGVtZW50cy4KKworICAgICAgICAqIGZhc3QvZm9ybXMv aW1wbGljaXQtc3VibWlzc2lvbi1leHBlY3RlZC50eHQ6IFVwZGF0ZWQgZXhwZWN0YXRpb25zIHdp dGggbmV3IHRlc3QgcmVzdWx0cy4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL2ltcGxpY2l0LXN1Ym1p c3Npb24uaHRtbDogQWRkZWQgdGVzdHMgYW5kIGNvZGUgdG8gY292ZXIgYnV0dG9uIGVsZW1lbnRz LgorCiAyMDEwLTA1LTA3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9pbXBsaWNpdC1zdWJtaXNzaW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvaW1wbGljaXQtc3VibWlzc2lvbi1leHBlY3RlZC50eHQKaW5kZXggZjI2MzM2 OThkY2M1MDZjMDllYzkzYzM2MWIyMDQ5MjQ1ZGFjNjc2ZS4uOTNiYzEwNWI1NmYwODk3ZjBiNDY5 NmE1MmMxMmQ5Njc3MmE0Y2NmNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9p bXBsaWNpdC1zdWJtaXNzaW9uLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL2ltcGxpY2l0LXN1Ym1pc3Npb24tZXhwZWN0ZWQudHh0CkBAIC03LDggKzcsOCBAQCBNdWx0 aXBsZSB0ZXh0IGlucHV0cyB3aXRoIHN1Ym1pdCBzaG91bGQgc3VibWl0OiBQQVNTCiBNdWx0aXBs ZSB0ZXh0IGlucHV0cyB3aXRoIHN1Ym1pdCBkaXNhYmxlZCBzaG91bGQgbm90IHN1Ym1pdDogUEFT UwogTXVsdGlwbGUgdGV4dCBpbnB1dHMgYW5kIG11bHRpcGxlIHN1Ym1pdHMsIGZpcnN0IHN1Ym1p dCBkaXNhYmxlZCBzaG91bGQgc3VibWl0OiBQQVNTCiBUZXh0IGlucHV0IGFuZCB0ZXh0IGFyZWEs IHRleHQgaW5wdXQgZm9jdXNlZCBzaG91bGQgc3VibWl0OiBQQVNTCi1UZXh0IGlucHV0IGFuZCB0 ZXh0IGFyZWEgYW5kIGEgc3VibWl0IGJ1dHRvbiwgdGV4dCBpbnB1dCBmb2N1c2VkIHNob3VsZCBz dWJtaXQ6IFBBU1MKLVRleHQgaW5wdXQgYW5kIHRleHQgYXJlYSBhbmQgYSBkaXNhYmxlZCBzdWJt aXQgYnV0dG9uLCB0ZXh0IGlucHV0IGZvY3VzZWQgc2hvdWxkIHN1Ym1pdDogUEFTUworVGV4dCBp bnB1dCBhbmQgdGV4dCBhcmVhIGFuZCBhIHN1Ym1pdCwgdGV4dCBpbnB1dCBmb2N1c2VkIHNob3Vs ZCBzdWJtaXQ6IFBBU1MKK1RleHQgaW5wdXQgYW5kIHRleHQgYXJlYSBhbmQgYSBkaXNhYmxlZCBz dWJtaXQsIHRleHQgaW5wdXQgZm9jdXNlZCBzaG91bGQgc3VibWl0OiBQQVNTCiBUZXh0IGlucHV0 IGFuZCBjaGVja2JveCwgdGV4dCBpbnB1dCBmb2N1c2VkIHNob3VsZCBzdWJtaXQ6IFBBU1MKIFRl eHQgaW5wdXQgYW5kIHJhZGlvLCB0ZXh0IGlucHV0IGZvY3VzZWQgc2hvdWxkIHN1Ym1pdDogUEFT UwogVGV4dCBpbnB1dCBhbmQgdGV4dCBhcmVhLCB0ZXh0YXJlYSBmb2N1c2VkIHNob3VsZCBub3Qg c3VibWl0OiBQQVNTCkBAIC0xNiw5ICsxNiwxMSBAQCBUZXh0IGlucHV0IGFuZCBjaGVja2JveCwg Y2hlY2tib3ggZm9jdXNlZCBzaG91bGQgbm90IHN1Ym1pdDogUEFTUwogVGV4dCBpbnB1dCBhbmQg cmFkaW8sIHJhZGlvIGZvY3VzZWQgc2hvdWxkIG5vdCBzdWJtaXQ6IFBBU1MKIFNpbmdsZSByYWRp byBzaG91bGQgbm90IHN1Ym1pdDogUEFTUwogU2luZ2xlIGNoZWNrYm94IHNob3VsZCBub3Qgc3Vi bWl0OiBQQVNTCi1TaW5nbGUgY2hlY2tib3ggd2l0aCBhIHN1Ym1pdCBidXR0b24gc2hvdWxkIHN1 Ym1pdDogUEFTUworU2luZ2xlIGNoZWNrYm94IHdpdGggYSBzdWJtaXQgc2hvdWxkIHN1Ym1pdDog UEFTUwogU2luZ2xlIGNoZWNrYm94IHdpdGggYSBzdWJtaXQgZGlzYWJsZWQgc2hvdWxkIG5vdCBz dWJtaXQ6IFBBU1MKIFNpbmdsZSBzZWxlY3Qgc2hvdWxkIG5vdCBzdWJtaXQ6IFBBU1MKIFRleHQg ZmllbGQgYW5kIHNpbmdsZSBzZWxlY3QsIHRleHQgZm9jdXNlZCBzaG91bGQgc3VibWl0OiBQQVNT CiBUZXh0IGZpZWxkIGFuZCBzaW5nbGUgc2VsZWN0LCBzZWxlY3QgZm9jdXNlZCBzaG91bGQgbm90 IHN1Ym1pdDogUEFTUwogSXNpbmRleCBzaG91bGQgc3VibWl0OiBQQVNTCitNdWx0aXBsZSB0ZXh0 IGlucHV0cyB3aXRoIGEgYnV0dG9uIHNob3VsZCBzdWJtaXQ6IFBBU1MKK011bHRpcGxlIHRleHQg aW5wdXRzIHdpdGggYSBkaXNhYmxlZCBidXR0b24gc2hvdWxkIG5vdCBzdWJtaXQ6IFBBU1MKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW1wbGljaXQtc3VibWlzc2lvbi5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbXBsaWNpdC1zdWJtaXNzaW9uLmh0bWwKaW5kZXgg NGJmMWM1MGViYTg2Njg0OGNjZTZmOWJhMGFlMWQzNWU3MWVmYmIxZS4uMTQzMzNiYzA3ZGIwZjVj OGM2NDcxOTg3OWNjNzMxOTRmYWEyMDk0MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9pbXBsaWNpdC1zdWJtaXNzaW9uLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9pbXBsaWNpdC1zdWJtaXNzaW9uLmh0bWwKQEAgLTE1LDggKzE1LDggQEAgdmFyIGFsbFRlc3Rz ID0gWwogICAgIFsgIk11bHRpcGxlIHRleHQgaW5wdXRzIHdpdGggc3VibWl0IGRpc2FibGVkIiwg IiF0ZXh0LHRleHQsdGV4dCwtc3VibWl0IiwgIm4iIF0sCiAgICAgWyAiTXVsdGlwbGUgdGV4dCBp bnB1dHMgYW5kIG11bHRpcGxlIHN1Ym1pdHMsIGZpcnN0IHN1Ym1pdCBkaXNhYmxlZCIsICIhdGV4 dCx0ZXh0LHRleHQsLXN1Ym1pdCxzdWJtaXQiLCAieSIgXSwgLy8gbWF0Y2ggSUUsIG5vdCBGRi4K ICAgICBbICJUZXh0IGlucHV0IGFuZCB0ZXh0IGFyZWEsIHRleHQgaW5wdXQgZm9jdXNlZCIsICIh dGV4dCx0ZXh0YXJlYSIsICJ5IiBdLAotICAgIFsgIlRleHQgaW5wdXQgYW5kIHRleHQgYXJlYSBh bmQgYSBzdWJtaXQgYnV0dG9uLCB0ZXh0IGlucHV0IGZvY3VzZWQiLCAiIXRleHQsdGV4dGFyZWEs c3VibWl0IiwgInkiIF0sCi0gICAgWyAiVGV4dCBpbnB1dCBhbmQgdGV4dCBhcmVhIGFuZCBhIGRp c2FibGVkIHN1Ym1pdCBidXR0b24sIHRleHQgaW5wdXQgZm9jdXNlZCIsICIhdGV4dCx0ZXh0YXJl YSwtc3VibWl0IiwgInkiIF0sIC8vIG1hdGNoIElFLCBub3QgRkYuCisgICAgWyAiVGV4dCBpbnB1 dCBhbmQgdGV4dCBhcmVhIGFuZCBhIHN1Ym1pdCwgdGV4dCBpbnB1dCBmb2N1c2VkIiwgIiF0ZXh0 LHRleHRhcmVhLHN1Ym1pdCIsICJ5IiBdLAorICAgIFsgIlRleHQgaW5wdXQgYW5kIHRleHQgYXJl YSBhbmQgYSBkaXNhYmxlZCBzdWJtaXQsIHRleHQgaW5wdXQgZm9jdXNlZCIsICIhdGV4dCx0ZXh0 YXJlYSwtc3VibWl0IiwgInkiIF0sIC8vIG1hdGNoIElFLCBub3QgRkYuCiAgICAgWyAiVGV4dCBp bnB1dCBhbmQgY2hlY2tib3gsIHRleHQgaW5wdXQgZm9jdXNlZCIsICIhdGV4dCxjaGVja2JveCIs ICJ5IiBdLAogICAgIFsgIlRleHQgaW5wdXQgYW5kIHJhZGlvLCB0ZXh0IGlucHV0IGZvY3VzZWQi LCAiIXRleHQscmFkaW8iLCAieSIgXSwKICAgICBbICJUZXh0IGlucHV0IGFuZCB0ZXh0IGFyZWEs IHRleHRhcmVhIGZvY3VzZWQiLCAidGV4dCwhdGV4dGFyZWEiLCAibiIgXSwKQEAgLTI0LDEyICsy NCwxNCBAQCB2YXIgYWxsVGVzdHMgPSBbCiAgICAgWyAiVGV4dCBpbnB1dCBhbmQgcmFkaW8sIHJh ZGlvIGZvY3VzZWQiLCAidGV4dCwhcmFkaW8iLCAibiIgXSwgLy8gbWF0Y2ggSUUsIG5vdCBGRi4K ICAgICBbICJTaW5nbGUgcmFkaW8iLCAiIXJhZGlvIiwgIm4iIF0sIC8vIG1hdGNoIElFLCBub3Qg RkYuCiAgICAgWyAiU2luZ2xlIGNoZWNrYm94IiwgIiFjaGVja2JveCIsICJuIiBdLAotICAgIFsg IlNpbmdsZSBjaGVja2JveCB3aXRoIGEgc3VibWl0IGJ1dHRvbiIsICIhY2hlY2tib3gsc3VibWl0 IiwgInkiIF0sCisgICAgWyAiU2luZ2xlIGNoZWNrYm94IHdpdGggYSBzdWJtaXQiLCAiIWNoZWNr Ym94LHN1Ym1pdCIsICJ5IiBdLAogICAgIFsgIlNpbmdsZSBjaGVja2JveCB3aXRoIGEgc3VibWl0 IGRpc2FibGVkIiwgIiFjaGVja2JveCwtc3VibWl0IiwgIm4iIF0sCiAgICAgWyAiU2luZ2xlIHNl bGVjdCIsICIhc2VsZWN0IiwgIm4iIF0sCiAgICAgWyAiVGV4dCBmaWVsZCBhbmQgc2luZ2xlIHNl bGVjdCwgdGV4dCBmb2N1c2VkIiwgIiF0ZXh0LHNlbGVjdCIsICJ5IiBdLAogICAgIFsgIlRleHQg ZmllbGQgYW5kIHNpbmdsZSBzZWxlY3QsIHNlbGVjdCBmb2N1c2VkIiwgInRleHQsIXNlbGVjdCIs ICJuIiBdLAotICAgIFsgIklzaW5kZXgiLCAiIWlzaW5kZXgiLCAieSJdCisgICAgWyAiSXNpbmRl eCIsICIhaXNpbmRleCIsICJ5Il0sCisgICAgWyAiTXVsdGlwbGUgdGV4dCBpbnB1dHMgd2l0aCBh IGJ1dHRvbiIsICIhdGV4dCx0ZXh0LGJ1dHRvbiIsICJ5Il0sCisgICAgWyAiTXVsdGlwbGUgdGV4 dCBpbnB1dHMgd2l0aCBhIGRpc2FibGVkIGJ1dHRvbiIsICIhdGV4dCx0ZXh0LC1idXR0b24iLCAi biJdCiBdOwogCiBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CkBAIC04Nyw2ICs4 OSw5IEBAIGZ1bmN0aW9uIHJ1blRlc3RJbklmcmFtZSgpCiAgICAgICAgIH0gZWxzZSBpZiAodHlw ZSA9PSAic2VsZWN0IikgewogICAgICAgICAgICAgY29udHJvbCA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQodHlwZSk7CiAgICAgICAgICAgICBjb250cm9sLm9wdGlvbnMuYWRkKG5ldyBPcHRpb24o ImEiKSk7CisgICAgICAgIH0gZWxzZSBpZiAodHlwZSA9PSAiYnV0dG9uIikgeworICAgICAgICAg ICAgY29udHJvbCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQodHlwZSk7CisgICAgICAgICAgICBj b250cm9sLnR5cGUgPSAic3VibWl0IjsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIGNv bnRyb2wgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpbnB1dCIpOwogICAgICAgICAgICAgY29u dHJvbC50eXBlID0gdHlwZTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggOWEzMjFkZDI1NTc0MWQwNGE3YmVlYTIzMDkzYTQ3MDVjZmE3NzFk Mi4uMTYyMTRmYjA0ODcxZmJlMWRiNTc0NTNlMGQ3YmFlN2I1OTM3NmQwYSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOSBA QAorMjAxMC0wNS0xMSAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJ T04ocjU4NTIwKTogSW1wbGljaXQgc3VibWlzc2lvbiBvbiBmb3JtcyB3aXRoIGJ1dHRvbiB0eXBl PSJzdWJtaXQiIG5vIGxvbmdlciB3b3JrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Mzg5MTMKKworICAgICAgICAqIFdpZGVuZWQgdGhlIGNoZWNrIGZv ciBhIHN1Y2Nlc3NmdWwgc3VibWl0IGJ1dHRvbiB0byBpbmNsdWRlIGFsbCBIVE1MRm9ybUNvbnRy b2xFbGVtZW50cy4KKyAgICAgICAgKiBDbGFyaWZpZWQgaW1wbGljaXQgc3VibWlzc2lvbiBjb2Rl IGJ5OgorICAgICAgICAgICAgLSBpbnRyb2R1Y2luZyBIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojpj YW5UcmlnZ2VySW1wbGljaXRTdWJtaXNzaW9uIGZsYWcsCisgICAgICAgICAgICAtIGdldHRpbmcg cmlkIG9mIHN0YXRpYyBjYXN0aW5nIGFuZCBjaGVja2luZyBmb3IgdGFnIG5hbWVzLgorCisgICAg ICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpI VE1MRm9ybUNvbnRyb2xFbGVtZW50OjpjYW5UcmlnZ2VySW1wbGljaXRTdWJtaXNzaW9uKTogQWRk ZWQuCisgICAgICAgICogaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SFRNTEZvcm1FbGVtZW50OjpzdWJtaXRJbXBsaWNpdGx5KTogUmVuYW1lZCBwYXJhbWV0ZXJz IGZvciBjbGFyaXR5LCByZWZhY3RvcmVkIGNvZGUKKyAgICAgICAgICAgIHRvIHVzZSBjYW5Ucmln Z2VySW1wbGljaXRTdWJtaXNzaW9uLgorICAgICAgICAqIGh0bWwvSFRNTEZvcm1FbGVtZW50Lmg6 IFJlbmFtZWQgcGFyYW1ldGVyIGZvciBjbGFyaXR5LgorICAgICAgICAqIGh0bWwvSFRNTElucHV0 RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpkZWZhdWx0 RXZlbnRIYW5kbGVyKTogIFVzZWQgY2FuVHJpZ2dlckltcGxpY2l0U3VibWlzc2lvbigpCisgICAg ICAgICAgICBpbnN0ZWFkIG9mIGlzVGV4dEZpZWxkKCkgZm9yIGNsYXJpdHkuCisgICAgICAgICog aHRtbC9IVE1MSW5wdXRFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVt ZW50OjpjYW5UcmlnZ2VySW1wbGljaXRTdWJtaXNzaW9uKTogQWRkZWQuCisgICAgICAgICogaHRt bC9IVE1MSXNJbmRleEVsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJc0luZGV4RWxl bWVudDo6Y2FuVHJpZ2dlckltcGxpY2l0U3VibWlzc2lvbik6IEFkZGVkLgorCiAyMDEwLTA1LTEw ICBEdW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRy b2xFbGVtZW50LmggYi9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5oCmluZGV4 IDViM2E0OTA1MmJmYTg2M2ZlZGYwZjFkM2ZjYmY3OTY4N2EzZmM5YmEuLjY3OTJmNzZlZTI4ODlj YWIxYzRjNGExY2JjZmIxMTcyYWUzY2EyNjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1M Rm9ybUNvbnRyb2xFbGVtZW50LmgKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVs ZW1lbnQuaApAQCAtOTQsNiArOTQsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNG b3JtQ29udHJvbEVsZW1lbnQoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAgICAgdmlydHVhbCBi b29sIGlzUmFkaW9CdXR0b24oKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorICAgIHZpcnR1YWwg Ym9vbCBjYW5UcmlnZ2VySW1wbGljaXRTdWJtaXNzaW9uKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7 IH0KIAogICAgIC8qIE92ZXJyaWRlIGluIGRlcml2ZWQgY2xhc3NlcyB0byBnZXQgdGhlIGVuY29k ZWQgbmFtZT12YWx1ZSBwYWlyIGZvciBzdWJtaXR0aW5nLgogICAgICAqIFJldHVybiB0cnVlIGZv ciBhIHN1Y2Nlc3NmdWwgY29udHJvbCAoc2VlIEhUTUw0LTE3LjEzLjIpLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTEZvcm1F bGVtZW50LmNwcAppbmRleCBkN2Y1ZDk2YTVkOTU1MzhmMmFiMTQxYjdmMmE3Mzg2OGY2OTZkMzM2 Li43YzU4MzY0NGI4NmYwZjFlNzVjZTFlYjljODQzNTE2MzUwY2U5ZTNmIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTEZv cm1FbGVtZW50LmNwcApAQCAtMTc2LDIxICsxNzYsMjAgQEAgTm9kZSogSFRNTEZvcm1FbGVtZW50 OjppdGVtKHVuc2lnbmVkIGluZGV4KQogICAgIHJldHVybiBlbGVtZW50cygpLT5pdGVtKGluZGV4 KTsKIH0KIAotdm9pZCBIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdEltcGxpY2l0bHkoRXZlbnQqIGV2 ZW50LCBib29sIGZyb21UZXh0RmllbGQpCit2b2lkIEhUTUxGb3JtRWxlbWVudDo6c3VibWl0SW1w bGljaXRseShFdmVudCogZXZlbnQsIGJvb2wgZnJvbUltcGxpY2l0U3VibWlzc2lvblRyaWdnZXIp CiB7Ci0gICAgaW50IHRleHRDb250cm9sQ291bnQgPSAwOworICAgIGludCBzdWJtaXNzaW9uVHJp Z2dlckNvdW50ID0gMDsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZm9ybUVsZW1lbnRz LnNpemUoKTsgKytpKSB7Ci0gICAgICAgIGlmIChmb3JtRWxlbWVudHNbaV0tPmhhc0xvY2FsTmFt ZShpbnB1dFRhZykpIHsKLSAgICAgICAgICAgIEhUTUxJbnB1dEVsZW1lbnQqIGVsZW1lbnQgPSBz dGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oZm9ybUVsZW1lbnRzW2ldKTsKLSAgICAgICAg ICAgIGlmIChlbGVtZW50LT5pc1N1Y2Nlc3NmdWxTdWJtaXRCdXR0b24oKSAmJiBlbGVtZW50LT5y ZW5kZXJlcigpKSB7Ci0gICAgICAgICAgICAgICAgZWxlbWVudC0+ZGlzcGF0Y2hTaW11bGF0ZWRD bGljayhldmVudCk7CisgICAgICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQqIGZvcm1FbGVtZW50 ID0gZm9ybUVsZW1lbnRzW2ldOworICAgICAgICBpZiAoZm9ybUVsZW1lbnQtPmlzU3VjY2Vzc2Z1 bFN1Ym1pdEJ1dHRvbigpKSB7CisgICAgICAgICAgICBpZiAoZm9ybUVsZW1lbnQtPnJlbmRlcmVy KCkpIHsKKyAgICAgICAgICAgICAgICBmb3JtRWxlbWVudC0+ZGlzcGF0Y2hTaW11bGF0ZWRDbGlj ayhldmVudCk7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgfSBlbHNlIGlm IChlbGVtZW50LT5pc1RleHRGaWVsZCgpKQotICAgICAgICAgICAgICAgICsrdGV4dENvbnRyb2xD b3VudDsKLSAgICAgICAgfSBlbHNlIGlmIChmb3JtRWxlbWVudHNbaV0tPmhhc0xvY2FsTmFtZShp c2luZGV4VGFnKSkKLSAgICAgICAgICAgICsrdGV4dENvbnRyb2xDb3VudDsKKyAgICAgICAgICAg IH0KKyAgICAgICAgfSBlbHNlIGlmIChmb3JtRWxlbWVudC0+Y2FuVHJpZ2dlckltcGxpY2l0U3Vi bWlzc2lvbigpKQorICAgICAgICAgICAgKytzdWJtaXNzaW9uVHJpZ2dlckNvdW50OwogICAgIH0K LSAgICBpZiAoZnJvbVRleHRGaWVsZCAmJiB0ZXh0Q29udHJvbENvdW50ID09IDEpCisgICAgaWYg KGZyb21JbXBsaWNpdFN1Ym1pc3Npb25UcmlnZ2VyICYmIHN1Ym1pc3Npb25UcmlnZ2VyQ291bnQg PT0gMSkKICAgICAgICAgcHJlcGFyZVN1Ym1pdChldmVudCk7CiB9CiAKZGlmZiAtLWdpdCBhL1dl YkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuaCBiL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1l bnQuaAppbmRleCBhMjE0MmVjOTg0MWM4YjMwNGM3ZTJkY2ExMjE0YmVhZWU0MDYzMjA2Li42OGFl YmRmZmJkNDk2MzIyYzE2ZmUwM2RhMmNmNDAzYWVmZWI4ZWY5IDEwMDY0NAotLS0gYS9XZWJDb3Jl L2h0bWwvSFRNTEZvcm1FbGVtZW50LmgKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVu dC5oCkBAIC05MSw3ICs5MSw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgYm9vbCBpc1VSTEF0 dHJpYnV0ZShBdHRyaWJ1dGUqKSBjb25zdDsKICAgICAKLSAgICB2b2lkIHN1Ym1pdEltcGxpY2l0 bHkoRXZlbnQqLCBib29sIGZyb21UZXh0RmllbGQpOworICAgIHZvaWQgc3VibWl0SW1wbGljaXRs eShFdmVudCosIGJvb2wgZnJvbUltcGxpY2l0U3VibWlzc2lvblRyaWdnZXIpOwogICAgIGJvb2wg Zm9ybVdvdWxkSGF2ZVNlY3VyZVN1Ym1pc3Npb24oY29uc3QgU3RyaW5nJiB1cmwpOwogCiAgICAg U3RyaW5nIG5hbWUoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRF bGVtZW50LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAppbmRleCBlNDk5 Y2FhYjE2YzIzZTAyY2FjMThhOWMzMDBiZDRjM2Y4ZTQzZjgxLi41Y2YxZWJmMDU1YmM5YmE2ZTVj NDQzNjNmNWQ3YTU0YjkxM2NjZGI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0 RWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC0y MzQxLDcgKzIzNDEsNyBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRs ZXIoRXZlbnQqIGV2dCkKIAogICAgICAgICAvLyBGb3JtIG1heSBuZXZlciBoYXZlIGJlZW4gcHJl c2VudCwgb3IgbWF5IGhhdmUgYmVlbiBkZXN0cm95ZWQgYnkgY29kZSByZXNwb25kaW5nIHRvIHRo ZSBjaGFuZ2UgZXZlbnQuCiAgICAgICAgIGlmIChmb3JtRm9yU3VibWlzc2lvbikKLSAgICAgICAg ICAgIGZvcm1Gb3JTdWJtaXNzaW9uLT5zdWJtaXRJbXBsaWNpdGx5KGV2dCwgaXNUZXh0RmllbGQo KSk7CisgICAgICAgICAgICBmb3JtRm9yU3VibWlzc2lvbi0+c3VibWl0SW1wbGljaXRseShldnQs IGNhblRyaWdnZXJJbXBsaWNpdFN1Ym1pc3Npb24oKSk7CiAKICAgICAgICAgZXZ0LT5zZXREZWZh dWx0SGFuZGxlZCgpOwogICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwv SFRNTElucHV0RWxlbWVudC5oIGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaAppbmRl eCBlNzE3NjI4MDZkZmNkMmU5ZDZmMmZjZjNjMjY3NTczN2Q4MmM4ZWRlLi45NmZiNDkyYjcyODky ZGQzNDQwNTlkNzhmMzJlMzhhMWRkNTM0YWM5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRN TElucHV0RWxlbWVudC5oCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKQEAg LTEzMSw2ICsxMzEsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGlzSW5wdXRUeXBlSGlk ZGVuKCkgY29uc3QgeyByZXR1cm4gbV90eXBlID09IEhJRERFTjsgfQogICAgIHZpcnR1YWwgYm9v bCBpc1Bhc3N3b3JkRmllbGQoKSBjb25zdCB7IHJldHVybiBtX3R5cGUgPT0gUEFTU1dPUkQ7IH0K ICAgICB2aXJ0dWFsIGJvb2wgaGFzU3BpbkJ1dHRvbigpIGNvbnN0IHsgcmV0dXJuIG1fdHlwZSA9 PSBOVU1CRVIgfHwgbV90eXBlID09IERBVEUgfHwgbV90eXBlID09IERBVEVUSU1FIHx8IG1fdHlw ZSA9PSBEQVRFVElNRUxPQ0FMIHx8IG1fdHlwZSA9PSBNT05USCB8fCBtX3R5cGUgPT0gVElNRSB8 fCBtX3R5cGUgPT0gV0VFSzsgfQorICAgIHZpcnR1YWwgYm9vbCBjYW5UcmlnZ2VySW1wbGljaXRT dWJtaXNzaW9uKCkgY29uc3QgeyByZXR1cm4gaXNUZXh0RmllbGQoKTsgfQogCiAgICAgYm9vbCBj aGVja2VkKCkgY29uc3QgeyByZXR1cm4gbV9jaGVja2VkOyB9CiAgICAgdm9pZCBzZXRDaGVja2Vk KGJvb2wsIGJvb2wgc2VuZENoYW5nZUV2ZW50ID0gZmFsc2UpOwpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9odG1sL0hUTUxJc0luZGV4RWxlbWVudC5oIGIvV2ViQ29yZS9odG1sL0hUTUxJc0luZGV4RWxl bWVudC5oCmluZGV4IGExNDYyYjgzZGQ5OTA3YWNhOTE2N2JmZGZlNjI4YjFmZmQ2MDU4ZTQuLmFk NTYwNzk3OTI3YTc2NGNkOTI2NzJlMmM5MDkzOWNlNGY4ZTRlZDMgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaHRtbC9IVE1MSXNJbmRleEVsZW1lbnQuaAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTElzSW5k ZXhFbGVtZW50LmgKQEAgLTMzLDYgKzMzLDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBIVE1M VGFnU3RhdHVzIGVuZFRhZ1JlcXVpcmVtZW50KCkgY29uc3QgeyByZXR1cm4gVGFnU3RhdHVzRm9y YmlkZGVuOyB9CiAgICAgdmlydHVhbCBpbnQgdGFnUHJpb3JpdHkoKSBjb25zdCB7IHJldHVybiAw OyB9CisgICAgdmlydHVhbCBib29sIGNhblRyaWdnZXJJbXBsaWNpdFN1Ym1pc3Npb24oKSBjb25z dCB7IHJldHVybiB0cnVlOyB9CiAKICAgICB2aXJ0dWFsIHZvaWQgcGFyc2VNYXBwZWRBdHRyaWJ1 dGUoTWFwcGVkQXR0cmlidXRlICphdHRyKTsKIAo=