38905 2010-05-11 06:59:00 -0700 Include missing header - PageGroup.h 2010-05-14 01:44:57 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 lucas.de.marchi webkit-unassigned barbieri commit-queue oldest_to_newest 223903 0 lucas.de.marchi 2010-05-11 06:59:00 -0700 PageGroup.h is needed in function ewk_init and was missing in ewk_main.cpp. 223904 1 55700 lucas.de.marchi 2010-05-11 07:00:45 -0700 Created attachment 55700 Include missing header This patch fixes this bug. 223907 2 55700 jorlow 2010-05-11 07:09:03 -0700 Comment on attachment 55700 Include missing header r=me 223945 3 55700 lucas.de.marchi 2010-05-11 09:05:10 -0700 Comment on attachment 55700 Include missing header patch is malformed 223947 4 55709 lucas.de.marchi 2010-05-11 09:11:34 -0700 Created attachment 55709 Include missing header Prior patch was malformed. This one fix the problem. 224545 5 55709 commit-queue 2010-05-12 05:36:09 -0700 Comment on attachment 55709 Include missing header Rejecting patch 55709 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Last 500 characters of output: that name could be found Testing 18333 test cases. media/video-loop.html -> timed out Sampling process 64560 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 64560 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 14929 tests run. 349.25s total testing time 14928 test cases (99%) succeeded 1 test case (<1%) timed out 11 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/2172155 224549 6 barbieri 2010-05-12 05:43:43 -0700 Could someone (Eric?) check that, given the patch it is clearly not related to this patch. The patch just touches WebKit/efl/ewk/ewk_main.cpp! 224649 7 55709 eric 2010-05-12 08:47:00 -0700 Comment on attachment 55709 Include missing header This was bug 38912. 225715 8 55709 commit-queue 2010-05-14 01:44:52 -0700 Comment on attachment 55709 Include missing header Clearing flags on attachment: 55709 Committed r59453: <http://trac.webkit.org/changeset/59453> 225716 9 commit-queue 2010-05-14 01:44:57 -0700 All reviewed patches have been landed. Closing bug. 55700 2010-05-11 07:00:45 -0700 2010-05-11 09:11:34 -0700 Include missing header include-missing-header.patch text/plain 914 lucas.de.marchi SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNTkxNDkpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTEgQEAKKzIwMTAtMDUtMTEgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hp QHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtFRl0gSW5jbHVkZSBtaXNzaW5nIGhlYWRlci4KKyAgICAgICAgaHR0cDovL3dl YmtpdC5vcmcvYi8zODkwNQorCisgICAgICAgICogZWZsL2V3ay9ld2tfbWFpbi5jcHA6IEluY2x1 ZGUgUGFnZUdyb3VwLmgKKwogMjAxMC0wNS0wOCAgTGVhbmRybyBQZXJlaXJhICA8bGVhbmRyb0Bw cm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpJbmRl eDogV2ViS2l0L2VmbC9ld2svZXdrX21haW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwv ZXdrL2V3a19tYWluLmNwcAkocmV2aXNpb24gNTkxNDcpCisrKyBXZWJLaXQvZWZsL2V3ay9ld2tf bWFpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI0LDYgKzI0LDcgQEAKICNpbmNsdWRlICJFV2Vi S2l0LmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIlBhZ2VDYWNoZS5oIgorI2lu Y2x1ZGUgIlBhZ2VHcm91cC5oIgogI2luY2x1ZGUgImV3a19wcml2YXRlLmgiCiAjaW5jbHVkZSAi cnVudGltZS9Jbml0aWFsaXplVGhyZWFkaW5nLmgiCiAjaW5jbHVkZSAid3RmL1RocmVhZGluZy5o Igo= 55709 2010-05-11 09:11:34 -0700 2010-05-14 01:44:52 -0700 Include missing header include-missing-header.patch text/plain 914 lucas.de.marchi SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNTkxNTIpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTAtMDUtMTEgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hp QHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtFRl0gSW5jbHVkZSBtaXNzaW5nIGhlYWRlci4KKyAgICAgICAgaHR0cDovL3dl YmtpdC5vcmcvYi8zODkwNQorCisgICAgICAgICogZWZsL2V3ay9ld2tfbWFpbi5jcHA6IEluY2x1 ZGUgUGFnZUdyb3VwLmgKKwogMjAxMC0wNS0wOCAgTGVhbmRybyBQZXJlaXJhICA8bGVhbmRyb0Bw cm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpJbmRl eDogV2ViS2l0L2VmbC9ld2svZXdrX21haW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwv ZXdrL2V3a19tYWluLmNwcAkocmV2aXNpb24gNTkxNTIpCisrKyBXZWJLaXQvZWZsL2V3ay9ld2tf bWFpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI0LDYgKzI0LDcgQEAKICNpbmNsdWRlICJFV2Vi S2l0LmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIlBhZ2VDYWNoZS5oIgorI2lu Y2x1ZGUgIlBhZ2VHcm91cC5oIgogI2luY2x1ZGUgImV3a19wcml2YXRlLmgiCiAjaW5jbHVkZSAi cnVudGltZS9Jbml0aWFsaXplVGhyZWFkaW5nLmgiCiAjaW5jbHVkZSAid3RmL1RocmVhZGluZy5o Igo=