3882 2005-07-06 18:48:35 -0700 GW: WebCore does not compile using bison 2.0 2005-07-07 00:47:47 -0700 1 1 1 Unclassified WebKit New Bugs 412 Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 3250 1 eric eric oldest_to_newest 14076 0 eric 2005-07-06 18:48:36 -0700 #define YYMAXDEPTH 0 causes a later warning when compiling the code (<= comparison with 0 is always true), which breaks the build. Still investigating solutions. 14077 1 eric 2005-07-06 19:00:56 -0700 6:46pm] toby: YYINITDEPTH is what the bison author suggested when i emailed [6:46pm] toby: i.e. #define YYMAXDEPTH YYINITDEPTH I also asked bdash to try removing the line and seeing if it still compiled under bison 1.3. He said it did. I'm not yet sure what #define YYMAXDEPTH 0 was supposed to accomplish. 14092 2 eric 2005-07-07 00:02:46 -0700 My best understanding is that #define YYMAXDEPTH 0 was actually just asking bison to use it's default value (under some previous version of bison). I think we inherited this line all the way from from initial import from khtml. http://www.mico.org/pipermail/mico-devel/2003-June/007336.html aids my suspicion that this is actually just setting the default value. Attached a fix. 14096 3 eric 2005-07-07 00:18:33 -0700 bdash confirmed this further for me: /* YYMAXDEPTH is the maximum size the stacks can grow to (effective only if the built-in stack extension method is used). */ #if YYMAXDEPTH == 0 #undef YYMAXDEPTH #endif #ifndef YYMAXDEPTH #define YYMAXDEPTH 10000 #endif used to be generated by bison 1.3 now the #if YYMAXDEPTH == 0 #undef YYMAXDEPTH #endif is missing from 2.0's generation. Comparing the generated output you see exactly this: -#if YYMAXDEPTH == 0 -#undef YYMAXDEPTH -#endif 14097 4 2844 eric 2005-07-07 00:19:51 -0700 Created attachment 2844 A trivial fix for 2.0 compatibility. 14100 5 2844 mjs 2005-07-07 00:33:17 -0700 Comment on attachment 2844 A trivial fix for 2.0 compatibility. r=me but just to be on the safe side make sure the layout tests pass. 2844 2005-07-07 00:19:51 -0700 2005-07-07 00:33:17 -0700 A trivial fix for 2.0 compatibility. bison2.patch text/plain 980 eric SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9ncmFtbWFyLnkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9yb290L0phdmFTY3JpcHRDb3JlL2tqcy9ncmFtbWFyLnksdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuMjAKZGlmZiAtcCAtdSAtcjEuMjAgSmF2YVNjcmlwdENvcmUva2pzL2dyYW1tYXIueQot LS0gSmF2YVNjcmlwdENvcmUva2pzL2dyYW1tYXIueQkyMSBKdW4gMjAwNSAwODoyNToyMiAtMDAw MAkxLjIwCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvZ3JhbW1hci55CTcgSnVsIDIwMDUgMDY6NDI6 MDkgLTAwMDAKQEAgLTM4LDcgKzM4LDYgQEAKIAogLyogZGVmYXVsdCB2YWx1ZXMgZm9yIGJpc29u ICovCiAjZGVmaW5lIFlZREVCVUcgMAotI2RlZmluZSBZWU1BWERFUFRIIDAKICNpZiAhQVBQTEVf Q0hBTkdFUwogI2RlZmluZSBZWUVSUk9SX1ZFUkJPU0UKICNlbmRpZgpJbmRleDogV2ViQ29yZS9r aHRtbC9jc3MvcGFyc2VyLnkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUv a2h0bWwvY3NzL3BhcnNlci55LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjM5CmRpZmYgLXAgLXUg LXIxLjM5IFdlYkNvcmUva2h0bWwvY3NzL3BhcnNlci55Ci0tLSBXZWJDb3JlL2todG1sL2Nzcy9w YXJzZXIueQkyMiBKdW4gMjAwNSAyMTowNTo1OSAtMDAwMAkxLjM5CisrKyBXZWJDb3JlL2todG1s L2Nzcy9wYXJzZXIueQk3IEp1bCAyMDA1IDA2OjQyOjExIC0wMDAwCkBAIC0xMTQsNyArMTE0LDYg QEAgc3RhdGljIGlubGluZSBpbnQgZ2V0VmFsdWVJRChjb25zdCBjaGFyIAogCiAKICNkZWZpbmUg WVlERUJVRyAwCi0jZGVmaW5lIFlZTUFYREVQVEggMAogI2RlZmluZSBZWVBBUlNFX1BBUkFNIHBh cnNlcgogJX0KIAo=