38803 2010-05-08 10:42:20 -0700 webkit-patch rollout throws exception if bug was never confirmed 2010-05-14 12:19:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth oldest_to_newest 222900 0 eric 2010-05-08 10:42:20 -0700 webkit-patch rollout throws exception if bug is already open 222903 1 55480 eric 2010-05-08 10:45:55 -0700 Created attachment 55480 Patch 222929 2 55480 abarth 2010-05-08 12:31:39 -0700 Comment on attachment 55480 Patch WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py:38 + class MockBrowser(Mock): This makes the mock very loose. It'd rather we just added the methods we need with their proper API. 222979 3 eric 2010-05-08 23:17:08 -0700 Attachment 55480 was posted by a committer and has review+, assigning to Eric Seidel for commit. 223483 4 eric 2010-05-10 13:13:30 -0700 I made it inherit from Mock to match the mocks in mock_tool.py. I'm happy to change it if tighter mocks are the new best-practice? 223489 5 abarth 2010-05-10 13:29:47 -0700 Yeah. We should change the other mocks not to inherit from Mock too. I just haven't gotten around to it. 225942 6 eric 2010-05-14 12:19:28 -0700 Committed r59480: <http://trac.webkit.org/changeset/59480> 55480 2010-05-08 10:45:55 -0700 2010-05-08 12:31:39 -0700 Patch bug-38803-20100508104552.patch text/plain 5129 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyODNhY2U0NzY1ZmRlYzg0ZTFkM2IwMjM5NTRkOWY3YjVhMDIyOWFlLi5hNDJkODE3 NTc1MzJmMTVmOWIyZGE3NjkyOWNlOGRiNGI0OGJjYjUxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTAtMDUtMDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCByb2xsb3V0 IHRocm93cyBleGNlcHRpb24gaWYgYnVnIGlzIGFscmVhZHkgb3BlbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg4MDMKKworICAgICAgICBUaGlzIHdh cyBjYXVzZWQgYnkgc29tZW9uZSBpbmNvcnJlY3RseSB3cmFwcGluZyB0aGUgY29kZS4gOnAKKyAg ICAgICAgSSdtIGdvaW5nIHRvIGhhdmUgdG8gc3RhcnQgZGVtYW5kaW5nIHVuaXQgdGVzdHMgZm9y IHdyYXBwaW5nIGNoYW5nZXMuLi4KKworICAgICAgICBJIGFsc28gZml4ZWQgdGhlIGNvZGUgdG8g YmUgYWJsZSB0byByZW9wZW4gYnVncyB3aGljaCB3ZXJlIG5ldmVyIGNvbmZpcm1lZC4KKyAgICAg ICAgQmVmb3JlIGl0IHJlZ3Jlc3NlZCwgdGhlIGNvZGUgd291bGQganVzdCBsb2cgaW4gdGhhdCBj YXNlLiAgTm93IGl0IGFjdHVhbGx5CisgICAgICAgIHdpbGwgcmVvcGVuIHRoZSBidWcsIGJ1dCB0 aGVyZSBpcyBhIEZJWE1FIGFib3V0IGhvdyB0aGUgbG9naWMgaXMgYSBiaXQgYmFja3dhcmRzLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhLnB5OgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYV91bml0dGVzdC5weToK KyAgICAgICAgIC0gWWF5IHRlc3RpbmchCisKIDIwMTAtMDUtMDggIFJvYmVydCBIb2dhbiAgPHJv YmVydEByb2JlcnRob2dhbi5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21h bm4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQv YnVnemlsbGEucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVn emlsbGEucHkKaW5kZXggNDMxMWEwMDc5OGNjODIxMzZmMmI3NTI3YWNmMjY1YWRhZjA4ODVlNS4u MDc0YTAyMWIwMDg3NmUwMTdmMjQxMzQxYjVmNmE2MjNlMTRlNzhhOCAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhLnB5CisrKyBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS5weQpAQCAtODU2 LDkgKzg1NiwxMyBAQCBjbGFzcyBCdWd6aWxsYShvYmplY3QpOgogICAgICAgICBwb3NzaWJsZV9i dWdfc3RhdHVzZXMgPSBtYXAobGFtYmRhIGl0ZW06IGl0ZW0ubmFtZSwgYnVnX3N0YXR1cy5pdGVt cykKICAgICAgICAgaWYgIlJFT1BFTkVEIiBpbiBwb3NzaWJsZV9idWdfc3RhdHVzZXM6CiAgICAg ICAgICAgICBidWdfc3RhdHVzLnZhbHVlID0gWyJSRU9QRU5FRCJdCisgICAgICAgICMgSWYgdGhl IGJ1ZyB3YXMgbmV2ZXIgY29uZmlybWVkIGl0IHdpbGwgbm90IGhhdmUgYSAiUkVPUEVORUQiCisg ICAgICAgICMgc3RhdGUsIGJ1dCBvbmx5IGFuICJVTkNPTkZJUk1FRCIgc3RhdGUuCisgICAgICAg IGVsaWYgIlVOQ09ORklSTUVEIiBpbiBwb3NzaWJsZV9idWdfc3RhdHVzZXM6CisgICAgICAgICAg ICBidWdfc3RhdHVzLnZhbHVlID0gWyJVTkNPTkZJUk1FRCJdCiAgICAgICAgIGVsc2U6Ci0gICAg ICAgICAgICBsb2coIkRpZCBub3QgcmVvcGVuIGJ1ZyAlcy4gICIgKwotICAgICAgICAgICAgICAg ICJJdCBhcHBlYXJzIHRvIGFscmVhZHkgYmUgb3BlbiB3aXRoIHN0YXR1cyAlcy4iICUgKAotICAg ICAgICAgICAgICAgICAgICAgICAgYnVnX2lkLCBidWdfc3RhdHVzLnZhbHVlKSkKKyAgICAgICAg ICAgICMgRklYTUU6IFRoaXMgbG9naWMgaXMgc2xpZ2h0bHkgYmFja3dhcmRzLiAgV2Ugd29uJ3Qg cHJpbnQgdGhpcworICAgICAgICAgICAgIyBtZXNzYWdlIGlmIHRoZSBidWcgaXMgYWxyZWFkeSBv cGVuIHdpdGggc3RhdGUgIlVOQ09ORklSTUVEIi4KKyAgICAgICAgICAgIGxvZygiRGlkIG5vdCBy ZW9wZW4gYnVnICVzLCBpdCBhcHBlYXJzIHRvIGFscmVhZHkgYmUgb3BlbiB3aXRoIHN0YXR1cyAl cy4iICUgKGJ1Z19pZCwgYnVnX3N0YXR1cy52YWx1ZSkpCiAgICAgICAgIHNlbGYuYnJvd3Nlclsn Y29tbWVudCddID0gY29tbWVudF90ZXh0CiAgICAgICAgIHNlbGYuYnJvd3Nlci5zdWJtaXQoKQpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3pp bGxhX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0 L2J1Z3ppbGxhX3VuaXR0ZXN0LnB5CmluZGV4IDRjNDRjZGYzNWI1NTI3M2JhMTFmMmJlOGNkZGRi NGFiMDk4MTk5NDcuLmQ3NDMyMWYzY2M3NjdhNTVkN2VjOGM3YWI2Zjc3NTI1NmRkYTI5ZDcgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxs YV91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVnemlsbGFfdW5pdHRlc3QucHkKQEAgLTM1LDcgKzM1LDcgQEAgZnJvbSB3ZWJraXRweS50 aGlyZHBhcnR5Lm1vY2sgaW1wb3J0IE1vY2sKIGZyb20gd2Via2l0cHkudGhpcmRwYXJ0eS5CZWF1 dGlmdWxTb3VwIGltcG9ydCBCZWF1dGlmdWxTb3VwCiAKIAotY2xhc3MgTW9ja0Jyb3dzZXIob2Jq ZWN0KToKK2NsYXNzIE1vY2tCcm93c2VyKE1vY2spOgogICAgIGRlZiBvcGVuKHNlbGYsIHVybCk6 CiAgICAgICAgIHBhc3MKIApAQCAtMjU5LDYgKzI1OSwzNSBAQCBaRVpwYm1semFFeHZZV1JYYVhS b1VtVmhjMjl1T25KbFlYTnZibDA3Q2l0OUNpc0tJRUJsYm1RS0lBb2dJMlZ1WkdsbUNnPT0KICAg ICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIkFkZGluZyBbJ2FkYW1AZXhhbXBsZS5jb20nXSB0byB0 aGUgQ0MgbGlzdCBmb3IgYnVnIDQyXG4iCiAgICAgICAgIE91dHB1dENhcHR1cmUoKS5hc3NlcnRf b3V0cHV0cyhzZWxmLCBidWd6aWxsYS5hZGRfY2NfdG9fYnVnLCBbNDIsIFsiYWRhbUBleGFtcGxl LmNvbSJdXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAorICAgIGRlZiBfbW9j a19jb250cm9sX2l0ZW0oc2VsZiwgbmFtZSk6CisgICAgICAgIG1vY2tfaXRlbSA9IE1vY2soKQor ICAgICAgICBtb2NrX2l0ZW0ubmFtZSA9IG5hbWUKKyAgICAgICAgcmV0dXJuIG1vY2tfaXRlbQor CisgICAgZGVmIF9tb2NrX2ZpbmRfY29udHJvbChzZWxmLCBpdGVtX25hbWVzPVtdLCBzZWxlY3Rl ZF9pbmRleD0wKToKKyAgICAgICAgbW9ja19jb250cm9sID0gTW9jaygpCisgICAgICAgIG1vY2tf Y29udHJvbC5pdGVtcyA9IFtzZWxmLl9tb2NrX2NvbnRyb2xfaXRlbShuYW1lKSBmb3IgbmFtZSBp biBpdGVtX25hbWVzXQorICAgICAgICBtb2NrX2NvbnRyb2wudmFsdWUgPSBbaXRlbV9uYW1lc1tz ZWxlY3RlZF9pbmRleF1dIGlmIGl0ZW1fbmFtZXMgZWxzZSBOb25lCisgICAgICAgIHJldHVybiBs YW1iZGEgbmFtZSwgdHlwZTogbW9ja19jb250cm9sCisKKyAgICBkZWYgX2Fzc2VydF9yZW9wZW4o c2VsZiwgaXRlbV9uYW1lcz1Ob25lLCBzZWxlY3RlZF9pbmRleD1Ob25lLCBleHRyYV9zdGRlcnI9 Tm9uZSk6CisgICAgICAgIGJ1Z3ppbGxhID0gQnVnemlsbGEoKQorICAgICAgICBidWd6aWxsYS5i cm93c2VyID0gTW9ja0Jyb3dzZXIoKQorICAgICAgICBidWd6aWxsYS5hdXRoZW50aWNhdGUgPSBs YW1iZGE6IE5vbmUKKworICAgICAgICBtb2NrX2ZpbmRfY29udHJvbCA9IHNlbGYuX21vY2tfZmlu ZF9jb250cm9sKGl0ZW1fbmFtZXMsIHNlbGVjdGVkX2luZGV4KQorICAgICAgICBidWd6aWxsYS5i cm93c2VyLmZpbmRfY29udHJvbCA9IG1vY2tfZmluZF9jb250cm9sCisgICAgICAgIGV4cGVjdGVk X3N0ZGVyciA9ICJSZS1vcGVuaW5nIGJ1ZyA0MlxuWydjb21tZW50J11cbiIKKyAgICAgICAgaWYg ZXh0cmFfc3RkZXJyOgorICAgICAgICAgICAgZXhwZWN0ZWRfc3RkZXJyICs9IGV4dHJhX3N0ZGVy cgorICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgYnVnemlsbGEu cmVvcGVuX2J1ZywgWzQyLCBbImNvbW1lbnQiXV0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9z dGRlcnIpCisKKyAgICBkZWYgdGVzdF9yZW9wZW5fYnVnKHNlbGYpOgorICAgICAgICBzZWxmLl9h c3NlcnRfcmVvcGVuKGl0ZW1fbmFtZXM9WyJSRU9QRU5FRCIsICJSRVNPTFZFRCIsICJDTE9TRUQi XSwgc2VsZWN0ZWRfaW5kZXg9MSkKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3Jlb3BlbihpdGVtX25h bWVzPVsiVU5DT05GSVJNRUQiLCAiUkVTT0xWRUQiLCAiQ0xPU0VEIl0sIHNlbGVjdGVkX2luZGV4 PTEpCisgICAgICAgIGV4dHJhX3N0ZGVyciA9ICJEaWQgbm90IHJlb3BlbiBidWcgNDIsIGl0IGFw cGVhcnMgdG8gYWxyZWFkeSBiZSBvcGVuIHdpdGggc3RhdHVzIFsnTkVXJ10uXG4iCisgICAgICAg IHNlbGYuX2Fzc2VydF9yZW9wZW4oaXRlbV9uYW1lcz1bIk5FVyIsICJSRVNPTFZFRCJdLCBzZWxl Y3RlZF9pbmRleD0wLCBleHRyYV9zdGRlcnI9ZXh0cmFfc3RkZXJyKQorCiAKIGNsYXNzIEJ1Z3pp bGxhUXVlcmllc1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgIF9zYW1wbGVfcmVxdWVzdF9w YWdlID0gIiIiCkBAIC0zNDEsNyArMzcwLDMgQEAgY2xhc3MgQnVnemlsbGFRdWVyaWVzVGVzdCh1 bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3RfbG9hZF9xdWVyeShzZWxmKToKICAgICAg ICAgcXVlcmllcyA9IEJ1Z3ppbGxhUXVlcmllcyhNb2NrKCkpCiAgICAgICAgIHF1ZXJpZXMuX2xv YWRfcXVlcnkoInJlcXVlc3QuY2dpP2FjdGlvbj1xdWV1ZSZ0eXBlPXJldmlldyZncm91cD10eXBl IikKLQotCi1pZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgotICAgIHVuaXR0ZXN0Lm1haW4oKQo=