38800 2010-05-08 06:09:47 -0700 JavaScriptCore build breaks with some combinations of JIT features disabled 2010-05-12 19:26:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cmarcelo webkit-unassigned commit-queue eric oliver oldest_to_newest 222872 0 cmarcelo 2010-05-08 06:09:47 -0700 With JIT enabled, but disabling ENABLE_JIT_OPTIMIZE_CALL or ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS (and consequently ENABLE_JIT_OPTIMIZE_METHOD_CALLS), the build breaks due to references to unknown variables in a UNUSED_PARAM. Patch follows. 222874 1 55474 cmarcelo 2010-05-08 06:11:53 -0700 Created attachment 55474 Remove outdated UNUSED_PARAMs 222980 2 55474 eric 2010-05-08 23:17:44 -0700 Comment on attachment 55474 Remove outdated UNUSED_PARAMs OK. 222991 3 55474 commit-queue 2010-05-08 23:46:19 -0700 Comment on attachment 55474 Remove outdated UNUSED_PARAMs Rejecting patch 55474 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file JavaScriptCore/jit/JITOpcodes.cpp Hunk #1 FAILED at 403. Hunk #2 succeeded at 458 (offset -1486 lines). 1 out of 2 hunks FAILED -- saving rejects to file JavaScriptCore/jit/JITOpcodes.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/2218088 223045 4 55502 cmarcelo 2010-05-09 09:20:28 -0700 Created attachment 55502 Rebased patch Rebased since changes are now spread in two files due to recent split in JITOpcodes.cpp. 223473 5 55502 eric 2010-05-10 13:00:35 -0700 Comment on attachment 55502 Rebased patch OK. 223991 6 55502 commit-queue 2010-05-11 10:16:29 -0700 Comment on attachment 55502 Rebased patch Rejecting patch 55502 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Last 500 characters of output: that name could be found Testing 18328 test cases. media/video-loop.html -> timed out Sampling process 66199 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 66199 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 14927 tests run. 432.81s total testing time 14926 test cases (99%) succeeded 1 test case (<1%) timed out 12 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/2184135 224002 7 55502 cmarcelo 2010-05-11 10:36:37 -0700 Comment on attachment 55502 Rebased patch Requesting cq again as it seems to have been hit by a flaky test. 224024 8 eric 2010-05-11 11:12:10 -0700 This false rejection was caused by bug 38912. 225053 9 55502 commit-queue 2010-05-12 19:26:09 -0700 Comment on attachment 55502 Rebased patch Clearing flags on attachment: 55502 Committed r59334: <http://trac.webkit.org/changeset/59334> 225054 10 commit-queue 2010-05-12 19:26:15 -0700 All reviewed patches have been landed. Closing bug. 55474 2010-05-08 06:11:53 -0700 2010-05-09 09:20:28 -0700 Remove outdated UNUSED_PARAMs 0001-JavaScriptCore-fix-build-when-some-optimizations-are.patch text/plain 2460 cmarcelo RnJvbSA1ZTg0MGM3YjZhMmI2MjFmZTdjMGY5YjBkMmQwZTExYWEyNzIwOTk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gPGNhaW8u b2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KRGF0ZTogU2F0LCA4IE1heSAyMDEwIDEwOjAwOjM2IC0w MzAwClN1YmplY3Q6IFtQQVRDSF0gSmF2YVNjcmlwdENvcmU6IGZpeCBidWlsZCB3aGVuIHNvbWUg b3B0aW1pemF0aW9ucyBhcmUgZGlzYWJsZWQKClJlbW92ZSBvdXRkYXRlZCBVTlVTRURfUEFSQU1z IHdoZW4gdXNpbmcgSklUIGJ1dCB3aXRoCkVOQUJMRV9KSVRfT1BUSU1JWkVfQ0FMTCBhbmQgRU5B QkxFX0pJVF9PUFRJTUlaRV9QUk9QRVJUWV9BQ0NFU1MKZGlzYWJsZWQuCi0tLQogSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogSmF2YVNjcmlwdENv cmUvaml0L0pJVE9wY29kZXMuY3BwIHwgICAgNiAtLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTEg aW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggODA0MTdjNC4uNjIz Y2I4YiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA1LTA4ICBDYWlvIE1hcmNl bG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSmF2YVNjcmlwdENv cmU6IGZpeCBidWlsZCB3aGVuIHNvbWUgb3B0aW1pemF0aW9ucyBhcmUgZGlzYWJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4ODAwCisKKyAgICAg ICAgKiBqaXQvSklUT3Bjb2Rlcy5jcHA6IHJlbW92ZSBvdXRkYXRlZCBVTlVTRURfUEFSQU1zIHdo ZW4gdXNpbmcgSklUCisgICAgICAgIGJ1dCB3aXRoIEVOQUJMRV9KSVRfT1BUSU1JWkVfQ0FMTCBh bmQKKyAgICAgICAgRU5BQkxFX0pJVF9PUFRJTUlaRV9QUk9QRVJUWV9BQ0NFU1MgZGlzYWJsZWQu CisKIDIwMTAtMDUtMDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIGp1c3QgcmV2ZXJ0aW5nIGNvbW1pdC4KZGlmZiAtLWdpdCBhL0phdmFTY3Jp cHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcCBiL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVz LmNwcAppbmRleCBhODI0ODAwLi40YzljODZkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9q aXQvSklUT3Bjb2Rlcy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMuY3Bw CkBAIC00MDMsMTMgKzQwMyw5IEBAIHZvaWQgSklUOjpwcml2YXRlQ29tcGlsZUNUSU1hY2hpbmVU cmFtcG9saW5lcyhSZWZQdHI8RXhlY3V0YWJsZVBvb2w+KiBleGVjdXRhYmxlCiAgICAgdHJhbXBv bGluZXMtPmN0aU5hdGl2ZUNhbGxUaHVuayA9IGFkb3B0UmVmKG5ldyBOYXRpdmVFeGVjdXRhYmxl KEpJVENvZGUoSklUQ29kZTo6SG9zdEZ1bmN0aW9uKHRyYW1wb2xpbmVBdChmaW5hbENvZGUsIG5h dGl2ZUNhbGxUaHVuaykpKSkpOwogI2lmIEVOQUJMRShKSVRfT1BUSU1JWkVfUFJPUEVSVFlfQUND RVNTKQogICAgIHRyYW1wb2xpbmVzLT5jdGlTdHJpbmdMZW5ndGhUcmFtcG9saW5lID0gdHJhbXBv bGluZUF0KGZpbmFsQ29kZSwgc3RyaW5nTGVuZ3RoQmVnaW4pOwotI2Vsc2UKLSAgICBVTlVTRURf UEFSQU0oY3RpU3RyaW5nTGVuZ3RoVHJhbXBvbGluZSk7CiAjZW5kaWYKICNpZiBFTkFCTEUoSklU X09QVElNSVpFX0NBTEwpCiAgICAgdHJhbXBvbGluZXMtPmN0aVZpcnR1YWxDYWxsTGluayA9IHRy YW1wb2xpbmVBdChmaW5hbENvZGUsIHZpcnR1YWxDYWxsTGlua0JlZ2luKTsKLSNlbHNlCi0gICAg VU5VU0VEX1BBUkFNKGN0aVZpcnR1YWxDYWxsTGluayk7CiAjZW5kaWYKICNpZiBFTkFCTEUoSklU X09QVElNSVpFX01PRCkKICAgICB0cmFtcG9saW5lcy0+Y3RpU29mdE1vZHVsbyA9IHRyYW1wb2xp bmVBdChmaW5hbENvZGUsIHNvZnRNb2RCZWdpbik7CkBAIC0xOTQ4LDggKzE5NDQsNiBAQCB2b2lk IEpJVDo6cHJpdmF0ZUNvbXBpbGVDVElNYWNoaW5lVHJhbXBvbGluZXMoUmVmUHRyPEV4ZWN1dGFi bGVQb29sPiogZXhlY3V0YWJsZQogI2VuZGlmCiAjaWYgRU5BQkxFKEpJVF9PUFRJTUlaRV9QUk9Q RVJUWV9BQ0NFU1MpCiAgICAgdHJhbXBvbGluZXMtPmN0aVN0cmluZ0xlbmd0aFRyYW1wb2xpbmUg PSB0cmFtcG9saW5lQXQoZmluYWxDb2RlLCBzdHJpbmdMZW5ndGhCZWdpbik7Ci0jZWxzZQotICAg IFVOVVNFRF9QQVJBTShjdGlTdHJpbmdMZW5ndGhUcmFtcG9saW5lKTsKICNlbmRpZgogfQogCi0t IAoxLjcuMQoK 55502 2010-05-09 09:20:28 -0700 2010-05-12 19:26:09 -0700 Rebased patch 0001-JavaScriptCore-fix-build-when-some-optimizations-are.patch text/plain 2776 cmarcelo RnJvbSA3ZmY1M2YzMDRlMDcxMTk5MTAzZTJiNGZmM2VjZWYxOTNjYzNlMGY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gPGNhaW8u b2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KRGF0ZTogU2F0LCA4IE1heSAyMDEwIDEwOjAwOjM2IC0w MzAwClN1YmplY3Q6IFtQQVRDSF0gSmF2YVNjcmlwdENvcmU6IGZpeCBidWlsZCB3aGVuIHNvbWUg b3B0aW1pemF0aW9ucyBhcmUgZGlzYWJsZWQKClJlbW92ZSBvdXRkYXRlZCBVTlVTRURfUEFSQU1z IHdoZW4gdXNpbmcgSklUIGJ1dCB3aXRoCkVOQUJMRV9KSVRfT1BUSU1JWkVfQ0FMTCBhbmQgRU5B QkxFX0pJVF9PUFRJTUlaRV9QUk9QRVJUWV9BQ0NFU1MKZGlzYWJsZWQuCi0tLQogSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBKYXZh U2NyaXB0Q29yZS9qaXQvSklUT3Bjb2Rlcy5jcHAgICAgICB8ICAgIDIgLS0KIEphdmFTY3JpcHRD b3JlL2ppdC9KSVRPcGNvZGVzMzJfNjQuY3BwIHwgICAgNCAtLS0tCiAzIGZpbGVzIGNoYW5nZWQs IDE0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGFjZGU0ZTMu LmZlNzIzYTYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNS0wOSAgQ2FpbyBN YXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEphdmFTY3Jp cHRDb3JlOiBmaXggYnVpbGQgd2hlbiBzb21lIG9wdGltaXphdGlvbnMgYXJlIGRpc2FibGVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODgwMAorCisg ICAgICAgIFJlbW92ZSBvdXRkYXRlZCBVTlVTRURfUEFSQU1zIHdoZW4gdXNpbmcgSklUIGJ1dCB3 aXRoCisgICAgICAgIEVOQUJMRV9KSVRfT1BUSU1JWkVfQ0FMTCBhbmQgRU5BQkxFX0pJVF9PUFRJ TUlaRV9QUk9QRVJUWV9BQ0NFU1MKKyAgICAgICAgZGlzYWJsZWQuCisKKyAgICAgICAgKiBqaXQv SklUT3Bjb2Rlcy5jcHA6CisgICAgICAgICogaml0L0pJVE9wY29kZXMzMl82NC5jcHA6CisKIDIw MTAtMDUtMDkgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRPcGNvZGVzLmNwcCBiL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAppbmRl eCAyMWU4YzZjLi44N2NkYjYxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bj b2Rlcy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMuY3BwCkBAIC00NjIs OCArNDYyLDYgQEAgdm9pZCBKSVQ6OnByaXZhdGVDb21waWxlQ1RJTWFjaGluZVRyYW1wb2xpbmVz KFJlZlB0cjxFeGVjdXRhYmxlUG9vbD4qIGV4ZWN1dGFibGUKICNlbmRpZgogI2lmIEVOQUJMRShK SVRfT1BUSU1JWkVfUFJPUEVSVFlfQUNDRVNTKQogICAgIHRyYW1wb2xpbmVzLT5jdGlTdHJpbmdM ZW5ndGhUcmFtcG9saW5lID0gdHJhbXBvbGluZUF0KGZpbmFsQ29kZSwgc3RyaW5nTGVuZ3RoQmVn aW4pOwotI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0oY3RpU3RyaW5nTGVuZ3RoVHJhbXBvbGluZSk7 CiAjZW5kaWYKIH0KIApkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMz Ml82NC5jcHAgYi9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2RlczMyXzY0LmNwcAppbmRleCAz NDNhMWM0Li42MGNhNWE4IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2Rl czMyXzY0LmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2RlczMyXzY0LmNwcApA QCAtNDAxLDEzICs0MDEsOSBAQCB2b2lkIEpJVDo6cHJpdmF0ZUNvbXBpbGVDVElNYWNoaW5lVHJh bXBvbGluZXMoUmVmUHRyPEV4ZWN1dGFibGVQb29sPiogZXhlY3V0YWJsZQogICAgIHRyYW1wb2xp bmVzLT5jdGlOYXRpdmVDYWxsVGh1bmsgPSBhZG9wdFJlZihuZXcgTmF0aXZlRXhlY3V0YWJsZShK SVRDb2RlKEpJVENvZGU6Okhvc3RGdW5jdGlvbih0cmFtcG9saW5lQXQoZmluYWxDb2RlLCBuYXRp dmVDYWxsVGh1bmspKSkpKTsKICNpZiBFTkFCTEUoSklUX09QVElNSVpFX1BST1BFUlRZX0FDQ0VT UykKICAgICB0cmFtcG9saW5lcy0+Y3RpU3RyaW5nTGVuZ3RoVHJhbXBvbGluZSA9IHRyYW1wb2xp bmVBdChmaW5hbENvZGUsIHN0cmluZ0xlbmd0aEJlZ2luKTsKLSNlbHNlCi0gICAgVU5VU0VEX1BB UkFNKGN0aVN0cmluZ0xlbmd0aFRyYW1wb2xpbmUpOwogI2VuZGlmCiAjaWYgRU5BQkxFKEpJVF9P UFRJTUlaRV9DQUxMKQogICAgIHRyYW1wb2xpbmVzLT5jdGlWaXJ0dWFsQ2FsbExpbmsgPSB0cmFt cG9saW5lQXQoZmluYWxDb2RlLCB2aXJ0dWFsQ2FsbExpbmtCZWdpbik7Ci0jZWxzZQotICAgIFVO VVNFRF9QQVJBTShjdGlWaXJ0dWFsQ2FsbExpbmspOwogI2VuZGlmCiAjaWYgRU5BQkxFKEpJVF9P UFRJTUlaRV9NT0QpCiAgICAgdHJhbXBvbGluZXMtPmN0aVNvZnRNb2R1bG8gPSB0cmFtcG9saW5l QXQoZmluYWxDb2RlLCBzb2Z0TW9kQmVnaW4pOwotLSAKMS43LjEKCg==