38655 2010-05-06 10:19:05 -0700 [Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing 2010-05-14 01:49:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All CLOSED FIXED Qt P2 Normal --- 38654 1 jesus kenneth benjamin commit-queue eric hausmann kenneth kling tonikitoo oldest_to_newest 221777 0 jesus 2010-05-06 10:19:05 -0700 Using Qt 4.7 HEAD 32ecf8e8ad326ea13ec9a430c99ce540e8b4efac and WebKit r58755, this test failed on Linux and crashed on Mac OS X (Snow Leopard). With Qt 4.6 and the same WebKit revision and does not fail on Maemo 5. 223146 1 tonikitoo 2010-05-09 20:41:26 -0700 reproducible on both release and debud builds. I can have a look 223732 2 tonikitoo 2010-05-10 21:48:50 -0700 this autotest has a failing history: * r56529 - NO BUG - broke it * r57323 - bug 37317 - fixed it * r58497 - bug 38179 - broke it again 223999 3 kenneth 2010-05-11 10:34:51 -0700 The bug is causes by the fact that a resize of an empty page causes a layout, thus deleting the qgraphicswebview before setHtml is called, which then deletes it again, causing a double free. Patch coming. 224008 4 55719 kenneth 2010-05-11 10:42:39 -0700 Created attachment 55719 Patch 224058 5 55730 kenneth 2010-05-11 11:52:19 -0700 Created attachment 55730 Patch 2 (fixes typo) 224061 6 55730 laszlo.gombos 2010-05-11 11:53:16 -0700 Comment on attachment 55730 Patch 2 (fixes typo) Looks good to me, r+. 225061 7 55730 commit-queue 2010-05-12 19:49:27 -0700 Comment on attachment 55730 Patch 2 (fixes typo) Rejecting patch 55730 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['../WebKit/WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 55730, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: id=55730&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=38655&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 55730 from bug 38655. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebKit/qt/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebKit/qt/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 225071 8 eric 2010-05-12 20:10:24 -0700 This false rejection is caused by bug 38998. This won't work in the commit-queue until that's fixed, sorry. :( 225419 9 tonikitoo 2010-05-13 11:59:39 -0700 Committed r59378: <http://trac.webkit.org/changeset/59378> 225700 10 hausmann 2010-05-14 01:10:26 -0700 Revision r59378 cherry-picked into qtwebkit-2.0 with commit 3e4eb12fb842fa1709551e05c52fc695014a21fa 55719 2010-05-11 10:42:39 -0700 2010-05-11 11:52:19 -0700 Patch 0001-Qt-REGRESSION-r58497-tst_QGraphicsWebView-crashOnVie.patch text/plain 3331 kenneth RnJvbSAwZmY4NTk1MDY5YmUwNzIzOTE2YjI3NTYxZDljN2I5ZjA1Mjg3YTJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3 ZWJraXQub3JnPgpEYXRlOiBUdWUsIDExIE1heSAyMDEwIDE0OjQxOjIxIC0wMzAwClN1YmplY3Q6 IFtQQVRDSF0gW1F0XSBSRUdSRVNTSU9OKHI1ODQ5NykgdHN0X1FHcmFwaGljc1dlYlZpZXc6OmNy YXNoT25WaWV3bGVzc1dlYlBhZ2VzKCkgaXMgZmFpbGluZwogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM4NjU1CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkZp eCBkb3VibGUgZnJlZSBteSBtb3ZpbmcgdGhlIGNvbm5lY3QgdGlsbCBhZnRlciB0aGUgcmVzaXpl LgoKVGhlIGJ1ZyBpcyBjYXVzZXMgYnkgdGhlIGZhY3QgdGhhdCBhIHJlc2l6ZSBvZiBhbiBlbXB0 eSBwYWdlIGNhdXNlcyBhCmxheW91dCwgdGh1cyBkZWxldGluZyB0aGUgcWdyYXBoaWNzd2Vidmll dyBiZWZvcmUgc2V0SHRtbCBpcyBjYWxsZWQsCndoaWNoIHRoZW4gZGVsZXRlcyBpdCBhZ2Fpbiwg Y2F1c2luZyBhIGRvdWJsZSBmcmVlLgoKKiB0ZXN0cy9xZ3JhcGhpY3N3ZWJ2aWV3L3RzdF9xZ3Jh cGhpY3N3ZWJ2aWV3LmNwcDoKKHRzdF9RR3JhcGhpY3NXZWJWaWV3OjpjcmFzaE9uVmlld2xlc3NX ZWJQYWdlcyk6Ci0tLQogV2ViS2l0L3F0L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIC4uLi9xZ3JhcGhpY3N3ZWJ2aWV3L3Rz dF9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcCAgICAgIHwgICAgOCArKysrKystLQogMiBmaWxlcyBjaGFu Z2VkLCAyMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktp dC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDU4YjhmMmUuLjhhZjA4 NjEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTA1LTExICBLZW5uZXRoIFJvaGRlIENocmlzdGlh bnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbUXRdIFJFR1JFU1NJT04ocjU4NDk3KSB0c3RfUUdyYXBoaWNz V2ViVmlldzo6Y3Jhc2hPblZpZXdsZXNzV2ViUGFnZXMoKSBpcyBmYWlsaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY1NQorCisgICAgICAgIEZp eCBkb3VibGUgZnJlZSBteSBtb3ZpbmcgdGhlIGNvbm5lY3QgdGlsbCBhZnRlciB0aGUgcmVzaXpl LgorCisgICAgICAgIFRoZSBidWcgaXMgY2F1c2VzIGJ5IHRoZSBmYWN0IHRoYXQgYSByZXNpemUg b2YgYW4gZW1wdHkgcGFnZSBjYXVzZXMgYQorICAgICAgICBsYXlvdXQsIHRodXMgZGVsZXRpbmcg dGhlIHFncmFwaGljc3dlYnZpZXcgYmVmb3JlIHNldEh0bWwgaXMgY2FsbGVkLAorICAgICAgICB3 aGljaCB0aGVuIGRlbGV0ZXMgaXQgYWdhaW4sIGNhdXNpbmcgYSBkb3VibGUgZnJlZS4KKworICAg ICAgICAqIHRlc3RzL3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dlYnZpZXcuY3BwOgor ICAgICAgICAodHN0X1FHcmFwaGljc1dlYlZpZXc6OmNyYXNoT25WaWV3bGVzc1dlYlBhZ2VzKToK KwogMjAxMC0wNS0wNyAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQg YS9XZWJLaXQvcXQvdGVzdHMvcWdyYXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmlldy5j cHAgYi9XZWJLaXQvcXQvdGVzdHMvcWdyYXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmll dy5jcHAKaW5kZXggMTRmNTgyMC4uZWJlODQ3ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3Rz L3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9x dC90ZXN0cy9xZ3JhcGhpY3N3ZWJ2aWV3L3RzdF9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcApAQCAtODQs MTYgKzg0LDE5IEBAIHZvaWQgdHN0X1FHcmFwaGljc1dlYlZpZXc6OmNyYXNoT25WaWV3bGVzc1dl YlBhZ2VzKCkKICAgICBXZWJQYWdlKiBwYWdlID0gbmV3IFdlYlBhZ2U7CiAgICAgd2ViVmlldy0+ c2V0UGFnZShwYWdlKTsKICAgICBwYWdlLT53ZWJWaWV3ID0gd2ViVmlldzsKLSAgICBjb25uZWN0 KHBhZ2UtPm1haW5GcmFtZSgpLCBTSUdOQUwoaW5pdGlhbExheW91dENvbXBsZXRlZCgpKSwgcGFn ZSwgU0xPVChhYm9ydGluZygpKSk7Ci0KICAgICBzY2VuZS5hZGRJdGVtKHdlYlZpZXcpOwogCiAg ICAgdmlldy5zZXRTaXplUG9saWN5KFFTaXplUG9saWN5OjpFeHBhbmRpbmcsIFFTaXplUG9saWN5 OjpFeHBhbmRpbmcpOwogICAgIHZpZXcucmVzaXplKDYwMCwgNDgwKTsKICAgICB3ZWJWaWV3LT5y ZXNpemUodmlldy5nZW9tZXRyeSgpLnNpemUoKSk7CisKICAgICBRQ29yZUFwcGxpY2F0aW9uOjpw cm9jZXNzRXZlbnRzKCk7CiAgICAgdmlldy5zaG93KCk7CiAKKyAgICAvLyBSZXNpemluZyB0aGUg cGFnZSB3aWxsIHJlc2l6ZSBhbmQgbGF5b3V0IHRoZSBlbXB0eSAiYWJvdXQ6YmxhbmsiCisgICAg Ly8gcGFnZSwgc28gd2UgZmlyc3QgY29ubmVjdCB0aGUgc2lnbmFsIGFmdGVyd2FyZC4KKyAgICBj b25uZWN0KHBhZ2UtPm1haW5GcmFtZSgpLCBTSUdOQUwoaW5pdGlhbExheW91dENvbXBsZXRlZCgp KSwgcGFnZSwgU0xPVChhYm9ydGluZygpKSk7CisKICAgICBwYWdlLT5tYWluRnJhbWUoKS0+c2V0 SHRtbChRU3RyaW5nKCJkYXRhOnRleHQvaHRtbCwiCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICI8ZnJhbWVzZXQgY29scz1cIjI1JSw3NSVcIj4iCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGZyYW1lIHNyYz1cImRh dGE6dGV4dC9odG1sLGZvbyBcIj4iCkBAIC0xMDEsNiArMTA0LDcgQEAgdm9pZCB0c3RfUUdyYXBo aWNzV2ViVmlldzo6Y3Jhc2hPblZpZXdsZXNzV2ViUGFnZXMoKQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiPC9mcmFtZXNldD4iKSk7CiAKICAgICBRVkVSSUZZ KHdhaXRGb3JTaWduYWwocGFnZSwgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSkpKTsKKyAgICBk ZWxldGUgcGFnZTsKIH0KIAogdm9pZCB0c3RfUUdyYXBoaWNzV2ViVmlldzo6bWljcm9Gb2N1c0Nv b3JkaW5hdGVzKCkKLS0gCjEuNy4wLjMKCg== 55730 2010-05-11 11:52:19 -0700 2010-05-13 11:35:15 -0700 Patch 2 (fixes typo) 0001-Qt-REGRESSION-r58497-tst_QGraphicsWebView-crashOnVie.patch text/plain 3331 kenneth RnJvbSBhZjQwNWVjMzg5YzE3NjA3MTAwNzE1Mjc5NDgxN2U2NDg1NWJmNDc5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3 ZWJraXQub3JnPgpEYXRlOiBUdWUsIDExIE1heSAyMDEwIDE0OjQxOjIxIC0wMzAwClN1YmplY3Q6 IFtQQVRDSF0gW1F0XSBSRUdSRVNTSU9OKHI1ODQ5NykgdHN0X1FHcmFwaGljc1dlYlZpZXc6OmNy YXNoT25WaWV3bGVzc1dlYlBhZ2VzKCkgaXMgZmFpbGluZwogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM4NjU1CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkZp eCBkb3VibGUgZnJlZSBieSBtb3ZpbmcgdGhlIGNvbm5lY3QgdGlsbCBhZnRlciB0aGUgcmVzaXpl LgoKVGhlIGJ1ZyBpcyBjYXVzZXMgYnkgdGhlIGZhY3QgdGhhdCBhIHJlc2l6ZSBvZiBhbiBlbXB0 eSBwYWdlIGNhdXNlcyBhCmxheW91dCwgdGh1cyBkZWxldGluZyB0aGUgcWdyYXBoaWNzd2Vidmll dyBiZWZvcmUgc2V0SHRtbCBpcyBjYWxsZWQsCndoaWNoIHRoZW4gZGVsZXRlcyBpdCBhZ2Fpbiwg Y2F1c2luZyBhIGRvdWJsZSBmcmVlLgoKKiB0ZXN0cy9xZ3JhcGhpY3N3ZWJ2aWV3L3RzdF9xZ3Jh cGhpY3N3ZWJ2aWV3LmNwcDoKKHRzdF9RR3JhcGhpY3NXZWJWaWV3OjpjcmFzaE9uVmlld2xlc3NX ZWJQYWdlcyk6Ci0tLQogV2ViS2l0L3F0L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIC4uLi9xZ3JhcGhpY3N3ZWJ2aWV3L3Rz dF9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcCAgICAgIHwgICAgOCArKysrKystLQogMiBmaWxlcyBjaGFu Z2VkLCAyMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktp dC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDU4YjhmMmUuLjA5MTM3 MjggMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTA1LTExICBLZW5uZXRoIFJvaGRlIENocmlzdGlh bnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbUXRdIFJFR1JFU1NJT04ocjU4NDk3KSB0c3RfUUdyYXBoaWNz V2ViVmlldzo6Y3Jhc2hPblZpZXdsZXNzV2ViUGFnZXMoKSBpcyBmYWlsaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY1NQorCisgICAgICAgIEZp eCBkb3VibGUgZnJlZSBieSBtb3ZpbmcgdGhlIGNvbm5lY3QgdGlsbCBhZnRlciB0aGUgcmVzaXpl LgorCisgICAgICAgIFRoZSBidWcgaXMgY2F1c2VzIGJ5IHRoZSBmYWN0IHRoYXQgYSByZXNpemUg b2YgYW4gZW1wdHkgcGFnZSBjYXVzZXMgYQorICAgICAgICBsYXlvdXQsIHRodXMgZGVsZXRpbmcg dGhlIHFncmFwaGljc3dlYnZpZXcgYmVmb3JlIHNldEh0bWwgaXMgY2FsbGVkLAorICAgICAgICB3 aGljaCB0aGVuIGRlbGV0ZXMgaXQgYWdhaW4sIGNhdXNpbmcgYSBkb3VibGUgZnJlZS4KKworICAg ICAgICAqIHRlc3RzL3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dlYnZpZXcuY3BwOgor ICAgICAgICAodHN0X1FHcmFwaGljc1dlYlZpZXc6OmNyYXNoT25WaWV3bGVzc1dlYlBhZ2VzKToK KwogMjAxMC0wNS0wNyAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQg YS9XZWJLaXQvcXQvdGVzdHMvcWdyYXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmlldy5j cHAgYi9XZWJLaXQvcXQvdGVzdHMvcWdyYXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmll dy5jcHAKaW5kZXggMTRmNTgyMC4uZWJlODQ3ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3Rz L3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9x dC90ZXN0cy9xZ3JhcGhpY3N3ZWJ2aWV3L3RzdF9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcApAQCAtODQs MTYgKzg0LDE5IEBAIHZvaWQgdHN0X1FHcmFwaGljc1dlYlZpZXc6OmNyYXNoT25WaWV3bGVzc1dl YlBhZ2VzKCkKICAgICBXZWJQYWdlKiBwYWdlID0gbmV3IFdlYlBhZ2U7CiAgICAgd2ViVmlldy0+ c2V0UGFnZShwYWdlKTsKICAgICBwYWdlLT53ZWJWaWV3ID0gd2ViVmlldzsKLSAgICBjb25uZWN0 KHBhZ2UtPm1haW5GcmFtZSgpLCBTSUdOQUwoaW5pdGlhbExheW91dENvbXBsZXRlZCgpKSwgcGFn ZSwgU0xPVChhYm9ydGluZygpKSk7Ci0KICAgICBzY2VuZS5hZGRJdGVtKHdlYlZpZXcpOwogCiAg ICAgdmlldy5zZXRTaXplUG9saWN5KFFTaXplUG9saWN5OjpFeHBhbmRpbmcsIFFTaXplUG9saWN5 OjpFeHBhbmRpbmcpOwogICAgIHZpZXcucmVzaXplKDYwMCwgNDgwKTsKICAgICB3ZWJWaWV3LT5y ZXNpemUodmlldy5nZW9tZXRyeSgpLnNpemUoKSk7CisKICAgICBRQ29yZUFwcGxpY2F0aW9uOjpw cm9jZXNzRXZlbnRzKCk7CiAgICAgdmlldy5zaG93KCk7CiAKKyAgICAvLyBSZXNpemluZyB0aGUg cGFnZSB3aWxsIHJlc2l6ZSBhbmQgbGF5b3V0IHRoZSBlbXB0eSAiYWJvdXQ6YmxhbmsiCisgICAg Ly8gcGFnZSwgc28gd2UgZmlyc3QgY29ubmVjdCB0aGUgc2lnbmFsIGFmdGVyd2FyZC4KKyAgICBj b25uZWN0KHBhZ2UtPm1haW5GcmFtZSgpLCBTSUdOQUwoaW5pdGlhbExheW91dENvbXBsZXRlZCgp KSwgcGFnZSwgU0xPVChhYm9ydGluZygpKSk7CisKICAgICBwYWdlLT5tYWluRnJhbWUoKS0+c2V0 SHRtbChRU3RyaW5nKCJkYXRhOnRleHQvaHRtbCwiCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICI8ZnJhbWVzZXQgY29scz1cIjI1JSw3NSVcIj4iCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGZyYW1lIHNyYz1cImRh dGE6dGV4dC9odG1sLGZvbyBcIj4iCkBAIC0xMDEsNiArMTA0LDcgQEAgdm9pZCB0c3RfUUdyYXBo aWNzV2ViVmlldzo6Y3Jhc2hPblZpZXdsZXNzV2ViUGFnZXMoKQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiPC9mcmFtZXNldD4iKSk7CiAKICAgICBRVkVSSUZZ KHdhaXRGb3JTaWduYWwocGFnZSwgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSkpKTsKKyAgICBk ZWxldGUgcGFnZTsKIH0KIAogdm9pZCB0c3RfUUdyYXBoaWNzV2ViVmlldzo6bWljcm9Gb2N1c0Nv b3JkaW5hdGVzKCkKLS0gCjEuNy4wLjMKCg==