38617 2010-05-05 17:51:28 -0700 Scientific Notation for z-index prints out different values for Mac and Windows 2010-05-05 22:34:14 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bweinstein s3lance commit-queue oldest_to_newest 221391 0 bweinstein 2010-05-05 17:51:28 -0700 fast/dom/clone-node-z-index.html fails on Windows - due to differences in how Mac and WIndows print Scientific Notation. http://build.webkit.org/results/Windows%20Debug%20(Tests)/r58840%20(13147)/fast/dom/clone-node-z-index-pretty-diff.html On Mac: zIndex = "2.0002e+07" On Windows: zIndex = "2.0002e+007" There is one extra 0 in the scientific notation. 221404 1 s3lance 2010-05-05 18:08:51 -0700 There are several places in existing code that uses "%.6lg" to format numbers in css string. For example, WebCore/css/CSSPrimitiveValue.cpp: CSSPrimitiveValue::cssText() JavascriptCore/wtf/text/WTFString.cpp: WTFString::format(double) 221416 2 s3lance 2010-05-05 18:22:11 -0700 There was a general fix to this problem, the patch does manual number formatting. 1. It avoids cross-platform discrepancies 2. Avoid large integers being formatted as scientific notation. http://trac.webkit.org/changeset/49585 But it got rolled out because it broke a website Please see: http://trac.webkit.org/changeset/52071 https://bugs.webkit.org/show_bug.cgi?id=32078 221426 3 s3lance 2010-05-05 18:34:03 -0700 Also see: https://bugs.webkit.org/show_bug.cgi?id=18994 It shows the number formatting could be different on the same platform with different locale. Now, I'm not certain if that could possibly affect scientific notation as well, but from this point of view, we shouldn't be printing the formatted value in the particular test case because the purpose of the test case is to simply validate that the z-index won't be lost. 221442 4 55195 s3lance 2010-05-05 19:34:41 -0700 Created attachment 55195 Patch Alternative patch to the offending layout test (so that we don't risk breaking layout tests on every other platform) 221509 5 55195 commit-queue 2010-05-05 22:34:09 -0700 Comment on attachment 55195 Patch Clearing flags on attachment: 55195 Committed r58861: <http://trac.webkit.org/changeset/58861> 221510 6 commit-queue 2010-05-05 22:34:14 -0700 All reviewed patches have been landed. Closing bug. 55195 2010-05-05 19:34:41 -0700 2010-05-05 22:34:09 -0700 Patch z-index-layout-test.patch text/plain 2237 s3lance SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4ODU1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMDUgIFN0ZXZlbiBMYWkgIDxzdGV2 ZW5fbGFpQGFzaWEuYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlbW92ZSBwbGF0Zm9ybSBzcGVjaWZpYyB0ZXN0IHJlc3VsdAorICAg ICAgICBEb24ndCBwcmludCB0aGUgZm9ybWF0dGVkIHN0cmluZyBvZiB0aGUgei1pbmRleCBpbiB0 aGUgdGVzdCBjYXNlCisgICAgICAgIHNpbmNlIHRoZXJlJ3MgYSByaXNrIHRoYXQgdGhlIG91dHB1 dCBvbiBkaWZmZXJlbnQgYyBzdGRsaWIgaW1wbGVtZW50YXRpb25zL3BsYXRmb3Jtcy9sb2NhbGUg Y291bGQgYmUgZGlmZmVyZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zODYxNy4KKworICAgICAgICAqIGZhc3QvZG9tL2Nsb25lLW5vZGUtei1pbmRl eC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20vY2xvbmUtbm9kZS16LWluZGV4Lmh0 bWw6CisgICAgICAgICogcGxhdGZvcm0vd2luL2Zhc3QvZG9tL2Nsb25lLW5vZGUtei1pbmRleC1l eHBlY3RlZC50eHQ6IFJlbW92ZWQuCisKIDIwMTAtMDUtMDUgIERpcmsgUHJhbmtlICA8ZHByYW5r ZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZXhwZWN0YXRpb25zIGNoYW5n ZS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2Nsb25lLW5vZGUtei1pbmRleC1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vY2xvbmUtbm9kZS16LWlu ZGV4LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNTg3ODEpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9jbG9uZS1ub2RlLXotaW5kZXgtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQg KzEsMyBAQAogVGVzdCBmb3IgYnVnIDM3OTAwOiBjbG9uZU5vZGUoKSBkb2VzIG5vdCBwcmVzZXJ2 ZSB6LWluZGV4IHdpdGggbW9yZSB0aGFuIHNpeCBkaWdpdAogCi16SW5kZXggPSAiMi4wMDAyZSsw NyIKIFBBU1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2Nsb25lLW5vZGUtei1pbmRleC5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2Nsb25lLW5vZGUtei1pbmRl eC5odG1sCShyZXZpc2lvbiA1ODc4MSkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL2Nsb25lLW5v ZGUtei1pbmRleC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw2IEBAIGNvbnRhaW5l ci5yZW1vdmVDaGlsZChvbGRFbCk7CiBjb250YWluZXIuYXBwZW5kQ2hpbGQobmV3RWwpOwogCiB2 YXIgbXNncyA9IFtdOwotbXNncy5wdXNoKCd6SW5kZXggPSAiJyArIG5ld0VsLnN0eWxlLnpJbmRl eCArICciJyk7CiBtc2dzLnB1c2gobmV3RWwuc3R5bGUuekluZGV4ID09IDIwMDAyMDAwID8gIlBB U1MiIDogIkZBSUwiKTsKIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdtc2dzJykuaW5uZXJIVE1M ID0gbXNncy5qb2luKCc8YnIvPicpOwogCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4v ZmFzdC9kb20vY2xvbmUtbm9kZS16LWluZGV4LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFzdC9kb20vY2xvbmUtbm9kZS16LWluZGV4LWV4cGVj dGVkLnR4dAkocmV2aXNpb24gNTg4NTUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFz dC9kb20vY2xvbmUtbm9kZS16LWluZGV4LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAt MSw0ICswLDAgQEAKLVRlc3QgZm9yIGJ1ZyAzNzkwMDogY2xvbmVOb2RlKCkgZG9lcyBub3QgcHJl c2VydmUgei1pbmRleCB3aXRoIG1vcmUgdGhhbiBzaXggZGlnaXQKLQotekluZGV4ID0gIjIuMDAw MmUrMDA3IgotUEFTUwo=