<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>3850</bug_id>
          
          <creation_ts>2005-07-04 01:54:13 -0700</creation_ts>
          <short_desc>GW: Additions to KWQPtrList.h</short_desc>
          <delta_ts>2005-07-05 00:27:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P4</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>3250</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Eric Seidel (no email)">eric</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>13895</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-07-04 01:54:15 -0700</bug_when>
    <thetext>Several small additions to our QPtrList:

int findRef(const T *item) { return impl.findRef(item); }
typedef QPtrListIterator&lt;T&gt; Iterator;
typedef QPtrListIterator&lt;T&gt; ConstIterator;
ConstIterator begin() const { return ConstIterator(*this); }
ConstIterator end() const { ConstIterator itr(*this); }

And to QPtrListIterator:
T *operator*() const { return (T *)impl.current(); }</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13899</commentid>
    <comment_count>1</comment_count>
      <attachid>2788</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-07-04 02:02:17 -0700</bug_when>
    <thetext>Created attachment 2788
straightforward additions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13932</commentid>
    <comment_count>2</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2005-07-04 18:52:18 -0700</bug_when>
    <thetext>More standard C++ semantics would be for operator* to return T *&amp; rather than T* but I guess this 
matches KDE.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13939</commentid>
    <comment_count>3</comment_count>
      <attachid>2788</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2005-07-04 20:39:37 -0700</bug_when>
    <thetext>Comment on attachment 2788
straightforward additions.

r=me</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>2788</attachid>
            <date>2005-07-04 02:02:17 -0700</date>
            <delta_ts>2005-07-04 20:39:37 -0700</delta_ts>
            <desc>straightforward additions.</desc>
            <filename>kwqptrlist.patch</filename>
            <type>text/plain</type>
            <size>1192</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">SW5kZXg6IEtXUVB0ckxpc3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29y
ZS9rd3EvS1dRUHRyTGlzdC5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjI4CmRpZmYgLXAgLXUg
LXIxLjI4IEtXUVB0ckxpc3QuaAotLS0gS1dRUHRyTGlzdC5oCTIwMDMvMDEvMjIgMDA6MTI6MzUJ
MS4yOAorKysgS1dRUHRyTGlzdC5oCTIwMDUvMDcvMDQgMDg6NTY6MTIKQEAgLTcyLDggKzcyLDE0
IEBAIHB1YmxpYzoKICAgICB2b2lkIHByZXBlbmQoY29uc3QgVCAqaXRlbSkgeyBpbXBsLnByZXBl
bmQoaXRlbSk7IH0KIAogICAgIHVpbnQgY29udGFpbnNSZWYoY29uc3QgVCAqaXRlbSkgY29uc3Qg
eyByZXR1cm4gaW1wbC5jb250YWluc1JlZihpdGVtKTsgfQorICAgIGludCBmaW5kUmVmKGNvbnN0
IFQgKml0ZW0pIHsgcmV0dXJuIGltcGwuZmluZFJlZihpdGVtKTsgfQogCiAgICAgdmlydHVhbCBp
bnQgY29tcGFyZUl0ZW1zKHZvaWQgKmEsIHZvaWQgKmIpIHsgcmV0dXJuIGEgIT0gYjsgfQorICAg
IAorICAgIHR5cGVkZWYgUVB0ckxpc3RJdGVyYXRvcjxUPiBJdGVyYXRvcjsKKyAgICB0eXBlZGVm
IFFQdHJMaXN0SXRlcmF0b3I8VD4gQ29uc3RJdGVyYXRvcjsKKyAgICBDb25zdEl0ZXJhdG9yIGJl
Z2luKCkgY29uc3QgeyByZXR1cm4gQ29uc3RJdGVyYXRvcigqdGhpcyk7IH0KKyAgICBDb25zdEl0
ZXJhdG9yIGVuZCgpIGNvbnN0IHsgQ29uc3RJdGVyYXRvciBpdHIoKnRoaXMpOyBpdHIudG9MYXN0
KCk7ICsraXRyOyByZXR1cm4gaXRyOyB9CiAKICBwcml2YXRlOgogICAgIHN0YXRpYyB2b2lkIGRl
bGV0ZUZ1bmModm9pZCAqaXRlbSkgeyBkZWxldGUgKFQgKilpdGVtOyB9CkBAIC05NSw2ICsxMDEs
NyBAQCBwdWJsaWM6CiAgICAgVCAqY3VycmVudCgpIGNvbnN0IHsgcmV0dXJuIChUICopaW1wbC5j
dXJyZW50KCk7IH0KIAogICAgIG9wZXJhdG9yIFQgKigpIGNvbnN0IHsgcmV0dXJuIChUICopaW1w
bC5jdXJyZW50KCk7IH0KKyAgICBUICpvcGVyYXRvciooKSBjb25zdCB7IHJldHVybiAoVCAqKWlt
cGwuY3VycmVudCgpOyB9CiAgICAgVCAqb3BlcmF0b3ItLSgpIHsgcmV0dXJuIChUICopLS1pbXBs
OyB9CiAgICAgVCAqb3BlcmF0b3IrKygpICB7IHJldHVybiAoVCAqKSsraW1wbDsgfQogCg==
</data>
<flag name="review"
          id="167"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>