<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>3849</bug_id>
          
          <creation_ts>2005-07-04 01:48:32 -0700</creation_ts>
          <short_desc>GW: Add T *QPtrDict::operator()()</short_desc>
          <delta_ts>2005-07-07 00:53:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P4</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>3250</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Eric Seidel (no email)">eric</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>13890</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-07-04 01:48:32 -0700</bug_when>
    <thetext>Add the very strange T *QPtrDict::operator()() which is used in kdom:

T *operator()() { T *ret = (T *)impl.current(); ++impl; return ret; }

And is described here:
http://doc.trolltech.com/3.3/qptrdictiterator.html#operator()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13891</commentid>
    <comment_count>1</comment_count>
      <attachid>2787</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-07-04 01:49:19 -0700</bug_when>
    <thetext>Created attachment 2787
self explanitory patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13929</commentid>
    <comment_count>2</comment_count>
      <attachid>2787</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2005-07-04 18:42:06 -0700</bug_when>
    <thetext>Comment on attachment 2787
self explanitory patch.

Eric and I discussed this and agreed it is probably a bad idea to iterate over
a dictionary this way, instead of using an iterator, so better to fix the
caller.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13930</commentid>
    <comment_count>3</comment_count>
      <attachid>2787</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2005-07-04 18:47:33 -0700</bug_when>
    <thetext>Comment on attachment 2787
self explanitory patch.

ok, this is an iterator method, nonstandard, but not so bad.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13931</commentid>
    <comment_count>4</comment_count>
      <attachid>2787</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2005-07-04 18:49:21 -0700</bug_when>
    <thetext>Comment on attachment 2787
self explanitory patch.

I&apos;d rather see use of this syntax removed than have support for it added to
QDict. But re-request review if it turns out to be too much hassle.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13933</commentid>
    <comment_count>5</comment_count>
      <attachid>2787</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-07-04 19:06:46 -0700</bug_when>
    <thetext>Comment on attachment 2787
self explanitory patch.

After further discussions on IRC, I think we came to the conclusion that there
is a real need for this... even if it is a little &quot;odd&quot;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>2787</attachid>
            <date>2005-07-04 01:49:19 -0700</date>
            <delta_ts>2005-07-07 00:39:59 -0700</delta_ts>
            <desc>self explanitory patch.</desc>
            <filename>qptrdict.patch</filename>
            <type>text/plain</type>
            <size>507</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">SW5kZXg6IC4va3dxL0tXUVB0ckRpY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3Qv
V2ViQ29yZS9rd3EvS1dRUHRyRGljdC5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjI4CmRpZmYg
LXAgLXUgLXIxLjI4IC4va3dxL0tXUVB0ckRpY3QuaAotLS0gLi9rd3EvS1dRUHRyRGljdC5oCTIw
MDQvMTAvMDUgMjA6MjU6MTkJMS4yOAorKysgLi9rd3EvS1dRUHRyRGljdC5oCTIwMDUvMDcvMDQg
MDg6MTk6NTUKQEAgLTcyLDYgKzcyLDcgQEAgcHVibGljOgogCiAgICAgVCogdG9GaXJzdCgpIHsg
cmV0dXJuIChUKikoaW1wbC50b0ZpcnN0KCkpOyB9CiAKKyAgICBUICpvcGVyYXRvcigpKCkgeyBU
ICpyZXQgPSAoVCAqKWltcGwuY3VycmVudCgpOyArK2ltcGw7IHJldHVybiByZXQ7IH0KICAgICBU
ICpvcGVyYXRvcisrKCkgeyByZXR1cm4gKFQgKikrK2ltcGw7IH0KIAogcHJpdmF0ZToK
</data>
<flag name="review"
          id="166"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>