3847 2005-07-04 01:37:30 -0700 GW: add Cap support to QRegExp 2005-07-08 18:15:19 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED P4 Enhancement --- 3250 1 eric eric oldest_to_newest 13884 0 eric 2005-07-04 01:37:31 -0700 The attached patch adds QRegExp::cap(int) support to KWQ. 13886 1 2785 eric 2005-07-04 01:38:40 -0700 Created attachment 2785 a little more tricky than some, but should still be easily understandable 14157 2 2785 mjs 2005-07-07 21:30:29 -0700 Comment on attachment 2785 a little more tricky than some, but should still be easily understandable r=me Make sure to test performance before landing. minor style nitpick: we prefer no braces around single-line if bodies. Please fix that before landing. 14158 3 2785 mjs 2005-07-07 21:34:05 -0700 Comment on attachment 2785 a little more tricky than some, but should still be easily understandable r=me Make sure to test performance before landing. minor style nitpick: we prefer no braces around single-line if bodies. Please fix that before landing. 14247 4 eric 2005-07-08 18:07:23 -0700 I ran autovicki. No performance regressions: Before: cvs-base AvgCached: 0.144 After: cvs-base AvgCached: 0.144 2785 2005-07-04 01:38:40 -0700 2005-07-07 21:34:05 -0700 a little more tricky than some, but should still be easily understandable qregexp.patch text/plain 3412 eric SW5kZXg6IC4va3dxL0tXUVJlZ0V4cC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJDb3JlL2t3cS9LV1FSZWdFeHAuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xOQpkaWZmIC1w IC11IC1yMS4xOSAuL2t3cS9LV1FSZWdFeHAuaAotLS0gLi9rd3EvS1dRUmVnRXhwLmgJMjAwMy8w Ny8zMCAxOTowNDowNwkxLjE5CisrKyAuL2t3cS9LV1FSZWdFeHAuaAkyMDA1LzA3LzA0IDA4OjE5 OjU1CkBAIC00OSw2ICs0OSw4IEBAIHB1YmxpYzoKICAgICBpbnQgcG9zKGludCBuID0gMCk7CiAg ICAgaW50IG1hdGNoZWRMZW5ndGgoKSBjb25zdDsKICAgICAKKyAgICBRU3RyaW5nIGNhcChpbnQg biA9IDApIGNvbnN0OworICAgIAogcHJpdmF0ZToKICAgICBjbGFzcyBLV1FSZWdFeHBQcml2YXRl OyAgICAKICAgICBLV1FSZWZQdHI8S1dRUmVnRXhwUHJpdmF0ZT4gZDsKSW5kZXg6IC4va3dxL0tX UVJlZ0V4cC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9rd3EvS1dR UmVnRXhwLm1tLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzCmRpZmYgLXAgLXUgLXIxLjEzIC4v a3dxL0tXUVJlZ0V4cC5tbQotLS0gLi9rd3EvS1dRUmVnRXhwLm1tCTIwMDQvMDgvMTAgMjE6MzU6 MDgJMS4xMworKysgLi9rd3EvS1dRUmVnRXhwLm1tCTIwMDUvMDcvMDQgMDg6MTk6NTYKQEAgLTI5 LDYgKzI5LDkgQEAKICNpbXBvcnQgPHN5cy90eXBlcy5oPgogI2ltcG9ydCA8SmF2YVNjcmlwdENv cmUvcGNyZS5oPgogCisjZGVmaW5lIE1BWF9TVUJTVFJJTkdTICAxMAorI2RlZmluZSBNQVhfT0ZG U0VUUyAgICAgKDMgKk1BWF9TVUJTVFJJTkdTKQorCiBjbGFzcyBRUmVnRXhwOjpLV1FSZWdFeHBQ cml2YXRlCiB7CiBwdWJsaWM6CkBAIC00Myw2ICs0Niw5IEBAIHB1YmxpYzoKICAgICAKICAgICB1 aW50IHJlZkNvdW50OwogCisgICAgUVN0cmluZyBsYXN0TWF0Y2hTdHJpbmc7CisgICAgaW50IGxh c3RNYXRjaE9mZnNldHNbTUFYX09GRlNFVFNdOworICAgIGludCBsYXN0TWF0Y2hDb3VudDsKICAg ICBpbnQgbGFzdE1hdGNoUG9zOwogICAgIGludCBsYXN0TWF0Y2hMZW5ndGg7CiB9OwpAQCAtMTQ4 LDIzICsxNTQsMjMgQEAgUVN0cmluZyBRUmVnRXhwOjpwYXR0ZXJuKCkgY29uc3QKIAogaW50IFFS ZWdFeHA6Om1hdGNoKGNvbnN0IFFTdHJpbmcgJnN0ciwgaW50IHN0YXJ0RnJvbSwgaW50ICptYXRj aExlbmd0aCkgY29uc3QKIHsKKyAgICBkLT5sYXN0TWF0Y2hTdHJpbmcgPSBzdHI7CiAgICAgLy8g Rmlyc3QgMiBvZmZzZXRzIGFyZSBzdGFydCBhbmQgZW5kIG9mZnNldHM7IDNyZCBlbnRyeSBpcyB1 c2VkIGludGVybmFsbHkgYnkgcGNyZQotICAgIGludCBvZmZzZXRzWzNdOwotICAgIGludCByZXN1 bHQgPSBwY3JlX2V4ZWMoZC0+cmVnZXgsIE5VTEwsIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWlu dDE2X3QgKj4oc3RyLnVuaWNvZGUoKSksIHN0ci5sZW5ndGgoKSwgc3RhcnRGcm9tLCAKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0RnJvbSA9PSAwID8gMCA6IFBDUkVfTk9UQk9MLCBv ZmZzZXRzLCAzKTsKLSAgICBpZiAocmVzdWx0IDwgMCkgewotICAgICAgICBpZiAocmVzdWx0ICE9 IFBDUkVfRVJST1JfTk9NQVRDSCkgewotICAgICAgICAgICAgRVJST1IoIktXUVJlZ0V4cDogcGNy ZV9leGVjKCkgZmFpbGVkIHdpdGggcmVzdWx0ICVkIiwgcmVzdWx0KTsKKyAgICBkLT5sYXN0TWF0 Y2hDb3VudCA9IHBjcmVfZXhlYyhkLT5yZWdleCwgTlVMTCwgcmVpbnRlcnByZXRfY2FzdDxjb25z dCB1aW50MTZfdCAqPihkLT5sYXN0TWF0Y2hTdHJpbmcudW5pY29kZSgpKSwgZC0+bGFzdE1hdGNo U3RyaW5nLmxlbmd0aCgpLCBzdGFydEZyb20sIHN0YXJ0RnJvbSA9PSAwID8gMCA6IFBDUkVfTk9U Qk9MLCBkLT5sYXN0TWF0Y2hPZmZzZXRzLCBNQVhfT0ZGU0VUUyk7CisgICAgaWYgKGQtPmxhc3RN YXRjaENvdW50IDwgMCkgeworICAgICAgICBpZiAoZC0+bGFzdE1hdGNoQ291bnQgIT0gUENSRV9F UlJPUl9OT01BVENIKSB7CisgICAgICAgICAgICBFUlJPUigiS1dRUmVnRXhwOiBwY3JlX2V4ZWMo KSBmYWlsZWQgd2l0aCByZXN1bHQgJWQiLCBkLT5sYXN0TWF0Y2hDb3VudCk7CiAgICAgICAgIH0K ICAgICAgICAgZC0+bGFzdE1hdGNoUG9zID0gLTE7CiAgICAgICAgIGQtPmxhc3RNYXRjaExlbmd0 aCA9IC0xOworICAgICAgICBkLT5sYXN0TWF0Y2hTdHJpbmcgPSBRU3RyaW5nKCk7CiAgICAgICAg IHJldHVybiAtMTsKICAgICB9CiAgICAgCiAgICAgLy8gMSBtZWFucyAxIG1hdGNoOyAwIG1lYW5z IG1vcmUgdGhhbiBvbmUgbWF0Y2guIEZpcnN0IG1hdGNoIGlzIHJlY29yZGVkIGluIG9mZnNldHMu Ci0gICAgQVNTRVJUKHJlc3VsdCA8IDIpOwotICAgIGQtPmxhc3RNYXRjaFBvcyA9IG9mZnNldHNb MF07Ci0gICAgZC0+bGFzdE1hdGNoTGVuZ3RoID0gb2Zmc2V0c1sxXSAtIG9mZnNldHNbMF07Cisg ICAgLy9BU1NFUlQoZC0+bGFzdE1hdGNoQ291bnQgPCAyKTsKKyAgICBkLT5sYXN0TWF0Y2hQb3Mg PSBkLT5sYXN0TWF0Y2hPZmZzZXRzWzBdOworICAgIGQtPmxhc3RNYXRjaExlbmd0aCA9IGQtPmxh c3RNYXRjaE9mZnNldHNbMV0gLSBkLT5sYXN0TWF0Y2hPZmZzZXRzWzBdOwogICAgIGlmIChtYXRj aExlbmd0aCAhPSBOVUxMKSB7CiAgICAgICAgICptYXRjaExlbmd0aCA9IGQtPmxhc3RNYXRjaExl bmd0aDsKICAgICB9CkBAIC0yMTMsMyArMjE5LDE3IEBAIGludCBRUmVnRXhwOjptYXRjaGVkTGVu Z3RoKCkgY29uc3QKIHsKICAgICByZXR1cm4gZC0+bGFzdE1hdGNoTGVuZ3RoOwogfQorCitRU3Ry aW5nIFFSZWdFeHA6OmNhcChpbnQgbikgY29uc3QKK3sKKyAgICBRX0FTU0VSVCghZC0+bGFzdFNl YXJjaFN0cmluZy5pc051bGwoKSk7CisgICAgY29uc3QgcGNyZV9jaGFyICpzdWJzdHJpbmcgPSBO VUxMOworICAgIGludCBzdWJzdHJpbmdMZW5ndGggPSAgcGNyZV9nZXRfc3Vic3RyaW5nKHJlaW50 ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDE2X3QgKj4oZC0+bGFzdE1hdGNoU3RyaW5nLnVuaWNvZGUo KSksIGQtPmxhc3RNYXRjaE9mZnNldHMsIGQtPmxhc3RNYXRjaENvdW50LCBuLCAmc3Vic3RyaW5n KTsKKyAgICBpZiAoc3Vic3RyaW5nTGVuZ3RoID4gMCkgeworICAgICAgIFFTdHJpbmcgY2FwdHVy ZShyZWludGVycHJldF9jYXN0PGNvbnN0IFFDaGFyICo+KHN1YnN0cmluZyksIHN1YnN0cmluZ0xl bmd0aCk7CisgICAgICAgcGNyZV9mcmVlX3N1YnN0cmluZyhzdWJzdHJpbmcpOworICAgICAgIHJl dHVybiBjYXB0dXJlOworICAgIH0KKyAgICByZXR1cm4gUVN0cmluZygpOworfQorCg==