38444 2010-05-02 17:44:08 -0700 [Qt] GraphicsLayer caches directly composited images 2010-05-16 01:03:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All CLOSED FIXED Qt P2 Enhancement --- 38744 1 noam webkit-unassigned commit-queue eric hausmann jesus jturcotte simon.fraser oldest_to_newest 219930 0 noam 2010-05-02 17:44:08 -0700 it could be optimized to draw them directly. 219931 1 54894 noam 2010-05-02 17:47:12 -0700 Created attachment 54894 Only cache HTML content 219935 2 54894 eric 2010-05-02 18:24:24 -0700 Comment on attachment 54894 Only cache HTML content Looks sane. Do other ports have this optimization? 219941 3 noam 2010-05-02 18:30:42 -0700 Yes - that's what the direct-compositing API in GraphicsLayer.h is for. We've had this optimization in before, but I omitted it by mistake when I introduced another optimization 224550 4 54894 kenneth 2010-05-12 05:43:46 -0700 Comment on attachment 54894 Only cache HTML content I think this deserves an explanation in the code. So please add a comment. 225371 5 55994 noam 2010-05-13 10:35:53 -0700 Created attachment 55994 added comments per Kenneth's review 226090 6 55994 commit-queue 2010-05-14 18:43:44 -0700 Comment on attachment 55994 added comments per Kenneth's review Clearing flags on attachment: 55994 Committed r59510: <http://trac.webkit.org/changeset/59510> 226091 7 commit-queue 2010-05-14 18:43:51 -0700 All reviewed patches have been landed. Closing bug. 226444 8 hausmann 2010-05-16 01:03:15 -0700 Revision r59510 cherry-picked into qtwebkit-2.0 with commit ead6be782dbaa32cf9c33e21b3c32d2f78c4d0a5 54894 2010-05-02 17:47:12 -0700 2010-05-13 10:35:53 -0700 Only cache HTML content patch-38444.diff text/plain 1467 noam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjhkOTQyOS4uZjcxNDNlOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0wMiAgTm9hbSBSb3NlbnRo YWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBHcmFwaGljc0xheWVyIGNhY2hlcyBkaXJlY3Rs eSBjb21wb3NpdGVkIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzg0NDQKKworICAgICAgICBPcHRpbWl6YXRpb246IG9ubHkgY2FjaGUgaXRl bXMgd2l0aCBIVE1MLWNvbnRlbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9H cmFwaGljc0xheWVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclF0SW1w bDo6Zmx1c2hDaGFuZ2VzKToKKwogMjAxMC0wNS0wMiAgVGFzdWt1IFN1enVraSAgPHRhc3VrdS5z dXp1a2lAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQu Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwCmlu ZGV4IDFjNGMyNzUuLjRkOWY2NTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKQEAgLTYwOCw3ICs2MDgsOCBAQCB2b2lkIEdyYXBoaWNz TGF5ZXJRdEltcGw6OmZsdXNoQ2hhbmdlcyhib29sIHJlY3Vyc2l2ZSwgYm9vbCBmb3JjZVVwZGF0 ZVRyYW5zZm9ybQogICAgICAgICBtX21hc2tFZmZlY3QuZGF0YSgpLT51cGRhdGUoKTsKICAgICBl bHNlIGlmIChtX2NoYW5nZU1hc2sgJiBEaXNwbGF5Q2hhbmdlKSB7ICAgICAgICAKICAgICAgICAg Ly8gUmVjYWNoZSBub3c6IGFsbCB0aGUgY29udGVudCBpcyByZWFkeSBhbmQgd2UgZG9uJ3Qgd2Fu dCB0byB3YWl0IHVudGlsIHRoZSBwYWludCBldmVudC4KLSAgICAgICAgcmVjYWNoZShtX3BlbmRp bmdDb250ZW50LnJlZ2lvblRvVXBkYXRlKTsKKyAgICAgICAgaWYgKG1fcGVuZGluZ0NvbnRlbnQu Y29udGVudFR5cGUgPT0gSFRNTENvbnRlbnRUeXBlKQorICAgICAgICAgICAgcmVjYWNoZShtX3Bl bmRpbmdDb250ZW50LnJlZ2lvblRvVXBkYXRlKTsKICAgICAgICAgdXBkYXRlKG1fcGVuZGluZ0Nv bnRlbnQucmVnaW9uVG9VcGRhdGUuYm91bmRpbmdSZWN0KCkpOwogICAgICAgICBtX3BlbmRpbmdD b250ZW50LnJlZ2lvblRvVXBkYXRlID0gUVJlZ2lvbigpOwogICAgIH0K 55994 2010-05-13 10:35:53 -0700 2010-05-14 18:43:44 -0700 added comments per Kenneth's review patch-38444-2.diff text/plain 2015 noam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjUwNjk5MC4uYTIzZGI2MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNS0xMyAgTm9hbSBSb3NlbnRo YWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBHcmFwaGljc0xheWVyIGNhY2hlcyBkaXJlY3Rs eSBjb21wb3NpdGVkIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzg0NDQKKworICAgICAgICBEaXJlY3RseS1jb21wb3NpdGVkIGltYWdlcyBh bmQgc29saWQgZmlsbHMgc2hvdWxkbid0IGJlIGNhY2hlZCwgYXMgdGhhdCBjYWNoZQorICAgICAg ICBpcyBuZXZlciB1c2VkIChzZWUgR3JhcGhpY3NMYXllclF0SW1wbDo6cGFpbnQpLiBDYWNoZSBp cyBvbmx5IHJlbGV2YW50IGZvciBIVE1MIGNvbnRlbnQsCisgICAgICAgIGJ1dCB3ZSB3ZXJlIG1p c3NpbmcgdGhhdCB0ZXN0LgorICAgICAgICBUaGUgZml4IG1ha2VzIHN1cmUgd2Ugb25seSBjYWNo ZSBIVE1MIGNvbnRlbnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiB0aGlzIGlzIGEgbWlub3Ig b3B0aW1pemF0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NM YXllclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJRdEltcGw6OmZsdXNo Q2hhbmdlcyk6CisKIDIwMTAtMDUtMTMgIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKaW5kZXgg NThkY2ZjOC4uYWFjMTE2NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9HcmFwaGljc0xheWVyUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv R3JhcGhpY3NMYXllclF0LmNwcApAQCAtNjIxLDggKzYyMSwxMCBAQCB2b2lkIEdyYXBoaWNzTGF5 ZXJRdEltcGw6OmZsdXNoQ2hhbmdlcyhib29sIHJlY3Vyc2l2ZSwgYm9vbCBmb3JjZVVwZGF0ZVRy YW5zZm9ybQogICAgIGlmIChtX21hc2tFZmZlY3QpCiAgICAgICAgIG1fbWFza0VmZmVjdC5kYXRh KCktPnVwZGF0ZSgpOwogICAgIGVsc2UgaWYgKG1fY2hhbmdlTWFzayAmIERpc3BsYXlDaGFuZ2Up IHsgICAgICAgIAotICAgICAgICAvLyBSZWNhY2hlIG5vdzogYWxsIHRoZSBjb250ZW50IGlzIHJl YWR5IGFuZCB3ZSBkb24ndCB3YW50IHRvIHdhaXQgdW50aWwgdGhlIHBhaW50IGV2ZW50LgotICAg ICAgICByZWNhY2hlKG1fcGVuZGluZ0NvbnRlbnQucmVnaW9uVG9VcGRhdGUpOworICAgICAgICAv LyBSZWNhY2hlIG5vdzogYWxsIHRoZSBjb250ZW50IGlzIHJlYWR5IGFuZCB3ZSBkb24ndCB3YW50 IHRvIHdhaXQgdW50aWwgdGhlIHBhaW50IGV2ZW50LiBXZSBvbmx5IG5lZWQgdG8gZG8gdGhpcyBm b3IgSFRNTCBjb250ZW50LCAKKyAgICAgICAgLy8gdGhlcmUncyBubyBwb2ludCBpbiBjYWNoaW5n IGRpcmVjdGx5IGNvbXBvc2l0ZWQgY29udGVudCBsaWtlIGltYWdlcyBvciBzb2xpZCByZWN0YW5n bGVzLgorICAgICAgICBpZiAobV9wZW5kaW5nQ29udGVudC5jb250ZW50VHlwZSA9PSBIVE1MQ29u dGVudFR5cGUpCisgICAgICAgICAgICByZWNhY2hlKG1fcGVuZGluZ0NvbnRlbnQucmVnaW9uVG9V cGRhdGUpOwogICAgICAgICB1cGRhdGUobV9wZW5kaW5nQ29udGVudC5yZWdpb25Ub1VwZGF0ZS5i b3VuZGluZ1JlY3QoKSk7CiAgICAgICAgIG1fcGVuZGluZ0NvbnRlbnQucmVnaW9uVG9VcGRhdGUg PSBRUmVnaW9uKCk7CiAgICAgfQo=