38370 2010-04-29 20:32:39 -0700 [Qt] GraphicsLayer: depth-test causes flicker in certain situations 2010-05-14 01:25:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All CLOSED FIXED http://webkit.org/blog-files/3d-transforms/morphing-cubes.html Qt P2 Normal --- 38744 1 noam webkit-unassigned commit-queue eric hausmann krit ossy zherczeg oldest_to_newest 219347 0 noam 2010-04-29 20:32:39 -0700 the depth test for stacking items in 3D space is inaccurate - suggesting to remove it for this version. 219349 1 54778 noam 2010-04-29 20:36:37 -0700 Created attachment 54778 Remove the simplistic depth test 219551 2 54778 eric 2010-04-30 11:46:36 -0700 Comment on attachment 54778 Remove the simplistic depth test OK. Do we have no way to test this using repaint tests? 219619 3 noam 2010-04-30 14:33:21 -0700 Actually, now that you mention it, the tests in LayoutTests/compositing/geometry seem to test this, and some of them regressed. This patch is still good - but I probably need a couple of more patches to fix those regressions. 219805 4 noam 2010-05-02 02:52:08 -0700 Sorry, my last comment was meant for another bug. There's no way to test this because the depth-test functionality is not specified anywhere. The depth-test functionality is a completely platform-specific choice. 225156 5 54778 commit-queue 2010-05-12 23:27:50 -0700 Comment on attachment 54778 Remove the simplistic depth test Clearing flags on attachment: 54778 Committed r59347: <http://trac.webkit.org/changeset/59347> 225157 6 commit-queue 2010-05-12 23:27:57 -0700 All reviewed patches have been landed. Closing bug. 225707 7 hausmann 2010-05-14 01:23:41 -0700 Revision r59347 cherry-picked into qtwebkit-2.0 with commit 88ea502ee97de59515558c299272cc3420048d68 54778 2010-04-29 20:36:37 -0700 2010-05-12 23:27:50 -0700 Remove the simplistic depth test patch-38370-1.diff text/plain 1859 noam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjljNjZjOC4uNWMyZDcxMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNC0yOSAgTm9hbSBSb3NlbnRo YWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBHcmFwaGljc0xheWVyOiBkZXB0aC10ZXN0IGNh dXNlcyBmbGlja2VyIGluIGNlcnRhaW4gc2l0dWF0aW9ucworCisgICAgICAgIFRoaXMgcGF0Y2gg cmVtb3ZlcyB0aGUgc2ltcGxpc3RpYyAyRCBkZXB0aCB0ZXN0IGFzIGl0IGxlYWRzIHRvIGZsaWNr ZXJpbmcgc2lkZSBlZmZlY3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzgzNzAKKworICAgICAgICBUZXN0ZWQgYnkgaHR0cDovL3dlYmtpdC5vcmcv YmxvZy1maWxlcy8zZC10cmFuc2Zvcm1zL21vcnBoaW5nLWN1YmVzLmh0bWwKKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHcmFwaGljc0xheWVyUXRJbXBsOjp1cGRhdGVUcmFuc2Zvcm0pOgorCiAyMDEwLTA0LTI5 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4g IFVwZGF0ZSBKU0MgQ29kZUdlbmVyYXRvciBiYXNlbGluZS4gIE5vdCBzdXJlIGhvdyBJIG1pc3Nl ZApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVy UXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3Bw CmluZGV4IDFjNGMyNzUuLmQ5Mzk0ZTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKQEAgLTM1NywxNCArMzU3LDYgQEAgdm9pZCBHcmFw aGljc0xheWVyUXRJbXBsOjp1cGRhdGVUcmFuc2Zvcm0oKQogICAgICAgICByZXR1cm47CiAgICAg fQogCi0gICAgLy8gU2ltcGxpc3RpYyBkZXB0aCB0ZXN0IC0gd2Ugc3RhY2sgdGhlIGl0ZW0gYmVo aW5kIGl0cyBwYXJlbnQgaWYgaXRzIGNvbXB1dGVkIHogaXMgbG93ZXIgdGhhbiB0aGUgcGFyZW50 J3MgY29tcHV0ZWQgeiBhdCB0aGUgaXRlbSdzIGNlbnRlciBwb2ludC4KLSAgICBpZiAocGFyZW50 KSB7Ci0gICAgICAgIGNvbnN0IFFQb2ludEYgY2VudGVyUG9pbnRNYXBwZWRUb1Jvb3QgPSByb290 TGF5ZXIoKS0+bWFwRnJvbUl0ZW0odGhpcywgbV9zaXplLndpZHRoKCkgLyAyLCBtX3NpemUuaGVp Z2h0KCkgLyAyKTsKLSAgICAgICAgc2V0RmxhZyhJdGVtU3RhY2tzQmVoaW5kUGFyZW50LAotICAg ICAgICAgICAgICAgIG1fdHJhbnNmb3JtUmVsYXRpdmVUb1Jvb3RMYXllci5tYXBQb2ludChGbG9h dFBvaW50M0QoY2VudGVyUG9pbnRNYXBwZWRUb1Jvb3QueCgpLCBjZW50ZXJQb2ludE1hcHBlZFRv Um9vdC55KCksIDApKS56KCkgPAotICAgICAgICAgICAgICAgIHBhcmVudC0+bV90cmFuc2Zvcm1S ZWxhdGl2ZVRvUm9vdExheWVyLm1hcFBvaW50KEZsb2F0UG9pbnQzRChjZW50ZXJQb2ludE1hcHBl ZFRvUm9vdC54KCksIGNlbnRlclBvaW50TWFwcGVkVG9Sb290LnkoKSwgMCkpLnooKSk7Ci0gICAg fQotCiAgICAgLy8gVGhlIGl0ZW0gaXMgZnJvbnQtZmFjaW5nIG9yIGJhY2tmYWNlLXZpc2liaWxp dHkgaXMgb24uCiAgICAgc2V0VmlzaWJsZSh0cnVlKTsKIAo=