3826 2005-07-02 20:34:26 -0700 GW: Add defs to KWQDefs 2005-07-07 00:32:17 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED P4 Enhancement --- 3250 1 eric eric oldest_to_newest 13724 0 eric 2005-07-02 20:34:26 -0700 These defs are necessary for compiling kdom, and other products on top of KWQ. 13725 1 2765 eric 2005-07-02 20:36:02 -0700 Created attachment 2765 Adds a few defs to KWQDefs This patch also removes the Q_UNUSED(a) hack, or at least changes the implementation thereof. The previous implementation did not work with unused "const" arguments. At least not under GCC 4.0 13746 2 2765 mjs 2005-07-03 00:36:31 -0700 Comment on attachment 2765 Adds a few defs to KWQDefs > +typedef __int64_t Q_INT64; > +typedef __uint64_t Q_UINT64; Suggest using int64_t and uint_64_t with no underscores instead. Regarding QMAX/QMIN and KMAX/KMIN, I think it would be better to port the relevant code to kMax kMin, since that's the direction KHTML went, but failing that, at least use the typesafe version for QMAX/QMIN. > +#define qRound(a) lround(a) Suggest an inline function instead of a macro. 13881 3 2783 eric 2005-07-04 01:14:34 -0700 Created attachment 2783 fixes mjs's concerns 13926 4 2783 mjs 2005-07-04 18:11:36 -0700 Comment on attachment 2783 fixes mjs's concerns r=me 14017 5 2783 ggaren 2005-07-05 11:17:48 -0700 Comment on attachment 2783 fixes mjs's concerns this patch fails to build 14018 6 2819 ggaren 2005-07-05 11:20:36 -0700 Created attachment 2819 patch to fix failed build This patch will build successfully 14019 7 2783 eric 2005-07-05 11:26:49 -0700 Comment on attachment 2783 fixes mjs's concerns ggaren, can I get a log message, or a reason? This patch builds for me just fine. I'm using gcc 4.0 14020 8 eric 2005-07-05 11:38:45 -0700 The build failure was only on 3.3 (which Apple internal is the only one left using). 14029 9 2821 ggaren 2005-07-05 13:38:58 -0700 Created attachment 2821 patch that builds w/gcc 3.3 This version of the patch builds successfully w/gcc 3.3 14038 10 2821 mjs 2005-07-05 18:58:46 -0700 Comment on attachment 2821 patch that builds w/gcc 3.3 r=me 2765 2005-07-02 20:36:02 -0700 2005-07-04 01:14:34 -0700 Adds a few defs to KWQDefs KWQDefs.patch text/plain 1199 eric SW5kZXg6IC4va3dxL0tXUURlZi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJD b3JlL2t3cS9LV1FEZWYuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMwpkaWZmIC1wIC11IC1y MS4xMyAuL2t3cS9LV1FEZWYuaAotLS0gLi9rd3EvS1dRRGVmLmgJMjAwNS8wNS8xMSAwMjoxMDox MAkxLjEzCisrKyAuL2t3cS9LV1FEZWYuaAkyMDA1LzA3LzAzIDAzOjAwOjE0CkBAIC0zMywxMiAr MzMsMjEgQEAgdHlwZWRlZiB1bnNpZ25lZCBjaGFyIHVjaGFyOwogdHlwZWRlZiB1bnNpZ25lZCBs b25nIHVsb25nOwogI2VuZGlmCiAKK3R5cGVkZWYgX19pbnQ2NF90IFFfSU5UNjQ7Cit0eXBlZGVm IF9fdWludDY0X3QgUV9VSU5UNjQ7CisKIHR5cGVkZWYgaW50IFFfSU5UMzI7CiB0eXBlZGVmIHVu c2lnbmVkIGludCBRX1VJTlQzMjsKIAogdHlwZWRlZiBzaG9ydCBRX0lOVDE2OwogdHlwZWRlZiB1 bnNpZ25lZCBzaG9ydCBRX1VJTlQxNjsKIAorI2RlZmluZSBRTUFYKGEsYikgKChhKSA+IChiKSA/ IChhKSA6IChiKSkKKyNkZWZpbmUgUU1JTihhLGIpICgoYSkgPCAoYikgPyAoYSkgOiAoYikpCisK KyNkZWZpbmUgS01BWChhLGIpIGtNYXgoYSwgYikKKyNkZWZpbmUgS01JTihhLGIpIGtNaW4oYSwg YikKKwogdGVtcGxhdGU8Y2xhc3MgVD4KIGlubGluZSBjb25zdCBUJiBrTWluICggY29uc3QgVCYg YSwgY29uc3QgVCYgYiApIHsgcmV0dXJuIGEgPCBiID8gYSA6IGI7IH0KIApAQCAtNDcsNiArNTYs OCBAQCBpbmxpbmUgY29uc3QgVCYga01heCAoIGNvbnN0IFQmIGEsIGNvbnN0CiAKICNkZWZpbmUg UUFCUyhhKSAoKChhKSA+PSAwKSA/IChhKSA6IC0oYSkpCiAKKyNkZWZpbmUgcVJvdW5kKGEpIGxy b3VuZChhKQorCiAjaWZuZGVmIFRSVUUKICNkZWZpbmUgVFJVRSAxCiAjZW5kaWYKQEAgLTU5LDcg KzcwLDcgQEAgdm9pZCBxRGVidWcoY29uc3QgY2hhciAqbXNnLCAuLi4pOwogdm9pZCBxV2Fybmlu Zyhjb25zdCBjaGFyICptc2csIC4uLik7CiAKIC8qIFNpbGx5IGhhY2sgdG8gYXZvaWQgInVudXNl ZCBwYXJhbWV0ZXIiIHdhcm5pbmdzICovCi0jZGVmaW5lIFFfVU5VU0VEKHgpICh4KT0oeCkKKyNk ZWZpbmUgUV9VTlVTRUQoeCkKIAogI2RlZmluZSBRX0FTU0VSVChhcmcpIGRvIHt9IHdoaWxlKDAp CiA= 2783 2005-07-04 01:14:34 -0700 2005-07-05 11:20:36 -0700 fixes mjs's concerns kwqdef.patch text/plain 896 eric SW5kZXg6IEtXUURlZi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2t3 cS9LV1FEZWYuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMwpkaWZmIC1wIC11IC1yMS4xMyBL V1FEZWYuaAotLS0gS1dRRGVmLmgJMjAwNS8wNS8xMSAwMjoxMDoxMAkxLjEzCisrKyBLV1FEZWYu aAkyMDA1LzA3LzA0IDA4OjE0OjMxCkBAIC0zMyw2ICszMyw5IEBAIHR5cGVkZWYgdW5zaWduZWQg Y2hhciB1Y2hhcjsKIHR5cGVkZWYgdW5zaWduZWQgbG9uZyB1bG9uZzsKICNlbmRpZgogCit0eXBl ZGVmIGludDY0X3QgUV9JTlQ2NDsKK3R5cGVkZWYgdWludDY0X3QgUV9VSU5UNjQ7CisKIHR5cGVk ZWYgaW50IFFfSU5UMzI7CiB0eXBlZGVmIHVuc2lnbmVkIGludCBRX1VJTlQzMjsKIApAQCAtNDcs NiArNTAsOCBAQCBpbmxpbmUgY29uc3QgVCYga01heCAoIGNvbnN0IFQmIGEsIGNvbnN0CiAKICNk ZWZpbmUgUUFCUyhhKSAoKChhKSA+PSAwKSA/IChhKSA6IC0oYSkpCiAKK2lubGluZSBpbnQgcVJv dW5kKGRvdWJsZSBhKSB7IHJldHVybiBscm91bmQoYSk7IH0KKwogI2lmbmRlZiBUUlVFCiAjZGVm aW5lIFRSVUUgMQogI2VuZGlmCkBAIC01OSw3ICs2NCw3IEBAIHZvaWQgcURlYnVnKGNvbnN0IGNo YXIgKm1zZywgLi4uKTsKIHZvaWQgcVdhcm5pbmcoY29uc3QgY2hhciAqbXNnLCAuLi4pOwogCiAv KiBTaWxseSBoYWNrIHRvIGF2b2lkICJ1bnVzZWQgcGFyYW1ldGVyIiB3YXJuaW5ncyAqLwotI2Rl ZmluZSBRX1VOVVNFRCh4KSAoeCk9KHgpCisjZGVmaW5lIFFfVU5VU0VEKHgpICh2b2lkKSh4KQog CiAjZGVmaW5lIFFfQVNTRVJUKGFyZykgZG8ge30gd2hpbGUoMCkKIAo= 2819 2005-07-05 11:20:36 -0700 2005-07-05 13:38:58 -0700 patch to fix failed build kwqdef.patch.txt text/plain 897 ggaren SW5kZXg6IEtXUURlZi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2t3 cS9LV1FEZWYuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMwpkaWZmIC1wIC11IC1yMS4xMyBL V1FEZWYuaAotLS0gS1dRRGVmLmgJMjAwNS8wNS8xMSAwMjoxMDoxMAkxLjEzCisrKyBLV1FEZWYu aAkyMDA1LzA3LzA0IDA4OjE0OjMxCkBAIC0zMyw2ICszMyw5IEBAIHR5cGVkZWYgdW5zaWduZWQg Y2hhciB1Y2hhcjsKIHR5cGVkZWYgdW5zaWduZWQgbG9uZyB1bG9uZzsKICNlbmRpZgogCit0eXBl ZGVmIGludDY0X3QgUV9JTlQ2NDsKK3R5cGVkZWYgdV9pbnQ2NF90IFFfVUlOVDY0OworCiB0eXBl ZGVmIGludCBRX0lOVDMyOwogdHlwZWRlZiB1bnNpZ25lZCBpbnQgUV9VSU5UMzI7CiAKQEAgLTQ3 LDYgKzUwLDggQEAgaW5saW5lIGNvbnN0IFQmIGtNYXggKCBjb25zdCBUJiBhLCBjb25zdAogCiAj ZGVmaW5lIFFBQlMoYSkgKCgoYSkgPj0gMCkgPyAoYSkgOiAtKGEpKQogCitpbmxpbmUgaW50IHFS b3VuZChkb3VibGUgYSkgeyByZXR1cm4gbHJvdW5kKGEpOyB9CisKICNpZm5kZWYgVFJVRQogI2Rl ZmluZSBUUlVFIDEKICNlbmRpZgpAQCAtNTksNyArNjQsNyBAQCB2b2lkIHFEZWJ1Zyhjb25zdCBj aGFyICptc2csIC4uLik7CiB2b2lkIHFXYXJuaW5nKGNvbnN0IGNoYXIgKm1zZywgLi4uKTsKIAog LyogU2lsbHkgaGFjayB0byBhdm9pZCAidW51c2VkIHBhcmFtZXRlciIgd2FybmluZ3MgKi8KLSNk ZWZpbmUgUV9VTlVTRUQoeCkgKHgpPSh4KQorI2RlZmluZSBRX1VOVVNFRCh4KSAodm9pZCkoeCkK IAogI2RlZmluZSBRX0FTU0VSVChhcmcpIGRvIHt9IHdoaWxlKDApCiAK 2821 2005-07-05 13:38:58 -0700 2005-07-05 18:58:46 -0700 patch that builds w/gcc 3.3 patch.txt text/plain 2374 ggaren SW5kZXg6IGtodG1sL3JlbmRlcmluZy9yZW5kZXJfY2FudmFzaW1hZ2UuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfY2FudmFz aW1hZ2UuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjExCmRpZmYgLXUgLXIxLjExIHJlbmRl cl9jYW52YXNpbWFnZS5jcHAKLS0tIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfY2FudmFzaW1hZ2Uu Y3BwCTI1IE1heSAyMDA1IDAxOjMzOjIyIC0wMDAwCTEuMTEKKysrIGtodG1sL3JlbmRlcmluZy9y ZW5kZXJfY2FudmFzaW1hZ2UuY3BwCTUgSnVsIDIwMDUgMjA6MTk6MzYgLTAwMDAKQEAgLTQzLDcg KzQzLDEyIEBACiAjaW5jbHVkZSAiaHRtbC9kdGQuaCIKICNpbmNsdWRlICJ4bWwvZG9tMl9ldmVu dHNpbXBsLmgiCiAjaW5jbHVkZSAiaHRtbC9odG1sX2RvY3VtZW50aW1wbC5oIgotI2luY2x1ZGUg PG1hdGguaD4KKworLy8gTXVzdCBpbmNsdWRlIDxjbWF0aD4gaW5zdGVhZCBvZiA8bWF0aC5oPiBi ZWNhdXNlIG9mIGEgYnVnIGluIHRoZQorLy8gZ2NjIDMuMyBsaWJyYXJ5IHZlcnNpb24gb2YgPG1h dGguaD4gd2hlcmUgaWYgeW91IGluY2x1ZGUgYm90aAorLy8gPGNtYXRoPiBhbmQgPG1hdGguaD4g dGhlIG1hY3JvcyBuZWNlc3NhcnkgZm9yIGZ1bmN0aW9ucyBsaWtlCisvLyBpc25hbiBhcmUgbm90 IGRlZmluZWQuCisjaW5jbHVkZSA8Y21hdGg+CiAKIAogCkluZGV4OiBraHRtbC9yZW5kZXJpbmcv cmVuZGVyX2ltYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9r aHRtbC9yZW5kZXJpbmcvcmVuZGVyX2ltYWdlLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS43 NgpkaWZmIC11IC1yMS43NiByZW5kZXJfaW1hZ2UuY3BwCi0tLSBraHRtbC9yZW5kZXJpbmcvcmVu ZGVyX2ltYWdlLmNwcAk1IEp1bCAyMDA1IDA3OjU3OjQ3IC0wMDAwCTEuNzYKKysrIGtodG1sL3Jl bmRlcmluZy9yZW5kZXJfaW1hZ2UuY3BwCTUgSnVsIDIwMDUgMjA6MTk6MzYgLTAwMDAKQEAgLTQz LDcgKzQzLDEyIEBACiAjaW5jbHVkZSAiaHRtbC9kdGQuaCIKICNpbmNsdWRlICJ4bWwvZG9tMl9l dmVudHNpbXBsLmgiCiAjaW5jbHVkZSAiaHRtbC9odG1sX2RvY3VtZW50aW1wbC5oIgotI2luY2x1 ZGUgPG1hdGguaD4KKworLy8gTXVzdCBpbmNsdWRlIDxjbWF0aD4gaW5zdGVhZCBvZiA8bWF0aC5o PiBiZWNhdXNlIG9mIGEgYnVnIGluIHRoZQorLy8gZ2NjIDMuMyBsaWJyYXJ5IHZlcnNpb24gb2Yg PG1hdGguaD4gd2hlcmUgaWYgeW91IGluY2x1ZGUgYm90aAorLy8gPGNtYXRoPiBhbmQgPG1hdGgu aD4gdGhlIG1hY3JvcyBuZWNlc3NhcnkgZm9yIGZ1bmN0aW9ucyBsaWtlCisvLyBpc25hbiBhcmUg bm90IGRlZmluZWQuCisjaW5jbHVkZSA8Y21hdGg+CiAKIHVzaW5nIG5hbWVzcGFjZSBET007CiB1 c2luZyBuYW1lc3BhY2Uga2h0bWw7CkluZGV4OiBrd3EvS1dRRGVmLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9yb290L1dlYkNvcmUva3dxL0tXUURlZi5oLHYKcmV0cmlldmluZyByZXZpc2lv biAxLjE2CmRpZmYgLXUgLXIxLjE2IEtXUURlZi5oCi0tLSBrd3EvS1dRRGVmLmgJNSBKdWwgMjAw NSAxODozNzozMiAtMDAwMAkxLjE2CisrKyBrd3EvS1dRRGVmLmgJNSBKdWwgMjAwNSAyMDoxOToz NiAtMDAwMApAQCAtMzMsNiArMzMsOSBAQAogdHlwZWRlZiB1bnNpZ25lZCBsb25nIHVsb25nOwog I2VuZGlmCiAKK3R5cGVkZWYgaW50NjRfdCBRX0lOVDY0OwordHlwZWRlZiB1X2ludDY0X3QgUV9V SU5UNjQ7CisKIHR5cGVkZWYgaW50IFFfSU5UMzI7CiB0eXBlZGVmIHVuc2lnbmVkIGludCBRX1VJ TlQzMjsKIApAQCAtNDcsNiArNTAsOCBAQAogCiAjZGVmaW5lIFFBQlMoYSkgKCgoYSkgPj0gMCkg PyAoYSkgOiAtKGEpKQogCitpbmxpbmUgaW50IHFSb3VuZChkb3VibGUgYSkgeyByZXR1cm4gbHJv dW5kKGEpOyB9CisKICNpZm5kZWYgVFJVRQogI2RlZmluZSBUUlVFIDEKICNlbmRpZgpAQCAtNTks NyArNjQsNyBAQAogdm9pZCBxV2FybmluZyhjb25zdCBjaGFyICptc2csIC4uLik7CiAKIC8qIFNp bGx5IGhhY2sgdG8gYXZvaWQgInVudXNlZCBwYXJhbWV0ZXIiIHdhcm5pbmdzICovCi0jZGVmaW5l IFFfVU5VU0VEKHgpICh4KT0oeCkKKyNkZWZpbmUgUV9VTlVTRUQoeCkgKHZvaWQpKHgpCiAKICNk ZWZpbmUgUV9BU1NFUlQoYXJnKSBkbyB7fSB3aGlsZSgwKQogCg==