38200 2010-04-27 07:35:42 -0700 run-bindings-tests should use --reset-results instead of --overwrite 2010-04-27 14:24:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan webkit-unassigned abarth eric webkit.review.bot yaar oldest_to_newest 217699 0 ojan 2010-04-27 07:35:42 -0700 That would make it consistent with run-webkit-tests, which seems like a good thing. 217760 1 54426 abarth 2010-04-27 10:14:20 -0700 Created attachment 54426 Patch 217863 2 54426 darin 2010-04-27 12:53:36 -0700 Comment on attachment 54426 Patch OK 217882 3 54426 abarth 2010-04-27 13:25:14 -0700 Comment on attachment 54426 Patch Clearing flags on attachment: 54426 Committed r58329: <http://trac.webkit.org/changeset/58329> 217883 4 abarth 2010-04-27 13:25:20 -0700 All reviewed patches have been landed. Closing bug. 217909 5 webkit.review.bot 2010-04-27 13:50:56 -0700 http://trac.webkit.org/changeset/58329 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/58329 http://trac.webkit.org/changeset/58330 http://trac.webkit.org/changeset/58331 54426 2010-04-27 10:14:20 -0700 2010-04-27 13:25:14 -0700 Patch bug-38200-20100427101419.patch text/plain 3367 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4MjA0YTdjNDhkYWM0YTdiMWZiMmQzMWM3YzNmYjViMjhkNmFjYzg3Li4wZmYyYTcz YWEwYjEwN2VkYjA0NDAyNDBmNGM5MWY1YTBmMGMyOGViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAK IDIwMTAtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBydW4tYmluZGluZ3MtdGVzdHMg c2hvdWxkIHVzZSAtLXJlc2V0LXJlc3VsdHMgaW5zdGVhZCBvZiAtLW92ZXJ3cml0ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgyMDAKKworICAgICAg ICBBcyByZXF1ZXN0ZWQgYnkgT2phbi4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWJpbmRpbmdz LXRlc3RzOgorCisyMDEwLTA0LTI3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK ICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCiAKICAgICAgICAgUkVHUkVT U0lPTihyNTgyNjEpOiB3ZWJraXQtcGF0Y2ggdXBsb2FkIGRvZXMgbm90IHdvcmsgaW4gYW4gU1ZO IGNoZWNrb3V0LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4tYmluZGluZ3Mt dGVzdHMgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0cwppbmRleCBhZTE3 NGNmNWU5ZDMzNzEzZGM0Y2I4OTM2YjliZGZiYTAyM2E1MDA2Li41NmIyYWZmYWU2Mjg4YzJlMTc2 ODQzNzM0NTRmYmY4M2M1NGM2N2I2IDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1 bi1iaW5kaW5ncy10ZXN0cworKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10 ZXN0cwpAQCAtNjcsNyArNjcsNyBAQCBkZWYgZGV0ZWN0X2NoYW5nZXMod29ya19kaXJlY3Rvcnks IHJlZmVyZW5jZV9kaXJlY3RvcnkpOgogICAgIHJldHVybiBjaGFuZ2VzX2ZvdW5kCiAKIAotZGVm IHJ1bl90ZXN0cyhnZW5lcmF0b3IsIGlucHV0X2RpcmVjdG9yeSwgcmVmZXJlbmNlX2RpcmVjdG9y eSwgb3ZlcndyaXRlKToKK2RlZiBydW5fdGVzdHMoZ2VuZXJhdG9yLCBpbnB1dF9kaXJlY3Rvcnks IHJlZmVyZW5jZV9kaXJlY3RvcnksIHJlc2V0X3Jlc3VsdHMpOgogICAgIHdvcmtfZGlyZWN0b3J5 ID0gcmVmZXJlbmNlX2RpcmVjdG9yeQogCiAgICAgcGFzc2VkID0gVHJ1ZQpAQCAtNzcsMTQgKzc3 LDE0IEBAIGRlZiBydW5fdGVzdHMoZ2VuZXJhdG9yLCBpbnB1dF9kaXJlY3RvcnksIHJlZmVyZW5j ZV9kaXJlY3RvcnksIG92ZXJ3cml0ZSk6CiAgICAgICAgICAgICBjb250aW51ZQogICAgICAgICBw cmludCAnVGVzdGluZyB0aGUgJXMgZ2VuZXJhdG9yIG9uICVzJyAlIChnZW5lcmF0b3IsIGlucHV0 X2ZpbGUpCiAgICAgICAgICMgR2VuZXJhdGUgb3V0cHV0IGludG8gdGhlIHdvcmsgZGlyZWN0b3J5 IChlaXRoZXIgdGhlIGdpdmVuIG9uZSBvciBhIAotICAgICAgICAjIHRlbXAgb25lIGlmIG5vdCBv dmVyd3JpdGUgaXMgcGVyZm9ybWVkKQotICAgICAgICBpZiBub3Qgb3ZlcndyaXRlOgorICAgICAg ICAjIHRlbXAgb25lIGlmIG5vdCByZXNldF9yZXN1bHRzIGlzIHBlcmZvcm1lZCkKKyAgICAgICAg aWYgbm90IHJlc2V0X3Jlc3VsdHM6CiAgICAgICAgICAgICB3b3JrX2RpcmVjdG9yeSA9IHRlbXBm aWxlLm1rZHRlbXAoKQogICAgICAgICBpZiBub3QgZ2VuZXJhdGVfZnJvbV9pZGwoZ2VuZXJhdG9y LCBvcy5wYXRoLmpvaW4oaW5wdXRfZGlyZWN0b3J5LAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5wdXRfZmlsZSksCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB3b3JrX2RpcmVjdG9yeSk6CiAgICAgICAgICAgICBwYXNz ZWQgPSBGYWxzZQotICAgICAgICBpZiBvdmVyd3JpdGU6CisgICAgICAgIGlmIHJlc2V0X3Jlc3Vs dHM6CiAgICAgICAgICAgICBwcmludCAiT3Zlcndyb3RlIHJlZmVyZW5jZSBmaWxlcyIKICAgICAg ICAgICAgIGNvbnRpbnVlCiAgICAgICAgICMgRGV0ZWN0IGNoYW5nZXMKQEAgLTEwMSwxMCArMTAx LDEwIEBAIGRlZiBtYWluKGFyZ3YpOgogICAgIHRoZSByZXN1bHRzIHdpdGggcmVmZXJlbmNlIGZp bGVzLgogCiAgICAgT3B0aW9uczoKLSAgICAgICAgLS1vdmVyd3JpdGU6IE92ZXJ3cml0ZXMgdGhl IHJlZmVyZW5jZSBmaWxlcyB3aXRoIHRoZSBnZW5lcmF0ZWQgcmVzdWx0cy4KKyAgICAgICAtLXJl c2V0LXJlc3VsdHM6IE92ZXJ3cml0ZXMgdGhlIHJlZmVyZW5jZSBmaWxlcyB3aXRoIHRoZSBnZW5l cmF0ZWQgcmVzdWx0cy4KIAogICAgICIiIgotICAgIG92ZXJ3cml0ZSA9ICItLW92ZXJ3cml0ZSIg aW4gYXJndgorICAgIHJlc2V0X3Jlc3VsdHMgPSAiLS1yZXNldC1yZXN1bHRzIiBpbiBhcmd2CiAK ICAgICBjdXJyZW50X3NjbSA9IHNjbS5kZXRlY3Rfc2NtX3N5c3RlbShvcy5jdXJkaXIpCiAgICAg b3MuY2hkaXIoY3VycmVudF9zY20uY2hlY2tvdXRfcm9vdCkKQEAgLTEyMSwxNCArMTIxLDE0IEBA IGRlZiBtYWluKGFyZ3YpOgogICAgIGZvciBnZW5lcmF0b3IgaW4gZ2VuZXJhdG9yczoKICAgICAg ICAgaW5wdXRfZGlyZWN0b3J5ID0gb3MucGF0aC5qb2luKCdXZWJDb3JlJywgJ2JpbmRpbmdzJywg J3NjcmlwdHMnLCAndGVzdCcpCiAgICAgICAgIHJlZmVyZW5jZV9kaXJlY3RvcnkgPSBvcy5wYXRo LmpvaW4oJ1dlYkNvcmUnLCAnYmluZGluZ3MnLCAnc2NyaXB0cycsICd0ZXN0JywgZ2VuZXJhdG9y KQotICAgICAgICBpZiBub3QgcnVuX3Rlc3RzKGdlbmVyYXRvciwgaW5wdXRfZGlyZWN0b3J5LCBy ZWZlcmVuY2VfZGlyZWN0b3J5LCBvdmVyd3JpdGUpOgorICAgICAgICBpZiBub3QgcnVuX3Rlc3Rz KGdlbmVyYXRvciwgaW5wdXRfZGlyZWN0b3J5LCByZWZlcmVuY2VfZGlyZWN0b3J5LCByZXNldF9y ZXN1bHRzKToKICAgICAgICAgICAgIGFsbF90ZXN0c19wYXNzZWQgPSBGYWxzZQogCiAgICAgaWYg YWxsX3Rlc3RzX3Bhc3NlZDoKICAgICAgICAgcHJpbnQgJ0FsbCB0ZXN0cyBwYXNzZWQhJwogICAg ICAgICByZXR1cm4gMAogICAgIGVsc2U6Ci0gICAgICAgIHByaW50ICcoVG8gdXBkYXRlIHRoZSBy ZWZlcmVuY2UgZmlsZXMsIGV4ZWN1dGUgInJ1bi1iaW5kaW5ncy10ZXN0IC0tb3ZlcndyaXRlIikn CisgICAgICAgIHByaW50ICcoVG8gdXBkYXRlIHRoZSByZWZlcmVuY2UgZmlsZXMsIGV4ZWN1dGUg InJ1bi1iaW5kaW5ncy10ZXN0IC0tcmVzZXQtcmVzdWx0cyIpJwogICAgICAgICByZXR1cm4gLTEK IAogCg==