38103 2010-04-25 23:24:30 -0700 [DRT/Chromium] Enable Windows project generation 2010-04-27 21:58:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Windows Vista RESOLVED FIXED P2 Normal --- 35902 1 tkent webkit-unassigned dglazkov hamaji rolandsteiner tony oldest_to_newest 216903 0 tkent 2010-04-25 23:24:30 -0700 [DRT/Chromium] Enable Windows project generation 216905 1 tony 2010-04-25 23:28:17 -0700 On my machine, I just switched from system.Platform() to sys.platform. Also, roland says that on Windows 7 system.Platform() works, so the crash in system.Platform() might be Vista specific. 216906 2 54258 tkent 2010-04-25 23:29:18 -0700 Created attachment 54258 Proposed patch 216907 3 54258 tony 2010-04-25 23:30:39 -0700 Comment on attachment 54258 Proposed patch WebKit/chromium/gyp_webkit:80 + if sys.platform == 'Linux2': Nit: I think this has to be lowercase to match. Otherwise, LGTM. 216908 4 54259 tkent 2010-04-25 23:33:30 -0700 Created attachment 54259 Proposed patch (rev.2) 216909 5 tkent 2010-04-25 23:34:11 -0700 (In reply to comment #3) > + if sys.platform == 'Linux2': > Nit: I think this has to be lowercase to match. You're right! Fixed. 216917 6 54259 hamaji 2010-04-25 23:46:56 -0700 Comment on attachment 54259 Proposed patch (rev.2) rs=me as per Tony's LGTM. 216929 7 54259 tkent 2010-04-26 00:33:55 -0700 Comment on attachment 54259 Proposed patch (rev.2) Clearing flags on attachment: 54259 Committed r58237: <http://trac.webkit.org/changeset/58237> 216930 8 tkent 2010-04-26 00:34:05 -0700 All reviewed patches have been landed. Closing bug. 216933 9 webkit.review.bot 2010-04-26 00:44:43 -0700 http://trac.webkit.org/changeset/58237 might have broken Chromium Linux Release 216943 10 tkent 2010-04-26 01:29:59 -0700 Reopened because I rolled out r58237. Probably Chromium/Linux bot should have libglu1-mesa-dev, or Chromium code should use third_party/mesa/. 218108 11 tkent 2010-04-27 18:06:05 -0700 Dimitri kindly updated packages on Chromium Linux bot. I'll commit the patch again. 218191 12 tkent 2010-04-27 21:49:33 -0700 (In reply to comment #11) > Dimitri kindly updated packages on Chromium Linux bot. > I'll commit the patch again. r58341 already bumped the Chromium revision to r45696. I'll commit only the gyp_webkit and ChangeLog changes. 218194 13 tkent 2010-04-27 21:53:39 -0700 Committed r58377: <http://trac.webkit.org/changeset/58377> 54258 2010-04-25 23:29:18 -0700 2010-04-25 23:33:24 -0700 Proposed patch bug-38103-20100426152916.patch text/plain 2365 tkent ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGEzMGExNjEuLmM1NjU4YWMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDEwLTA0LTI1ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRFJUL0Nocm9t aXVtXSBFbmFibGUgV2luZG93cyBwcm9qZWN0IGdlbmVyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MTAzCisKKyAgICAgICAgLSBCdW1wIHRo ZSBDaHJvbWl1bSByZXZpc2lvbiB0byByNDU1MTUgdG8gaGF2ZSBHWVAgcjgxOCwgd2hpY2ggZml4 ZXMKKyAgICAgICAgICBhIFdpbmRvd3MgcHJvamVjdCBnZW5lcmF0aW9uIGJ1Zy4KKyAgICAgICAg LSBBdm9pZCBwbGF0Zm9ybS5zeXN0ZW0oKSwgd2hpY2ggY2F1c2VzIGEgY3Jhc2ggd2l0aCBweXRo b24uZXhlIGluCisgICAgICAgICAgZGVwb3RfdG9vbHMuIFVzZSBzeXMucGxhdGZvcm0gaW5zdGVh ZC4KKyAgICAgICAgLSBQcm9jZXNzIER1bXBSZW5kZXJUcmVlLmd5cCBvbiBhbGwgcGxhdGZvcm1z LgorCisgICAgICAgICogREVQUzoKKyAgICAgICAgKiBneXBfd2Via2l0OgorCiAyMDEwLTA0LTIz ICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0RFUFMgYi9XZWJLaXQvY2hy b21pdW0vREVQUwppbmRleCAxNWYyOTE3Li5iMTQyMGRmIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hy b21pdW0vREVQUworKysgYi9XZWJLaXQvY2hyb21pdW0vREVQUwpAQCAtMzIsNyArMzIsNyBAQAog CiB2YXJzID0gewogICAnY2hyb21pdW1fc3ZuJzogJ2h0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2 bi90cnVuay9zcmMnLAotICAnY2hyb21pdW1fcmV2JzogJzQ1Mjk0JywKKyAgJ2Nocm9taXVtX3Jl dic6ICc0NTUxNScsCiAKICAgJ3B0aHJlYWRzLXdpbjMyX3Jldic6ICcyNjcxNicsCiB9CmRpZmYg LS1naXQgYS9XZWJLaXQvY2hyb21pdW0vZ3lwX3dlYmtpdCBiL1dlYktpdC9jaHJvbWl1bS9neXBf d2Via2l0CmluZGV4IDNmYWE2ZDMuLjNiOGJjZDYgMTAwNzU1Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9neXBfd2Via2l0CisrKyBiL1dlYktpdC9jaHJvbWl1bS9neXBfd2Via2l0CkBAIC0zMiw3ICsz Miw2IEBACiAKIGltcG9ydCBnbG9iCiBpbXBvcnQgb3MKLWltcG9ydCBwbGF0Zm9ybQogaW1wb3J0 IHNobGV4CiBpbXBvcnQgc3lzCiAKQEAgLTc4LDcgKzc3LDcgQEAgaWYgX19uYW1lX18gPT0gJ19f bWFpbl9fJzoKICAgYXJncy5leHRlbmQoWyctSScgKyBpIGZvciBpIGluIGFkZGl0aW9uYWxfaW5j bHVkZV9maWxlcyhhcmdzKV0pCiAKICAgIyBPbiBsaW51eCwgd2Ugd2FudCBneXAgdG8gb3V0cHV0 IGEgbWFrZWZpbGUgKGRlZmF1bHQgaXMgc2NvbnMpLgotICBpZiBwbGF0Zm9ybS5zeXN0ZW0oKSA9 PSAnTGludXgnOgorICBpZiBzeXMucGxhdGZvcm0gPT0gJ0xpbnV4Mic6CiAgICAgYXJncy5leHRl bmQoWyctZm1ha2UnXSkKIAogICAjIE90aGVyIGNvbW1hbmQgYXJnczoKQEAgLTkxLDEyICs5MCw5 IEBAIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6CiAgICAgICAgICAgICAgICAjIGd5cCBoYWNr OiBvdGhlcndpc2UgZ3lwIGFzc3VtZXMgaXRzIGluIGNocm9taXVtJ3Mgc3JjLyBkaXIuCiAgICAg ICAgICAgICAgICAnLS1kZXB0aD0uLycsCiAKLSAgICAgICAgICAgICAgICMgZ3lwIGZpbGUgdG8g ZXhlY3V0ZS4KLSAgICAgICAgICAgICAgICdXZWJLaXQuZ3lwJ10pCi0KLSAgIyBHZW5lcmF0ZSBE UlQgYnVpbGQgZmlsZXMgb24gdGhlIHBsYXRmb3JtcyB0aGF0IHN1cHBvcnQgaXQuCi0gIGlmIHBs YXRmb3JtLnN5c3RlbSgpIGluICgnRGFyd2luJywgJ0xpbnV4Jyk6Ci0gICAgYXJncy5hcHBlbmQo Jy4uLy4uL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1w UmVuZGVyVHJlZS5neXAnKQorICAgICAgICAgICAgICAgIyBneXAgZmlsZXMgdG8gZXhlY3V0ZS4K KyAgICAgICAgICAgICAgICdXZWJLaXQuZ3lwJywKKyAgICAgICAgICAgICAgICcuLi8uLi9XZWJL aXRUb29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUu Z3lwJ10pCiAKICAgcHJpbnQgJ1VwZGF0aW5nIHdlYmtpdCBwcm9qZWN0cyBmcm9tIGd5cCBmaWxl cy4uLicKICAgc3lzLnN0ZG91dC5mbHVzaCgpCg== 54259 2010-04-25 23:33:30 -0700 2010-04-26 00:33:54 -0700 Proposed patch (rev.2) bug-38103-20100426153328.patch text/plain 2365 tkent ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGEzMGExNjEuLmM1NjU4YWMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDEwLTA0LTI1ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRFJUL0Nocm9t aXVtXSBFbmFibGUgV2luZG93cyBwcm9qZWN0IGdlbmVyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MTAzCisKKyAgICAgICAgLSBCdW1wIHRo ZSBDaHJvbWl1bSByZXZpc2lvbiB0byByNDU1MTUgdG8gaGF2ZSBHWVAgcjgxOCwgd2hpY2ggZml4 ZXMKKyAgICAgICAgICBhIFdpbmRvd3MgcHJvamVjdCBnZW5lcmF0aW9uIGJ1Zy4KKyAgICAgICAg LSBBdm9pZCBwbGF0Zm9ybS5zeXN0ZW0oKSwgd2hpY2ggY2F1c2VzIGEgY3Jhc2ggd2l0aCBweXRo b24uZXhlIGluCisgICAgICAgICAgZGVwb3RfdG9vbHMuIFVzZSBzeXMucGxhdGZvcm0gaW5zdGVh ZC4KKyAgICAgICAgLSBQcm9jZXNzIER1bXBSZW5kZXJUcmVlLmd5cCBvbiBhbGwgcGxhdGZvcm1z LgorCisgICAgICAgICogREVQUzoKKyAgICAgICAgKiBneXBfd2Via2l0OgorCiAyMDEwLTA0LTIz ICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0RFUFMgYi9XZWJLaXQvY2hy b21pdW0vREVQUwppbmRleCAxNWYyOTE3Li5iMTQyMGRmIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hy b21pdW0vREVQUworKysgYi9XZWJLaXQvY2hyb21pdW0vREVQUwpAQCAtMzIsNyArMzIsNyBAQAog CiB2YXJzID0gewogICAnY2hyb21pdW1fc3ZuJzogJ2h0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2 bi90cnVuay9zcmMnLAotICAnY2hyb21pdW1fcmV2JzogJzQ1Mjk0JywKKyAgJ2Nocm9taXVtX3Jl dic6ICc0NTUxNScsCiAKICAgJ3B0aHJlYWRzLXdpbjMyX3Jldic6ICcyNjcxNicsCiB9CmRpZmYg LS1naXQgYS9XZWJLaXQvY2hyb21pdW0vZ3lwX3dlYmtpdCBiL1dlYktpdC9jaHJvbWl1bS9neXBf d2Via2l0CmluZGV4IDNmYWE2ZDMuLjgxMmVkMjcgMTAwNzU1Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9neXBfd2Via2l0CisrKyBiL1dlYktpdC9jaHJvbWl1bS9neXBfd2Via2l0CkBAIC0zMiw3ICsz Miw2IEBACiAKIGltcG9ydCBnbG9iCiBpbXBvcnQgb3MKLWltcG9ydCBwbGF0Zm9ybQogaW1wb3J0 IHNobGV4CiBpbXBvcnQgc3lzCiAKQEAgLTc4LDcgKzc3LDcgQEAgaWYgX19uYW1lX18gPT0gJ19f bWFpbl9fJzoKICAgYXJncy5leHRlbmQoWyctSScgKyBpIGZvciBpIGluIGFkZGl0aW9uYWxfaW5j bHVkZV9maWxlcyhhcmdzKV0pCiAKICAgIyBPbiBsaW51eCwgd2Ugd2FudCBneXAgdG8gb3V0cHV0 IGEgbWFrZWZpbGUgKGRlZmF1bHQgaXMgc2NvbnMpLgotICBpZiBwbGF0Zm9ybS5zeXN0ZW0oKSA9 PSAnTGludXgnOgorICBpZiBzeXMucGxhdGZvcm0gPT0gJ2xpbnV4Mic6CiAgICAgYXJncy5leHRl bmQoWyctZm1ha2UnXSkKIAogICAjIE90aGVyIGNvbW1hbmQgYXJnczoKQEAgLTkxLDEyICs5MCw5 IEBAIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6CiAgICAgICAgICAgICAgICAjIGd5cCBoYWNr OiBvdGhlcndpc2UgZ3lwIGFzc3VtZXMgaXRzIGluIGNocm9taXVtJ3Mgc3JjLyBkaXIuCiAgICAg ICAgICAgICAgICAnLS1kZXB0aD0uLycsCiAKLSAgICAgICAgICAgICAgICMgZ3lwIGZpbGUgdG8g ZXhlY3V0ZS4KLSAgICAgICAgICAgICAgICdXZWJLaXQuZ3lwJ10pCi0KLSAgIyBHZW5lcmF0ZSBE UlQgYnVpbGQgZmlsZXMgb24gdGhlIHBsYXRmb3JtcyB0aGF0IHN1cHBvcnQgaXQuCi0gIGlmIHBs YXRmb3JtLnN5c3RlbSgpIGluICgnRGFyd2luJywgJ0xpbnV4Jyk6Ci0gICAgYXJncy5hcHBlbmQo Jy4uLy4uL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1w UmVuZGVyVHJlZS5neXAnKQorICAgICAgICAgICAgICAgIyBneXAgZmlsZXMgdG8gZXhlY3V0ZS4K KyAgICAgICAgICAgICAgICdXZWJLaXQuZ3lwJywKKyAgICAgICAgICAgICAgICcuLi8uLi9XZWJL aXRUb29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUu Z3lwJ10pCiAKICAgcHJpbnQgJ1VwZGF0aW5nIHdlYmtpdCBwcm9qZWN0cyBmcm9tIGd5cCBmaWxl cy4uLicKICAgc3lzLnN0ZG91dC5mbHVzaCgpCg==