37902 2010-04-20 16:39:21 -0700 REGRESSION(r57292): Safari/Win and Chromium/Win no longer pass the acid3 test. 2010-04-21 11:10:41 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC All RESOLVED FIXED InRadar P1 Normal --- 24300 1 dglazkov dglazkov abarth aroben eric hyatt jamesr mjs webkit.review.bot oldest_to_newest 215060 0 dglazkov 2010-04-20 16:39:21 -0700 The issue is in bit mis-alignment, caused by http://trac.webkit.org/browser/trunk/WebCore/rendering/style/RenderStyle.h?rev=57292#L204. Setting _insideLink to any value clobbers fields around it in weird and unanderstandable ways. 215113 1 mrowe 2010-04-20 19:40:08 -0700 <rdar://problem/7887076> 215114 2 dglazkov 2010-04-20 19:41:37 -0700 will fix tomorrow, btw. 215137 3 mjs 2010-04-20 22:31:28 -0700 MSVC likes to make enum bitfields signed. _insideLink probably just needs to be bumped up to three bits. That or the type changed from EInsideLink to unsigned. 215353 4 53962 dglazkov 2010-04-21 09:24:48 -0700 Created attachment 53962 Patch 215355 5 53962 darin 2010-04-21 09:26:44 -0700 Comment on attachment 53962 Patch The correct fix is not to make the bitfield larger. Instead we type the bitfield "unsigned" and add a comment with the type: unsigned _insideLink : 2; // EInsideLink See the line above. We might be able to change check-webkit-style to catch this. 215374 6 53966 dglazkov 2010-04-21 10:01:12 -0700 Created attachment 53966 Patch 215375 7 dglazkov 2010-04-21 10:02:08 -0700 Thanks Darin! I should've thought of this. dhyatt did all the casting for me already. 215376 8 webkit.review.bot 2010-04-21 10:04:20 -0700 Attachment 53966 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/rendering/style/RenderStyle.h:206: _insideLink is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 215393 9 dglazkov 2010-04-21 10:34:46 -0700 Landed as http://trac.webkit.org/changeset/57994. 215414 10 webkit.review.bot 2010-04-21 11:10:41 -0700 http://trac.webkit.org/changeset/57994 might have broken Qt Linux Release 53962 2010-04-21 09:24:48 -0700 2010-04-21 10:01:08 -0700 Patch bug-37902-20100421092446.patch text/plain 1434 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2I4ZWI1ZS4uYjUxNDc4ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNC0yMSAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04ocjU3MjkyKTogU2FmYXJpL1dpbiBhbmQg Q2hyb21pdW0vV2luIG5vIGxvbmdlciBwYXNzIHRoZSBhY2lkMyB0ZXN0LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc5MDIKKworICAgICAgICBUaGUg aXNzdWUgaXMgZHVlIHRvIE1TVkMgY3JlYXRpbmcgZW51bXMgYXMgc2lnbmVkIGFuZCB0aHVzIG5l ZWRpbmcgYW4gZXh0cmEgYml0CisgICAgICAgIGluIGJpdC1maWVsZCBzdHJ1Y3RzLgorCisgICAg ICAgIFRlc3Q6IGh0dHA6Ly9hY2lkMy5hY2lkdGVzdHMub3JnLworCisgICAgICAgICogcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlLmg6CisgICAgICAgIChXZWJDb3JlOjpJbmhlcml0ZWRGbGFn cyk6IEJ1bXBlZCBfaW5zaWRlTGluayB0byAzIGJpdHMuCisKIDIwMTAtMDQtMjEgIFhhbiBMb3Bl eiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFRyeSB0byBmaXggY29tcGlsYXRpb24g b24gR1RLKyBkZWJ1ZyBib3RzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUv UmVuZGVyU3R5bGUuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgKaW5k ZXggZmUzOTVhZi4uNTBmMzJjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUv UmVuZGVyU3R5bGUuaAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5o CkBAIC0yMDMsOCArMjAzLDggQEAgcHJvdGVjdGVkOgogICAgICAgICBib29sIF9odG1sSGFja3Mg OiAxOwogICAgICAgICBib29sIF9mb3JjZV9iYWNrZ3JvdW5kc190b193aGl0ZSA6IDE7CiAgICAg ICAgIHVuc2lnbmVkIF9wb2ludGVyRXZlbnRzIDogNDsgLy8gRVBvaW50ZXJFdmVudHMKLSAgICAg ICAgRUluc2lkZUxpbmsgX2luc2lkZUxpbmsgOiAyOyAvLyBXaGV0aGVyIG9yIG5vdCB3ZSBhcmUg Y29udGFpbmVkIGluc2lkZSBhIGxpbmsuCi0gICAgICAgIC8vIDQzIGJpdHMKKyAgICAgICAgRUlu c2lkZUxpbmsgX2luc2lkZUxpbmsgOiAzOyAvLyBXaGV0aGVyIG9yIG5vdCB3ZSBhcmUgY29udGFp bmVkIGluc2lkZSBhIGxpbms7IDMgYml0cyBiZWNhdXNlIE1TVkMgbWFrZXMgZW51bXMgc2lnbmVk LgorICAgICAgICAvLyA0NCBiaXRzCiAgICAgfSBpbmhlcml0ZWRfZmxhZ3M7CiAKIC8vIGRvbid0 IGluaGVyaXQK 53966 2010-04-21 10:01:12 -0700 2010-04-21 10:31:21 -0700 Patch bug-37902-20100421100111.patch text/plain 1321 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2I4ZWI1ZS4uMTIyNTQwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNC0yMSAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04ocjU3MjkyKTogU2FmYXJpL1dpbiBhbmQg Q2hyb21pdW0vV2luIG5vIGxvbmdlciBwYXNzIHRoZSBhY2lkMyB0ZXN0LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc5MDIKKworICAgICAgICBUaGUg aXNzdWUgaXMgZHVlIHRvIE1TVkMgY3JlYXRpbmcgZW51bXMgYXMgc2lnbmVkLiBUaGUgZml4IGlz IHRvIHN0b3JlIHRoZSB2YWx1ZQorICAgICAgICBhcyB1bnNpZ25lZC4KKworICAgICAgICBUZXN0 OiBodHRwOi8vYWNpZDMuYWNpZHRlc3RzLm9yZy8KKworICAgICAgICAqIHJlbmRlcmluZy9zdHls ZS9SZW5kZXJTdHlsZS5oOgorICAgICAgICAoV2ViQ29yZTo6SW5oZXJpdGVkRmxhZ3MpOiBDaGFu Z2VkIHR5cGUgb2YgX2luc2lkZUxpbmsgdG8gdW5zaWduZWQuCisKIDIwMTAtMDQtMjEgIFhhbiBM b3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFRyeSB0byBmaXggY29tcGlsYXRp b24gb24gR1RLKyBkZWJ1ZyBib3RzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvc3R5 bGUvUmVuZGVyU3R5bGUuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgK aW5kZXggZmUzOTVhZi4uYTMxOTQ5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvc3R5 bGUvUmVuZGVyU3R5bGUuaAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHls ZS5oCkBAIC0yMDMsNyArMjAzLDcgQEAgcHJvdGVjdGVkOgogICAgICAgICBib29sIF9odG1sSGFj a3MgOiAxOwogICAgICAgICBib29sIF9mb3JjZV9iYWNrZ3JvdW5kc190b193aGl0ZSA6IDE7CiAg ICAgICAgIHVuc2lnbmVkIF9wb2ludGVyRXZlbnRzIDogNDsgLy8gRVBvaW50ZXJFdmVudHMKLSAg ICAgICAgRUluc2lkZUxpbmsgX2luc2lkZUxpbmsgOiAyOyAvLyBXaGV0aGVyIG9yIG5vdCB3ZSBh cmUgY29udGFpbmVkIGluc2lkZSBhIGxpbmsuCisgICAgICAgIHVuc2lnbmVkIF9pbnNpZGVMaW5r IDogMjsgLy8gRUluc2lkZUxpbmsKICAgICAgICAgLy8gNDMgYml0cwogICAgIH0gaW5oZXJpdGVk X2ZsYWdzOwogCg==