37793 2010-04-19 01:23:37 -0700 [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt 2010-04-19 12:14:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 37645 35902 1 tkent webkit-unassigned abarth dpranke eric tony oldest_to_newest 213947 0 tkent 2010-04-19 01:23:37 -0700 [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt 213948 1 53659 tkent 2010-04-19 01:26:39 -0700 Created attachment 53659 Patch 213949 2 53659 eric 2010-04-19 01:29:16 -0700 Comment on attachment 53659 Patch User.open_url is probably better than calling webbrowser directly: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/user.py#L81 it allows us to more easily mock out this code for testing. This is a rather strange class inversion. I guess eventually Chromium will be a subclass of WebKitPort. 213950 3 eric 2010-04-19 01:29:44 -0700 Seems maybe we should have called them TestShellDriver and DumpRenderTreeDriver. 213951 4 53659 eric 2010-04-19 01:31:02 -0700 Comment on attachment 53659 Patch I guess ChromiumPort may not have access to a tool object, which would expose the User() object, so this is probably the best we have for now. 213956 5 53659 tkent 2010-04-19 01:41:03 -0700 Comment on attachment 53659 Patch Clearing flags on attachment: 53659 Committed r57806: <http://trac.webkit.org/changeset/57806> 213957 6 tkent 2010-04-19 01:41:13 -0700 All reviewed patches have been landed. Closing bug. 214093 7 dpranke 2010-04-19 10:36:40 -0700 (In reply to comment #2) > (From update of attachment 53659 [details]) > User.open_url is probably better than calling webbrowser directly: > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/user.py#L81 > it allows us to more easily mock out this code for testing. > > This is a rather strange class inversion. I guess eventually Chromium will be > a subclass of WebKitPort. If this were to become the case, then WebKitPort should probably be merged into port/base.py. It is useful to think of base.py as declaring an interface, but it really is a base class. The only other implementations that wouldn't inherit from WebKitPort would be the testing/mock classes, and they can override whatever they need do. 214156 8 eric 2010-04-19 12:14:10 -0700 I agree that I think eventually we'll push more code down into base instead of WebKitPort or ChromiumPort. 53659 2010-04-19 01:26:39 -0700 2010-04-19 01:41:03 -0700 Patch bug-37793-20100419172637.patch text/plain 2072 tkent ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0MWJhZTgzLi42Y2Y3NjkwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQt MTkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gbmV3LXJ1bi13ZWJraXQt dGVzdHMgc2hvdWxkIHVzZSBXZWJLaXREcml2ZXIgZm9yIC0tdXNlLWRydAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc3OTMKKworICAgICAgICBXZSBu ZWVkIHRvIHVzZSBXZWJLaXREcml2ZXIgaW5zdGVhZCBvZiBDaHJvbWl1bURyaXZlciBmb3IgQ2hy b21pdW0KKyAgICAgICAgRFJUIGJlY2F1c2UgaXRzIGludGVyZmFjZSBpcyBkaWZmZXJlbnQgZnJv bSB0ZXN0X3NoZWxsLgorCisgICAgICAgIENocm9taXVtIERSVCBoYXMgbm8gVUkuICBTbyB3ZSBj YW4ndCB1c2UgaXQgdG8gc2hvdyB0ZXN0IHJlc3VsdHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5OgorCiAyMDEwLTA0LTE4ICBDaHJp cyBKZXJkb25layAgPGNqZXJkb25la0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNoaW5pY2hpcm8gSGFtYWppLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKaW5kZXggYTU0OTkyNi4uYjg4 YjZhMyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9jaHJvbWl1bS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CkBAIC0zNiw5ICszNiwxMSBAQCBpbXBvcnQgc2ln bmFsCiBpbXBvcnQgc3VicHJvY2VzcwogaW1wb3J0IHN5cwogaW1wb3J0IHRpbWUKK2ltcG9ydCB3 ZWJicm93c2VyCiAKIGltcG9ydCBiYXNlCiBpbXBvcnQgaHR0cF9zZXJ2ZXIKK2ltcG9ydCB3ZWJr aXQKIGltcG9ydCB3ZWJzb2NrZXRfc2VydmVyCiAKIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcigi d2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQuY2hyb21pdW0iKQpAQCAtMTUwLDExICsxNTIsMTYg QEAgY2xhc3MgQ2hyb21pdW1Qb3J0KGJhc2UuUG9ydCk6CiAgICAgICAgICAgICBzaHV0aWwucm10 cmVlKGNhY2hlZGlyKQogCiAgICAgZGVmIHNob3dfcmVzdWx0c19odG1sX2ZpbGUoc2VsZiwgcmVz dWx0c19maWxlbmFtZSk6Ci0gICAgICAgIHN1YnByb2Nlc3MuUG9wZW4oW3NlbGYuX3BhdGhfdG9f ZHJpdmVyKCksCi0gICAgICAgICAgICAgICAgICAgICAgICAgIHNlbGYuZmlsZW5hbWVfdG9fdXJp KHJlc3VsdHNfZmlsZW5hbWUpXSkKKyAgICAgICAgdXJpID0gc2VsZi5maWxlbmFtZV90b191cmko cmVzdWx0c19maWxlbmFtZSkKKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy51c2VfZHJ0OgorICAg ICAgICAgICAgd2ViYnJvd3Nlci5vcGVuKHVyaSwgbmV3PTEpCisgICAgICAgIGVsc2U6CisgICAg ICAgICAgICBzdWJwcm9jZXNzLlBvcGVuKFtzZWxmLl9wYXRoX3RvX2RyaXZlcigpLCB1cmldKQog CiAgICAgZGVmIHN0YXJ0X2RyaXZlcihzZWxmLCBpbWFnZV9wYXRoLCBvcHRpb25zKToKICAgICAg ICAgIiIiU3RhcnRzIGEgbmV3IERyaXZlciBhbmQgcmV0dXJucyBhIGhhbmRsZSB0byBpdC4iIiIK KyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy51c2VfZHJ0OgorICAgICAgICAgICAgcmV0dXJuIHdl YmtpdC5XZWJLaXREcml2ZXIoc2VsZiwgaW1hZ2VfcGF0aCwgb3B0aW9ucykKICAgICAgICAgcmV0 dXJuIENocm9taXVtRHJpdmVyKHNlbGYsIGltYWdlX3BhdGgsIG9wdGlvbnMpCiAKICAgICBkZWYg c3RhcnRfaGVscGVyKHNlbGYpOgo=