37763 2010-04-17 21:19:50 -0700 Compile Error in MathML-enabled build (r57788) 2010-04-21 20:47:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 37765 3251 0 distler webkit-unassigned alex commit-queue eric oldest_to_newest 213708 0 distler 2010-04-17 21:19:50 -0700 Building the latest WebKit with the '--mathml' flag yields a compilation error. The file that fails to compile is 'RenderMathMLOperator.cpp': src/WebKit/WebCore/mathml/RenderMathMLOperator.cpp: In member function 'virtual void WebCore::RenderMathMLOperator::updateFromElement()': src/WebKit/WebCore/mathml/RenderMathMLOperator.cpp:196: error: no matching function for call to 'WebCore::StringImpl::create(WebCore::String)' src/WebKit/WebCore/platform/text/StringImpl.h:135: note: candidates are: static WTF::PassRefPtr<WebCore::StringImpl> WebCore::StringImpl::create(const UChar*, unsigned int) src/WebKit/WebCore/platform/text/StringImpl.h:136: note: static WTF::PassRefPtr<WebCore::StringImpl> WebCore::StringImpl::create(const char*, unsigned int) src/WebKit/WebCore/platform/text/StringImpl.h:137: note: static WTF::PassRefPtr<WebCore::StringImpl> WebCore::StringImpl::create(const char*) src/WebKit/WebCore/platform/text/StringImpl.h:138: note: static WTF::PassRefPtr<WebCore::StringImpl> WebCore::StringImpl::create(const UChar*, unsigned int, WTF::PassRefPtr<WTF::CrossThreadRefCounted<WTF::OwnFastMallocPtr<const short unsigned int> > >) PhaseScriptExecution "Check For Inappropriate Files In Framework" /Users/distler/src/WebkitBuild/WebCore.build/Release/WebCore.build/Script-5DF50887116F3077005202AB.sh 213711 1 distler 2010-04-17 21:37:08 -0700 Related, presumably, to changes in Revision 57748. 213759 2 53629 sausset 2010-04-18 08:09:30 -0700 Created attachment 53629 Proposed patch Fix to match the "StringImpl" changes. 214070 3 53629 commit-queue 2010-04-19 09:59:00 -0700 Comment on attachment 53629 Proposed patch Rejecting patch 53629 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53629', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: ', 'commit', '--all', '-F', '-'], input=message) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 85, in run_command return Executive().run_command(*args, **kwargs) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 186, in run_command string_to_communicate = str(input) UnicodeEncodeError: 'ascii' codec can't encode character u'\xe7' in position 16: ordinal not in range(128) 214167 4 eric 2010-04-19 12:26:13 -0700 Sorry, you were bitten by bug 37765. Hopefully I'll land that today and we'll re-queue this. 214896 5 53629 eric 2010-04-20 12:58:01 -0700 Comment on attachment 53629 Proposed patch Sorry again for the trouble. 215229 6 53629 eric 2010-04-21 03:49:08 -0700 Comment on attachment 53629 Proposed patch The fix for bug 37765 was rolled out. So this will fail to land. Hopefully I'll reland the fix tomorrow at which point I'll cq+ this again. 215530 7 53629 eric 2010-04-21 15:12:45 -0700 Comment on attachment 53629 Proposed patch Fixed again. 215674 8 53629 commit-queue 2010-04-21 20:47:38 -0700 Comment on attachment 53629 Proposed patch Clearing flags on attachment: 53629 Committed r58049: <http://trac.webkit.org/changeset/58049> 215675 9 commit-queue 2010-04-21 20:47:43 -0700 All reviewed patches have been landed. Closing bug. 53629 2010-04-18 08:09:30 -0700 2010-04-21 20:47:38 -0700 Proposed patch MathML_mo.patch text/plain 1484 sausset SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Nzc5NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMTggIEZyYW7Dp29pcyBTYXVzc2V0ICA8c2F1c3NldEBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4IHRvIHRha2UgaW50byBhY2NvdW50IGEgY2hhbmdlIG1hZGUgaW4gIlN0cmluZ0ltcGwi LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc3NjMK KworICAgICAgICAqIG1hdGhtbC9SZW5kZXJNYXRoTUxPcGVyYXRvci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJNYXRoTUxPcGVyYXRvcjo6dXBkYXRlRnJvbUVsZW1lbnQpOgorCiAyMDEw LTA0LTE3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJDb3JlL21hdGhtbC9SZW5kZXJNYXRoTUxP cGVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9tYXRobWwvUmVuZGVyTWF0aE1MT3Bl cmF0b3IuY3BwCShyZXZpc2lvbiA1Nzc4MykKKysrIFdlYkNvcmUvbWF0aG1sL1JlbmRlck1hdGhN TE9wZXJhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkzLDcgKzE5Myw3IEBAIHZvaWQgUmVu ZGVyTWF0aE1MT3BlcmF0b3I6OnVwZGF0ZUZyb21FbGUKICAgICAgICAgICAgIHRleHQgPSBuZXcg KHJlbmRlckFyZW5hKCkpIFJlbmRlclRleHQobm9kZSgpLCBTdHJpbmdJbXBsOjpjcmVhdGUoJm1f b3BlcmF0b3IsIDEpKTsKICAgICAgICAgZWxzZSBpZiAobm9kZSgpLT5ub2RlVHlwZSgpID09IE5v ZGU6OkVMRU1FTlRfTk9ERSkKICAgICAgICAgICAgIGlmIChFbGVtZW50KiBtbyA9IHN0YXRpY19j YXN0PEVsZW1lbnQqPihub2RlKCkpKQotICAgICAgICAgICAgICAgIHRleHQgPSBuZXcgKHJlbmRl ckFyZW5hKCkpIFJlbmRlclRleHQobm9kZSgpLCBTdHJpbmdJbXBsOjpjcmVhdGUobW8tPnRleHRD b250ZW50KCkpKTsKKyAgICAgICAgICAgICAgICB0ZXh0ID0gbmV3IChyZW5kZXJBcmVuYSgpKSBS ZW5kZXJUZXh0KG5vZGUoKSwgU3RyaW5nSW1wbDo6Y3JlYXRlKG1vLT50ZXh0Q29udGVudCgpLmNo YXJhY3RlcnMoKSwgbW8tPnRleHRDb250ZW50KCkubGVuZ3RoKCkpKTsKICAgICAgICAgLy8gSWYg d2UgY2FuJ3QgZmlndXJlIG91dCB0aGUgdGV4dCwgbGVhdmUgaXQgYmxhbmsuCiAgICAgICAgIGlm ICh0ZXh0KSB7CiAgICAgICAgICAgICB0ZXh0LT5zZXRTdHlsZShjb250YWluZXItPnN0eWxlKCkp Owo=