3771 2005-06-30 02:34:51 -0700 GW: Update create_hash_table closer to TOT KJS 2005-07-01 03:03:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 412 Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 3250 1 eric eric oldest_to_newest 13533 0 eric 2005-06-30 02:34:51 -0700 This update brings support for the -n <namespace> addition as part of KDOM This also (more importantly) adds support for for parsing more recent hashtable comments (w/o affecting support for exiting comments). The only change left to merge into this file form TOT KJS is support for the separate "string tables" lookup for better hashtable memory locality (and possibly perf improvements. That merger will have to be covered by another bug. 13534 1 2712 eric 2005-06-30 02:36:09 -0700 Created attachment 2712 relatively simple patch, which adds support to create_hash_table as detailed in the bug 13536 2 2712 eric 2005-06-30 03:04:31 -0700 Comment on attachment 2712 relatively simple patch, which adds support to create_hash_table as detailed in the bug verified all test cases pass 13546 3 2712 darin 2005-06-30 08:23:09 -0700 Comment on attachment 2712 relatively simple patch, which adds support to create_hash_table as detailed in the bug I'd prefer to roll in the "string tables" change at the same time, myself. I'm also not fond of comments that say "NEW", since they inevitably become "OLD" :-) I also don't like checking in commented-out debugging code. And it's very strange to use this: ".$nameEntries." when you one could just have said: $nameEntries But these are minor quibbles -- seems fine to land this. 13591 4 eric 2005-07-01 03:03:51 -0700 I removed the "NEW: " comment when committing. 2712 2005-06-30 02:36:09 -0700 2005-06-30 08:23:09 -0700 relatively simple patch, which adds support to create_hash_table as detailed in the bug create_hash_table.patch text/plain 4316 eric SW5kZXg6IC4va2pzL2NyZWF0ZV9oYXNoX3RhYmxlCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv cm9vdC9KYXZhU2NyaXB0Q29yZS9ranMvY3JlYXRlX2hhc2hfdGFibGUsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuNApkaWZmIC1wIC11IC1yMS40IC4va2pzL2NyZWF0ZV9oYXNoX3RhYmxlCi0tLSAu L2tqcy9jcmVhdGVfaGFzaF90YWJsZQkyMDAzLzEwLzA2IDE1OjUwOjEyCTEuNAorKysgLi9ranMv Y3JlYXRlX2hhc2hfdGFibGUJMjAwNS8wNi8zMCAwOToyOTo1MgpAQCAtNCw2ICs0LDcgQEAKICMK ICMgKGMpIDIwMDAtMjAwMiBieSBIYXJyaSBQb3J0ZW4gPHBvcnRlbkBrZGUub3JnPiBhbmQKICMg ICAgICAgICAgICAgICAgICBEYXZpZCBGYXVyZSA8ZmF1cmVAa2RlLm9yZz4KKyMgTW9kaWZpZWQg KGMpIDIwMDQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uIDx3aWxkZm94QGtkZS5vcmc+CiAKICRmaWxl ID0gJEFSR1ZbMF07CiBzaGlmdDsKQEAgLTEzLDYgKzE0LDEwIEBAIG15ICRpbmNsdWRlbG9va3Vw ID0gMDsKICRmaW5kU2l6ZSA9IDEgaWYgKGRlZmluZWQoJEFSR1ZbMF0pICYmICRBUkdWWzBdIGVx ICItcyIpOwogIyBVc2UgLWkgYXMgc2Vjb25kIGFyZ3VtZW50IHRvIG1ha2UgaXQgaW5jbHVkZSAi bG9va3VwLmgiCiAkaW5jbHVkZWxvb2t1cCA9IDEgaWYgKGRlZmluZWQoJEFSR1ZbMF0pICYmICRB UkdWWzBdIGVxICItaSIpOworIyBORVc6IFVzZSAtbiBhcyBzZWNvbmQgYXJndW1lbnQgdG8gbWFr ZSBpdCB1c2UgdGhlIHRoaXJkCisjICAgICAgYXJndW1lbnQgYXMgbmFtZXNwYWNlIHBhcmFtZXRl ciBpZS4gLW4gS0RPTQorJHVzZU5hbWVTcGFjZSA9ICRBUkdWWzFdIGlmIChkZWZpbmVkKCRBUkdW WzBdKSAmJiAkQVJHVlswXSBlcSAiLW4iKTsKKwogcHJpbnQgU1RERVJSICJDcmVhdGluZyBoYXNo dGFibGUgZm9yICRmaWxlXG4iOwogb3BlbihJTiwgJGZpbGUpIG9yIGRpZSAiTm8gc3VjaCBmaWxl ICRmaWxlIjsKIApAQCAtMzUsMTAgKzQwLDE0IEBAIHdoaWxlICg8SU4+KSB7CiAgIHMvXlxzKi8v ZzsKICAgaWYgKC9eXCN8XiQvKSB7CiAgICAgICAjIGNvbW1lbnQuIGRvIG5vdGhpbmcKLSAgICB9 IGVsc2lmICgvXlxAYmVnaW5ccyooXHcrKVxzKihcZCspXHMqJC8gJiYgISRpbnNpZGUpIHsKLSAg ICAgICRpbnNpZGUgPSAxOwotICAgICAgJG5hbWUgPSAkMTsKLSAgICAgICRoYXNoc2l6ZSA9ICQy OworICAgIH0gZWxzaWYgKC9eXEBiZWdpbi8gJiYgISRpbnNpZGUpIHsKKyAgICAgIGlmICgvXlxA YmVnaW5ccyooWzpfXHddKylccyooXGQrKVxzKiQvKSB7CisgICAgICAgICRpbnNpZGUgPSAxOwor ICAgICAgICAkbmFtZSA9ICQxOworICAgICAgICAkaGFzaHNpemUgPSAkMjsKKyAgICAgIH0gZWxz ZSB7CisgICAgICAgICBwcmludGYgU1RERVJSICJXQVJOSU5HOiBcQGJlZ2luIHdpdGhvdXQgdGFi bGUgbmFtZSBhbmQgaGFzaHNpemUsIHNraXBwaW5nICRfXG4iOworICAgICAgfQogICAgIH0gZWxz aWYgKC9eXEBlbmRccyokLyAmJiAkaW5zaWRlKSB7CiAKICAgICAgIGlmKCRmaW5kU2l6ZSkgewpA QCAtNTUsNyArNjQsNyBAQCB3aGlsZSAoPElOPikgewogICAgICAgQGF0dHJzID0gKCk7CiAgICAg ICBAcGFyYW1zID0gKCk7CiAgICAgICAkaW5zaWRlID0gMDsKLSAgICB9IGVsc2lmICgvXihbXHdc W1w9XF1dKylccyooW1x3XDotXSspXHMqKFtcd1x8XSopXHMqKFx3KilccyokLyAmJiAkaW5zaWRl KSB7CisJfSBlbHNpZiAoL14oWy06XEBcd1xbXD1cXV0rKVxzKihbXHdcOi1dKylccyooW1x3XHxd KilccyooXHcqKVxzKiQvICYmICRpbnNpZGUpIHsKICAgICAgIG15ICRrZXkgPSAkMTsKICAgICAg IG15ICR2YWwgPSAkMjsKICAgICAgIG15ICRhdHQgPSAkMzsKQEAgLTk0LDExICsxMDMsMTggQEAg c3ViIGNhbGNUYWJsZSgpIHsKIAkkc2l6ZSsrOwogICAgICAgfQogICAgIH0KKyAgICAjcHJpbnQg U1RERVJSICJ0YWJsZVskaF0gPSAkaVxuIjsKICAgICAkdGFibGVbJGhdID0gJGk7CiAgICAgJGkr KzsKICAgICAkbWF4ZGVwdGggPSAkZGVwdGggaWYgKCAkZGVwdGggPiAkbWF4ZGVwdGgpOwogICB9 CiAKKyAgIyBFbnN1cmUgdGFibGUgaXMgYmlnIGVub3VnaCAoaW4gY2FzZSBvZiB1bmRlZiBlbnRy aWVzIGF0IHRoZSBlbmQpCisgIGlmICggJCN0YWJsZSsxIDwgJHNpemUgKSB7CisgICAgJCN0YWJs ZSA9ICRzaXplLTE7CisgIH0KKyAgI3ByaW50IFNUREVSUiAiQWZ0ZXIgbG9vcDogc2l6ZT0kc2l6 ZSB0YWJsZT0iLigkI3RhYmxlKzEpLiJcbiI7CisKICAgaWYgKCRmaW5kU2l6ZSkgewogICAgIG15 ICRlbXB0eWNvdW50ID0gMDsKICAgICBmb3JlYWNoICRlbnRyeSAoQHRhYmxlKSB7CkBAIC0xMDYs MTIgKzEyMiwxMiBAQCBzdWIgY2FsY1RhYmxlKCkgewogICAgIH0KICAgICBwcmludCBTVERFUlIg Ikhhc2hzaXplOiAkaGFzaHNpemUgIFRvdGFsIFNpemU6ICRzaXplIEVtcHR5OiAkZW1wdHljb3Vu dCBNYXhEZXB0aDogJG1heGRlcHRoIENvbGxpc2lvbnM6ICRjb2xsaXNpb25zXG4iOwogICB9Ci0j ICBteSAkaSA9IDA7CisjICBteSAkZGVidWd0YWJsZSA9IDA7CiAjICBmb3JlYWNoICRlbnRyeSAo QHRhYmxlKSB7Ci0jICAgIHByaW50ICIkaSAiIC4gJGVudHJ5OwotIyAgICBwcmludCAiIC0+ICIg LiAkbGlua3NbJGldIGlmIChkZWZpbmVkKCRsaW5rc1skaV0pKTsKLSMgICAgcHJpbnQgIlxuIjsK LSMgICAgJGkrKzsKKyMgICAgcHJpbnQgU1RERVJSICIkZGVidWd0YWJsZSAiIC4gKGRlZmluZWQg JGVudHJ5ID8gJGVudHJ5IDogJzx1bmRlZmluZWQ+Jyk7CisjICAgIHByaW50IFNUREVSUiAiIC0+ ICIgLiAkbGlua3NbJGRlYnVndGFibGVdIGlmIChkZWZpbmVkKCRsaW5rc1skZGVidWd0YWJsZV0p KTsKKyMgICAgcHJpbnQgU1RERVJSICJcbiI7CisjICAgICRkZWJ1Z3RhYmxlKys7CiAjICB9CiB9 CiAKQEAgLTEzMCwxMCArMTQ2LDE5IEBAIHN1YiBvdXRwdXQoKSB7CiAgICAgcHJpbnQgIi8qIEF1 dG9tYXRpY2FsbHkgZ2VuZXJhdGVkIGZyb20gJGZpbGUgdXNpbmcgJDAuIERPIE5PVCBFRElUICEg Ki9cbiI7CiAgIH0KIAorICBteSAkbmFtZUVudHJpZXMgPSAiJHtuYW1lfUVudHJpZXMiOworICAk bmFtZUVudHJpZXMgPX4gcy86L18vZzsKKwogICBwcmludCAiXG4jaW5jbHVkZSBcImxvb2t1cC5o XCJcbiIgaWYgKCRpbmNsdWRlbG9va3VwKTsKLSAgcHJpbnQgIlxubmFtZXNwYWNlIEtKUyB7XG4i OwotICBwcmludCAiXG5jb25zdCBzdHJ1Y3QgSGFzaEVudHJ5ICR7bmFtZX1FbnRyaWVzW10gPSB7 XG4iOworICBpZiAoJHVzZU5hbWVTcGFjZSkgeworICAgIHByaW50ICJcbm5hbWVzcGFjZSAke3Vz ZU5hbWVTcGFjZX1cbntcbiI7CisgICAgcHJpbnQgIlxudXNpbmcgbmFtZXNwYWNlIEtKUzsiOwor ICB9IGVsc2UgeworICAgIHByaW50ICJcbm5hbWVzcGFjZSBLSlMge1xuIjsKKyAgfQorICBwcmlu dCAiXG5zdGF0aWMgY29uc3Qgc3RydWN0IEhhc2hFbnRyeSAiLiRuYW1lRW50cmllcy4iW10gPSB7 XG4iOwogICBteSAkaSA9IDA7CisgICNwcmludCBTVERFUlIgIndyaXRpbmcgb3V0IHRhYmxlIHdp dGggIi4oJCN0YWJsZSsxKS4iIGVudHJpZXNcbiI7CiAgIGZvcmVhY2ggJGVudHJ5IChAdGFibGUp IHsKICAgICBpZiAoZGVmaW5lZCgkZW50cnkpKSB7CiAgICAgICBteSAka2V5ID0gJGtleXNbJGVu dHJ5XTsKQEAgLTE0Myw3ICsxNjgsNyBAQCBzdWIgb3V0cHV0KCkgewogICAgICAgcHJpbnQgIiwg IiAuICRwYXJhbXNbJGVudHJ5XTsKICAgICAgIHByaW50ICIsICI7CiAgICAgICBpZiAoZGVmaW5l ZCgkbGlua3NbJGldKSkgewotCXByaW50ICImJHtuYW1lfUVudHJpZXNbJGxpbmtzWyRpXV0iIC4g IiBcfSI7CisJcHJpbnQgIiYke25hbWVFbnRyaWVzfVskbGlua3NbJGldXSIgLiAiIFx9IjsKICAg ICAgIH0gZWxzZSB7CiAJcHJpbnQgIjAgXH0iCiAgICAgICB9CkBAIC0xNTQsOCArMTc5LDggQEAg c3ViIG91dHB1dCgpIHsKICAgICBwcmludCAiXG4iOwogICAgICRpKys7CiAgIH0KLSAgcHJpbnQg In07XG4iOwotICBwcmludCAiXG5jb25zdCBzdHJ1Y3QgSGFzaFRhYmxlICRuYW1lID0gIjsKLSAg cHJpbnQgIlx7IDIsICRzaXplLCAke25hbWV9RW50cmllcywgJGhhc2hzaXplIFx9O1xuXG4iOwor ICBwcmludCAifTtcblxuIjsKKyAgcHJpbnQgImNvbnN0IHN0cnVjdCBIYXNoVGFibGUgJG5hbWUg PSAiOworICBwcmludCAiXHsgMiwgJHNpemUsICIuJG5hbWVFbnRyaWVzLiIsICRoYXNoc2l6ZSBc fTtcblxuIjsKICAgcHJpbnQgIn0gLy8gbmFtZXNwYWNlXG4iOwogfQo=