37598 2010-04-14 12:57:28 -0700 [Qt] tst_QScriptValue::toString has a memory leak. 2010-04-14 19:58:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt P1 Normal --- 31863 1 jedrzej.nowacki jedrzej.nowacki commit-queue jedrzej.nowacki kenneth kent.hansen oldest_to_newest 212508 0 jedrzej.nowacki 2010-04-14 12:57:28 -0700 Valgrind report a memory leak inside the QScriptValue::toString autotest. It seems that a temporary variable is not released. ==5038== at 0x4C221A7: malloc (vg_replace_malloc.c:195) ==5038== by 0x50BCB38: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:249) ==5038== by 0x50072DD: WTF::FastAllocBase::operator new(unsigned long) (FastAllocBase.h:96) ==5038== by 0x5020833: OpaqueJSString::create(unsigned short const*, unsigned int) (OpaqueJSString.h:45) ==5038== by 0x5020493: JSStringCreateWithUTF8CString (JSStringRef.cpp:50) ==5038== by 0x4FFFF34: QScriptConverter::toString(QString const&) (qscriptconverter_p.h:59) ==5038== by 0x50000C1: QScriptEnginePrivate::makeJSValue(QString const&) const (qscriptengine_p.h:112) ==5038== by 0x50036C1: QScriptValuePrivate::QScriptValuePrivate(QScriptEngine const*, QString const&) (qscriptvalue_p.h:284) ==5038== by 0x5001CE1: QScriptValue::QScriptValue(QScriptEngine*, QString const&) (qscriptvalue.cpp:162) ==5038== by 0x414952: tst_QScriptValue::initScriptValues() (tst_qscriptvalue_generated.cpp:112) ==5038== by 0x41F8CC: tst_QScriptValue::toString_initData() (tst_qscriptvalue_generated.cpp:667) ==5038== by 0x405C0E: tst_QScriptValue::dataHelper(void (tst_QScriptValue::*)(), void (tst_QScriptValue::*)(char const*)) (tst_qscriptvalue.cpp:36) 212538 1 53360 jedrzej.nowacki 2010-04-14 13:36:44 -0700 Created attachment 53360 Fix v1 212709 2 53360 commit-queue 2010-04-14 19:58:21 -0700 Comment on attachment 53360 Fix v1 Clearing flags on attachment: 53360 Committed r57625: <http://trac.webkit.org/changeset/57625> 212710 3 commit-queue 2010-04-14 19:58:26 -0700 All reviewed patches have been landed. Closing bug. 53360 2010-04-14 13:36:44 -0700 2010-04-14 19:58:21 -0700 Fix v1 memleak.diff text/plain 1505 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAyODk5MTA4Li4zYzRiNzcxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjAg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBGaXgg bWVtb3J5IGxlYWsgaW5zaWRlIFFTY3JpcHRFbmdpbmVQcml2YXRlOjptYWtlSlNWYWx1ZS4KKwor ICAgICAgICBRU2NyaXB0RW5naW5lUHJpdmF0ZTo6bWFrZUpTVmFsdWUgc2hvdWxkIHJlbGVhc2Ug dGVtcG9yYXJ5IEpTU3RyaW5nUmVmIHZhcmlhYmxlLgorCisgICAgICAgIFtRdF0gdHN0X1FTY3Jp cHRWYWx1ZTo6dG9TdHJpbmcgaGFzIGEgbWVtb3J5IGxlYWsuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzU5OAorCisgICAgICAgICogcXQvYXBpL3Fz Y3JpcHRlbmdpbmVfcC5oOgorICAgICAgICAoUVNjcmlwdEVuZ2luZVByaXZhdGU6Om1ha2VKU1Zh bHVlKToKKworMjAxMC0wNC0xNCAgSmVkcnplaiBOb3dhY2tpICA8amVkcnplai5ub3dhY2tpQG5v a2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAg ICBGaXggbWVtb3J5IGxlYWsgaW4gUVNjcmlwdEVuZ2luZTo6ZXZhbHVhdGUoKS4KIAogICAgICAg ICBRU2NyaXB0RW5naW5lUHJpdmF0ZTo6ZXZhbHVhdGUgc2hvdWxkIHJlbGVhc2UgdGVtcG9yYXJ5 IHZhcmlhYmxlcy4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0ZW5n aW5lX3AuaCBiL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0ZW5naW5lX3AuaAppbmRleCBm Mjk1NzY2Li4zMjQ0MmQ3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlw dGVuZ2luZV9wLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5o CkBAIC0xMDksNyArMTA5LDEwIEBAIEpTVmFsdWVSZWYgUVNjcmlwdEVuZ2luZVByaXZhdGU6Om1h a2VKU1ZhbHVlKHVpbnQgbnVtYmVyKSBjb25zdAogCiBKU1ZhbHVlUmVmIFFTY3JpcHRFbmdpbmVQ cml2YXRlOjptYWtlSlNWYWx1ZShjb25zdCBRU3RyaW5nJiBzdHJpbmcpIGNvbnN0CiB7Ci0gICAg cmV0dXJuIEpTVmFsdWVNYWtlU3RyaW5nKG1fY29udGV4dCwgUVNjcmlwdENvbnZlcnRlcjo6dG9T dHJpbmcoc3RyaW5nKSk7CisgICAgSlNTdHJpbmdSZWYgdG1wID0gUVNjcmlwdENvbnZlcnRlcjo6 dG9TdHJpbmcoc3RyaW5nKTsKKyAgICBKU1ZhbHVlUmVmIHJlc3VsdCA9IEpTVmFsdWVNYWtlU3Ry aW5nKG1fY29udGV4dCwgdG1wKTsKKyAgICBKU1N0cmluZ1JlbGVhc2UodG1wKTsKKyAgICByZXR1 cm4gcmVzdWx0OwogfQogCiBKU1ZhbHVlUmVmIFFTY3JpcHRFbmdpbmVQcml2YXRlOjptYWtlSlNW YWx1ZShib29sIHZhbHVlKSBjb25zdAo=