37596 2010-04-14 12:30:17 -0700 [Qt] QScriptEngine::evaluate has memory leak. 2010-04-15 02:54:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt P1 Normal --- 31863 1 jedrzej.nowacki jedrzej.nowacki commit-queue jedrzej.nowacki kenneth kent.hansen oldest_to_newest 212493 0 jedrzej.nowacki 2010-04-14 12:30:17 -0700 Method QScriptValuePrivate* QScriptEnginePrivate::evaluate(const QString& program, const QString& fileName, int lineNumber) creates two temporary values, but it doesn't release them. That produces memory leak. 212498 1 53353 jedrzej.nowacki 2010-04-14 12:36:20 -0700 Created attachment 53353 Fix v1 212633 2 53353 kenneth 2010-04-14 16:01:01 -0700 Comment on attachment 53353 Fix v1 > + Evaluates given JavaScript program and returns result of the evaluation. > + \attention this function doesn't take parameters ownership. this function doesn't take ownership of the parameters. 212658 3 53385 jedrzej.nowacki 2010-04-14 16:54:01 -0700 Created attachment 53385 Fix v2 Done 212792 4 53385 commit-queue 2010-04-15 02:53:59 -0700 Comment on attachment 53385 Fix v2 Clearing flags on attachment: 53385 Committed r57637: <http://trac.webkit.org/changeset/57637> 212793 5 commit-queue 2010-04-15 02:54:04 -0700 All reviewed patches have been landed. Closing bug. 53353 2010-04-14 12:36:20 -0700 2010-04-14 16:54:01 -0700 Fix v1 memleak.diff text/plain 2006 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA0YTdiNGQ1Li4yODk5MTA4IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTAtMDQtMTQgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IG1lbW9yeSBsZWFrIGluIFFTY3JpcHRFbmdpbmU6OmV2YWx1YXRlKCkuCisKKyAgICAgICAgUVNj cmlwdEVuZ2luZVByaXZhdGU6OmV2YWx1YXRlIHNob3VsZCByZWxlYXNlIHRlbXBvcmFyeSB2YXJp YWJsZXMuCisKKyAgICAgICAgW1F0XSBRU2NyaXB0RW5naW5lOjpldmFsdWF0ZSBoYXMgbWVtb3J5 IGxlYWsuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z NzU5NgorCisgICAgICAgICogcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5jcHA6CisgICAgICAgIChR U2NyaXB0RW5naW5lUHJpdmF0ZTo6ZXZhbHVhdGUpOgorICAgICAgICAqIHF0L2FwaS9xc2NyaXB0 ZW5naW5lX3AuaDoKKwogMjAxMC0wMy0yNSAgSmVkcnplaiBOb3dhY2tpICA8amVkcnplai5ub3dh Y2tpQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0ZW5naW5lX3AuY3BwIGIvSmF2 YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5jcHAKaW5kZXggOTVjZmE0NS4uODcz ZTdiNSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5j cHAKKysrIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5jcHAKQEAgLTU2 LDcgKzU2LDEwIEBAIFFTY3JpcHRWYWx1ZVByaXZhdGUqIFFTY3JpcHRFbmdpbmVQcml2YXRlOjpl dmFsdWF0ZShjb25zdCBRU3RyaW5nJiBwcm9ncmFtLCBjb25zCiB7CiAgICAgSlNTdHJpbmdSZWYg c2NyaXB0ID0gUVNjcmlwdENvbnZlcnRlcjo6dG9TdHJpbmcocHJvZ3JhbSk7CiAgICAgSlNTdHJp bmdSZWYgZmlsZSA9IFFTY3JpcHRDb252ZXJ0ZXI6OnRvU3RyaW5nKGZpbGVOYW1lKTsKLSAgICBy ZXR1cm4gbmV3IFFTY3JpcHRWYWx1ZVByaXZhdGUodGhpcywgZXZhbHVhdGUoc2NyaXB0LCBmaWxl LCBsaW5lTnVtYmVyKSk7CisgICAgUVNjcmlwdFZhbHVlUHJpdmF0ZSogcmVzdWx0ID0gbmV3IFFT Y3JpcHRWYWx1ZVByaXZhdGUodGhpcywgZXZhbHVhdGUoc2NyaXB0LCBmaWxlLCBsaW5lTnVtYmVy KSk7CisgICAgSlNTdHJpbmdSZWxlYXNlKHNjcmlwdCk7CisgICAgSlNTdHJpbmdSZWxlYXNlKGZp bGUpOworICAgIHJldHVybiByZXN1bHQ7CiB9CiAKIC8qIQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw dENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5oIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3Fz Y3JpcHRlbmdpbmVfcC5oCmluZGV4IDY2ZjU1ODMuLmYyOTU3NjYgMTAwNjQ0Ci0tLSBhL0phdmFT Y3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0ZW5naW5lX3AuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9x dC9hcGkvcXNjcmlwdGVuZ2luZV9wLmgKQEAgLTY3LDYgKzY3LDExIEBAIHByaXZhdGU6CiB9Owog CiAKKy8qIQorICBFdmFsdWF0ZXMgZ2l2ZW4gSmF2YVNjcmlwdCBwcm9ncmFtIGFuZCByZXR1cm5z IHJlc3VsdCBvZiB0aGUgZXZhbHVhdGlvbi4KKyAgXGF0dGVudGlvbiB0aGlzIGZ1bmN0aW9uIGRv ZXNuJ3QgdGFrZSBwYXJhbWV0ZXJzIG93bmVyc2hpcC4KKyAgXGludGVybmFsCisqLwogSlNWYWx1 ZVJlZiBRU2NyaXB0RW5naW5lUHJpdmF0ZTo6ZXZhbHVhdGUoSlNTdHJpbmdSZWYgcHJvZ3JhbSwg SlNTdHJpbmdSZWYgZmlsZU5hbWUsIGludCBsaW5lTnVtYmVyKQogewogICAgIEpTVmFsdWVSZWYg ZXhjZXB0aW9uOwo= 53385 2010-04-14 16:54:01 -0700 2010-04-15 02:53:58 -0700 Fix v2 memleak.diff text/plain 2013 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA0YTdiNGQ1Li4yODk5MTA4IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTAtMDQtMTQgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IG1lbW9yeSBsZWFrIGluIFFTY3JpcHRFbmdpbmU6OmV2YWx1YXRlKCkuCisKKyAgICAgICAgUVNj cmlwdEVuZ2luZVByaXZhdGU6OmV2YWx1YXRlIHNob3VsZCByZWxlYXNlIHRlbXBvcmFyeSB2YXJp YWJsZXMuCisKKyAgICAgICAgW1F0XSBRU2NyaXB0RW5naW5lOjpldmFsdWF0ZSBoYXMgbWVtb3J5 IGxlYWsuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z NzU5NgorCisgICAgICAgICogcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5jcHA6CisgICAgICAgIChR U2NyaXB0RW5naW5lUHJpdmF0ZTo6ZXZhbHVhdGUpOgorICAgICAgICAqIHF0L2FwaS9xc2NyaXB0 ZW5naW5lX3AuaDoKKwogMjAxMC0wMy0yNSAgSmVkcnplaiBOb3dhY2tpICA8amVkcnplai5ub3dh Y2tpQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0ZW5naW5lX3AuY3BwIGIvSmF2 YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5jcHAKaW5kZXggOTVjZmE0NS4uODcz ZTdiNSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5j cHAKKysrIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5jcHAKQEAgLTU2 LDcgKzU2LDEwIEBAIFFTY3JpcHRWYWx1ZVByaXZhdGUqIFFTY3JpcHRFbmdpbmVQcml2YXRlOjpl dmFsdWF0ZShjb25zdCBRU3RyaW5nJiBwcm9ncmFtLCBjb25zCiB7CiAgICAgSlNTdHJpbmdSZWYg c2NyaXB0ID0gUVNjcmlwdENvbnZlcnRlcjo6dG9TdHJpbmcocHJvZ3JhbSk7CiAgICAgSlNTdHJp bmdSZWYgZmlsZSA9IFFTY3JpcHRDb252ZXJ0ZXI6OnRvU3RyaW5nKGZpbGVOYW1lKTsKLSAgICBy ZXR1cm4gbmV3IFFTY3JpcHRWYWx1ZVByaXZhdGUodGhpcywgZXZhbHVhdGUoc2NyaXB0LCBmaWxl LCBsaW5lTnVtYmVyKSk7CisgICAgUVNjcmlwdFZhbHVlUHJpdmF0ZSogcmVzdWx0ID0gbmV3IFFT Y3JpcHRWYWx1ZVByaXZhdGUodGhpcywgZXZhbHVhdGUoc2NyaXB0LCBmaWxlLCBsaW5lTnVtYmVy KSk7CisgICAgSlNTdHJpbmdSZWxlYXNlKHNjcmlwdCk7CisgICAgSlNTdHJpbmdSZWxlYXNlKGZp bGUpOworICAgIHJldHVybiByZXN1bHQ7CiB9CiAKIC8qIQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw dENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5oIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3Fz Y3JpcHRlbmdpbmVfcC5oCmluZGV4IDY2ZjU1ODMuLjE5MDU0Y2IgMTAwNjQ0Ci0tLSBhL0phdmFT Y3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0ZW5naW5lX3AuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9x dC9hcGkvcXNjcmlwdGVuZ2luZV9wLmgKQEAgLTY3LDYgKzY3LDExIEBAIHByaXZhdGU6CiB9Owog CiAKKy8qIQorICBFdmFsdWF0ZXMgZ2l2ZW4gSmF2YVNjcmlwdCBwcm9ncmFtIGFuZCByZXR1cm5z IHJlc3VsdCBvZiB0aGUgZXZhbHVhdGlvbi4KKyAgXGF0dGVudGlvbiB0aGlzIGZ1bmN0aW9uIGRv ZXNuJ3QgdGFrZSBvd25lcnNoaXAgb2YgdGhlIHBhcmFtZXRlcnMuCisgIFxpbnRlcm5hbAorKi8K IEpTVmFsdWVSZWYgUVNjcmlwdEVuZ2luZVByaXZhdGU6OmV2YWx1YXRlKEpTU3RyaW5nUmVmIHBy b2dyYW0sIEpTU3RyaW5nUmVmIGZpbGVOYW1lLCBpbnQgbGluZU51bWJlcikKIHsKICAgICBKU1Zh bHVlUmVmIGV4Y2VwdGlvbjsK