37496 2010-04-13 01:10:13 -0700 Add URL scheme parsing tests 2010-04-15 01:07:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 37641 1 abarth webkit-unassigned ap dbates fishd mjs oldest_to_newest 211894 0 abarth 2010-04-13 01:10:13 -0700 Add URL scheme parsing tests 211895 1 53231 abarth 2010-04-13 01:13:23 -0700 Created attachment 53231 Patch 212117 2 ap 2010-04-13 15:43:35 -0700 Could it be correct behavior that " HTTP " is treated as a relative URL? Maybe it should never hit the "absolute URL" case, in fact? 212345 3 abarth 2010-04-14 08:24:36 -0700 > Could it be correct behavior that " HTTP " is treated as a relative URL? Maybe > it should never hit the "absolute URL" case, in fact? Yes, I believe that is the correct behavior. However, it makes it tricky to test how we parse absolute URLs that begin in this way. 212350 4 ap 2010-04-14 08:34:10 -0700 That would mean testing a code path that should never be taken. It seems better to just test that this code path is never taken by verifying that such URLs are parsed as relative. 212351 5 abarth 2010-04-14 08:41:57 -0700 > That would mean testing a code path that should never be taken. There might be another API that takes strings and parses them as absolute URLs, or if there isn't one today, we could well invent one tomorrow. > It seems better > to just test that this code path is never taken by verifying that such URLs are > parsed as relative. We can certainly test that if you like. The intent of this test is to test the URL parser, not the HTMLAnchorElement.href API. We're just using the href API as a convenient way to get at the URL parser. 212778 6 53231 mjs 2010-04-15 00:56:44 -0700 Comment on attachment 53231 Patch r=me 212779 7 abarth 2010-04-15 01:07:21 -0700 Committed r57635: <http://trac.webkit.org/changeset/57635> 53231 2010-04-13 01:13:23 -0700 2010-04-15 00:58:31 -0700 Patch bug-37496-20100413011322.patch text/plain 3757 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZDI0NWU3Li4wZGY2ZjJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDQt MTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgVVJMIHNjaGVtZSBwYXJzaW5nIHRlc3Rz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzQ5Ngor CisgICAgICAgIEknbSBub3Qgc3VwZXIgaGFwcHkgd2l0aCBob3cgdGhlc2UgdGVzdCB0dXJuZWQg b3V0LiAgSXQncyBkaWZmaWN1bHQgdG8KKyAgICAgICAgdGVzdCB0aGVzZSBjYXNlcyB3aXRoIHRo aXMgbWV0aG9kb2xvZ3kgYmVjYXVzZSBtb3N0IG9mIHRoZSBjYXNlcyBnZXQKKyAgICAgICAgdHJl YXRlZCBhcyByZWxhdGl2ZSBVUkxzLiAgSSB0aXJlZCB1c2luZyB0aGUgInByb3RvY29sIiBwcm9w ZXJ0eSBvZiB0aGUKKyAgICAgICAgSFRNTEFuY2hvckVsZW1lbnQsIGJ1dCB0aGF0IG9mdGVuIGNh dXNlZCB0aGUgdGVzdCBjYXNlIHRvIGJlIGlnbm9yZWQKKyAgICAgICAgZm9yIHJlYXNvbnMgSSBk b24ndCBmdWxseSB1bmRlcnN0YW5kLgorCisgICAgICAgICogZmFzdC91cmwvcmVzb3VyY2VzL3V0 aWxpdGllcy5qczoKKyAgICAgICAgKHNldEJhc2VVUkwpOgorICAgICAgICAgIC0gSW4gdGhlIGNv dXJzZSBvZiB0cnlpbmcgdmFyaW91cyB2YXJpYXRpb25zIG9mIHRoaXMgdGVzdCwgSSB3cm90ZQor ICAgICAgICAgICAgdGhpcyBmdW5jdGlvbi4gIEl0IHNlZW1lZCB1c2VmdWwsIHNvIEkgbGVmdCBp dCBoZXJlIGZvciB0aGUgYmVuZWZpdAorICAgICAgICAgICAgb2YgZnV0dXJlIHRlc3Qgd3JpdGlu Zy4KKyAgICAgICAgKiBmYXN0L3VybC9zY2hlbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L3VybC9zY2hlbWUuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC91cmwvc2Ny aXB0LXRlc3RzL3NjaGVtZS5qczogQWRkZWQuCisKIDIwMTAtMDQtMTIgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lh ay4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdXJsL3Jlc291cmNlcy91dGlsaXRpZXMu anMgYi9MYXlvdXRUZXN0cy9mYXN0L3VybC9yZXNvdXJjZXMvdXRpbGl0aWVzLmpzCmluZGV4IDI2 MGI1MjguLmM0ZmQwYmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvdXJsL3Jlc291cmNl cy91dGlsaXRpZXMuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC91cmwvcmVzb3VyY2VzL3V0aWxp dGllcy5qcwpAQCAtNCwzICs0LDEwIEBAIGZ1bmN0aW9uIGNhbm9uaWNhbGl6ZSh1cmwpCiAgIGEu aHJlZiA9IHVybDsKICAgcmV0dXJuIGEuaHJlZjsKIH0KKworZnVuY3Rpb24gc2V0QmFzZVVSTCh1 cmwpCit7CisgIHZhciBiYXNlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYmFzZSIpOworICBi YXNlLmhyZWYgPSB1cmw7CisgIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5hcHBlbmRDaGlsZChi YXNlKTsKK30KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdXJsL3NjaGVtZS1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3VybC9zY2hlbWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjg3MDliODEKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L3VybC9zY2hlbWUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTEgQEAK K0Nhbm9uaWNhbGl6YXRpb24gb2YgVVJMIHNjaGVtZXMuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBM RVRFIi4KKworCitQQVNTIGNhbm9uaWNhbGl6ZSgnaHR0cDovL2V4YW1wbGUuY29tLycpIGlzICdo dHRwOi8vZXhhbXBsZS5jb20vJworRkFJTCBjYW5vbmljYWxpemUoJ0hUVFA6Ly9leGFtcGxlLmNv bS8nKSBzaG91bGQgYmUgaHR0cDovL2V4YW1wbGUuY29tLy4gV2FzIEhUVFA6Ly9leGFtcGxlLmNv bS8uCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC91cmwvc2NoZW1lLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L3VybC9zY2hlbWUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li5hZmI3NzgyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC91cmwvc2NoZW1l Lmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9E VEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJl Zj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi9q cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291 cmNlcy91dGlsaXRpZXMuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVz Y3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9InNj cmlwdC10ZXN0cy9zY2hlbWUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291 cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC91cmwvc2NyaXB0LXRlc3RzL3NjaGVtZS5qcyBiL0xheW91 dFRlc3RzL2Zhc3QvdXJsL3NjcmlwdC10ZXN0cy9zY2hlbWUuanMKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMC4uYzQyMmRjOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvdXJsL3NjcmlwdC10ZXN0cy9zY2hlbWUuanMKQEAgLTAsMCArMSwyMCBAQAorZGVzY3Jp cHRpb24oIkNhbm9uaWNhbGl6YXRpb24gb2YgVVJMIHNjaGVtZXMuIik7CisKK2Nhc2VzID0gWyAK KyAgWyJodHRwIiwgImh0dHAiXSwKKyAgWyJIVFRQIiwgImh0dHAiXSwKKyAgLy8gVGhlc2UgdGVz dHMgZG9uJ3Qgd29yayBwcm9wZXJseSBiZWNhdXNlIHRoZXkgZ2V0IGludGVycHJldGVkIGFzIHJl bGF0aXZlCisgIC8vIFVSTHMuICBUaGV5J3JlIGhlcmUgaW4gY2FzZSB3ZSBmaWd1cmUgb3V0IGhv dyB0byB0ZXN0IHRoZXNlIGNhc2VzLgorICAvLyBbIiBIVFRQICIsICIlMjBodHRwJTIwIl0sCisg IC8vIFsiaHR0OiAiLCAiaHR0JTNBJTIwIl0sCisgIC8vIFsiXHhlNFx4YmRceGEwXHhlNVx4YTVc eGJkaHR0cCIsICIlRTQlQkQlQTAlRTUlQTUlQkRodHRwIl0sCisgIC8vIFsiaHQlM0F0cCIsICJo dCUzYXRwIl0sCitdOworCitmb3IgKHZhciBpID0gMDsgaSA8IGNhc2VzLmxlbmd0aDsgKytpKSB7 CisgIHRlc3RfdmVjdG9yID0gY2FzZXNbaV1bMF07CisgIGV4cGVjdGVkX3Jlc3VsdCA9IGNhc2Vz W2ldWzFdOworICBzaG91bGRCZSgiY2Fub25pY2FsaXplKCciICsgdGVzdF92ZWN0b3IgKyAiOi8v ZXhhbXBsZS5jb20vJykiLAorICAgICAgICAgICAiJyIgKyBleHBlY3RlZF9yZXN1bHQgKyAiOi8v ZXhhbXBsZS5jb20vJyIpOworfQordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==