37426 2010-04-11 18:45:27 -0700 new-run-webkit-tests should use the ServerProcess abstraction in chromium.py 2011-05-31 18:54:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 dpranke webkit-unassigned aroben dpranke tony oldest_to_newest 211480 0 dpranke 2010-04-11 18:45:27 -0700 The code to launch and read from test_shell in chromium.py predates the ServerProcess abstraction that WebKit Mac uses. It should be rewritten to use it to minimize code duplication. 308337 1 dpranke 2010-11-11 20:00:54 -0800 Tony, I'm punting this over to you, because it becomes true when we remove the test_shell code and only use DRT. 308617 2 tony 2010-11-12 10:05:14 -0800 Ok, after we switch, I'll see about removing the test_shell related code. 345912 3 tony 2011-02-04 16:34:59 -0800 Hmm, as mentioned in bug 34826 comment 20, it is non-trivial to make use of ServerProcess on Windows python. I'm not sure if this is something we want to pursue. 370071 4 dpranke 2011-03-18 18:46:53 -0700 punting back to me ;) 381075 5 dpranke 2011-04-06 19:44:43 -0700 I don't think it should block bug 34984 and I plan to clear the blocking flag on Mon 4/11. If you disagree, now would be a good time to speak up :). 384587 6 dpranke 2011-04-12 18:05:31 -0700 clearing blocking flag. 387059 7 dpranke 2011-04-15 17:11:49 -0700 See bug 37426 for a way to make serverprocess work w/o blocking on win32. 413077 8 dpranke 2011-05-31 18:54:00 -0700 A more accurate description of this would probably be that we should just use the WebKitDriver implementation if we ever want to switch the Chromium DRT to webkit-style output. Whether or not the WebKitDriver implementation works on windows is a separate issue that should probably be tracked under a separate bug. I'm marking this as WONTFIX for now and clearing ownership; if anyone disagrees, feel free to reopen it.