3742 2005-06-27 18:02:38 -0700 Eyes don't render properly in acid2 test With Plugins disabled. 2007-11-02 23:47:23 -0700 1 1 1 Unclassified WebKit New Bugs 412 Mac OS X 10.4 RESOLVED FIXED http://webstandards.org/act/acid2/test.html P3 Normal --- 1 webkitBugzilla webkit-unassigned ddkilzer ian mitz webkit oldest_to_newest 13389 0 webkitBugzilla 2005-06-27 18:02:39 -0700 The eyes in the acid2 test don't appear. Instead, a 50% red band appears, and the black bar on the right of the eyes is red. 13405 1 joost 2005-06-27 23:24:54 -0700 Tested in fresh ToT, worksforme. The Tiger version of Safari will probably not pass the acid 2 test yet, the built from tree version however does. Thx for the bugreport tho. 13410 2 webkitBugzilla 2005-06-27 23:45:11 -0700 I had just updated the tree before I filed the bug. I just updated the tree again, and it now works... 13411 3 webkitBugzilla 2005-06-27 23:52:53 -0700 Actually, this works properly with plug-ins enabled, but it doesn't work if the plug-ins are disabled. 13412 4 joost 2005-06-28 03:00:36 -0700 I don't have any plugins installed and it works perfectly... Can somebody else confirm this bug? 13417 5 matrix9180 2005-06-28 05:29:49 -0700 I don't have canconfirm, but I just checked using ToT, and result was exactly as described. Safari menu -> Preferences... Security tab, uncheck "Enable plug-ins", (I restarted Safari @ this point, might not be needed), load the acid2 test. 13419 6 joost 2005-06-28 05:33:12 -0700 Confirmed. 13423 7 info 2005-06-28 06:39:01 -0700 I tracked this problem down to an inability of Webcore to display fallback content for object elements, when plugins are disabled. This is obviously problematic, because the fallback content is intented for such situations. html_objectimpl.cpp: 621: bool HTMLObjectElementImpl::rendererIsNeeded(RenderStyle *style) 622: { 623: if (m_useFallbackContent || isImageType()) 624: return HTMLElementImpl::rendererIsNeeded(style); 625: 626: KHTMLPart* part = getDocument()->part(); 627: if (!part || !part->pluginsEnabled()) { 628: return false; 629: } m_useFallbackContent is initially false and isImageType() will return false for regular plugin content. This means that line 627 is reached which result in false being returned if plugins are disabled. If rendererIsNeeded() returns false, createRenderer() will not be called and the RenderObject for the fallback content will not be created. The solution is return always true for rendererIsNeeded() and check which type of renderer we need to create in the createRenderer() function. 13425 8 2687 info 2005-06-28 06:59:46 -0700 Created attachment 2687 Possible solution This attachment contains a possible solution to the problem. The function listed here should be modified in html_objectimpl.cpp. Sorry, I currently do not have the time to do a proper patch. 20179 9 3992 info 2005-09-21 14:41:55 -0700 Created attachment 3992 Properly use images and fallback content If plugins are disabled by the user, the object element should still be able to display images, because images are not handled by plugins. The same applies to fallback content, if plugins are disabled and fallback content is provided, the fallback content should be displayed instead of the plugin. (Additionally this patch also makes sure fallback content is shown when the object element does not contain a type or url, for example: <object>Hello</object>. This example should simply print 'Hello'.) 20287 10 3992 darin 2005-09-23 08:53:24 -0700 Comment on attachment 3992 Properly use images and fallback content Patch has at least one tab in it. We indent using spaces, not tabs. Does this do the right thing when display is "none"? I don't think it does because rendererIsNeeded is supposed to return false in that case. Yet here was are returning true just so that we can eventually get to the fallback content code path. I think part of the fix should be to move the plug-ins enabled check completely out of rendererIsNeeded and instead do that check inside updateWidget. I'd like Dave to review this. 22057 11 mjs 2005-10-14 00:10:42 -0700 I'm going to r- based on darin's comments, even though this may need additional review. At the very least we need a test case for the display: none case. 42258 12 ddkilzer 2006-12-13 14:14:55 -0800 Reassigning bug to webkit-unassigned for more visibility. 233 13 mitz 2007-09-20 10:40:50 -0700 Looks like it is fixed in TOT. 60146 14 ddkilzer 2007-11-02 23:47:23 -0700 This appears to be fixed. Tested with a local debug build of WebKit r27388 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218) with plug-ins disabled. Note that reloading the page after viewing the test for the first time still has issues. See Bug 13693. 2687 2005-06-28 06:59:46 -0700 2005-09-21 14:41:55 -0700 Possible solution 3742.txt text/plain 1685 info DQpib29sIEhUTUxPYmplY3RFbGVtZW50SW1wbDo6aGFzRmFsbGJhY2tDb250ZW50KCkNCnsNCiAg ICBib29sIGhhc0ZhbGxiYWNrQ29udGVudCA9IGZhbHNlOw0KICAgIA0KICAgIGZvciAoTm9kZUlt cGwgKmNoaWxkID0gZmlyc3RDaGlsZCgpOyBjaGlsZCAmJiAhaGFzRmFsbGJhY2tDb250ZW50OyBj aGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKSB7DQogICAgICAgIGlmICgoIWNoaWxkLT5pc1Rl eHROb2RlKCkgJiYgY2hpbGQtPmlkKCkgIT0gSURfRU1CRUQgJiYgY2hpbGQtPmlkKCkgIT0gSURf UEFSQU0pIHx8IA0KICAgICAgICAgICAgKGNoaWxkLT5pc1RleHROb2RlKCkgJiYgIWNoaWxkLT5j b250YWluc09ubHlXaGl0ZXNwYWNlKCkpKQ0KICAgICAgICAgICAgaGFzRmFsbGJhY2tDb250ZW50 ID0gdHJ1ZTsNCiAgICB9ICAgIA0KICAgIA0KICAgIHJldHVybiBoYXNGYWxsYmFja0NvbnRlbnQ7 DQp9ICAgIA0KDQpib29sIEhUTUxPYmplY3RFbGVtZW50SW1wbDo6cmVuZGVyZXJJc05lZWRlZChS ZW5kZXJTdHlsZSAqc3R5bGUpDQp7DQogICAgaWYgKG1fdXNlRmFsbGJhY2tDb250ZW50IHx8IGlz SW1hZ2VUeXBlKCkpDQogICAgICAgIHJldHVybiBIVE1MRWxlbWVudEltcGw6OnJlbmRlcmVySXNO ZWVkZWQoc3R5bGUpOw0KDQogICAgaWYgKGhhc0ZhbGxiYWNrQ29udGVudCgpKQ0KICAgICAgICBy ZXR1cm4gdHJ1ZTsNCg0KICAgIEtIVE1MUGFydCogcGFydCA9IGdldERvY3VtZW50KCktPnBhcnQo KTsNCiAgICBpZiAoIXBhcnQgfHwgIXBhcnQtPnBsdWdpbnNFbmFibGVkKCkpIHsNCiAgICAgICAg cmV0dXJuIGZhbHNlOw0KICAgIH0NCiNpZiBBUFBMRV9DSEFOR0VTDQogICAgLy8gRXZlbnR1YWxs eSB3ZSB3aWxsIG1lcmdlIHdpdGggdGhlIGJldHRlciB2ZXJzaW9uIG9mIHRoaXMgY2hlY2sgb24g dGhlIHRpcCBvZiB0cmVlLg0KICAgIC8vIFVudGlsIHRoZW4sIGp1c3QgbGVhdmUgaXQgb3V0Lg0K I2Vsc2UNCiAgICBLVVJMIHUgPSBnZXREb2N1bWVudCgpLT5jb21wbGV0ZVVSTCh1cmwpOw0KICAg IGZvciAoS0hUTUxQYXJ0KiBwYXJ0ID0gdy0+cGFydCgpLT5wYXJlbnRQYXJ0KCk7IHBhcnQ7IHBh cnQgPSBwYXJ0LT5wYXJlbnRQYXJ0KCkpDQogICAgICAgIGlmIChwYXJ0LT51cmwoKSA9PSB1KSB7 DQogICAgICAgICAgICByZXR1cm4gZmFsc2U7DQogICAgICAgIH0NCiNlbmRpZg0KICAgIHJldHVy biB0cnVlOw0KfQ0KDQpSZW5kZXJPYmplY3QgKkhUTUxPYmplY3RFbGVtZW50SW1wbDo6Y3JlYXRl UmVuZGVyZXIoUmVuZGVyQXJlbmEgKmFyZW5hLCBSZW5kZXJTdHlsZSAqc3R5bGUpDQp7DQogICAg aWYgKG1fdXNlRmFsbGJhY2tDb250ZW50KQ0KICAgICAgICByZXR1cm4gUmVuZGVyT2JqZWN0Ojpj cmVhdGVPYmplY3QodGhpcywgc3R5bGUpOw0KICAgIGlmIChpc0ltYWdlVHlwZSgpKQ0KICAgICAg ICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVySW1hZ2UodGhpcyk7DQogICAgICAgIA0KICAgIEtI VE1MUGFydCogcGFydCA9IGdldERvY3VtZW50KCktPnBhcnQoKTsNCiAgICBpZiAoIXBhcnQgfHwg IXBhcnQtPnBsdWdpbnNFbmFibGVkKCkpDQogICAgICAgIHJldHVybiBSZW5kZXJPYmplY3Q6OmNy ZWF0ZU9iamVjdCh0aGlzLCBzdHlsZSk7DQogICAgZWxzZQ0KICAgICAgICByZXR1cm4gbmV3IChh cmVuYSkgUmVuZGVyUGFydE9iamVjdCh0aGlzKTsNCn0= 3992 2005-09-21 14:41:55 -0700 2005-10-14 00:10:51 -0700 Properly use images and fallback content patch.txt text/plain 4195 info SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNzkKZGlmZiAtcCAtdSAtcjEuNzkga2h0bWwvaHRtbC9odG1sX29i amVjdGltcGwuY3BwCi0tLSBraHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAJMTYgU2VwIDIw MDUgMjI6NDI6MTIgLTAwMDAJMS43OQorKysga2h0bWwvaHRtbC9odG1sX29iamVjdGltcGwuY3Bw CTIxIFNlcCAyMDA1IDIxOjMwOjQ2IC0wMDAwCkBAIC03MDMsMTEgKzcwMywyNyBAQCBEb2N1bWVu dEltcGwqIEhUTUxPYmplY3RFbGVtZW50SW1wbDo6Y29uCiAgICAgcmV0dXJuIDA7CiB9CiAKK2Jv b2wgSFRNTE9iamVjdEVsZW1lbnRJbXBsOjpoYXNGYWxsYmFja0NvbnRlbnQoKQoreworICAgIGJv b2wgaGFzRmFsbGJhY2tDb250ZW50ID0gZmFsc2U7CisJCisgICAgZm9yIChOb2RlSW1wbCAqY2hp bGQgPSBmaXJzdENoaWxkKCk7IGNoaWxkICYmICFoYXNGYWxsYmFja0NvbnRlbnQ7IGNoaWxkID0g Y2hpbGQtPm5leHRTaWJsaW5nKCkpIHsKKyAgICAgICAgaWYgKCghY2hpbGQtPmlzVGV4dE5vZGUo KSAmJiAhY2hpbGQtPmhhc1RhZ05hbWUoZW1iZWRUYWcpICYmICFjaGlsZC0+aGFzVGFnTmFtZShw YXJhbVRhZykpIHx8IC8vIERpc2NvdW50IDxlbWJlZD4gYW5kIDxwYXJhbT4KKyAgICAgICAgICAg IChjaGlsZC0+aXNUZXh0Tm9kZSgpICYmICFjaGlsZC0+Y29udGFpbnNPbmx5V2hpdGVzcGFjZSgp KSkKKyAgICAgICAgaGFzRmFsbGJhY2tDb250ZW50ID0gdHJ1ZTsKKyAgICB9CisgICAgCisgICAg cmV0dXJuIGhhc0ZhbGxiYWNrQ29udGVudDsKK30gIAorCiBib29sIEhUTUxPYmplY3RFbGVtZW50 SW1wbDo6cmVuZGVyZXJJc05lZWRlZChSZW5kZXJTdHlsZSAqc3R5bGUpCiB7CiAgICAgaWYgKG1f dXNlRmFsbGJhY2tDb250ZW50IHx8IGlzSW1hZ2VUeXBlKCkpCiAgICAgICAgIHJldHVybiBIVE1M RWxlbWVudEltcGw6OnJlbmRlcmVySXNOZWVkZWQoc3R5bGUpOwogCisgICAgaWYgKGhhc0ZhbGxi YWNrQ29udGVudCgpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKwogICAgIEtIVE1MUGFydCogcGFy dCA9IGdldERvY3VtZW50KCktPnBhcnQoKTsKICAgICBpZiAoIXBhcnQgfHwgIXBhcnQtPnBsdWdp bnNFbmFibGVkKCkpIHsKICAgICAgICAgcmV0dXJuIGZhbHNlOwpJbmRleDoga2h0bWwvaHRtbC9o dG1sX29iamVjdGltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9r aHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjM2CmRp ZmYgLXAgLXUgLXIxLjM2IGtodG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmgKLS0tIGtodG1sL2h0 bWwvaHRtbF9vYmplY3RpbXBsLmgJMTYgU2VwIDIwMDUgMjI6NDI6MTIgLTAwMDAJMS4zNgorKysg a2h0bWwvaHRtbC9odG1sX29iamVjdGltcGwuaAkyMSBTZXAgMjAwNSAyMTozMDo0NiAtMDAwMApA QCAtMTY4LDYgKzE2OCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcGFyc2VNYXBwZWRB dHRyaWJ1dGUoTWFwcGVkQXR0cmlidXRlSW1wbCAqdG9rZW4pOwogCiAgICAgdmlydHVhbCB2b2lk IGF0dGFjaCgpOworICAgIHZpcnR1YWwgYm9vbCBoYXNGYWxsYmFja0NvbnRlbnQoKTsKICAgICB2 aXJ0dWFsIGJvb2wgcmVuZGVyZXJJc05lZWRlZChraHRtbDo6UmVuZGVyU3R5bGUgKik7CiAgICAg dmlydHVhbCBraHRtbDo6UmVuZGVyT2JqZWN0ICpjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSAq LCBraHRtbDo6UmVuZGVyU3R5bGUgKik7CiAgICAgdmlydHVhbCB2b2lkIGRldGFjaCgpOwpJbmRl eDoga2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJhbWVzLmNwcCx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS43NwpkaWZmIC1wIC11IC1yMS43NyBraHRtbC9yZW5kZXJpbmcv cmVuZGVyX2ZyYW1lcy5jcHAKLS0tIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfZnJhbWVzLmNwcAkx NiBTZXAgMjAwNSAyMjo0MjoxNiAtMDAwMAkxLjc3CisrKyBraHRtbC9yZW5kZXJpbmcvcmVuZGVy X2ZyYW1lcy5jcHAJMjEgU2VwIDIwMDUgMjE6MzA6NDYgLTAwMDAKQEAgLTc5MSwxNSArNzkxLDIy IEBAIHZvaWQgUmVuZGVyUGFydE9iamVjdDo6dXBkYXRlV2lkZ2V0KCkKICAgICAgICAgICAvLyBU T0RPOiBhZGQgbW9yZSBwbHVnaW5zIGhlcmUKICAgICAgIH0KICAgICAgIAotICAgICAgLy8gSWYg bm8gVVJMIGFuZCB0eXBlLCBhYm9ydC4KKyAgICAgIC8vIEZpbmQgb3V0IGlmIHdlIHN1cHBvcnQg ZmFsbGJhY2sgY29udGVudC4KKyAgICAgIG1faGFzRmFsbGJhY2tDb250ZW50ID0gby0+aGFzRmFs bGJhY2tDb250ZW50KCk7CisJICAKKwkgIC8vIElmIG5vIFVSTCBhbmQgdHlwZSwgYWJvcnQuCiAg ICAgICBpZiAodXJsLmlzRW1wdHkoKSAmJiBzZXJ2aWNlVHlwZS5pc0VtcHR5KCkpIHsKICNpZmRl ZiBERUJVR19MQVlPVVQKICAgICAgICAgICBrZERlYnVnKCkgPDwgIlJlbmRlclBhcnRPYmplY3Q6 OmNsb3NlIC0gZW1wdHkgdXJsIGFuZCBzZXJ2ZXJUeXBlIiA8PCBlbmRsOwogI2VuZGlmCisgICAg ICAgICAgaWYgKG1faGFzRmFsbGJhY2tDb250ZW50KQorICAgICAgICAgICAgICBvLT5yZW5kZXJG YWxsYmFja0NvbnRlbnQoKTsKICAgICAgICAgICByZXR1cm47CiAgICAgICB9CiAgICAgICAvLyBB dm9pZCBpbmZpbml0ZSByZWN1cnNpb24uIElmIHRoZSBwbHVnLWluJ3MgVVJMIGlzIHRoZSBzYW1l IGFzIHRoZSBwYXJ0J3MgVVJMLCBpbmZpbml0ZSBmcmFtZXMgbWF5IGJlIGNyZWF0ZWQuCiAgICAg ICBpZiAoIXVybC5pc0VtcHR5KCkgJiYgcGFydC0+Y29tcGxldGVVUkwodXJsKSA9PSBwYXJ0LT5i YXNlVVJMKCkpIHsKKyAgICAgICAgICBpZiAobV9oYXNGYWxsYmFja0NvbnRlbnQpCisJCSAgICAg IG8tPnJlbmRlckZhbGxiYWNrQ29udGVudCgpOwogICAgICAgICAgIHJldHVybjsKICAgICAgIH0K ICAgICAgICAgICAgIApAQCAtODA4LDEyICs4MTUsMTAgQEAgdm9pZCBSZW5kZXJQYXJ0T2JqZWN0 Ojp1cGRhdGVXaWRnZXQoKQogICAgICAgcGFyYW1zLmFwcGVuZCggUVN0cmluZzo6ZnJvbUxhdGlu MSgiX19LSFRNTF9fQ09ERUJBU0U9XCIlMVwiIikuYXJnKCBvLT5nZXRBdHRyaWJ1dGUoY29kZWJh c2VBdHRyKS5xc3RyaW5nKCkgKSApOwogI2VuZGlmCiAKLSAgICAgIC8vIEZpbmQgb3V0IGlmIHdl IHN1cHBvcnQgZmFsbGJhY2sgY29udGVudC4KLSAgICAgIG1faGFzRmFsbGJhY2tDb250ZW50ID0g ZmFsc2U7Ci0gICAgICBmb3IgKE5vZGVJbXBsICpjaGlsZCA9IG8tPmZpcnN0Q2hpbGQoKTsgY2hp bGQgJiYgIW1faGFzRmFsbGJhY2tDb250ZW50OyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygp KSB7Ci0gICAgICAgICAgaWYgKCghY2hpbGQtPmlzVGV4dE5vZGUoKSAmJiAhY2hpbGQtPmhhc1Rh Z05hbWUoZW1iZWRUYWcpICYmICFjaGlsZC0+aGFzVGFnTmFtZShwYXJhbVRhZykpIHx8IC8vIERp c2NvdW50IDxlbWJlZD4gYW5kIDxwYXJhbT4KLSAgICAgICAgICAgICAgKGNoaWxkLT5pc1RleHRO b2RlKCkgJiYgIWNoaWxkLT5jb250YWluc09ubHlXaGl0ZXNwYWNlKCkpKQotICAgICAgICAgICAg ICBtX2hhc0ZhbGxiYWNrQ29udGVudCA9IHRydWU7CisgICAgICBpZiAoIXBhcnQgfHwgIXBhcnQt PnBsdWdpbnNFbmFibGVkKCkpIHsKKyAgICAgICAgICBpZiAobV9oYXNGYWxsYmFja0NvbnRlbnQp CisgICAgICAgICAgICAgIG8tPnJlbmRlckZhbGxiYWNrQ29udGVudCgpOworCQkgIHJldHVybjsK ICAgICAgIH0KICAgICAgIGJvb2wgc3VjY2VzcyA9IHBhcnQtPnJlcXVlc3RPYmplY3QoIHRoaXMs IHVybCwgc2VydmljZVR5cGUsIHBhcmFtTmFtZXMsIHBhcmFtVmFsdWVzICk7CiAgICAgICBpZiAo IXN1Y2Nlc3MgJiYgbV9oYXNGYWxsYmFja0NvbnRlbnQpCg==