37320 2010-04-09 02:57:08 -0700 [Qt] tst_QWebFrame::popupFocus() fails 2010-04-12 07:12:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux CLOSED FIXED Qt P1 Blocker --- 35784 1 hausmann max.hong.shen commit-queue cshu kenneth luiz oldest_to_newest 210650 0 hausmann 2010-04-09 02:57:08 -0700 PASS : tst_QWebFrame::initTestCase() FAIL! : tst_QWebFrame::popupFocus() 'combo != 0' returned FALSE. () Loc: [/home/shausman/src/webkit/trunk/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2520)] PASS : tst_QWebFrame::cleanupTestCase() Reproducible on Linux/X11. It does not appear to be timing related, it fails consistenly for me. 210828 1 52972 max.hong.shen 2010-04-09 11:58:20 -0700 Created attachment 52972 proposal patch The class WebCore::QWebPopup has been removed, so the test cases need to be updated also. 210846 2 luiz 2010-04-09 12:28:40 -0700 I can verify that this is the right fix. But you should elaborate more on what you are doing and how you fixed it in change log. 210848 3 kenneth 2010-04-09 12:30:15 -0700 (In reply to comment #2) > I can verify that this is the right fix. But you should elaborate more on what > you are doing and how you fixed it in change log. I agree, the ChangeLog entry doesn't fulfill the requirements of the projects, r- for that reason. Please provide a new patch with a better description and I will review it ASAP! Thanks :-) 210859 4 52980 max.hong.shen 2010-04-09 12:53:45 -0700 Created attachment 52980 patch updated the description in the changelog 210869 5 52980 kenneth 2010-04-09 13:19:29 -0700 Comment on attachment 52980 patch > + > + The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu. > + :-( Please keep the changelog at max 80-100 char per line as everyone else. sorry 210877 6 52982 max.hong.shen 2010-04-09 13:28:39 -0700 Created attachment 52982 patch 210878 7 max.hong.shen 2010-04-09 13:29:22 -0700 It's my bad :) Thanks for the reviewing. 211057 8 52982 commit-queue 2010-04-09 17:51:35 -0700 Comment on attachment 52982 patch Clearing flags on attachment: 52982 Committed r57388: <http://trac.webkit.org/changeset/57388> 211058 9 commit-queue 2010-04-09 17:51:41 -0700 All reviewed patches have been landed. Closing bug. 211598 10 hausmann 2010-04-12 07:11:53 -0700 Revision r57388 cherry-picked into qtwebkit-2.0 with commit 862268aeb7150d3795d05bfc05f661bb5c598a27 52972 2010-04-09 11:58:20 -0700 2010-04-09 12:53:45 -0700 proposal patch bug37320.patch text/plain 1331 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTczMzgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMDkgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gdHN0X1FXZWJGcmFtZTo6cG9wdXBGb2N1cygpIGZhaWxzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzMyMAorCisgICAgICAgIE5vICJXZWJD b3JlOjpRV2ViUG9wdXAiIGFueW1vcmUKKworICAgICAgICAqIHRlc3RzL3F3ZWJmcmFtZS90c3Rf cXdlYmZyYW1lLmNwcDoKKwogMjAxMC0wNC0wOSAgVGFzdWt1IFN1enVraSAgPHRhc3VrdS5zdXp1 a2lAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRl eDogV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCShyZXZpc2lv biA1NzMzOCkKKysrIFdlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTI1MTUsNyArMjUxNSw3IEBAIHZvaWQgdHN0X1FXZWJGcmFtZTo6 cG9wdXBGb2N1cygpCiAKICAgICAvLyBvcGVuIHRoZSBwb3B1cCBieSBjbGlja2luZy4gY2hlY2sg aWYgZm9jdXMgaXMgb24gdGhlIHBvcHVwCiAgICAgUVRlc3Q6Om1vdXNlQ2xpY2soJnZpZXcsIFF0 OjpMZWZ0QnV0dG9uLCAwLCBRUG9pbnQoMjUsIDI1KSk7Ci0gICAgUU9iamVjdCogd2VicG9wdXAg PSBmaXJzdENoaWxkQnlDbGFzc05hbWUoJnZpZXcsICJXZWJDb3JlOjpRV2ViUG9wdXAiKTsKKyAg ICBRT2JqZWN0KiB3ZWJwb3B1cCA9IGZpcnN0Q2hpbGRCeUNsYXNzTmFtZSgmdmlldywgIlFDb21i b0JveCIpOwogICAgIFFDb21ib0JveCogY29tYm8gPSBxb2JqZWN0X2Nhc3Q8UUNvbWJvQm94Kj4o d2VicG9wdXApOwogICAgIFFWRVJJRlkoY29tYm8gIT0gMCk7CiAgICAgUVRSWV9WRVJJRlkoIXZp ZXcuaGFzRm9jdXMoKSAmJiBjb21iby0+dmlldygpLT5oYXNGb2N1cygpKTsgLy8gRm9jdXMgc2hv dWxkIGJlIG9uIHRoZSBwb3B1cAo= 52980 2010-04-09 12:53:45 -0700 2010-04-09 13:28:39 -0700 patch bug37320.patch text/plain 1473 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTczNDkpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMDkgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gdHN0X1FXZWJGcmFtZTo6cG9wdXBGb2N1cygpIGZhaWxzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzMyMAorCisgICAgICAgIFRoZSBRV2Vi UG9wdXAgY2xhc3MgaGFzIGJlZW4gbW92ZWQgJiByZW5hbWVkLCBzbyB0c3RfUVdlYkZyYW1lOjpw b3B1cEZvY3VzKCkgc2hvdWxkIHVzZSB0aGUgY2xhc3MgbmFtZSAiUUNvbWJvQm94IiwgcmF0aGVy IHRoYW4gIldlYkNvcmU6OlFXZWJQb3B1cCIgdG8gZmluZCB0aGUgcG9wdXAgbWVudS4gCisKKyAg ICAgICAgKiB0ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHA6CisKIDIwMTAtMDQtMDkg IFRhc3VrdSBTdXp1a2kgIDx0YXN1a3Uuc3V6dWtpQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUv dHN0X3F3ZWJmcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFt ZS90c3RfcXdlYmZyYW1lLmNwcAkocmV2aXNpb24gNTczMzgpCisrKyBXZWJLaXQvcXQvdGVzdHMv cXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTE1LDcgKzI1 MTUsNyBAQCB2b2lkIHRzdF9RV2ViRnJhbWU6OnBvcHVwRm9jdXMoKQogCiAgICAgLy8gb3BlbiB0 aGUgcG9wdXAgYnkgY2xpY2tpbmcuIGNoZWNrIGlmIGZvY3VzIGlzIG9uIHRoZSBwb3B1cAogICAg IFFUZXN0Ojptb3VzZUNsaWNrKCZ2aWV3LCBRdDo6TGVmdEJ1dHRvbiwgMCwgUVBvaW50KDI1LCAy NSkpOwotICAgIFFPYmplY3QqIHdlYnBvcHVwID0gZmlyc3RDaGlsZEJ5Q2xhc3NOYW1lKCZ2aWV3 LCAiV2ViQ29yZTo6UVdlYlBvcHVwIik7CisgICAgUU9iamVjdCogd2VicG9wdXAgPSBmaXJzdENo aWxkQnlDbGFzc05hbWUoJnZpZXcsICJRQ29tYm9Cb3giKTsKICAgICBRQ29tYm9Cb3gqIGNvbWJv ID0gcW9iamVjdF9jYXN0PFFDb21ib0JveCo+KHdlYnBvcHVwKTsKICAgICBRVkVSSUZZKGNvbWJv ICE9IDApOwogICAgIFFUUllfVkVSSUZZKCF2aWV3Lmhhc0ZvY3VzKCkgJiYgY29tYm8tPnZpZXco KS0+aGFzRm9jdXMoKSk7IC8vIEZvY3VzIHNob3VsZCBiZSBvbiB0aGUgcG9wdXAK 52982 2010-04-09 13:28:39 -0700 2010-04-09 17:51:35 -0700 patch bug37320.patch text/plain 1481 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTczNTUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMDkgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gdHN0X1FXZWJGcmFtZTo6cG9wdXBGb2N1cygpIGZhaWxzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzMyMAorCisgICAgICAgIFRoZSBRV2Vi UG9wdXAgY2xhc3MgaGFzIGJlZW4gbW92ZWQgJiByZW5hbWVkLCBzbyB0c3RfUVdlYkZyYW1lOjpw b3B1cEZvY3VzKCkgc2hvdWxkIHVzZQorICAgICAgICB0aGUgY2xhc3MgbmFtZSAiUUNvbWJvQm94 IiwgcmF0aGVyIHRoYW4gIldlYkNvcmU6OlFXZWJQb3B1cCIgdG8gZmluZCB0aGUgcG9wdXAgbWVu dS4KKworICAgICAgICAqIHRlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcDoKKwogMjAx MC0wNC0wOSAgVGFzdWt1IFN1enVraSAgPHRhc3VrdS5zdXp1a2lAbm9raWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViS2l0L3F0L3Rlc3RzL3F3 ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvdGVzdHMv cXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCShyZXZpc2lvbiA1NzMzOCkKKysrIFdlYktpdC9x dC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1 MTUsNyArMjUxNSw3IEBAIHZvaWQgdHN0X1FXZWJGcmFtZTo6cG9wdXBGb2N1cygpCiAKICAgICAv LyBvcGVuIHRoZSBwb3B1cCBieSBjbGlja2luZy4gY2hlY2sgaWYgZm9jdXMgaXMgb24gdGhlIHBv cHVwCiAgICAgUVRlc3Q6Om1vdXNlQ2xpY2soJnZpZXcsIFF0OjpMZWZ0QnV0dG9uLCAwLCBRUG9p bnQoMjUsIDI1KSk7Ci0gICAgUU9iamVjdCogd2VicG9wdXAgPSBmaXJzdENoaWxkQnlDbGFzc05h bWUoJnZpZXcsICJXZWJDb3JlOjpRV2ViUG9wdXAiKTsKKyAgICBRT2JqZWN0KiB3ZWJwb3B1cCA9 IGZpcnN0Q2hpbGRCeUNsYXNzTmFtZSgmdmlldywgIlFDb21ib0JveCIpOwogICAgIFFDb21ib0Jv eCogY29tYm8gPSBxb2JqZWN0X2Nhc3Q8UUNvbWJvQm94Kj4od2VicG9wdXApOwogICAgIFFWRVJJ RlkoY29tYm8gIT0gMCk7CiAgICAgUVRSWV9WRVJJRlkoIXZpZXcuaGFzRm9jdXMoKSAmJiBjb21i by0+dmlldygpLT5oYXNGb2N1cygpKTsgLy8gRm9jdXMgc2hvdWxkIGJlIG9uIHRoZSBwb3B1cAo=