37227 2010-04-07 12:05:05 -0700 Remove "all" value from the view-mode media feature 2010-04-09 07:23:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All CLOSED FIXED Qt P3 Normal --- 35784 1 kenneth webkit-unassigned commit-queue hausmann simon.fraser oldest_to_newest 209768 0 52767 kenneth 2010-04-07 12:05:05 -0700 Created attachment 52767 Patch Remove "all" value from the view-mode media feature (as agreed on 1-Apr-2010) in the Widgets voice conf. 210314 1 52767 simon.fraser 2010-04-08 12:20:02 -0700 Comment on attachment 52767 Patch No layout test? r=me. 210329 2 kenneth 2010-04-08 12:37:29 -0700 It updates the current layout test fast/media/media-feature-wgt-view-mode.html, so yes. 210638 3 52767 commit-queue 2010-04-09 01:59:38 -0700 Comment on attachment 52767 Patch Clearing flags on attachment: 52767 Committed r57319: <http://trac.webkit.org/changeset/57319> 210639 4 commit-queue 2010-04-09 01:59:44 -0700 All reviewed patches have been landed. Closing bug. 210716 5 hausmann 2010-04-09 07:23:15 -0700 Revision r57319 cherry-picked into qtwebkit-2.0 with commit d9efc55dce31450313cfc5e795698fd1f66e9f54 52767 2010-04-07 12:05:05 -0700 2010-04-09 01:59:38 -0700 Patch 0001-WebCore-Remove-all-value-from-the-view-mode-media-fe.patch text/plain 3652 kenneth RnJvbSA0OTI4OGYzNDVjNWZjMjAxMjhlNzcwMTI2NWE0MzlkYTk1ZDQ4NzkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3 ZWJraXQub3JnPgpEYXRlOiBXZWQsIDcgQXByIDIwMTAgMTY6MDI6MjggLTAzMDAKU3ViamVjdDog W1BBVENIXSBXZWJDb3JlOiBSZW1vdmUgImFsbCIgdmFsdWUgZnJvbSB0aGUgdmlldy1tb2RlIG1l ZGlhIGZlYXR1cmUgKGFzIGFncmVlZCBvbgogMS1BcHItMjAxMCkgaW4gdGhlIFdpZGdldHMgdm9p Y2UgY29uZi4KClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBjc3MvQ1NTVmFsdWVLZXl3 b3Jkcy5pbjoKKiBjc3MvTWVkaWFRdWVyeUV2YWx1YXRvci5jcHA6CihXZWJDb3JlOjp2aWV3X21v ZGVNZWRpYUZlYXR1cmVFdmFsKToKCkxheW91dFRlc3RzOiBVcGRhdGUgdGVzdCBhcyB0aGUgJ2Fs bCcgdmFsdWUgaGFzIGJlZW4gcmVtb3ZlZAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoq IGZhc3QvbWVkaWEvbWVkaWEtZmVhdHVyZS13Z3Qtdmlldy1tb2RlLmh0bWw6Ci0tLQogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA4ICsrKysr KysrCiAuLi4vZmFzdC9tZWRpYS9tZWRpYS1mZWF0dXJlLXdndC12aWV3LW1vZGUuaHRtbCAgICB8 ICAgIDIgKy0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxMSArKysrKysrKysrKwogV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbiAg ICAgICAgICAgICAgICAgICAgfCAgICAxIC0KIFdlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFsdWF0 b3IuY3BwICAgICAgICAgICAgICAgIHwgICAgNCArLS0tCiA1IGZpbGVzIGNoYW5nZWQsIDIxIGlu c2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDk5MWQ5Y2IuLjg4MDhlN2MgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMSBAQAorMjAxMC0wNC0wNyAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRlc3QgYXMgdGhlICdhbGwnIHZhbHVlIGhhcyBiZWVu IHJlbW92ZWQKKworICAgICAgICAqIGZhc3QvbWVkaWEvbWVkaWEtZmVhdHVyZS13Z3Qtdmlldy1t b2RlLmh0bWw6CisKIDIwMTAtMDQtMDYgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9tZWRpYS9tZWRpYS1mZWF0dXJlLXdndC12aWV3LW1vZGUuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvbWVkaWEvbWVkaWEtZmVhdHVyZS13Z3Qtdmlldy1tb2RlLmh0bWwKaW5kZXgg OWI2ZWI1ZC4uNzNiM2UwYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYS9tZWRp YS1mZWF0dXJlLXdndC12aWV3LW1vZGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlh L21lZGlhLWZlYXR1cmUtd2d0LXZpZXctbW9kZS5odG1sCkBAIC05LDcgKzksNyBAQAogICAgICAg ICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IGJsdWU7CiAgICAgICAgICAgICB9CiAgICAgICAg IH0KLSAgICAgICAgQG1lZGlhICgtd2Via2l0LXZpZXctbW9kZTogYWxsKSB7CisgICAgICAgIEBt ZWRpYSAoLXdlYmtpdC12aWV3LW1vZGUpIHsKICAgICAgICAgICAgIGRpdiB7CiAgICAgICAgICAg ICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CiAgICAgICAgICAgICB9CmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDU2MTJjMWIuLjMy YTc2M2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMDcgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFu c2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbW92ZSAiYWxsIiB2YWx1ZSBmcm9tIHRoZSB2aWV3LW1vZGUg bWVkaWEgZmVhdHVyZSAoYXMgYWdyZWVkIG9uCisgICAgICAgIDEtQXByLTIwMTApIGluIHRoZSBX aWRnZXRzIHZvaWNlIGNvbmYuCisKKyAgICAgICAgKiBjc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbjoK KyAgICAgICAgKiBjc3MvTWVkaWFRdWVyeUV2YWx1YXRvci5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojp2aWV3X21vZGVNZWRpYUZlYXR1cmVFdmFsKToKKwogMjAxMC0wNC0wNyAgRW5yaWNhIENhc3Vj Y2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbiBiL1dlYkNvcmUv Y3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4KaW5kZXggOWQ3ZWQ2Yy4uMDlkOTY5YSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbgorKysgYi9XZWJDb3JlL2Nzcy9DU1NW YWx1ZUtleXdvcmRzLmluCkBAIC03MTUsNCArNzE1LDMgQEAgbWluaQogZmxvYXRpbmcKIGFwcGxp Y2F0aW9uCiBmdWxsc2NyZWVuCi0jYWxsCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9NZWRpYVF1 ZXJ5RXZhbHVhdG9yLmNwcCBiL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFsdWF0b3IuY3BwCmlu ZGV4IDhlYWExZTMuLjRmZGEwNzUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlF dmFsdWF0b3IuY3BwCisrKyBiL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFsdWF0b3IuY3BwCkBA IC01MDEsOCArNTAxLDYgQEAgc3RhdGljIGJvb2wgdmlld19tb2RlTWVkaWFGZWF0dXJlRXZhbChD U1NWYWx1ZSogdmFsdWUsIFJlbmRlclN0eWxlKiwgRnJhbWUqIGZyYW0KICAgICBpZiAodmFsdWUp IHsKICAgICAgICAgU3RyaW5nIG1vZGUgPSBzdGF0aWNfY2FzdDxDU1NQcmltaXRpdmVWYWx1ZSo+ KHZhbHVlKS0+Z2V0U3RyaW5nVmFsdWUoKTsKICAgICAgICAgaWYgKENocm9tZUNsaWVudCogY2xp ZW50ID0gZnJhbWUtPnBhZ2UoKS0+Y2hyb21lKCktPmNsaWVudCgpKSB7Ci0gICAgICAgICAgICBp ZiAobW9kZSA9PSAiYWxsIikKLSAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAg ICAgIGlmIChtb2RlID09ICJtaW5pIiAmJiBjbGllbnQtPmlzRG9ja2VkKCkpCiAgICAgICAgICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICBpZiAobW9kZSA9PSAiZmxvYXRpbmciICYm IGNsaWVudC0+aXNGbG9hdGluZygpKQpAQCAtNTE0LDcgKzUxMiw3IEBAIHN0YXRpYyBib29sIHZp ZXdfbW9kZU1lZGlhRmVhdHVyZUV2YWwoQ1NTVmFsdWUqIHZhbHVlLCBSZW5kZXJTdHlsZSosIEZy YW1lKiBmcmFtCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KICAgICB9Ci0g ICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiB0cnVlOwogfQogI2VuZGlmCiAKLS0gCjEuNy4w LjMKCg==