37102 2010-04-05 11:47:18 -0700 DerivedSources.make does not notice when FEATURE_DEFINES change 2012-05-14 14:21:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 1 eric webkit-unassigned abarth darin ddkilzer mjs mrowe oldest_to_newest 208605 0 eric 2010-04-05 11:47:18 -0700 DerivedSources.make does not notice when FEATURE_DEFINES change This caused: https://bugs.webkit.org/show_bug.cgi?id=36961#c21 One possible solution would be for DerivedSources.make to write out some sort of FEATURE_DEFINES file in DerivedSources/ during a build, and then if the incoming FEATURE_DEFINES are ever different from that file, simply rebuild everything. 208895 1 mjs 2010-04-05 22:17:22 -0700 Sounds like a good idea to fix this. 209058 2 darin 2010-04-06 08:35:20 -0700 I think this is critical to fix. I personally would fix it by eliminating FEATURE_DEFINES and using a file instead of an environment variable to communicate these settings. The build-webkit tool could generate the header file. 209059 3 darin 2010-04-06 08:35:43 -0700 But I suppose the file would need to be a format that multiple tools could read, so perhaps it's impractical. 623326 4 eric 2012-05-14 14:21:15 -0700 I wonder if this old bug is still valid. If it is, I wonder if landing bug 85456 will give us an easy way to fix it. :)