36929 2010-03-31 22:22:36 -0700 [Qt] REGRESSION(r56869): Windows build is broken 2010-05-05 06:43:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows XP RESOLVED FIXED Qt P1 Blocker --- 36472 1 ossy webkit-qt-unassigned abarth dimich eric jianli jturcotte webkit.review.bot oldest_to_newest 206955 0 ossy 2010-03-31 22:22:36 -0700 http://trac.webkit.org/changeset/56869 broke QtWebKit build on Windows (MinGW and MSVC build) missing ARRAYSIZE macro: (only with MinGW) ------------------------------------------- ..\..\..\WebCore\platform\UUID.cpp: In function 'WebCore::String WebCore::createCanonicalUUIDString()': ..\..\..\WebCore\platform\UUID.cpp:54: error: 'ARRAYSIZE' was not declared in this scope make.exe[1]: *** [obj/release/UUID.o] Error 1 missing CoCreateGuid() and StringFromGUID2() (Ole32.lib) --------------------------------------------------------- c:/qt/2010.02/mingw/bin/../lib/gcc/mingw32/4.4.0/../../../../mingw32/bin/ld.exe: :0: syntax error Warning: .drectve `-export:T.4466 ' unrecognized ./obj\release\UUID.o:UUID.cpp:(.text+0x1e): undefined reference to `CoCreateGuid@4' ./obj\release\UUID.o:UUID.cpp:(.text+0x3a): undefined reference to `StringFromGUID2@12' collect2: ld returned 1 exit status make.exe[1]: *** [..\lib\QtWebKit4.dll] Error 1 206956 1 52259 ossy 2010-03-31 22:34:22 -0700 Created attachment 52259 proposed fix Missing "LIBS += -lOle32" added. Missing ARRAYSIZE macro definition added if it isn't defined before. (copied from: \Program Files\Microsoft Platform SDK for Windows Server 2003 R2\Include\CeLib.h) 206958 2 webkit.review.bot 2010-03-31 22:37:08 -0700 Attachment 52259 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/UUID.cpp:39: Missing spaces around / [whitespace/operators] [3] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 206959 3 52260 ossy 2010-03-31 22:41:04 -0700 Created attachment 52260 proposed fix style fixed 206960 4 eric 2010-03-31 22:46:15 -0700 I see ARRAYSIZE_UNSAFE in: http://trac.webkit.org/changeset/53634 I thought we had an ARRAYSIZE macro in wtf/StdLibExtras.h, but we don't seem to. 207240 5 52260 jianli 2010-04-01 10:38:15 -0700 Comment on attachment 52260 proposed fix r=me 207250 6 ossy 2010-04-01 10:51:20 -0700 (In reply to comment #5) > (From update of attachment 52260 [details]) > r=me Landed in http://trac.webkit.org/changeset/56922 221005 7 55097 ossy 2010-05-05 01:25:15 -0700 Created attachment 55097 WinCE buildfix 221007 8 ossy 2010-05-05 01:27:59 -0700 WinCE build is broken too, fix attached here. See comments in https://bugs.webkit.org/show_bug.cgi?id=36472 221034 9 55097 hausmann 2010-05-05 02:42:49 -0700 Comment on attachment 55097 WinCE buildfix rs=me 221072 10 ossy 2010-05-05 05:59:53 -0700 (In reply to comment #9) > (From update of attachment 55097 [details]) > rs=me Landed in http://trac.webkit.org/changeset/58813 221083 11 webkit.review.bot 2010-05-05 06:43:56 -0700 http://trac.webkit.org/changeset/58813 might have broken Qt Linux Release 52259 2010-03-31 22:34:22 -0700 2010-03-31 22:41:04 -0700 proposed fix 1.patch text/plain 1260 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTIwYzMzOS4uOTc5MjQyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMy0zMSAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtRdF0gUkVHUkVTU0lPTihyNTY4NjkpOiBXaW5kb3dzIGJ1aWxk IGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzY5MjkKKworICAgICAgICAqIFdlYkNvcmUucHJvOiBMSUJTICs9IC1sT2xlMzIgYWRkZWQu CisgICAgICAgICogcGxhdGZvcm0vVVVJRC5jcHA6IERlZmluZSBBUlJBWVNJWkUgbWFjcm8gaWYg aXQgaXNuJ3QgZGVmaW5lZCBiZWZvcmUuCisKIDIwMTAtMDMtMzEgIE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CiAgICAgICAgIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB ZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5wcm8gYi9XZWJDb3JlL1dlYkNvcmUu cHJvCmluZGV4IDczMDMzNzAuLmZjZjBhNDggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5w cm8KKysrIGIvV2ViQ29yZS9XZWJDb3JlLnBybwpAQCAtMjE0MSw2ICsyMTQxLDcgQEAgbWFlbW81 IHsKIAogICAgIHdpbjMyLSogewogICAgICAgICBMSUJTICs9IC1sZ2RpMzIKKyAgICAgICAgTElC UyArPSAtbE9sZTMyCiAgICAgICAgIExJQlMgKz0gLWx1c2VyMzIKICAgICB9CiAgICAgd2luY2Uq OiBMSUJTICs9IC1sbW10aW1lcgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9VVUlELmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vVVVJRC5jcHAKaW5kZXggMjEzNWI4ZS4uZTM1NzQ1YyAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9VVUlELmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L1VVSUQuY3BwCkBAIC0zNSw2ICszNSw5IEBACiAKICNpZiBPUyhXSU5ET1dTKQogI2luY2x1ZGUg PG9iamJhc2UuaD4KKyNpZm5kZWYgQVJSQVlTSVpFCisjZGVmaW5lIEFSUkFZU0laRShhKSAgICAg ICAgICAgKHNpemVvZihhKS9zaXplb2YoKGEpWzBdKSkKKyNlbmRpZgogI2VsaWYgT1MoREFSV0lO KQogI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NvcmVGb3VuZGF0aW9uLmg+CiAjZWxpZiBPUyhM SU5VWCkK 52260 2010-03-31 22:41:04 -0700 2010-05-05 01:25:08 -0700 proposed fix 1.patch text/plain 1262 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTIwYzMzOS4uOTc5MjQyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMy0zMSAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtRdF0gUkVHUkVTU0lPTihyNTY4NjkpOiBXaW5kb3dzIGJ1aWxk IGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzY5MjkKKworICAgICAgICAqIFdlYkNvcmUucHJvOiBMSUJTICs9IC1sT2xlMzIgYWRkZWQu CisgICAgICAgICogcGxhdGZvcm0vVVVJRC5jcHA6IERlZmluZSBBUlJBWVNJWkUgbWFjcm8gaWYg aXQgaXNuJ3QgZGVmaW5lZCBiZWZvcmUuCisKIDIwMTAtMDMtMzEgIE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CiAgICAgICAgIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB ZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5wcm8gYi9XZWJDb3JlL1dlYkNvcmUu cHJvCmluZGV4IDczMDMzNzAuLmZjZjBhNDggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5w cm8KKysrIGIvV2ViQ29yZS9XZWJDb3JlLnBybwpAQCAtMjE0MSw2ICsyMTQxLDcgQEAgbWFlbW81 IHsKIAogICAgIHdpbjMyLSogewogICAgICAgICBMSUJTICs9IC1sZ2RpMzIKKyAgICAgICAgTElC UyArPSAtbE9sZTMyCiAgICAgICAgIExJQlMgKz0gLWx1c2VyMzIKICAgICB9CiAgICAgd2luY2Uq OiBMSUJTICs9IC1sbW10aW1lcgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9VVUlELmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vVVVJRC5jcHAKaW5kZXggMjEzNWI4ZS4uZDJkNjhjMSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9VVUlELmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L1VVSUQuY3BwCkBAIC0zNSw2ICszNSw5IEBACiAKICNpZiBPUyhXSU5ET1dTKQogI2luY2x1ZGUg PG9iamJhc2UuaD4KKyNpZm5kZWYgQVJSQVlTSVpFCisjZGVmaW5lIEFSUkFZU0laRShhKSAgICAg ICAgICAgKHNpemVvZihhKSAvIHNpemVvZigoYSlbMF0pKQorI2VuZGlmCiAjZWxpZiBPUyhEQVJX SU4pCiAjaW5jbHVkZSA8Q29yZUZvdW5kYXRpb24vQ29yZUZvdW5kYXRpb24uaD4KICNlbGlmIE9T KExJTlVYKQo= 55097 2010-05-05 01:25:15 -0700 2010-05-05 02:42:49 -0700 WinCE buildfix bug-36929-20100505012513.patch text/plain 953 ossy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODgwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUtMDUgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbUXRdIFJFR1JFU1NJT04ocjU2ODY5KTogV2luQ0UgYnVpbGQgaXMgYnJva2VuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjkyOQorCisgICAgICAg ICogV2ViQ29yZS5wcm86IExJQlMgKz0gLWxPbGUzMiBhZGRlZC4KKwogMjAxMC0wNS0wNSAgSm9z ZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUucHJvCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvV2ViQ29yZS5wcm8JKHJldmlzaW9uIDU4ODA3KQorKysgV2ViQ29yZS9XZWJDb3Jl LnBybwkod29ya2luZyBjb3B5KQpAQCAtMjE3Niw3ICsyMTc2LDEwIEBAIG1hZW1vNSB7CiAgICAg ICAgIExJQlMgKz0gLWxPbGUzMgogICAgICAgICBMSUJTICs9IC1sdXNlcjMyCiAgICAgfQotICAg IHdpbmNlKjogTElCUyArPSAtbG1tdGltZXIKKyAgICB3aW5jZSogeworICAgICAgICBMSUJTICs9 IC1sbW10aW1lcgorICAgICAgICBMSUJTICs9IC1sT2xlMzIKKyAgICB9CiAKIGNvbnRhaW5zKERF RklORVMsIEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJPTEpIHsKIAo=