36870 2010-03-30 22:28:03 -0700 [Qt] WebKit crashes while input text through input method 2010-04-09 01:14:38 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All CLOSED FIXED Qt P2 Critical --- 35784 0 tasuku.suzuki webkit-unassigned commit-queue hausmann joseph.ligman oldest_to_newest 206360 0 52128 tasuku.suzuki 2010-03-30 22:28:03 -0700 Created attachment 52128 Minimal test case for this issue QtWebKit crashes when I input text through input method on Windows 7, Mac OS X and Ubuntu Linux. 1. Launch Demo Browser in Qt. 2. Open google.com 3. Input "aiueo" in Japanese with Japanese IME 4. Translate it to Kanji. I'm sure this is not a language specific. Please see and run the minimal test case attached. 209417 1 52697 joseph.ligman 2010-04-06 20:26:51 -0700 Created attachment 52697 proposed patch I did some debugging with your test case and noticed that the problem could be with the underline start and end offset. 209528 2 tasuku.suzuki 2010-04-07 01:26:55 -0700 (In reply to comment #1) > Created an attachment (id=52697) [details] > proposed patch > > I did some debugging with your test case and noticed that the problem could be > with the underline start and end offset. I see that the problem was QWebPage passed start and length to CompositionUnderline instead of start and end. As far as I tested for a while, your patch works for me on Windows 7, Mac OS X(10.6) and Gentoo Linux. 209612 3 joseph.ligman 2010-04-07 06:44:54 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=52697) [details] [details] > > proposed patch > > > > I did some debugging with your test case and noticed that the problem could be > > with the underline start and end offset. > > I see that the problem was QWebPage passed start and length to > CompositionUnderline instead of start and end. > As far as I tested for a while, your patch works for me on Windows 7, Mac OS > X(10.6) and Gentoo Linux. Thanks. I will set the patch for review. 210122 4 52697 hausmann 2010-04-08 06:11:13 -0700 Comment on attachment 52697 proposed patch r=me 210128 5 52697 commit-queue 2010-04-08 06:24:32 -0700 Comment on attachment 52697 proposed patch Clearing flags on attachment: 52697 Committed r57270: <http://trac.webkit.org/changeset/57270> 210129 6 commit-queue 2010-04-08 06:24:37 -0700 All reviewed patches have been landed. Closing bug. 210623 7 hausmann 2010-04-09 01:14:07 -0700 Revision r57270 cherry-picked into qtwebkit-2.0 with commit b607ff42345b89dfcd328c95740491e8f9eeb367 52128 2010-03-30 22:28:03 -0700 2010-03-30 22:28:03 -0700 Minimal test case for this issue tst_qwebpage.cpp text/plain 1965 tasuku.suzuki I2luY2x1ZGUgPFF0VGVzdC9RdFRlc3Q+CgojaW5jbHVkZSA8UXRXZWJLaXQvUVdlYlZpZXc+CiNp bmNsdWRlIDxRdFdlYktpdC9RV2ViUGFnZT4KI2luY2x1ZGUgPFF0V2ViS2l0L1FXZWJGcmFtZT4K I2luY2x1ZGUgPFF0R3VpL1FJbnB1dE1ldGhvZEV2ZW50PgojaW5jbHVkZSA8UXRHdWkvUVRleHRD aGFyRm9ybWF0PgoKY2xhc3MgdHN0X1FXZWJQYWdlIDogcHVibGljIFFPYmplY3QKewogICAgUV9P QkpFQ1QKCnByaXZhdGUgc2xvdHM6CiAgICB2b2lkIGlucHV0TWV0aG9kc1RleHRGb3JtYXRfZGF0 YSgpOwogICAgdm9pZCBpbnB1dE1ldGhvZHNUZXh0Rm9ybWF0KCk7Cn07Cgp2b2lkIHRzdF9RV2Vi UGFnZTo6aW5wdXRNZXRob2RzVGV4dEZvcm1hdF9kYXRhKCkKewogICAgUVRlc3Q6OmFkZENvbHVt bjxRU3RyaW5nPigic3RyaW5nIik7CiAgICBRVGVzdDo6YWRkQ29sdW1uPGludD4oInN0YXJ0Iik7 CiAgICBRVGVzdDo6YWRkQ29sdW1uPGludD4oImxlbmd0aCIpOwogICAgUVRlc3Q6Om5ld1Jvdygi IikgPDwgUVN0cmluZygiIikgPDwgMCA8PCAwOwogICAgUVRlc3Q6Om5ld1JvdygiUSIpIDw8IFFT dHJpbmcoIlEiKSA8PCAwIDw8IDE7CiAgICBRVGVzdDo6bmV3Um93KCJRdCIpIDw8IFFTdHJpbmco IlF0IikgPDwgMCA8PCAxOwogICAgUVRlc3Q6Om5ld1JvdygiUXQiKSA8PCBRU3RyaW5nKCJRdCIp IDw8IDAgPDwgMjsKICAgIFFUZXN0OjpuZXdSb3coIlF0IikgPDwgUVN0cmluZygiUXQiKSA8PCAx IDw8IDE7CiAgICBRVGVzdDo6bmV3Um93KCJRdCAiKSA8PCBRU3RyaW5nKCJRdCAiKSA8PCAwIDw8 IDE7CiAgICBRVGVzdDo6bmV3Um93KCJRdCAiKSA8PCBRU3RyaW5nKCJRdCAiKSA8PCAxIDw8IDE7 CiAgICBRVGVzdDo6bmV3Um93KCJRdCAiKSA8PCBRU3RyaW5nKCJRdCAiKSA8PCAyIDw8IDE7CiAg ICBRVGVzdDo6bmV3Um93KCJRdCAiKSA8PCBRU3RyaW5nKCJRdCAiKSA8PCAwIDw8IDM7CiAgICBR VGVzdDo6bmV3Um93KCJRdCBieSIpIDw8IFFTdHJpbmcoIlF0IGJ5IikgPDwgMCA8PCAxOwogICAg UVRlc3Q6Om5ld1JvdygiUXQgYnkgTm9raWEiKSA8PCBRU3RyaW5nKCJRdCBieSBOb2tpYSIpIDw8 IDAgPDwgMTsKfQoKdm9pZCB0c3RfUVdlYlBhZ2U6OmlucHV0TWV0aG9kc1RleHRGb3JtYXQoKQp7 CiAgICBRRkVUQ0goUVN0cmluZywgc3RyaW5nKTsKICAgIFFGRVRDSChpbnQsIHN0YXJ0KTsKICAg IFFGRVRDSChpbnQsIGxlbmd0aCk7CgogICAgUVdlYlZpZXcqIHZpZXcgPSBuZXcgUVdlYlZpZXc7 CiAgICB2aWV3LT5wYWdlKCktPm1haW5GcmFtZSgpLT5zZXRIdG1sKCI8aHRtbD48Ym9keT48aW5w dXQgdHlwZT0ndGV4dCcgaWQ9J2lucHV0MScvPjwvYm9keT48L2h0bWw+Iik7CiAgICB2aWV3LT5w YWdlKCktPm1haW5GcmFtZSgpLT5ldmFsdWF0ZUphdmFTY3JpcHQoImRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdpbnB1dDEnKS5mb2N1cygpIik7CiAgICB2aWV3LT5wYWdlKCktPm1haW5GcmFtZSgp LT5zZXRGb2N1cygpOwogICAgdmlldy0+c2hvdygpOwoKICAgIFFMaXN0PFFJbnB1dE1ldGhvZEV2 ZW50OjpBdHRyaWJ1dGU+IGF0dHJzOwogICAgUVRleHRDaGFyRm9ybWF0IGZvcm1hdDsKICAgIGZv cm1hdC5zZXRVbmRlcmxpbmVTdHlsZShRVGV4dENoYXJGb3JtYXQ6OlNpbmdsZVVuZGVybGluZSk7 CiAgICBmb3JtYXQuc2V0VW5kZXJsaW5lQ29sb3IoUXQ6OnJlZCk7CiAgICBhdHRycy5hcHBlbmQo UUlucHV0TWV0aG9kRXZlbnQ6OkF0dHJpYnV0ZShRSW5wdXRNZXRob2RFdmVudDo6VGV4dEZvcm1h dCwgc3RhcnQsIGxlbmd0aCwgZm9ybWF0KSk7CiAgICBRSW5wdXRNZXRob2RFdmVudCBpbShzdHJp bmcsIGF0dHJzKTsKICAgIHZpZXctPnBhZ2UoKS0+ZXZlbnQoJmltKTsKCiAgICBRVGVzdDo6cVdh aXQoMTAwMCk7CiAgICBkZWxldGUgdmlldzsKfQoKUVRFU1RfTUFJTih0c3RfUVdlYlBhZ2UpCgoj aW5jbHVkZSAidHN0X3F3ZWJwYWdlLm1vYyIK 52697 2010-04-06 20:26:51 -0700 2010-04-08 06:24:32 -0700 proposed patch bug36870.patch text/plain 4622 joseph.ligman SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTcxODkpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMDYgIEpvZSBMaWdtYW4gIDxqb3NlcGgubGln bWFuQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIFdlYktpdCBjcmFzaGVzIHdoaWxlIGlucHV0IHRleHQgdGhyb3VnaCBpbnB1 dCBtZXRob2QuCisgICAgICAgIFRoZSBmb3JtYXR0ZWQgdGV4dCB1bmRlcmxpbmUgcGFpbnRpbmcg Y3Jhc2hlcyB3aGVuIHBhaW50aW5nIHdpdGggaW52YWxpZCBpbmRleGVzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY4NzAKKworICAgICAgICAqIEFw aS9xd2VicGFnZS5jcHA6CisgICAgICAgIChRV2ViUGFnZVByaXZhdGU6OmlucHV0TWV0aG9kRXZl bnQpOgorICAgICAgICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAg ICh0c3RfUVdlYlBhZ2U6OmlucHV0TWV0aG9kc1RleHRGb3JtYXRfZGF0YSk6CisgICAgICAgICh0 c3RfUVdlYlBhZ2U6OmlucHV0TWV0aG9kc1RleHRGb3JtYXQpOgorCiAyMDEwLTA0LTA2ICBEaWVn byBHb256YWxleiAgPGRpZWdvLmdvbnphbGV6QG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAkocmV2aXNpb24gNTcx ODIpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMz Myw3ICsxMzMzLDcgQEAgdm9pZCBRV2ViUGFnZVByaXZhdGU6OmlucHV0TWV0aG9kRXZlbnQoUQog ICAgICAgICBjYXNlIFFJbnB1dE1ldGhvZEV2ZW50OjpUZXh0Rm9ybWF0OiB7CiAgICAgICAgICAg ICBRVGV4dENoYXJGb3JtYXQgdGV4dENoYXJGb3JtYXQgPSBhLnZhbHVlLnZhbHVlPFFUZXh0Rm9y bWF0PigpLnRvQ2hhckZvcm1hdCgpOwogICAgICAgICAgICAgUUNvbG9yIHFjb2xvciA9IHRleHRD aGFyRm9ybWF0LnVuZGVybGluZUNvbG9yKCk7Ci0gICAgICAgICAgICB1bmRlcmxpbmVzLmFwcGVu ZChDb21wb3NpdGlvblVuZGVybGluZShhLnN0YXJ0LCBhLmxlbmd0aCwgQ29sb3IobWFrZVJHQkEo cWNvbG9yLnJlZCgpLCBxY29sb3IuZ3JlZW4oKSwgcWNvbG9yLmJsdWUoKSwgcWNvbG9yLmFscGhh KCkpKSwgZmFsc2UpKTsKKyAgICAgICAgICAgIHVuZGVybGluZXMuYXBwZW5kKENvbXBvc2l0aW9u VW5kZXJsaW5lKHFNaW4oYS5zdGFydCwgKGEuc3RhcnQgKyBhLmxlbmd0aCkpLCBxTWF4KGEuc3Rh cnQsIChhLnN0YXJ0ICsgYS5sZW5ndGgpKSwgQ29sb3IobWFrZVJHQkEocWNvbG9yLnJlZCgpLCBx Y29sb3IuZ3JlZW4oKSwgcWNvbG9yLmJsdWUoKSwgcWNvbG9yLmFscGhhKCkpKSwgZmFsc2UpKTsK ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGNhc2UgUUlucHV0TWV0aG9k RXZlbnQ6OkN1cnNvcjogewpJbmRleDogV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2Vi cGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2Vi cGFnZS5jcHAJKHJldmlzaW9uIDU3MTY4KQorKysgV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRl IDxRTWVudT4KICNpbmNsdWRlIDxRUHVzaEJ1dHRvbj4KICNpbmNsdWRlIDxRdFRlc3QvUXRUZXN0 PgorI2luY2x1ZGUgPFFUZXh0Q2hhckZvcm1hdD4KICNpbmNsdWRlIDxxZ3JhcGhpY3NzY2VuZS5o PgogI2luY2x1ZGUgPHFncmFwaGljc3ZpZXcuaD4KICNpbmNsdWRlIDxxZ3JhcGhpY3N3ZWJ2aWV3 Lmg+CkBAIC05OCw2ICs5OSw4IEBAIHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCBjb25zb2xlT3V0 cHV0KCk7CiAgICAgdm9pZCBpbnB1dE1ldGhvZHNfZGF0YSgpOwogICAgIHZvaWQgaW5wdXRNZXRo b2RzKCk7CisgICAgdm9pZCBpbnB1dE1ldGhvZHNUZXh0Rm9ybWF0X2RhdGEoKTsKKyAgICB2b2lk IGlucHV0TWV0aG9kc1RleHRGb3JtYXQoKTsKICAgICB2b2lkIGRlZmF1bHRUZXh0RW5jb2Rpbmco KTsKICAgICB2b2lkIGVycm9yUGFnZUV4dGVuc2lvbigpOwogICAgIHZvaWQgZXJyb3JQYWdlRXh0 ZW5zaW9uSW5JRnJhbWVzKCk7CkBAIC0xNDc5LDYgKzE0ODIsNTYgQEAgdm9pZCB0c3RfUVdlYlBh Z2U6OmlucHV0TWV0aG9kcygpCiAgICAgZGVsZXRlIGNvbnRhaW5lcjsKIH0KIAordm9pZCB0c3Rf UVdlYlBhZ2U6OmlucHV0TWV0aG9kc1RleHRGb3JtYXRfZGF0YSgpCit7CisgICAgUVRlc3Q6OmFk ZENvbHVtbjxRU3RyaW5nPigic3RyaW5nIik7CisgICAgUVRlc3Q6OmFkZENvbHVtbjxpbnQ+KCJz dGFydCIpOworICAgIFFUZXN0OjphZGRDb2x1bW48aW50PigibGVuZ3RoIik7CisKKyAgICBRVGVz dDo6bmV3Um93KCIiKSA8PCBRU3RyaW5nKCIiKSA8PCAwIDw8IDA7CisgICAgUVRlc3Q6Om5ld1Jv dygiUSIpIDw8IFFTdHJpbmcoIlEiKSA8PCAwIDw8IDE7CisgICAgUVRlc3Q6Om5ld1JvdygiUXQi KSA8PCBRU3RyaW5nKCJRdCIpIDw8IDAgPDwgMTsKKyAgICBRVGVzdDo6bmV3Um93KCJRdCIpIDw8 IFFTdHJpbmcoIlF0IikgPDwgMCA8PCAyOworICAgIFFUZXN0OjpuZXdSb3coIlF0IikgPDwgUVN0 cmluZygiUXQiKSA8PCAxIDw8IDE7CisgICAgUVRlc3Q6Om5ld1JvdygiUXQgIikgPDwgUVN0cmlu ZygiUXQgIikgPDwgMCA8PCAxOworICAgIFFUZXN0OjpuZXdSb3coIlF0ICIpIDw8IFFTdHJpbmco IlF0ICIpIDw8IDEgPDwgMTsKKyAgICBRVGVzdDo6bmV3Um93KCJRdCAiKSA8PCBRU3RyaW5nKCJR dCAiKSA8PCAyIDw8IDE7CisgICAgUVRlc3Q6Om5ld1JvdygiUXQgIikgPDwgUVN0cmluZygiUXQg IikgPDwgMiA8PCAtMTsKKyAgICBRVGVzdDo6bmV3Um93KCJRdCAiKSA8PCBRU3RyaW5nKCJRdCAi KSA8PCAtMiA8PCAzOworICAgIFFUZXN0OjpuZXdSb3coIlF0ICIpIDw8IFFTdHJpbmcoIlF0ICIp IDw8IDAgPDwgMzsKKyAgICBRVGVzdDo6bmV3Um93KCJRdCBieSIpIDw8IFFTdHJpbmcoIlF0IGJ5 IikgPDwgMCA8PCAxOworICAgIFFUZXN0OjpuZXdSb3coIlF0IGJ5IE5va2lhIikgPDwgUVN0cmlu ZygiUXQgYnkgTm9raWEiKSA8PCAwIDw8IDE7Cit9CisKKwordm9pZCB0c3RfUVdlYlBhZ2U6Omlu cHV0TWV0aG9kc1RleHRGb3JtYXQoKQoreworICAgIFFXZWJQYWdlKiBwYWdlID0gbmV3IFFXZWJQ YWdlOworICAgIFFXZWJWaWV3KiB2aWV3ID0gbmV3IFFXZWJWaWV3OworICAgIHZpZXctPnNldFBh Z2UocGFnZSk7CisgICAgcGFnZS0+c2V0dGluZ3MoKS0+c2V0Rm9udEZhbWlseShRV2ViU2V0dGlu Z3M6OlNlcmlmRm9udCwgIkZvb1NlcmlmRm9udCIpOworICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5z ZXRIdG1sKCI8aHRtbD48Ym9keT4iIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIjxpbnB1dCB0eXBlPSd0ZXh0JyBpZD0naW5wdXQxJyBzdHlsZT0nZm9udC1m YW1pbHk6IHNlcmlmJyB2YWx1ZT0nJyBtYXhsZW5ndGg9JzIwJy8+Iik7CisgICAgcGFnZS0+bWFp bkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlwdCgiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lu cHV0MScpLmZvY3VzKCkiKTsKKyAgICBwYWdlLT5tYWluRnJhbWUoKS0+c2V0Rm9jdXMoKTsKKyAg ICB2aWV3LT5zaG93KCk7CisKKyAgICBRRkVUQ0goUVN0cmluZywgc3RyaW5nKTsKKyAgICBRRkVU Q0goaW50LCBzdGFydCk7CisgICAgUUZFVENIKGludCwgbGVuZ3RoKTsKKworICAgIFFMaXN0PFFJ bnB1dE1ldGhvZEV2ZW50OjpBdHRyaWJ1dGU+IGF0dHJzOworICAgIFFUZXh0Q2hhckZvcm1hdCBm b3JtYXQ7CisgICAgZm9ybWF0LnNldFVuZGVybGluZVN0eWxlKFFUZXh0Q2hhckZvcm1hdDo6U2lu Z2xlVW5kZXJsaW5lKTsKKyAgICBmb3JtYXQuc2V0VW5kZXJsaW5lQ29sb3IoUXQ6OnJlZCk7Cisg ICAgYXR0cnMuYXBwZW5kKFFJbnB1dE1ldGhvZEV2ZW50OjpBdHRyaWJ1dGUoUUlucHV0TWV0aG9k RXZlbnQ6OlRleHRGb3JtYXQsIHN0YXJ0LCBsZW5ndGgsIGZvcm1hdCkpOworICAgIFFJbnB1dE1l dGhvZEV2ZW50IGltKHN0cmluZywgYXR0cnMpOworICAgIHBhZ2UtPmV2ZW50KCZpbSk7CisKKyAg ICBRVGVzdDo6cVdhaXQoMTAwMCk7CisKKyAgICBkZWxldGUgdmlldzsKK30KIC8vIGltcG9ydCBh IGxpdHRsZSBEUlQgaGVscGVyIGZ1bmN0aW9uIHRvIHRyaWdnZXIgdGhlIGdhcmJhZ2UgY29sbGVj dG9yCiB2b2lkIFFXRUJLSVRfRVhQT1JUIHF0X2RydF9nYXJiYWdlQ29sbGVjdG9yX2NvbGxlY3Qo KTsKIAo=