36760 2010-03-29 09:16:26 -0700 check-webkit-style shouldn't complain about namespace indents in forward declarations 2011-03-14 14:10:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 1 abarth webkit-unassigned cjerdonek darin hamaji levin oldest_to_newest 205475 0 abarth 2010-03-29 09:16:26 -0700 --- Comment #70 from Darin Adler <darin@apple.com> 2010-03-29 09:07:38 PST --- (In reply to comment #69) > > > Done, but now style checking script barks at me. > > > > Bug in the script. > > Is it? > > +namespace JSC { > + > + class JSGlobalData; > + class MarkStack; > + > +} > > versus Rule #3 <http://webkit.org/coding/coding-style.html>? There's nothing specific in the coding style document to make it clear that indenting is desirable in forward declarations as opposed to the actual code defined in a header. But there should be. 205487 1 levin 2010-03-29 09:29:23 -0700 It sounds like the desired rule is that namespaces which only have fwd declarations (class/struct) should be indented. (Or is it all fwd declarations should be indented?) I'm pretty sure it is the former. Original bug with the comment: https://bugs.webkit.org/show_bug.cgi?id=33696 367212 2 tonyg 2011-03-14 14:10:42 -0700 *** Bug 47755 has been marked as a duplicate of this bug. ***