36742 2010-03-29 01:14:13 -0700 compilation on gcce for Symbian fails 2010-03-31 17:19:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC S60 3rd edition CLOSED FIXED P1 Normal --- 35784 0 t.zander webkit-unassigned eric hausmann webkit.review.bot oldest_to_newest 205321 0 t.zander 2010-03-29 01:14:13 -0700 gcc for Symbian doesn't support gcc extensions like atomicity.h and fails on including them. 205323 1 51881 t.zander 2010-03-29 01:18:42 -0700 Created attachment 51881 Proposed fix JavaScriptCore/wtf/Threading.h: gcc for Symbian doesn't support gcc extensions like atomicity.h - disable 205327 2 webkit.review.bot 2010-03-29 01:24:24 -0700 Attachment 51881 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 205332 3 51884 t.zander 2010-03-29 01:44:56 -0700 Created attachment 51884 Proposed fix 205333 4 webkit.review.bot 2010-03-29 01:45:53 -0700 Attachment 51884 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 205338 5 t.zander 2010-03-29 01:53:02 -0700 running it locally shows no problems, not sure how to fix then :( WebKitTools/Scripts/check-webkit-style Total errors found: 0 in 2 files 205344 6 51884 hausmann 2010-03-29 02:06:25 -0700 Comment on attachment 51884 Proposed fix Looks good to me. I'll land it manually. 205347 7 hausmann 2010-03-29 02:08:26 -0700 (In reply to comment #6) > (From update of attachment 51884 [details]) > Looks good to me. I'll land it manually. (Manual because the patch doesn't apply with the standard tools, missing context it seems) 205349 8 hausmann 2010-03-29 02:11:11 -0700 Committed r56712: <http://trac.webkit.org/changeset/56712> 205353 9 hausmann 2010-03-29 02:17:01 -0700 Revision r56712 cherry-picked into qtwebkit-2.0 with commit 2b6255889c50a45035c045fd4575590f57887848 206838 10 eric 2010-03-31 17:19:17 -0700 Build 4429 (r56712) was the first to show failures: set([u'fast/js/kde/string-1-n.html', u'fast/js/kde/string-2-n.html']) Suspect revisions: r56712: http://trac.webkit.org/changeset/56712 Bug: 36742 (https://bugs.webkit.org/show_bug.cgi?id=36742) Author: "Thomas Zander" <t.zander@nokia.com> Reviewer: "Simon Hausmann" <hausmann@webkit.org> Committer: "Simon Hausmann" <hausmann@webkit.org> It appears this change caused a failure on teh Gtk 32-bit debug bot. 51881 2010-03-29 01:18:42 -0700 2010-03-29 01:44:56 -0700 Proposed fix gcce.diff text/plain 961 t.zander LS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmcuaAorKysgSmF2YVNjcmlwdENvcmUvd3Rm L1RocmVhZGluZy5oCkBAIC03NSw3ICs3NSw3IEBACiAjaW5jbHVkZSA8bGlia2Vybi9PU0F0b21p Yy5oPgogI2VsaWYgT1MoQU5EUk9JRCkKICNpbmNsdWRlIDxjdXRpbHMvYXRvbWljLmg+Ci0jZWxp ZiBDT01QSUxFUihHQ0MpCisjZWxpZiBDT01QSUxFUihHQ0MpICYmICFPUyhTWU1CSUFOKQogI2lm IChfX0dOVUNfXyA+IDQpIHx8ICgoX19HTlVDX18gPT0gNCkgJiYgKF9fR05VQ19NSU5PUl9fID49 IDIpKQogI2luY2x1ZGUgPGV4dC9hdG9taWNpdHkuaD4KICNlbHNlCkBAIC0yMzksNyArMjM5LDcg QEAgaW5saW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0 dXJuIE9TQXRvbWljRGVjcmVtZW50MzJCYXIKIGlubGluZSBpbnQgYXRvbWljSW5jcmVtZW50KGlu dCB2b2xhdGlsZSogYWRkZW5kKSB7IHJldHVybiBhbmRyb2lkX2F0b21pY19pbmMoYWRkZW5kKTsg fQogaW5saW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0 dXJuIGFuZHJvaWRfYXRvbWljX2RlYyhhZGRlbmQpOyB9CiAKLSNlbGlmIENPTVBJTEVSKEdDQykg JiYgIUNQVShTUEFSQzY0KSAvLyBzaXplb2YoX0F0b21pY193b3JkKSAhPSBzaXplb2YoaW50KSBv biBzcGFyYzY0IGdjYworI2VsaWYgQ09NUElMRVIoR0NDKSAmJiAhQ1BVKFNQQVJDNjQpICYmICFP UyhTWU1CSUFOKSAvLyBzaXplb2YoX0F0b21pY193b3JkKSAhPSBzaXplb2YoaW50KSBvbiBzcGFy YzY0IGdjYwogI2RlZmluZSBXVEZfVVNFX0xPQ0tGUkVFX1RIUkVBRFNBRkVTSEFSRUQgMQogCiBp bmxpbmUgaW50IGF0b21pY0luY3JlbWVudChpbnQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1cm4g X19nbnVfY3h4OjpfX2V4Y2hhbmdlX2FuZF9hZGQoYWRkZW5kLCAxKSArIDE7IH0KCg== 51884 2010-03-29 01:44:56 -0700 2010-03-29 02:06:24 -0700 Proposed fix gcce.diff text/plain 1353 t.zander LS0tIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTEgQEAKKzIwMTAtMDMtMjkgIFRob21hcyBaYW5kZXIgIDx0LnphbmRlckBu b2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZCisKKyAgICAgICAgZ2NjIGZv ciBTeW1iaWFuIGRvZXNuJ3Qgc3VwcG9ydCBnY2MgZXh0ZW5zaW9ucyBsaWtlIGF0b21pY2l0eS5o IC0gZGlzYWJsZQorCisgICAgICAgICogd3RmL1RocmVhZGluZy5oOiBhbHNvIGRldGVjdCBvcyBz eW1iaWFuCisKIDIwMTAtMDMtMjYgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRl QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KLS0tIEph dmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmcuaAorKysgSmF2YVNjcmlwdENvcmUvd3RmL1RocmVh ZGluZy5oCkBAIC03NSw3ICs3NSw3IEBACiAjaW5jbHVkZSA8bGlia2Vybi9PU0F0b21pYy5oPgog I2VsaWYgT1MoQU5EUk9JRCkKICNpbmNsdWRlIDxjdXRpbHMvYXRvbWljLmg+Ci0jZWxpZiBDT01Q SUxFUihHQ0MpCisjZWxpZiBDT01QSUxFUihHQ0MpICYmICFPUyhTWU1CSUFOKQogI2lmIChfX0dO VUNfXyA+IDQpIHx8ICgoX19HTlVDX18gPT0gNCkgJiYgKF9fR05VQ19NSU5PUl9fID49IDIpKQog I2luY2x1ZGUgPGV4dC9hdG9taWNpdHkuaD4KICNlbHNlCkBAIC0yMzksNyArMjM5LDcgQEAgaW5s aW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIE9T QXRvbWljRGVjcmVtZW50MzJCYXIKIGlubGluZSBpbnQgYXRvbWljSW5jcmVtZW50KGludCB2b2xh dGlsZSogYWRkZW5kKSB7IHJldHVybiBhbmRyb2lkX2F0b21pY19pbmMoYWRkZW5kKTsgfQogaW5s aW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIGFu ZHJvaWRfYXRvbWljX2RlYyhhZGRlbmQpOyB9CiAKLSNlbGlmIENPTVBJTEVSKEdDQykgJiYgIUNQ VShTUEFSQzY0KSAvLyBzaXplb2YoX0F0b21pY193b3JkKSAhPSBzaXplb2YoaW50KSBvbiBzcGFy YzY0IGdjYworI2VsaWYgQ09NUElMRVIoR0NDKSAmJiAhQ1BVKFNQQVJDNjQpICYmICFPUyhTWU1C SUFOKSAvLyBzaXplb2YoX0F0b21pY193b3JkKSAhPSBzaXplb2YoaW50KSBvbiBzcGFyYzY0IGdj YwogI2RlZmluZSBXVEZfVVNFX0xPQ0tGUkVFX1RIUkVBRFNBRkVTSEFSRUQgMQogCiBpbmxpbmUg aW50IGF0b21pY0luY3JlbWVudChpbnQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gX19nbnVf Y3h4OjpfX2V4Y2hhbmdlX2FuZF9hZGQoYWRkZW5kLCAxKSArIDE7IH0K