36735 2010-03-28 16:42:30 -0700 Live regions don't send out notifications when the element changing is the live region 2010-03-29 16:38:53 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin commit-queue oldest_to_newest 205261 0 cfleizach 2010-03-28 16:42:30 -0700 for example, if an image is the live region, and its alt text changes, it doesn't send out live region notifications 205262 1 51871 cfleizach 2010-03-28 16:49:24 -0700 Created attachment 51871 patch 205263 2 cfleizach 2010-03-28 16:50:44 -0700 the problem was that a live region change notification was only generated when an ancestor was a live region. it did not take into account if the element itself was the live region 205545 3 51871 commit-queue 2010-03-29 11:07:24 -0700 Comment on attachment 51871 patch Rejecting patch 51871 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12578 test cases. fast/workers/termination-with-port-messages.html -> failed Exiting early after 1 failures. 8861 tests run. 184.30s total testing time 8860 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1634020 205547 4 cfleizach 2010-03-29 11:10:00 -0700 unlikely that this patch caused this test to fail fast/workers/termination-with-port-messages.html 205556 5 51871 eric 2010-03-29 11:15:40 -0700 Comment on attachment 51871 patch Looks like bug 36585. 205736 6 51871 commit-queue 2010-03-29 16:38:48 -0700 Comment on attachment 51871 patch Clearing flags on attachment: 51871 Committed r56749: <http://trac.webkit.org/changeset/56749> 205737 7 commit-queue 2010-03-29 16:38:53 -0700 All reviewed patches have been landed. Closing bug. 51871 2010-03-28 16:49:24 -0700 2010-03-29 16:38:48 -0700 patch patch.txt text/plain 4825 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjcwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMjggIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWcgMzY3MzUgLSBMaXZlIHJlZ2lvbnMgZG9uJ3Qgc2VuZCBvdXQgbm90aWZpY2F0aW9ucyB3 aGVuIHRoZSBlbGVtZW50IGNoYW5naW5nIGlzIHRoZSBsaXZlIHJlZ2lvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY3MzUKKworICAgICAgICBUZXN0 OiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLWxpdmVyZWdpb24tb24taW1hZ2UuaHRt bAorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmNvbnRlbnRD aGFuZ2VkKToKKwogMjAxMC0wMy0yOCAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBX ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Qu Y3BwCShyZXZpc2lvbiA1NjY3OCkKKysrIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg1Nyw4ICsyODU3LDkgQEAg Ym9vbCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpjYW5TZXRUZQogdm9pZCBBY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0Ojpjb250ZW50Q2hhbmdlZCgpCiB7CiAgICAgLy8gSWYgdGhpcyBlbGVt ZW50IHN1cHBvcnRzIEFSSUEgbGl2ZSByZWdpb25zLCB0aGVuIG5vdGlmeSB0aGUgQVQgb2YgY2hh bmdlcy4KLSAgICBmb3IgKFJlbmRlck9iamVjdCogcmVuZGVyUGFyZW50ID0gbV9yZW5kZXJlci0+ cGFyZW50KCk7IHJlbmRlclBhcmVudDsgcmVuZGVyUGFyZW50ID0gcmVuZGVyUGFyZW50LT5wYXJl bnQoKSkgewotICAgICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnQgPSBtX3JlbmRlcmVy LT5kb2N1bWVudCgpLT5heE9iamVjdENhY2hlKCktPmdldChyZW5kZXJQYXJlbnQpOworICAgIEFY T2JqZWN0Q2FjaGUqIGNhY2hlID0gbV9yZW5kZXJlci0+ZG9jdW1lbnQoKS0+YXhPYmplY3RDYWNo ZSgpOworICAgIGZvciAoUmVuZGVyT2JqZWN0KiByZW5kZXJQYXJlbnQgPSBtX3JlbmRlcmVyOyBy ZW5kZXJQYXJlbnQ7IHJlbmRlclBhcmVudCA9IHJlbmRlclBhcmVudC0+cGFyZW50KCkpIHsKKyAg ICAgICAgQWNjZXNzaWJpbGl0eU9iamVjdCogcGFyZW50ID0gY2FjaGUtPmdldChyZW5kZXJQYXJl bnQpOwogICAgICAgICBpZiAoIXBhcmVudCkKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAg ICAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU2NzAzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMjggIENocmlzIEZsZWl6YWNo ICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBCdWcgMzY3MzUgLSBMaXZlIHJlZ2lvbnMgZG9uJ3Qgc2VuZCBvdXQg bm90aWZpY2F0aW9ucyB3aGVuIHRoZSBlbGVtZW50IGNoYW5naW5nIGlzIHRoZSBsaXZlIHJlZ2lv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY3MzUK KworICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtbGl2ZXJlZ2lvbi1v bi1pbWFnZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nl c3NpYmlsaXR5L2FyaWEtbGl2ZXJlZ2lvbi1vbi1pbWFnZS5odG1sOiBBZGRlZC4KKwogMjAxMC0w My0yOCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBb R1RLXSBJbXByb3ZlIHJlcG9ydGluZyBvZiBmcmFtZSBsb2FkZXIgY2FsbGJhY2tzIGluIERSVApJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1saXZlcmVn aW9uLW9uLWltYWdlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLWxpdmVyZWdpb24tb24taW1hZ2UtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxp dHkvYXJpYS1saXZlcmVnaW9uLW9uLWltYWdlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwxMSBAQAorCitUaGlzIHRlc3RzIHRoYXQgQVJJQSBsaXZlIHJlZ2lvbnMgdGhhdCBp cyBvbiBhbiBpbWFnZSB3aWxsIHdvcmsgd2hlbiB0aGUgYWx0IHRhZyBpcyBjaGFuZ2VkLgorCitP biBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xs b3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBhZGRlZE5vdGlmaWNhdGlvbiBpcyB0 cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1saXZlcmVn aW9uLW9uLWltYWdlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L2FjY2Vzc2liaWxpdHkvYXJpYS1saXZlcmVnaW9uLW9uLWltYWdlLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLWxpdmVyZWdp b24tb24taW1hZ2UuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0NSBAQAorPCFET0NUWVBF IEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxs aW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMt dGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdD4KK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxz ZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGlt ZyBhcmlhLWxpdmU9InBvbGl0ZSIgc3JjPSJ0ZXN0LmdpZiIgd2lkdGg9MTAwIGhlaWdodD0xMDAg YWx0PSJhbHQgdGV4dCIgdGFiaW5kZXg9MCBpZD0iaW1hZ2UiPgorCis8cCBpZD0iZGVzY3JpcHRp b24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorCisgICAgZGVz Y3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCBBUklBIGxpdmUgcmVnaW9ucyB0aGF0IGlzIG9uIGFu IGltYWdlIHdpbGwgd29yayB3aGVuIHRoZSBhbHQgdGFnIGlzIGNoYW5nZWQuIik7CisKKyAgICBm dW5jdGlvbiBhcmlhQ2FsbGJhY2sobm90aWZpY2F0aW9uKSB7CisgICAgICAgIGlmIChub3RpZmlj YXRpb24gPT0gIkFYTGl2ZVJlZ2lvbkNoYW5nZWQiKSB7CisgICAgICAgICAgICB3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9CisgICAgfQorCisgICAg aWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworICAgICAgICB3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworCisgICAgICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJpbWFnZSIpLmZvY3VzKCk7CisgICAgICAgIHZhciBpbWFnZSA9IHdpbmRv dy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsKKworICAgICAgICB2YXIg YWRkZWROb3RpZmljYXRpb24gPSBpbWFnZS5hZGROb3RpZmljYXRpb25MaXN0ZW5lcihhcmlhQ2Fs bGJhY2spOworICAgICAgICBzaG91bGRCZSgiYWRkZWROb3RpZmljYXRpb24iLCAidHJ1ZSIpOwor CisgICAgICAgIC8vIHRoaXMgc2hvdWxkIGFsc28gdHJpZ2dlciBvdXIgbGl2ZSByZWdpb24gY2hh bmdlIGJlY2F1c2UgaXRzIGEgdGV4dCBhbHRlcm5hdGl2ZSBjaGFuZ2UuIAorICAgICAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiaW1hZ2UiKS5zZXRBdHRyaWJ1dGUoJ2FsdCcsICJuZXcgaW1h Z2UgdGV4dCIpOworICAgIH0KKworICAgIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3Nj cmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qt cG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==