3673 2005-06-23 02:56:25 -0700 GW: Add QBuffer::setBuffer(QByteArray) support to KWQBuffer 2005-06-24 14:20:27 -0700 1 1 1 Unclassified WebKit New Bugs 412 Mac OS X 10.4 RESOLVED FIXED P3 Normal --- 3250 1 eric hyatt oldest_to_newest 12908 0 eric 2005-06-23 02:56:26 -0700 Adds QBuffer::setBuffer(QByteArray) support to KWQBuffer also adds QBuffer(QByteArray) constructor. The only thing I'm not sure about in this patch is the "open" state after setBuffer. However, I'm also pretty sure that it doesn't matter... at least for this minimalist implementation of QBuffer. Again code has been tested locally and does not affect the rest of WebKit. 12909 1 2577 eric 2005-06-23 02:58:21 -0700 Created attachment 2577 Adds setBuffer() support and a QByteArray based constructor 12923 2 2577 darin 2005-06-23 07:14:47 -0700 Comment on attachment 2577 Adds setBuffer() support and a QByteArray based constructor Formatting of QBuffer::setBuffer does not match our coding guidelines. The "{" should be on the line after the declaration, not on the same line. Also, the "if (isOpen()) return false;" should be broken into two lines rather than together on one. Other than the coding guidelines issue, this looks great. 12934 3 2589 eric 2005-06-23 09:23:35 -0700 Created attachment 2589 Formatting oversights now fixed. 12945 4 2589 darin 2005-06-23 10:01:40 -0700 Comment on attachment 2589 Formatting oversights now fixed. The parameter to the QBuffer constructor should be QByteArray, not QByteArray &, to match Qt. If it's going to be a reference, then I suggest that we make it const QByteArray & and do the same with the parameter to setBuffer. Otherwise, looks good. 12988 5 2606 eric 2005-06-23 12:55:22 -0700 Created attachment 2606 Fixed QByteArray & 13019 6 2606 darin 2005-06-23 22:58:06 -0700 Comment on attachment 2606 Fixed QByteArray & r=me 2577 2005-06-23 02:58:21 -0700 2005-06-23 09:23:35 -0700 Adds setBuffer() support and a QByteArray based constructor qbuffer.patch text/plain 1090 eric SW5kZXg6IEtXUUJ1ZmZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3Jl L2t3cS9LV1FCdWZmZXIuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNQpkaWZmIC1wIC11IC1y MS4xNSBLV1FCdWZmZXIuaAotLS0gS1dRQnVmZmVyLmgJMjAwMy8wMS8yMiAwMDoxMjozNAkxLjE1 CisrKyBLV1FCdWZmZXIuaAkyMDA1LzA2LzIzIDA5OjU1OjA5CkBAIC0zNSw3ICszNSw5IEBACiBj bGFzcyBRQnVmZmVyIHsKIHB1YmxpYzoKICAgICBRQnVmZmVyKCkgOiBvcGVuZWQoZmFsc2UpLCBw b3MoMCkgeyB9CisgICAgUUJ1ZmZlcihRQnl0ZUFycmF5ICZiKSA6IG9wZW5lZChmYWxzZSksIGJh KGIpLCBwb3MoMCkgeyB9CiAKKyAgICBib29sIHNldEJ1ZmZlcihRQnl0ZUFycmF5KTsKICAgICBR Qnl0ZUFycmF5IGJ1ZmZlcigpIGNvbnN0IHsgcmV0dXJuIGJhOyB9CiAgICAgdWludCBzaXplKCkg Y29uc3QgeyByZXR1cm4gYmEuc2l6ZSgpOyB9CiAgICAgYm9vbCBpc09wZW4oKSBjb25zdCB7IHJl dHVybiBvcGVuZWQ7IH0KSW5kZXg6IEtXUUJ1ZmZlci5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvV2ViQ29yZS9rd3EvS1dRQnVmZmVyLm1tLHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjUKZGlmZiAtcCAtdSAtcjEuNSBLV1FCdWZmZXIubW0KLS0tIEtXUUJ1ZmZlci5tbQkyMDAzLzAx LzIyIDAwOjEyOjM0CTEuNQorKysgS1dRQnVmZmVyLm1tCTIwMDUvMDYvMjMgMDk6NTU6MTAKQEAg LTQ4LDMgKzQ4LDEwIEBAIGludCBRQnVmZmVyOjp3cml0ZUJsb2NrKGNvbnN0IGNoYXIgKmRhdGEK IAogICAgIHJldHVybiBsZW47CiB9CisKK2Jvb2wgUUJ1ZmZlcjo6c2V0QnVmZmVyKFFCeXRlQXJy YXkgbmV3QnVmZikgeworICAgIGlmIChpc09wZW4oKSkgcmV0dXJuIGZhbHNlOworICAgIGJhLmR1 cGxpY2F0ZShuZXdCdWZmLmRhdGEoKSwgbmV3QnVmZi5zaXplKCkpOworICAgIHJldHVybiB0cnVl OworfQorCg== 2589 2005-06-23 09:23:35 -0700 2005-06-23 12:55:22 -0700 Formatting oversights now fixed. qbuffer2.patch text/plain 1100 eric SW5kZXg6IEtXUUJ1ZmZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3Jl L2t3cS9LV1FCdWZmZXIuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNQpkaWZmIC1wIC11IC1y MS4xNSBLV1FCdWZmZXIuaAotLS0gS1dRQnVmZmVyLmgJMjAwMy8wMS8yMiAwMDoxMjozNAkxLjE1 CisrKyBLV1FCdWZmZXIuaAkyMDA1LzA2LzIzIDE2OjIzOjIzCkBAIC0zNSw3ICszNSw5IEBACiBj bGFzcyBRQnVmZmVyIHsKIHB1YmxpYzoKICAgICBRQnVmZmVyKCkgOiBvcGVuZWQoZmFsc2UpLCBw b3MoMCkgeyB9CisgICAgUUJ1ZmZlcihRQnl0ZUFycmF5ICZiKSA6IG9wZW5lZChmYWxzZSksIGJh KGIpLCBwb3MoMCkgeyB9CiAKKyAgICBib29sIHNldEJ1ZmZlcihRQnl0ZUFycmF5KTsKICAgICBR Qnl0ZUFycmF5IGJ1ZmZlcigpIGNvbnN0IHsgcmV0dXJuIGJhOyB9CiAgICAgdWludCBzaXplKCkg Y29uc3QgeyByZXR1cm4gYmEuc2l6ZSgpOyB9CiAgICAgYm9vbCBpc09wZW4oKSBjb25zdCB7IHJl dHVybiBvcGVuZWQ7IH0KSW5kZXg6IEtXUUJ1ZmZlci5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvV2ViQ29yZS9rd3EvS1dRQnVmZmVyLm1tLHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjUKZGlmZiAtcCAtdSAtcjEuNSBLV1FCdWZmZXIubW0KLS0tIEtXUUJ1ZmZlci5tbQkyMDAzLzAx LzIyIDAwOjEyOjM0CTEuNQorKysgS1dRQnVmZmVyLm1tCTIwMDUvMDYvMjMgMTY6MjM6MjQKQEAg LTQ4LDMgKzQ4LDEyIEBAIGludCBRQnVmZmVyOjp3cml0ZUJsb2NrKGNvbnN0IGNoYXIgKmRhdGEK IAogICAgIHJldHVybiBsZW47CiB9CisKK2Jvb2wgUUJ1ZmZlcjo6c2V0QnVmZmVyKFFCeXRlQXJy YXkgbmV3QnVmZikKK3sKKyAgICBpZiAoaXNPcGVuKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KyAgICBiYS5kdXBsaWNhdGUobmV3QnVmZi5kYXRhKCksIG5ld0J1ZmYuc2l6ZSgpKTsKKyAgICBy ZXR1cm4gdHJ1ZTsKK30KKwo= 2606 2005-06-23 12:55:22 -0700 2005-06-23 22:58:06 -0700 Fixed QByteArray & buffer2.patch text/plain 1099 eric SW5kZXg6IEtXUUJ1ZmZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3Jl L2t3cS9LV1FCdWZmZXIuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNQpkaWZmIC1wIC11IC1y MS4xNSBLV1FCdWZmZXIuaAotLS0gS1dRQnVmZmVyLmgJMjAwMy8wMS8yMiAwMDoxMjozNAkxLjE1 CisrKyBLV1FCdWZmZXIuaAkyMDA1LzA2LzIzIDE5OjU0OjM1CkBAIC0zNSw3ICszNSw5IEBACiBj bGFzcyBRQnVmZmVyIHsKIHB1YmxpYzoKICAgICBRQnVmZmVyKCkgOiBvcGVuZWQoZmFsc2UpLCBw b3MoMCkgeyB9CisgICAgUUJ1ZmZlcihRQnl0ZUFycmF5IGIpIDogb3BlbmVkKGZhbHNlKSwgYmEo YiksIHBvcygwKSB7IH0KIAorICAgIGJvb2wgc2V0QnVmZmVyKFFCeXRlQXJyYXkpOwogICAgIFFC eXRlQXJyYXkgYnVmZmVyKCkgY29uc3QgeyByZXR1cm4gYmE7IH0KICAgICB1aW50IHNpemUoKSBj b25zdCB7IHJldHVybiBiYS5zaXplKCk7IH0KICAgICBib29sIGlzT3BlbigpIGNvbnN0IHsgcmV0 dXJuIG9wZW5lZDsgfQpJbmRleDogS1dRQnVmZmVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvcm9vdC9XZWJDb3JlL2t3cS9LV1FCdWZmZXIubW0sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu NQpkaWZmIC1wIC11IC1yMS41IEtXUUJ1ZmZlci5tbQotLS0gS1dRQnVmZmVyLm1tCTIwMDMvMDEv MjIgMDA6MTI6MzQJMS41CisrKyBLV1FCdWZmZXIubW0JMjAwNS8wNi8yMyAxOTo1NDozNQpAQCAt NDgsMyArNDgsMTIgQEAgaW50IFFCdWZmZXI6OndyaXRlQmxvY2soY29uc3QgY2hhciAqZGF0YQog CiAgICAgcmV0dXJuIGxlbjsKIH0KKworYm9vbCBRQnVmZmVyOjpzZXRCdWZmZXIoUUJ5dGVBcnJh eSBuZXdCdWZmKQoreworICAgIGlmIChpc09wZW4oKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIGJhLmR1cGxpY2F0ZShuZXdCdWZmLmRhdGEoKSwgbmV3QnVmZi5zaXplKCkpOworICAgIHJl dHVybiB0cnVlOworfQorCg==