3670 2005-06-23 02:20:53 -0700 GW: Add remove and byteOrderMark support to KWQString for kdom 2005-07-03 16:21:42 -0700 1 1 1 Unclassified WebKit New Bugs 412 Mac OS X 10.4 VERIFIED FIXED P3 Normal --- 3250 1 eric hyatt oldest_to_newest 12901 0 eric 2005-06-23 02:20:54 -0700 Add remove and byteOrderMark support to KWQString for kdom 12902 1 2574 eric 2005-06-23 02:26:05 -0700 Created attachment 2574 Adds remove() and byteOrderMark support to KWQString I'm not entirely sure about the byteOrderMark stuff, I'm not a unicode expert... The remove stuff should be just fine. 12903 2 2574 eric 2005-06-23 02:26:46 -0700 Comment on attachment 2574 Adds remove() and byteOrderMark support to KWQString Either way, this code is well tested, and seems to work fine for me ;-) 12920 3 2574 darin 2005-06-23 07:08:23 -0700 Comment on attachment 2574 Adds remove() and byteOrderMark support to KWQString Formatting is incorrect in the definitions of "remove". There are extra spaces before the "(" and ")" characters. Also, there's no need for "this->" in the implenetations of those methods. 12933 4 2588 eric 2005-06-23 09:18:50 -0700 Created attachment 2588 Formatting oversights now fixed. 12942 5 2588 darin 2005-06-23 09:59:54 -0700 Comment on attachment 2588 Formatting oversights now fixed. r=me 13809 6 joost 2005-07-03 08:17:36 -0700 Eric, could you confirm this one (too :) )? 2574 2005-06-23 02:26:05 -0700 2005-06-23 07:08:23 -0700 Adds remove() and byteOrderMark support to KWQString string.patch text/plain 1183 eric SW5kZXg6IGt3cS9LV1FTdHJpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2Vi Q29yZS9rd3EvS1dRU3RyaW5nLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTExCmRpZmYgLXAg LXUgLXIxLjExMSBrd3EvS1dRU3RyaW5nLmgKLS0tIGt3cS9LV1FTdHJpbmcuaAkyMDA1LzA1LzI2 IDIyOjE1OjU2CTEuMTExCisrKyBrd3EvS1dRU3RyaW5nLmgJMjAwNS8wNi8yMyAwOToxNToxOQpA QCAtNDksNiArNDksMTAgQEAgcHVibGljOgogICAgICAgICBEaXJMID0gMCwgRGlyUiwgRGlyRU4s IERpckVTLCBEaXJFVCwgRGlyQU4sIERpckNTLCBEaXJCLCBEaXJTLCBEaXJXUywgRGlyT04sCiAg ICAgICAgIERpckxSRSwgRGlyTFJPLCBEaXJBTCwgRGlyUkxFLCBEaXJSTE8sIERpclBERiwgRGly TlNNLCBEaXJCTgogICAgIH07CisgICAgCisgICAgZW51bSBTcGVjaWFsQ2hhcmFjdGVyIHsKKyAg ICAgICAgYnl0ZU9yZGVyTWFyayA9IDB4ZmVmZgorICAgIH07CiAKICAgICBzdGF0aWMgY29uc3Qg Y2hhciBudWxsID0gMDsgLy8gbm90IGEgUUNoYXIgYXMgaW4gUXQgKGNhbid0IGhhdmUgc3RhdGlj IGNvbnN0cnVjdG9yKSwgYnV0IGNsb3NlIGVub3VnaCB0byBiZSBjb21wYXRpYmxlIGluIG1vc3Qg Y2FzZXMKIApAQCAtNTM4LDYgKzU0Miw4IEBAIHB1YmxpYzoKICAgICBRU3RyaW5nICZpbnNlcnQo dWludCBpbmRleCwgY29uc3QgY2hhciAqaW5zZXJ0Q2hhcnMsIHVpbnQgaW5zZXJ0TGVuZ3RoKTsK ICAgICBRU3RyaW5nICZwcmVwZW5kKGNvbnN0IFFTdHJpbmcgJik7CiAgICAgUVN0cmluZyAmcmVt b3ZlKHVpbnQsIHVpbnQpOworICAgIFFTdHJpbmcgJnJlbW92ZSAoY29uc3QgUUNoYXIgJmMgKSB7 IHJldHVybiB0aGlzLT5yZXBsYWNlKFFTdHJpbmcoYyksICIiKTsgfQorICAgIFFTdHJpbmcgJnJl bW92ZSAoY29uc3QgUVN0cmluZyAmcyApIHsgcmV0dXJuIHRoaXMtPnJlcGxhY2UocywgIiIpOyB9 CiAgICAgUVN0cmluZyAmcmVwbGFjZSh1aW50IGluZGV4LCB1aW50IGxlbiwgY29uc3QgUVN0cmlu ZyAmcyk7CiAgICAgUVN0cmluZyAmcmVwbGFjZShjaGFyLCBjb25zdCBRU3RyaW5nICYpOwogICAg IFFTdHJpbmcgJnJlcGxhY2UoUUNoYXIsIGNvbnN0IFFTdHJpbmcgJik7Cg== 2588 2005-06-23 09:18:50 -0700 2005-06-23 09:59:54 -0700 Formatting oversights now fixed. string2.patch text/plain 1151 eric SW5kZXg6IEtXUVN0cmluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3Jl L2t3cS9LV1FTdHJpbmcuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMTEKZGlmZiAtcCAtdSAt cjEuMTExIEtXUVN0cmluZy5oCi0tLSBLV1FTdHJpbmcuaAkyMDA1LzA1LzI2IDIyOjE1OjU2CTEu MTExCisrKyBLV1FTdHJpbmcuaAkyMDA1LzA2LzIzIDE2OjEzOjUyCkBAIC00OSw2ICs0OSwxMCBA QCBwdWJsaWM6CiAgICAgICAgIERpckwgPSAwLCBEaXJSLCBEaXJFTiwgRGlyRVMsIERpckVULCBE aXJBTiwgRGlyQ1MsIERpckIsIERpclMsIERpcldTLCBEaXJPTiwKICAgICAgICAgRGlyTFJFLCBE aXJMUk8sIERpckFMLCBEaXJSTEUsIERpclJMTywgRGlyUERGLCBEaXJOU00sIERpckJOCiAgICAg fTsKKyAgICAKKyAgICBlbnVtIFNwZWNpYWxDaGFyYWN0ZXIgeworICAgICAgICBieXRlT3JkZXJN YXJrID0gMHhmZWZmCisgICAgfTsKIAogICAgIHN0YXRpYyBjb25zdCBjaGFyIG51bGwgPSAwOyAv LyBub3QgYSBRQ2hhciBhcyBpbiBRdCAoY2FuJ3QgaGF2ZSBzdGF0aWMgY29uc3RydWN0b3IpLCBi dXQgY2xvc2UgZW5vdWdoIHRvIGJlIGNvbXBhdGlibGUgaW4gbW9zdCBjYXNlcwogCkBAIC01Mzgs NiArNTQyLDggQEAgcHVibGljOgogICAgIFFTdHJpbmcgJmluc2VydCh1aW50IGluZGV4LCBjb25z dCBjaGFyICppbnNlcnRDaGFycywgdWludCBpbnNlcnRMZW5ndGgpOwogICAgIFFTdHJpbmcgJnBy ZXBlbmQoY29uc3QgUVN0cmluZyAmKTsKICAgICBRU3RyaW5nICZyZW1vdmUodWludCwgdWludCk7 CisgICAgUVN0cmluZyAmcmVtb3ZlKGNvbnN0IFFDaGFyICZjKSB7IHJldHVybiByZXBsYWNlKFFT dHJpbmcoYyksICIiKTsgfQorICAgIFFTdHJpbmcgJnJlbW92ZShjb25zdCBRU3RyaW5nICZzKSB7 IHJldHVybiByZXBsYWNlKHMsICIiKTsgfQogICAgIFFTdHJpbmcgJnJlcGxhY2UodWludCBpbmRl eCwgdWludCBsZW4sIGNvbnN0IFFTdHJpbmcgJnMpOwogICAgIFFTdHJpbmcgJnJlcGxhY2UoY2hh ciwgY29uc3QgUVN0cmluZyAmKTsKICAgICBRU3RyaW5nICZyZXBsYWNlKFFDaGFyLCBjb25zdCBR U3RyaW5nICYpOwo=