36686 2010-03-26 18:11:32 -0700 Handling of fixed pos state in mapLocalToContainer() may be wrong 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 37637 36652 1 simon.fraser simon.fraser benjamin hausmann kenneth oldest_to_newest 204888 0 simon.fraser 2010-03-26 18:11:32 -0700 mapLocalToContainer() may do the wrong thing when called directly on a fixed, transformed element, because 'fixed' on entry is false, and will stay false when we hit the hasTransform test. 204892 1 simon.fraser 2010-03-26 18:15:15 -0700 See bug 36652 also. 205409 2 benjamin 2010-03-29 05:36:26 -0700 I agree, this looks wrong. I will do a pixel test for it. 205456 3 51916 benjamin 2010-03-29 08:39:50 -0700 Created attachment 51916 Test case Another test case, this one should have the problems of computeRectForRepaint() and mapLocalToContainer(). 205478 4 51919 benjamin 2010-03-29 09:17:26 -0700 Created attachment 51919 Quick patch Quick fix. It passes the test and solve https://bug-36652-attachments.webkit.org/attachment.cgi?id=51750 But curiously, not https://bug-36686-attachments.webkit.org/attachment.cgi?id=51916 although the update rect is now at the correct position. I need to investigate why the previous area is not repainted correctly. 205610 5 51951 benjamin 2010-03-29 12:48:41 -0700 Created attachment 51951 New test case without transormation Apparently, the previous test case also show another, possibly unrelated, bug. This attachment is similar to https://bugs.webkit.org/attachment.cgi?id=51916 without the transformation. The bug is still present. I think about submitting this patch: https://bugs.webkit.org/attachment.cgi?id=51919 with this test: https://bug-36652-attachments.webkit.org/attachment.cgi?id=51750 for this bug report. And create a new bug report for https://bugs.webkit.org/attachment.cgi?id=51916 which look a bit more urgent than the current task. Simon, is that ok with you? 205654 6 simon.fraser 2010-03-29 13:46:08 -0700 I think we should fix the non-transformed bug (your last testcase) first. 205673 7 benjamin 2010-03-29 14:39:55 -0700 (In reply to comment #6) > I think we should fix the non-transformed bug (your last testcase) first. I agree. I have created the bug report https://bugs.webkit.org/show_bug.cgi?id=36783 for this case. I might be able to investigate it tomorrow. I will also make a proper patch for 36686 so I have a chance to close 36652 this week. 222344 8 kenneth 2010-05-07 07:11:11 -0700 (In reply to comment #7) > (In reply to comment #6) > > I think we should fix the non-transformed bug (your last testcase) first. > > I agree. I have created the bug report > https://bugs.webkit.org/show_bug.cgi?id=36783 for this case. > > I might be able to investigate it tomorrow. I will also make a proper patch for > 36686 so I have a chance to close 36652 this week. Any work on this? 51916 2010-03-29 08:39:50 -0700 2010-03-29 08:39:50 -0700 Test case fixed-transformed-update-after-move.html text/html 768 benjamin PGh0bWw+CjxoZWFkPgogICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgogICAgICAg IGZ1bmN0aW9uIHNjcm9sbEFuZFJlcGFpbnQoKQogICAgICAgIHsKICAgICAgICAgICAgc2Nyb2xs QnkoMCwgMTAwKTsKICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg ewogICAgICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7CiAgICAgICAgICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kaXNwbGF5KCk7CiAgICAgICAgICAgICAgICByZXBhaW50 VGVzdCgpOwogICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgc2V0VGltZW91dChy ZXBhaW50VGVzdCwgMTAwKTsKICAgICAgICAgICAgfQogICAgICAgfQogICAgICAgZnVuY3Rpb24g cmVwYWludFRlc3QoKQogICAgICAgewogICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCd0cmFuc2Zvcm1lZCcpLnN0eWxlLmxlZnQgPSAiMzAwcHgiOwogICAgICAgfQogICAgPC9zY3Jp cHQ+CjwvaGVhZD4KPGJvZHkgb25sb2FkPSJzY3JvbGxBbmRSZXBhaW50KCkiIHN0eWxlPSJoZWln aHQ6IDUwMDBweDsiPgoKIDxkaXYgaWQ9InRyYW5zZm9ybWVkIiBzdHlsZT0id2lkdGg6IDEwMHB4 OyBoZWlnaHQ6IDEwMHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsgcG9zaXRpb246IGZpeGVk OyB0b3A6IDcwcHg7IGxlZnQ6IDE3MHB4OyAtd2Via2l0LXRyYW5zZm9ybTogcm90YXRlKDMwZGVn KTsiPjwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 51919 2010-03-29 09:17:26 -0700 2010-06-11 13:00:50 -0700 Quick patch 36652.patch text/plain 2782 benjamin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3guY3BwCmluZGV4IDFjMGU4MzcuLmE0YjE4Y2UgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcApAQCAtOTc3LDEwICs5NzcsMTAgQEAgdm9pZCBSZW5kZXJCb3g6Om1hcExv Y2FsVG9Db250YWluZXIoUmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIsIGJv b2wKIAogICAgIGJvb2wgaXNGaXhlZFBvcyA9IHN0eWxlKCktPnBvc2l0aW9uKCkgPT0gRml4ZWRQ b3NpdGlvbjsKICAgICBib29sIGhhc1RyYW5zZm9ybSA9IGhhc0xheWVyKCkgJiYgbGF5ZXIoKS0+ dHJhbnNmb3JtKCk7Ci0gICAgaWYgKGhhc1RyYW5zZm9ybSkgeworICAgIGlmIChoYXNUcmFuc2Zv cm0gJiYgIWlzRml4ZWRQb3MpIHsKICAgICAgICAgLy8gSWYgdGhpcyBib3ggaGFzIGEgdHJhbnNm b3JtLCBpdCBhY3RzIGFzIGEgZml4ZWQgcG9zaXRpb24gY29udGFpbmVyIGZvciBmaXhlZCBkZXNj ZW5kYW50cywKICAgICAgICAgLy8gYW5kIG1heSBpdHNlbGYgYWxzbyBiZSBmaXhlZCBwb3NpdGlv bi4gU28gcHJvcGFnYXRlICdmaXhlZCcgdXAgb25seSBpZiB0aGlzIGJveCBpcyBmaXhlZCBwb3Np dGlvbi4KLSAgICAgICAgZml4ZWQgJj0gaXNGaXhlZFBvczsKKyAgICAgICAgZml4ZWQgPSBmYWxz ZTsKICAgICB9IGVsc2UKICAgICAgICAgZml4ZWQgfD0gaXNGaXhlZFBvczsKICAgICAKQEAgLTEw MTIsMTAgKzEwMTIsMTAgQEAgdm9pZCBSZW5kZXJCb3g6Om1hcEFic29sdXRlVG9Mb2NhbFBvaW50 KGJvb2wgZml4ZWQsIGJvb2wgdXNlVHJhbnNmb3JtcywgVHJhbnNmb3IKICAgICAKICAgICBib29s IGlzRml4ZWRQb3MgPSBzdHlsZSgpLT5wb3NpdGlvbigpID09IEZpeGVkUG9zaXRpb247CiAgICAg Ym9vbCBoYXNUcmFuc2Zvcm0gPSBoYXNMYXllcigpICYmIGxheWVyKCktPnRyYW5zZm9ybSgpOwot ICAgIGlmIChoYXNUcmFuc2Zvcm0pIHsKKyAgICBpZiAoaGFzVHJhbnNmb3JtICYmICFpc0ZpeGVk UG9zKSB7CiAgICAgICAgIC8vIElmIHRoaXMgYm94IGhhcyBhIHRyYW5zZm9ybSwgaXQgYWN0cyBh cyBhIGZpeGVkIHBvc2l0aW9uIGNvbnRhaW5lciBmb3IgZml4ZWQgZGVzY2VuZGFudHMsCiAgICAg ICAgIC8vIGFuZCBtYXkgaXRzZWxmIGFsc28gYmUgZml4ZWQgcG9zaXRpb24uIFNvIHByb3BhZ2F0 ZSAnZml4ZWQnIHVwIG9ubHkgaWYgdGhpcyBib3ggaXMgZml4ZWQgcG9zaXRpb24uCi0gICAgICAg IGZpeGVkICY9IGlzRml4ZWRQb3M7CisgICAgICAgIGZpeGVkID0gZmFsc2U7CiAgICAgfSBlbHNl CiAgICAgICAgIGZpeGVkIHw9IGlzRml4ZWRQb3M7CiAgICAgCkBAIC0xMTc5LDggKzExNzksMTQg QEAgdm9pZCBSZW5kZXJCb3g6OmNvbXB1dGVSZWN0Rm9yUmVwYWludChSZW5kZXJCb3hNb2RlbE9i amVjdCogcmVwYWludENvbnRhaW5lciwgSW4KICAgICBJbnRQb2ludCB0b3BMZWZ0ID0gcmVjdC5s b2NhdGlvbigpOwogICAgIHRvcExlZnQubW92ZSh4KCksIHkoKSk7CiAKLSAgICBpZiAoc3R5bGUo KS0+cG9zaXRpb24oKSA9PSBGaXhlZFBvc2l0aW9uKQotICAgICAgICBmaXhlZCA9IHRydWU7Cisg ICAgYm9vbCBpc0ZpeGVkUG9zID0gc3R5bGUoKS0+cG9zaXRpb24oKSA9PSBGaXhlZFBvc2l0aW9u OworICAgIGJvb2wgaGFzVHJhbnNmb3JtID0gaGFzTGF5ZXIoKSAmJiBsYXllcigpLT50cmFuc2Zv cm0oKTsKKyAgICBpZiAoaGFzVHJhbnNmb3JtICYmICFpc0ZpeGVkUG9zKSB7CisgICAgICAgIC8v IElmIHRoaXMgYm94IGhhcyBhIHRyYW5zZm9ybSwgaXQgYWN0cyBhcyBhIGZpeGVkIHBvc2l0aW9u IGNvbnRhaW5lciBmb3IgZml4ZWQgZGVzY2VuZGFudHMsCisgICAgICAgIC8vIGFuZCBtYXkgaXRz ZWxmIGFsc28gYmUgZml4ZWQgcG9zaXRpb24uIFNvIHByb3BhZ2F0ZSAnZml4ZWQnIHVwIG9ubHkg aWYgdGhpcyBib3ggaXMgZml4ZWQgcG9zaXRpb24uCisgICAgICAgIGZpeGVkID0gZmFsc2U7Cisg ICAgfSBlbHNlCisgICAgICAgIGZpeGVkIHw9IGlzRml4ZWRQb3M7CiAKICAgICBpZiAoby0+aXNC bG9ja0Zsb3coKSAmJiBzdHlsZSgpLT5wb3NpdGlvbigpICE9IEFic29sdXRlUG9zaXRpb24gJiYg c3R5bGUoKS0+cG9zaXRpb24oKSAhPSBGaXhlZFBvc2l0aW9uKSB7CiAgICAgICAgIFJlbmRlckJs b2NrKiBjYiA9IHRvUmVuZGVyQmxvY2sobyk7CkBAIC0xMTk0LDggKzEyMDAsNyBAQCB2b2lkIFJl bmRlckJveDo6Y29tcHV0ZVJlY3RGb3JSZXBhaW50KFJlbmRlckJveE1vZGVsT2JqZWN0KiByZXBh aW50Q29udGFpbmVyLCBJbgogCiAgICAgLy8gV2UgYXJlIG5vdyBpbiBvdXIgcGFyZW50IGNvbnRh aW5lcidzIGNvb3JkaW5hdGUgc3BhY2UuICBBcHBseSBvdXIgdHJhbnNmb3JtIHRvIG9idGFpbiBh IGJvdW5kaW5nIGJveAogICAgIC8vIGluIHRoZSBwYXJlbnQncyBjb29yZGluYXRlIHNwYWNlIHRo YXQgZW5jbG9zZXMgdXMuCi0gICAgaWYgKGxheWVyKCkgJiYgbGF5ZXIoKS0+dHJhbnNmb3JtKCkp IHsKLSAgICAgICAgZml4ZWQgPSBmYWxzZTsKKyAgICBpZiAoaGFzVHJhbnNmb3JtKSB7CiAgICAg ICAgIHJlY3QgPSBsYXllcigpLT50cmFuc2Zvcm0oKS0+bWFwUmVjdChyZWN0KTsKICAgICAgICAg Ly8gRklYTUU6IHRoaXMgY2xvYmJlcnMgdG9wTGVmdCBhZGp1c3RtZW50IGRvbmUgZm9yIG11bHRp Y29sIGFib3ZlCiAgICAgICAgIHRvcExlZnQgPSByZWN0LmxvY2F0aW9uKCk7Cg== 51951 2010-03-29 12:48:41 -0700 2010-03-29 12:48:41 -0700 New test case without transormation fixed-update-after-move.html text/html 882 benjamin PGh0bWw+PGhlYWQ+CjxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4 dC9odG1sOyBjaGFyc2V0PVVURi04Ij4KCiAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCI+CiAgICAgICAgZnVuY3Rpb24gc2Nyb2xsQW5kUmVwYWludCgpCiAgICAgICAgewogICAgICAg ICAgICBzY3JvbGxCeSgwLCAxMDApOwogICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKSB7CiAgICAgICAgICAgICAgICBkb2N1bWVudC5ib2R5Lm9mZnNldFRvcDsKICAg ICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmRpc3BsYXkoKTsKICAgICAgICAgICAg ICAgIHJlcGFpbnRUZXN0KCk7CiAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICBz ZXRUaW1lb3V0KHJlcGFpbnRUZXN0LCAxMDApOwogICAgICAgICAgICB9CiAgICAgICB9CiAgICAg ICBmdW5jdGlvbiByZXBhaW50VGVzdCgpCiAgICAgICB7CiAgICAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3RyYW5zZm9ybWVkJykuc3R5bGUubGVmdCA9ICI2MDBweCI7CiAgICAgICAg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RyYW5zZm9ybWVkJykuc3R5bGUuYmFja2dyb3Vu ZENvbG9yID0gImJsdWUiOwogICAgICAgfQogICAgPC9zY3JpcHQ+CjwvaGVhZD48Ym9keSBvbmxv YWQ9InNjcm9sbEFuZFJlcGFpbnQoKSIgc3R5bGU9ImhlaWdodDogNTAwMHB4OyI+CgogPGRpdiBp ZD0idHJhbnNmb3JtZWQiIHN0eWxlPSJ3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7IGJhY2tn cm91bmQtY29sb3I6IGdyZWVuOyBwb3NpdGlvbjogZml4ZWQ7IHRvcDogNzBweDsgbGVmdDogMzAw cHg7Ij48L2Rpdj4KPC9ib2R5PjwvaHRtbD4K