36674 2010-03-26 14:06:28 -0700 [Qt] qtwebkit_webframe_scrollRecursively scrolls when body.style.overflow="hidden" 2010-04-16 16:59:00 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware All CLOSED FIXED Qt P3 Normal --- 35784 1 joseph.ligman webkit-unassigned commit-queue hausmann laszlo.gombos tonikitoo oldest_to_newest 204770 0 joseph.ligman 2010-03-26 14:06:28 -0700 The frame scrolling check is based off of the frame view's IntSize scrollOffset = frame->view()->scrollOffset(); IntPoint maxScrollOffset = frame->view()->maximumScrollPosition(); This doesn't not automatically account for the body.overflow property 205479 1 51920 joseph.ligman 2010-03-29 09:19:50 -0700 Created attachment 51920 Proposed patch. 210094 2 51920 commit-queue 2010-04-08 02:14:00 -0700 Comment on attachment 51920 Proposed patch. Clearing flags on attachment: 51920 Committed r57266: <http://trac.webkit.org/changeset/57266> 210095 3 commit-queue 2010-04-08 02:14:06 -0700 All reviewed patches have been landed. Closing bug. 210113 4 hausmann 2010-04-08 03:40:46 -0700 Revision r57266 cherry-picked into qtwebkit-2.0 with commit ea5bda76dbcd88545b7552630e4ff9015c3bfacf 213499 5 hausmann 2010-04-16 16:59:00 -0700 (In reply to comment #2) > (From update of attachment 51920 [details]) > Clearing flags on attachment: 51920 > > Committed r57266: <http://trac.webkit.org/changeset/57266> Cherry-picked into qtwebkit-4.6 with commit 6ed0b6197addffc7dacbdb3e49db711420a2c47a 51920 2010-03-29 09:19:50 -0700 2010-04-08 02:14:00 -0700 Proposed patch. bug36674.patch text/plain 4133 joseph.ligman SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTY3MjMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDMtMjkgIEpvZSBMaWdtYW4gIDxqb3NlcGgubGln bWFuQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIHF0d2Via2l0X3dlYmZyYW1lX3Njcm9sbFJlY3Vyc2l2ZWx5IHNjcm9sbHMg d2hlbiBib2R5LnN0eWxlLm92ZXJmbG93PSJoaWRkZW4iCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjY3NAorCisgICAgICAgIFRoZSBzY3JvbGxpbmcg Y2hlY2sgd2FzIGJhc2VkIG9uIHRoZSBmcmFtZXZpZXcncyBzY3JvbGxvZmZzZXQsIGFuZAorICAg ICAgICBtYXhpbXVtU2Nyb2xsUG9zaXRpb24sIHdoaWNoIGRvZXMgbm90IGFja25vd2xlZGdlIHRo ZSBvdmVyZmxvdyBwcm9wZXJ0aWVzLgorCisgICAgICAgIEkgYW0gbm93IGJhc2luZyB0aGUgc2Ny b2xsaW5nIG9mZiB0aGUgc2Nyb2xsYmFyIHBvc2l0aW9uLiBUaGUgc2Nyb2xsYmFycyBhcmUKKyAg ICAgICAgYWZmZWN0ZWQgYnkgdGhlIG92ZXJmbG93IHByb3BlcnRpZXMgaW5kaWNhdGluZyB3aGVu IG5vdCB0byBzY3JvbGwuIFRoZSBzY3JvbGxiYXIKKyAgICAgICAgcG9zaXRpb25zIGFsc28gY29u dGludWUgdG8gd29yayBmb3IgQ1NTIDo6LXdlYmtpdC1zY3JvbGxiYXIgc3R5bGVzLgorCisgICAg ICAgICogQXBpL3F3ZWJmcmFtZS5jcHA6CisgICAgICAgIChxdHdlYmtpdF93ZWJmcmFtZV9zY3Jv bGxSZWN1cnNpdmVseSk6CisKIDIwMTAtMDMtMjkgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1 c21hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7gu CkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L3F0L0FwaS9xd2ViZnJhbWUuY3BwCShyZXZpc2lvbiA1NjcyMykKKysrIFdlYktpdC9xdC9BcGkv cXdlYmZyYW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjc3LDEwICsyNzcsMTEgQEAgdm9pZCBR V0VCS0lUX0VYUE9SVCBxdF9kcnRfZXZhbHVhdGVTY3JpcAogCiBzdGF0aWMgYm9vbCB3ZWJmcmFt ZV9zY3JvbGxPdmVyZmxvdyhXZWJDb3JlOjpGcmFtZSogZnJhbWUsIGludCBkeCwgaW50IGR5LCBj b25zdCBRUG9pbnQmIHBvcykKIHsKLSAgICBpZiAoIWZyYW1lIHx8ICFmcmFtZS0+ZG9jdW1lbnQo KSB8fCAhZnJhbWUtPmV2ZW50SGFuZGxlcigpKQorICAgIGlmICghZnJhbWUgfHwgIWZyYW1lLT5k b2N1bWVudCgpIHx8ICFmcmFtZS0+dmlldygpIHx8ICFmcmFtZS0+ZXZlbnRIYW5kbGVyKCkpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIE5vZGUqIG5vZGUgPSBmcmFtZS0+ZG9jdW1lbnQo KS0+ZWxlbWVudEZyb21Qb2ludChwb3MueCgpLCBwb3MueSgpKTsKKyAgICBRUG9pbnQgY29udGVu dHNQb3MgPSBmcmFtZS0+dmlldygpLT53aW5kb3dUb0NvbnRlbnRzKHBvcyk7CisgICAgTm9kZSog bm9kZSA9IGZyYW1lLT5kb2N1bWVudCgpLT5lbGVtZW50RnJvbVBvaW50KGNvbnRlbnRzUG9zLngo KSwgY29udGVudHNQb3MueSgpKTsKICAgICBpZiAoIW5vZGUpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKIApAQCAtMzIxLDM3ICszMjIsMzMgQEAgc3RhdGljIGJvb2wgd2ViZnJhbWVfc2Nyb2xsT3Zl cmZsb3coV2ViQwogKi8KIHZvaWQgUVdFQktJVF9FWFBPUlQgcXR3ZWJraXRfd2ViZnJhbWVfc2Ny b2xsUmVjdXJzaXZlbHkoUVdlYkZyYW1lKiBxRnJhbWUsIGludCBkeCwgaW50IGR5LCBjb25zdCBR UG9pbnQmIHBvcykKIHsKLSAgICBGcmFtZSogZnJhbWUgPSBRV2ViRnJhbWVQcml2YXRlOjpjb3Jl KHFGcmFtZSk7CisgICAgaWYgKCFxRnJhbWUpCisgICAgICAgIHJldHVybjsKIAotICAgIGlmICgh ZnJhbWUgfHwgIWZyYW1lLT52aWV3KCkpCisgICAgaWYgKHdlYmZyYW1lX3Njcm9sbE92ZXJmbG93 KFFXZWJGcmFtZVByaXZhdGU6OmNvcmUocUZyYW1lKSwgZHgsIGR5LCBwb3MpKQogICAgICAgICBy ZXR1cm47Ci0gICAgCi0gICAgaWYgKCF3ZWJmcmFtZV9zY3JvbGxPdmVyZmxvdyhmcmFtZSwgZHgs IGR5LCBwb3MpKSB7Ci0gICAgICAgIGRvIHsKLSAgICAgICAgICAgIGJvb2wgc2Nyb2xsZWRIb3Jp em9udGFsID0gZmFsc2U7Ci0gICAgICAgICAgICBib29sIHNjcm9sbGVkVmVydGljYWwgPSBmYWxz ZTsKLSAgICAgICAgICAgIAotICAgICAgICAgICAgSW50U2l6ZSBzY3JvbGxPZmZzZXQgPSBmcmFt ZS0+dmlldygpLT5zY3JvbGxPZmZzZXQoKTsKLSAgICAgICAgICAgIEludFBvaW50IG1heFNjcm9s bE9mZnNldCA9IGZyYW1lLT52aWV3KCktPm1heGltdW1TY3JvbGxQb3NpdGlvbigpOwotCi0gICAg ICAgICAgICBpZiAoZHggPiAwKSAvLyBzY3JvbGwgcmlnaHQKLSAgICAgICAgICAgICAgICBzY3Jv bGxlZEhvcml6b250YWwgPSBzY3JvbGxPZmZzZXQud2lkdGgoKSA8IG1heFNjcm9sbE9mZnNldC54 KCk7Ci0gICAgICAgICAgICBlbHNlIGlmIChkeCA8IDApIC8vIHNjcm9sbCBsZWZ0Ci0gICAgICAg ICAgICAgICAgc2Nyb2xsZWRIb3Jpem9udGFsID0gc2Nyb2xsT2Zmc2V0LndpZHRoKCkgPiAwOwog Ci0gICAgICAgICAgICBpZiAoZHkgPiAwKSAvLyBzY3JvbGwgZG93bgotICAgICAgICAgICAgICAg IHNjcm9sbGVkVmVydGljYWwgPSBzY3JvbGxPZmZzZXQuaGVpZ2h0KCkgPCBtYXhTY3JvbGxPZmZz ZXQueSgpOworICAgIGJvb2wgc2Nyb2xsSG9yaXpvbnRhbCA9IGZhbHNlOworICAgIGJvb2wgc2Ny b2xsVmVydGljYWwgPSBmYWxzZTsKKworICAgIGRvIHsKKyAgICAgICAgaWYgKGR4ID4gMCkgIC8v IHNjcm9sbCByaWdodAorICAgICAgICAgICAgc2Nyb2xsSG9yaXpvbnRhbCA9IHFGcmFtZS0+c2Ny b2xsQmFyVmFsdWUoUXQ6Okhvcml6b250YWwpIDwgcUZyYW1lLT5zY3JvbGxCYXJNYXhpbXVtKFF0 OjpIb3Jpem9udGFsKTsKKyAgICAgICAgZWxzZSBpZiAoZHggPCAwKSAgLy8gc2Nyb2xsIGxlZnQK KyAgICAgICAgICAgIHNjcm9sbEhvcml6b250YWwgPSBxRnJhbWUtPnNjcm9sbEJhclZhbHVlKFF0 OjpIb3Jpem9udGFsKSA+IHFGcmFtZS0+c2Nyb2xsQmFyTWluaW11bShRdDo6SG9yaXpvbnRhbCk7 CisKKyAgICAgICAgaWYgKGR5ID4gMCkgIC8vIHNjcm9sbCBkb3duCisgICAgICAgICAgICBzY3Jv bGxWZXJ0aWNhbCA9IHFGcmFtZS0+c2Nyb2xsQmFyVmFsdWUoUXQ6OlZlcnRpY2FsKSA8IHFGcmFt ZS0+c2Nyb2xsQmFyTWF4aW11bShRdDo6VmVydGljYWwpOwogICAgICAgICAgICAgZWxzZSBpZiAo ZHkgPCAwKSAvL3Njcm9sbCB1cAotICAgICAgICAgICAgICAgIHNjcm9sbGVkVmVydGljYWwgPSBz Y3JvbGxPZmZzZXQuaGVpZ2h0KCkgPiAwOworICAgICAgICAgICAgc2Nyb2xsVmVydGljYWwgPSBx RnJhbWUtPnNjcm9sbEJhclZhbHVlKFF0OjpWZXJ0aWNhbCkgPiBxRnJhbWUtPnNjcm9sbEJhck1p bmltdW0oUXQ6OlZlcnRpY2FsKTsKIAotICAgICAgICAgICAgaWYgKHNjcm9sbGVkSG9yaXpvbnRh bCB8fCBzY3JvbGxlZFZlcnRpY2FsKSB7Ci0gICAgICAgICAgICAgICAgZnJhbWUtPnZpZXcoKS0+ c2Nyb2xsQnkoSW50U2l6ZShkeCwgZHkpKTsKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAg ICAgICAgICB9Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIGZyYW1lID0gZnJhbWUtPnRyZWUo KS0+cGFyZW50KCk7IAotICAgICAgICB9IHdoaWxlIChmcmFtZSAmJiBmcmFtZS0+dmlldygpKTsK LSAgICB9CisgICAgICAgIGlmIChzY3JvbGxIb3Jpem9udGFsIHx8IHNjcm9sbFZlcnRpY2FsKSB7 CisgICAgICAgICAgICBxRnJhbWUtPnNjcm9sbChkeCwgZHkpOworICAgICAgICAgICAgcmV0dXJu OworICAgICAgICB9CisKKyAgICAgICAgcUZyYW1lID0gcUZyYW1lLT5wYXJlbnRGcmFtZSgpOwor ICAgIH0gd2hpbGUgKHFGcmFtZSk7CiB9CiAKIAo=