<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>36638</bug_id>
          
          <creation_ts>2010-03-25 19:09:43 -0700</creation_ts>
          <short_desc>Commit bot tried to land r? cq+ patch</short_desc>
          <delta_ts>2011-01-10 03:22:00 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Julien Chaffraix">jchaffraix</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>204377</commentid>
    <comment_count>0</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2010-03-25 19:09:43 -0700</bug_when>
    <thetext>Found in https://bugs.webkit.org/show_bug.cgi?id=36531

After having attached a patch for review and set the cq to +, the bot tried to land the patch directly and failed due to not finding any reviewer.

When posting the second patch, the first patch was still r? but I obsoleted it. The new patch original flags were r? and cq+.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>204860</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-03-26 16:46:34 -0700</bug_when>
    <thetext>If you mark a patch commit-queue+, the bot will try to land it.  If it wasn&apos;t reviewed, it doesn&apos;t sound like it&apos;s ready for commit.  Why did you mark it commit-queue+?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>204862</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-03-26 16:48:04 -0700</bug_when>
    <thetext>Oh posh.  I think we should handle this case.  We should not try to land patches which still have r? or which are marked r-.  Only empty review or r+.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>204867</commentid>
    <comment_count>3</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2010-03-26 16:55:49 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; If you mark a patch commit-queue+, the bot will try to land it.  If it wasn&apos;t
&gt; reviewed, it doesn&apos;t sound like it&apos;s ready for commit.  Why did you mark it
&gt; commit-queue+?

Simple, because I wanted the bot to land it for me (I usually land my patches manually to deal with the fallout). This one was special: it was a test fix so it was better to get it landed ASAP.
I have barely used the commit bot so my naive thought was that the bot would just wait until was reviewed to land it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331475</commentid>
    <comment_count>4</comment_count>
      <attachid>78357</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-01-09 15:23:41 -0800</bug_when>
    <thetext>Created attachment 78357
should work, needs testing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331476</commentid>
    <comment_count>5</comment_count>
      <attachid>78357</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-09 15:53:31 -0800</bug_when>
    <thetext>Comment on attachment 78357
should work, needs testing

Looks right.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331547</commentid>
    <comment_count>6</comment_count>
      <attachid>78381</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-01-10 01:56:38 -0800</bug_when>
    <thetext>Created attachment 78381
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331555</commentid>
    <comment_count>7</comment_count>
      <attachid>78381</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-10 02:09:30 -0800</bug_when>
    <thetext>Comment on attachment 78381
Patch

Now, this patch, on the other hand, is very nice.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331577</commentid>
    <comment_count>8</comment_count>
      <attachid>78381</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-10 03:21:55 -0800</bug_when>
    <thetext>Comment on attachment 78381
Patch

Clearing flags on attachment: 78381

Committed r75366: &lt;http://trac.webkit.org/changeset/75366&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331578</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-10 03:22:00 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>78357</attachid>
            <date>2011-01-09 15:23:41 -0800</date>
            <delta_ts>2011-01-10 01:56:34 -0800</delta_ts>
            <desc>should work, needs testing</desc>
            <filename>bug-36638-20110109152340.patch</filename>
            <type>text/plain</type>
            <size>1831</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ZDg3
OTE3N2JhZDUxYzM4MzMwYzYxMWIyZGY0OWU3N2VmMGMyNTZmLi4yNWI2YmNmYzliMTA3NzYyN2Qz
ZTk2MjM5ZTY0M2Q3Y2VlNTg0NTRmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv
VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDEtMDkgIEVyaWMgU2VpZGVs
ICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIENvbW1pdCBib3QgdHJpZWQgdG8gbGFuZCByPyBjcSsgcGF0Y2gKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NjM4CisKKyAgICAg
ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZlZWRlcnMucHk6CisKIDIwMTEtMDEtMDgg
IEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KIAogICAgICAg
ICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1Rv
b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvZmVlZGVycy5weSBiL1Rvb2xzL1NjcmlwdHMv
d2Via2l0cHkvdG9vbC9ib3QvZmVlZGVycy5weQppbmRleCAwNDZjNGMxZDZiZDNjZDAzZmEyODcy
ZGNiOTRmODIyZTE5NTg1YTI2Li44MjZjNWIwODgxNmVjOGFjY2YyYTg3OGM4MzZhZTMwYWY3ZDNj
OWI4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZlZWRlcnMu
cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9mZWVkZXJzLnB5CkBAIC01
NCw2ICs1NCw3IEBAIGNsYXNzIENvbW1pdFF1ZXVlRmVlZGVyKEFic3RyYWN0RmVlZGVyKToKIAog
ICAgIGRlZiBmZWVkKHNlbGYpOgogICAgICAgICBwYXRjaGVzID0gc2VsZi5fdmFsaWRhdGVfcGF0
Y2hlcygpCisgICAgICAgIHBhdGNoZXMgPSBzZWxmLl9wYXRjaGVzX3JlYWR5X2Zvcl9jb21taXQo
cGF0Y2hlcykKICAgICAgICAgcGF0Y2hlcyA9IHNvcnRlZChwYXRjaGVzLCBzZWxmLl9wYXRjaF9j
bXApCiAgICAgICAgIHBhdGNoX2lkcyA9IFtwYXRjaC5pZCgpIGZvciBwYXRjaCBpbiBwYXRjaGVz
XQogICAgICAgICBzZWxmLl91cGRhdGVfd29ya19pdGVtcyhwYXRjaF9pZHMpCkBAIC02MSw2ICs2
MiwxMCBAQCBjbGFzcyBDb21taXRRdWV1ZUZlZWRlcihBYnN0cmFjdEZlZWRlcik6CiAgICAgZGVm
IF9wYXRjaGVzX2Zvcl9idWcoc2VsZiwgYnVnX2lkKToKICAgICAgICAgcmV0dXJuIHNlbGYuX3Rv
b2wuYnVncy5mZXRjaF9idWcoYnVnX2lkKS5jb21taXRfcXVldWVkX3BhdGNoZXMoaW5jbHVkZV9p
bnZhbGlkPVRydWUpCiAKKyAgICAjIEZpbHRlcnMgb3V0IHBhdGNoZXMgd2l0aCByPyBvciByLSwg
b25seSByKyBvciBubyByZXZpZXcgYXJlICJyZWFkeSIKKyAgICBkZWYgX3BhdGNoZXNfcmVhZHlf
Zm9yX2NvbW1pdChzZWxmLCBwYXRjaGVzKToKKyAgICAgICAgcmV0dXJuIFtwYXRjaCBmb3IgcGF0
Y2ggaW4gcGF0Y2hlcyBpZiBwYXRjaC5yZXZpZXcoKSBpbiBbTm9uZSwgJysnXV0KKwogICAgIGRl
ZiBfdmFsaWRhdGVfcGF0Y2hlcyhzZWxmKToKICAgICAgICAgIyBOb3QgdXNpbmcgQnVnemlsbGFR
dWVyaWVzLmZldGNoX3BhdGNoZXNfZnJvbV9jb21taXRfcXVldWUoKSBzbyB3ZSBjYW4gcmVqZWN0
IHBhdGNoZXMgd2l0aCBpbnZhbGlkIGNvbW1pdHRlcnMvcmV2aWV3ZXJzLgogICAgICAgICBidWdf
aWRzID0gc2VsZi5fdG9vbC5idWdzLnF1ZXJpZXMuZmV0Y2hfYnVnX2lkc19mcm9tX2NvbW1pdF9x
dWV1ZSgpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>78381</attachid>
            <date>2011-01-10 01:56:38 -0800</date>
            <delta_ts>2011-01-10 03:21:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-36638-20110110015636.patch</filename>
            <type>text/plain</type>
            <size>6154</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ZDg3
OTE3N2JhZDUxYzM4MzMwYzYxMWIyZGY0OWU3N2VmMGMyNTZmLi4wZGFjNTk1NWUxZjgxYjQxZTM5
ZWU5NzBhNTFjNWUyYjgzZGI2NjkzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv
VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDEtMTAgIEVyaWMgU2VpZGVs
ICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIENvbW1pdCBib3QgdHJpZWQgdG8gbGFuZCByPyBjcSsgcGF0Y2gKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NjM4CisKKyAgICAg
ICAgSXQgc2hvdWxkIG5vdyBiZSBwb3NzaWJsZSB0byBwb3N0IGEgcGF0Y2ggd2l0aCByPyBhbmQg
Y3ErIGFuZCB0aGUKKyAgICAgICAgY29tbWl0LXF1ZXVlIHdpbGwgY29ycmVjdGx5IHdhaXQgZm9y
IHRoZSByKyBiZWZvcmUgYXR0ZW1wdGluZyB0byBsYW5kIHRoZSBwYXRjaC4KKyAgICAgICAgKFRo
aXMgd2FzIGEgZmVhdHVyZSByZXF1ZXN0ZWQgYnkgc2V2ZXJhbCB1c2Vycy4pCisKKyAgICAgICAg
T25lIGNhdmVhdDogV2UgZG9uJ3QgYWN0dWFsbHkgcmVqZWN0IHItLCBjcSsgcGF0Y2hlcyBmcm9t
IHRoZSBxdWV1ZQorICAgICAgICAod2UganVzdCBpZ25vcmUgdGhlbSksIGJ1dCBJIHRoaW5rIHRo
YXQncyBPSyBmb3Igbm93LgorCisgICAgICAgIEkgYWxzbyBub3RpY2VkIHRoYXQgc2V0dGluZyBy
LSBvbmNlIGEgY29tbWl0LXF1ZXVlIG5vZGUgaGFkIGdyYWJiZWQKKyAgICAgICAgYSBwYXRjaCB3
b3VsZCBub3QgcHJvcGVybHkgY2FuY2VsIHRoZSBsYW5kaW5nLiAgVGhhdCdzIGZpeGVkIGFuZAor
ICAgICAgICB0ZXN0ZWQgaW4gdGhpcyBwYXRjaC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0
cHkvdG9vbC9ib3QvY29tbWl0cXVldWV0YXNrLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0
cHkvdG9vbC9ib3QvY29tbWl0cXVldWV0YXNrX3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlw
dHMvd2Via2l0cHkvdG9vbC9ib3QvZmVlZGVycy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp
dHB5L3Rvb2wvYm90L2ZlZWRlcnNfdW5pdHRlc3QucHk6CisKIDIwMTEtMDEtMDggIEJlbmphbWlu
IFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl
ZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdG9vbC9ib3QvY29tbWl0cXVldWV0YXNrLnB5IGIvVG9vbHMvU2NyaXB0cy93
ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHkKaW5kZXggNGJkYzc5YjFlMTNjNGY1
YTc0MWYzZmU0ZjY0MjdkMjU1NmJlY2YzYS4uZjk5MjY3YTYxYzhhNTkwNDU2NTBkYzNlOWRiNzI5
YjQxMjFjZGFiNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9j
b21taXRxdWV1ZXRhc2sucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9j
b21taXRxdWV1ZXRhc2sucHkKQEAgLTY2LDYgKzY2LDggQEAgY2xhc3MgQ29tbWl0UXVldWVUYXNr
KG9iamVjdCk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgaWYgbm90IHNlbGYu
X3BhdGNoLmNvbW1pdHRlcigpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisgICAgICAgIGlm
IG5vdCBzZWxmLl9wYXRjaC5yZXZpZXcoKSAhPSAiLSI6CisgICAgICAgICAgICByZXR1cm4gRmFs
c2UKICAgICAgICAgIyBSZXZpZXdlciBpcyBub3QgcmVxdWlyZWQuIE1pc3NpbmcgcmV2aWV3ZXJz
IHdpbGwgYmUgY2F1Z2h0IGR1cmluZwogICAgICAgICAjIHRoZSBDaGFuZ2VMb2cgY2hlY2sgZHVy
aW5nIGxhbmRpbmcuCiAgICAgICAgIHJldHVybiBUcnVlCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp
cHRzL3dlYmtpdHB5L3Rvb2wvYm90L2NvbW1pdHF1ZXVldGFza191bml0dGVzdC5weSBiL1Rvb2xz
L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvY29tbWl0cXVldWV0YXNrX3VuaXR0ZXN0LnB5Cmlu
ZGV4IGYyNzljYWM1NGUxMzVhOTQ2NWI3ZDBiNTQ5ODIwMDJhZGYyNjgxMmUuLmQ3MGMzMmI0NTlm
YTJkZTE5NzQ0ZTI3YzAyYTNhMjFkMDQ3YWFhYjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv
d2Via2l0cHkvdG9vbC9ib3QvY29tbWl0cXVldWV0YXNrX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xz
L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvY29tbWl0cXVldWV0YXNrX3VuaXR0ZXN0LnB5CkBA
IC0yOSw2ICsyOSw3IEBACiBmcm9tIGRhdGV0aW1lIGltcG9ydCBkYXRldGltZQogaW1wb3J0IHVu
aXR0ZXN0CiAKK2Zyb20gd2Via2l0cHkuY29tbW9uLm5ldCBpbXBvcnQgYnVnemlsbGEKIGZyb20g
d2Via2l0cHkuY29tbW9uLnN5c3RlbS5kZXByZWNhdGVkX2xvZ2dpbmcgaW1wb3J0IGVycm9yLCBs
b2cKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5vdXRwdXRjYXB0dXJlIGltcG9ydCBPdXRw
dXRDYXB0dXJlCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5sYXlvdXRfcGFja2FnZSBpbXBv
cnQgdGVzdF9yZXN1bHRzCkBAIC0zMjAsMyArMzIxLDI0IEBAIGNvbW1hbmRfZmFpbGVkOiBmYWls
dXJlX21lc3NhZ2U9J1VuYWJsZSB0byBsYW5kIHBhdGNoJyBzY3JpcHRfZXJyb3I9J01PQ0sgbGFu
ZCBmCiAiIiIKICAgICAgICAgIyBGSVhNRTogVGhpcyBzaG91bGQgcmVhbGx5IGJlIGV4cGVjdF9y
ZXRyeT1UcnVlIGZvciBhIGJldHRlciB1c2VyIGV4cGVyaWFuY2UuCiAgICAgICAgIHNlbGYuX3J1
bl90aHJvdWdoX3Rhc2soY29tbWl0X3F1ZXVlLCBleHBlY3RlZF9zdGRlcnIsIFNjcmlwdEVycm9y
KQorCisgICAgZGVmIF9leHBlY3RfdmFsaWRhdGUoc2VsZiwgcGF0Y2gsIGlzX3ZhbGlkKToKKyAg
ICAgICAgY2xhc3MgTW9ja0RlbGVnYXRlKG9iamVjdCk6CisgICAgICAgICAgICBkZWYgcmVmZXRj
aF9wYXRjaChzZWxmLCBwYXRjaCk6CisgICAgICAgICAgICAgICAgcmV0dXJuIHBhdGNoCisKKyAg
ICAgICAgdGFzayA9IENvbW1pdFF1ZXVlVGFzayhNb2NrRGVsZWdhdGUoKSwgcGF0Y2gpCisgICAg
ICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHRhc2suX3ZhbGlkYXRlKCksIGlzX3ZhbGlkKQorCisgICAg
ZGVmIF9tb2NrX3BhdGNoKHNlbGYsIGF0dGFjaG1lbnRfZGljdD17fSwgYnVnX2RpY3Q9eydidWdf
c3RhdHVzJzogJ05FVyd9LCBjb21taXR0ZXI9ImZha2UiKToKKyAgICAgICAgYnVnID0gYnVnemls
bGEuQnVnKGJ1Z19kaWN0LCBOb25lKQorICAgICAgICBwYXRjaCA9IGJ1Z3ppbGxhLkF0dGFjaG1l
bnQoYXR0YWNobWVudF9kaWN0LCBidWcpCisgICAgICAgIHBhdGNoLl9jb21taXR0ZXIgPSBjb21t
aXR0ZXIKKyAgICAgICAgcmV0dXJuIHBhdGNoCisKKyAgICBkZWYgdGVzdF92YWxpZGF0ZShzZWxm
KToKKyAgICAgICAgc2VsZi5fZXhwZWN0X3ZhbGlkYXRlKHNlbGYuX21vY2tfcGF0Y2goKSwgVHJ1
ZSkKKyAgICAgICAgc2VsZi5fZXhwZWN0X3ZhbGlkYXRlKHNlbGYuX21vY2tfcGF0Y2goeydpc19v
YnNvbGV0ZSc6IFRydWV9KSwgRmFsc2UpCisgICAgICAgIHNlbGYuX2V4cGVjdF92YWxpZGF0ZShz
ZWxmLl9tb2NrX3BhdGNoKGJ1Z19kaWN0PXsnYnVnX3N0YXR1cyc6ICdDTE9TRUQnfSksIEZhbHNl
KQorICAgICAgICBzZWxmLl9leHBlY3RfdmFsaWRhdGUoc2VsZi5fbW9ja19wYXRjaChjb21taXR0
ZXI9Tm9uZSksIEZhbHNlKQorICAgICAgICBzZWxmLl9leHBlY3RfdmFsaWRhdGUoc2VsZi5fbW9j
a19wYXRjaCh7J3Jldmlldyc6ICctJ30pLCBGYWxzZSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdG9vbC9ib3QvZmVlZGVycy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dG9vbC9ib3QvZmVlZGVycy5weQppbmRleCAwNDZjNGMxZDZiZDNjZDAzZmEyODcyZGNiOTRmODIy
ZTE5NTg1YTI2Li4wYjdmMjNkMjU1NWQwODU5MGM3ZDcwOGRkMmFkODllY2U4NTI2MzFkIDEwMDY0
NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZlZWRlcnMucHkKKysrIGIv
VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9mZWVkZXJzLnB5CkBAIC01NCw2ICs1NCw3
IEBAIGNsYXNzIENvbW1pdFF1ZXVlRmVlZGVyKEFic3RyYWN0RmVlZGVyKToKIAogICAgIGRlZiBm
ZWVkKHNlbGYpOgogICAgICAgICBwYXRjaGVzID0gc2VsZi5fdmFsaWRhdGVfcGF0Y2hlcygpCisg
ICAgICAgIHBhdGNoZXMgPSBzZWxmLl9wYXRjaGVzX3dpdGhfYWNjZXB0YWJsZV9yZXZpZXdfZmxh
ZyhwYXRjaGVzKQogICAgICAgICBwYXRjaGVzID0gc29ydGVkKHBhdGNoZXMsIHNlbGYuX3BhdGNo
X2NtcCkKICAgICAgICAgcGF0Y2hfaWRzID0gW3BhdGNoLmlkKCkgZm9yIHBhdGNoIGluIHBhdGNo
ZXNdCiAgICAgICAgIHNlbGYuX3VwZGF0ZV93b3JrX2l0ZW1zKHBhdGNoX2lkcykKQEAgLTYxLDYg
KzYyLDEwIEBAIGNsYXNzIENvbW1pdFF1ZXVlRmVlZGVyKEFic3RyYWN0RmVlZGVyKToKICAgICBk
ZWYgX3BhdGNoZXNfZm9yX2J1ZyhzZWxmLCBidWdfaWQpOgogICAgICAgICByZXR1cm4gc2VsZi5f
dG9vbC5idWdzLmZldGNoX2J1ZyhidWdfaWQpLmNvbW1pdF9xdWV1ZWRfcGF0Y2hlcyhpbmNsdWRl
X2ludmFsaWQ9VHJ1ZSkKIAorICAgICMgRmlsdGVycyBvdXQgcGF0Y2hlcyB3aXRoIHI/IG9yIHIt
LCBvbmx5IHIrIG9yIG5vIHJldmlldyBhcmUgT0sgdG8gbGFuZC4KKyAgICBkZWYgX3BhdGNoZXNf
d2l0aF9hY2NlcHRhYmxlX3Jldmlld19mbGFnKHNlbGYsIHBhdGNoZXMpOgorICAgICAgICByZXR1
cm4gW3BhdGNoIGZvciBwYXRjaCBpbiBwYXRjaGVzIGlmIHBhdGNoLnJldmlldygpIGluIFtOb25l
LCAnKyddXQorCiAgICAgZGVmIF92YWxpZGF0ZV9wYXRjaGVzKHNlbGYpOgogICAgICAgICAjIE5v
dCB1c2luZyBCdWd6aWxsYVF1ZXJpZXMuZmV0Y2hfcGF0Y2hlc19mcm9tX2NvbW1pdF9xdWV1ZSgp
IHNvIHdlIGNhbiByZWplY3QgcGF0Y2hlcyB3aXRoIGludmFsaWQgY29tbWl0dGVycy9yZXZpZXdl
cnMuCiAgICAgICAgIGJ1Z19pZHMgPSBzZWxmLl90b29sLmJ1Z3MucXVlcmllcy5mZXRjaF9idWdf
aWRzX2Zyb21fY29tbWl0X3F1ZXVlKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0
cHkvdG9vbC9ib3QvZmVlZGVyc191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dG9vbC9ib3QvZmVlZGVyc191bml0dGVzdC5weQppbmRleCA1ODBmODQwODA3NWY4OGZiYzM2ZTc0
MjcwY2M0NjExNjIyYjNiNzkxLi5lOTU2YThmNWZjYzJkMmZkYWVkNjA4NDgyNTEzZDdmNWEyZTNj
YWQ4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZlZWRlcnNf
dW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9mZWVkZXJz
X3VuaXR0ZXN0LnB5CkBAIC02OCwzICs2OCwxMyBAQCBGZWVkaW5nIGNvbW1pdC1xdWV1ZSBpdGVt
cyBbMTA2LCAxOTddCiAgICAgICAgIHF1ZXVlID0gQ29tbWl0UXVldWVGZWVkZXIoTW9ja1Rvb2wo
KSkKICAgICAgICAgYXR0YWNobWVudHMuc29ydChxdWV1ZS5fcGF0Y2hfY21wKQogICAgICAgICBz
ZWxmLmFzc2VydEVxdWFsKGF0dGFjaG1lbnRzLCBleHBlY3RlZF9zb3J0KQorCisgICAgZGVmIHRl
c3RfcGF0Y2hlc193aXRoX2FjY2VwdGFibGVfcmV2aWV3X2ZsYWcoc2VsZik6CisgICAgICAgIGNs
YXNzIE1vY2tQYXRjaChvYmplY3QpOgorICAgICAgICAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHBh
dGNoX2lkLCByZXZpZXcpOgorICAgICAgICAgICAgICAgIHNlbGYuaWQgPSBwYXRjaF9pZAorICAg
ICAgICAgICAgICAgIHNlbGYucmV2aWV3ID0gbGFtYmRhOiByZXZpZXcKKworICAgICAgICBmZWVk
ZXIgPSBDb21taXRRdWV1ZUZlZWRlcihNb2NrVG9vbCgpKQorICAgICAgICBwYXRjaGVzID0gW01v
Y2tQYXRjaCgxLCBOb25lKSwgTW9ja1BhdGNoKDIsICctJyksIE1vY2tQYXRjaCgzLCAiKyIpXQor
ICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhbcGF0Y2guaWQgZm9yIHBhdGNoIGluIGZlZWRlci5f
cGF0Y2hlc193aXRoX2FjY2VwdGFibGVfcmV2aWV3X2ZsYWcocGF0Y2hlcyldLCBbMSwgM10pCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>